Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-08
15:43:02 lajoskatona efried: from my side it is ok for rebasing. I just tried to put my patch for tests on top of yours to see how it goes on latest nested patches
15:43:29 efried lajoskatona: Okay. Should be coming up in the next 10-15 minutes.
15:44:58 mriedem dansmith: one of the proxy methods in https://review.openstack.org/#/c/541005/ is broken
15:45:03 mriedem otherwise just some questions
15:45:50 dansmith mriedem: ack thanks /cc stephenfin
15:49:49 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Fix wrong link for "Manage Flavors" in CPU topologies doc https://review.openstack.org/542270
15:50:19 stephenfin mriedem, dansmith: Alrighty then, dumb question time 🎉 How are we able to drop the v4 proxy in the above change so early? Surely that means all our clients would have to talk 5.0 as soon as we do that?
15:50:44 dansmith stephenfin: we merge the 5.0 server and client in queens,
15:50:53 dansmith then in rocky we can drop the 4.x server proxy
15:51:02 dansmith stephenfin: we send 5.0 by default after that second change
15:51:21 dansmith which means queens supports 5.0 client side, and since we only support one gap, we can drop 4.x in rocky
15:51:40 dansmith stephenfin: you saw the second change in that stack right?
15:53:45 stephenfin dansmith: Riiight, so once people start deploying from master (future Rocky), the expectation is that _everything_ in the deployment will be on stable/queens code or newer
15:53:50 stephenfin Yup, I did indeed
15:54:48 dansmith stephenfin: them's the rules yeah
15:54:49 stephenfin sean-k-mooney: Success! (I think) Now to actually test it and recreate NUMA issues :)
15:55:08 stephenfin dansmith: Gotcha. And the 6 month rule we have for conf options doesn't apply to this?
15:55:14 dansmith stephenfin: no
15:55:20 dansmith stephenfin: (no it does not)
15:55:43 stephenfin 👍
15:56:38 dansmith I'm assuming you mean the 6-mo deprecation warning period.. this is per release, and nothing is being deprecated.. we only support one version back technically anyway, so this is just us officially dropping stuff that has technically been deprecated for a long time
15:56:46 dansmith (and this is the pattern we do every time we bump)
15:58:29 stephenfin dansmith: Yup, that's the one. Thanks for the context
15:58:55 stephenfin dansmith: and a last one: this is a different RPC API with it's own unique version, right? https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L51
15:59:03 dansmith aye
16:00:05 stephenfin Lovely. So now I need to go figure out _which_ other RPC API needs to be bumped to v5 to remove all that code I linked. Fun times :)
16:01:32 openstackgerrit Merged openstack/nova master: Fixed auto-convergence option name in doc https://review.openstack.org/542237
16:01:40 dansmith given you linked to stuff in virt, really it should only be compute rpc
16:01:53 dansmith if not, we're leaking details (which is possible I guess)
16:05:12 mriedem dansmith: did you want to +W this backport https://review.openstack.org/#/c/539005/ ?
16:08:34 hrw mriedem: thanks for accepting my pike backport
16:09:11 mriedem yw
16:09:40 stephenfin dansmith: [1] is my main concern. Assuming RequestSpec objects are used by the scheduler, we'll need to bump that version too to remove the called function [1] https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L140
16:09:43 hrw mriedem, stephenfin: can you find a few minutes for https://review.openstack.org/#/c/541728/ one? support matrix for aarch64 patch
16:09:56 stephenfin hrw: I can probably squeeze it in
16:10:01 hrw thx
16:10:16 hrw trying to get my nova queue cleaned
16:11:09 stephenfin dansmith: More specifically, that calls into one of those offending functions here https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L177-L178
16:11:34 dansmith stephenfin: I'm not sure why that's a problem, but I can't really concentrate while on this call so I'll look when I'm done
16:11:46 mriedem hrw: left a comment in doc/source/user/feature-matrix-gp.ini but i don't really understand what the values are supposed to mean in that doc
16:11:52 mriedem if 'missing' means CI or functionality
16:11:57 mriedem johnthetubaguy might know
16:12:07 mriedem it was part of the feature classification work that osic was doing
16:12:24 hrw mriedem: functionality rather. there are other column without CI stuff
16:12:43 mriedem hrw: you can't create/delete a server with aarch64?
16:13:19 stephenfin mriedem: Looking at line 76, it would seem we should be using partial, not missing
16:13:33 hrw mriedem: docs part is weird.
16:13:34 stephenfin Assuming you _can_ create a server, heh
16:14:01 hrw mriedem: functionality list depends on tempest tests. and in tempest output I did not found ones referred there
16:14:23 hrw mriedem: support-matrix depends on commands == can be tested
16:14:41 mriedem doc/source/user/support-matrix.ini is much more straight forward, it doesn't concern itself with CI coverage
16:14:50 mriedem the doc/source/user/feature-matrix-gp.ini one is the one that annoys me
16:14:51 hrw mriedem: did not found or found errors in tempest
16:15:05 mriedem we have no CI coverage for libvirt+aarch64,
16:15:10 mriedem so that's an easy one,
16:15:20 mriedem but i don't know if the gp doc is just about CI coverage or not
16:15:24 mriedem it's half baked
16:15:29 mriedem and i'd kind of like to delete it
16:15:46 hrw mriedem: if feature-matrix-gp.ini tells me that feature X depends on test A-B-C-D and I see that A-B-C-D failed in tempest run then it looks like missing rather then complete
16:16:38 mriedem hrw: so for L73 you're saying you can't create or delete a server with libvirt+aarch64?
16:18:40 hrw mriedem: if I go straight through tests like this doc suggests then it looks like that
16:21:45 hrw feature-matrix-gp.ini/operation.create-delete-server lists two tests: 9a438d88-10c6-4bcd-8b5b-5b6e25e1346f (test_list_servers) and 585e934c-448e-43c4-acbf-d06a9b899997 (test_list_servers_with_detail) and I lack both in any tempest run logs
16:21:48 mriedem hrw: honestly i'd just remove the changes for the -gp doc and ignore it
16:22:11 mriedem let's just sort out the more complete feature support matrix, which isn't about CI
16:22:40 hrw mriedem: that's an option
16:24:49 openstackgerrit Claudiu Belu proposed openstack/nova master: hyperv: Cleans up live migration Planned VM https://review.openstack.org/478943
16:26:06 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Add release note for Aggregate[Core|Ram|Disk]Filter change https://review.openstack.org/542290
16:28:27 cfriesen is there a debug option to include the body of requests in the nova-api log?
16:28:58 hrw mriedem: will check your comments on my setup
16:31:53 ameeda mriedem: I am back. I added this line "libpcre3-dev [platform:dpkg]" as you mentioned before to bindep.txt , do I have to add "pcre-devel" too ?
16:32:27 mriedem ameeda: i'm going to restore and approve https://review.openstack.org/#/c/542002/
16:32:38 mriedem it's so trivial it's not worth dropping it since yours would be the same
16:32:49 mriedem ameeda: yes you'd add pcre-devel for rpm
16:34:22 ameeda mriedem: but I take it before him :( , anyway feel free to do what you want
16:35:26 hrw how to use interface-detach? "nova interface-detach dd8 eth1" does nothing
16:35:57 ameeda mriedem: pcre-devel [platform:rpm test] is fine ?
16:37:02 johnthetubaguy hrw: good questions, the long term aim was for the tests to help auto generate the grid, only some tests passing sounds like partial to me
16:37:29 hrw johnthetubaguy: create-delete does not test either creating nor deleting
16:38:08 johnthetubaguy hrw: that sounds wrong, you got the links I can dig to see what was going on there
16:38:59 hrw johnthetubaguy: at least it goes like that when you look at 'tempest --list' output (sth like that - the one which gives names<>uuid mapping)
16:40:59 johnthetubaguy hrw: yep I see now, this looks broken: https://github.com/openstack/nova/blob/5158ca7dcffd583dc8dd7c29b0a9a595d7de7dcf/doc/source/feature_matrix_gp.ini#L51
16:41:27 hrw johnthetubaguy: exactly
16:41:49 hrw anyone used 'interface-detach' without --port-id?
16:41:58 johnthetubaguy hrw: oh wait... that does a create in the setup
16:42:20 johnthetubaguy hrw: I think its taken from what was used for the logo certification stuff at the time
16:42:36 hrw johnthetubaguy: anyway I skip that part for aarch64
16:42:46 johnthetubaguy hrw: I think that's a nova-network thingy, the error handling is super dodgy
16:42:59 johnthetubaguy hrw: why skip for aarch64? I missed that
16:42:59 hrw johnthetubaguy: support-matrix.ini is easier to fill
16:43:14 johnthetubaguy ah, got you
16:43:33 hrw johnthetubaguy: like I told earlier: feature-matrix-gp.ini/operation.create-delete-server lists two tests: 9a438d88-10c6-4bcd-8b5b-5b6e25e1346f (test_list_servers) and 585e934c-448e-43c4-acbf-d06a9b899997 (test_list_servers_with_detail) and I lack both in any tempest run logs
16:44:01 hrw johnthetubaguy: so if I go right then create-delete functionality is missing, right??
16:46:03 johnthetubaguy hrw: correct, if its not tested in the gate, you would mark it as missing
16:46:58 johnthetubaguy by gate I mean 3rdparty I guess
16:47:33 hrw johnthetubaguy: http://logs.openstack.org/28/541728/8/check/build-openstack-sphinx-docs/b9ac718/html/user/feature-classification.html
16:48:49 hrw johnthetubaguy: table is bogus for aarch64: is marked as missing or unknown despite working. just because tests used in ini files test for other stuff than names say
16:49:04 hrw johnthetubaguy: or listed tests are not used anymore
16:49:32 johnthetubaguy hrw: yeah seems like its bit rotted
16:49:35 hrw hm. no volumes in my setup
16:49:37 hrw (openstack) volume create --image f91ae3a7-e067-466c-b1b3-e592ea58d266 --size 8 --availability-zone nova my-new-volume

Earlier   Later