| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-19 | |||
| 14:52:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: QEMU native LUKS decryption for encrypted volumes https://review.openstack.org/523958 | |
| 14:52:45 | fried_rice | And you can *probably* even ask for multiple vifs on separate subnets in the same request. As long as you only want one of each. And don't share those traits with any other provider. Which is probably doable. | |
| 14:53:16 | fried_rice | brb | |
| 14:54:01 | sean-k-mooney | ill cross that bridge when i come to it but ya granular resouce requests in queens will support all of these usecase more cleanly/correctly | |
| 14:54:08 | sean-k-mooney | * in rocky | |
| 15:01:48 | openstackgerrit | Jim Rollenhagen proposed openstack/nova master: WIP: hacky negotiation of ironic microversion https://review.openstack.org/535786 | |
| 15:02:44 | leakypipes | alex_xu: review done. | |
| 15:14:59 | rabel | hm. why is a PUT to /os-quota-sets/default working? this does not make sense in my brain | |
| 15:25:52 | leakypipes | fried_rice: just confirming... mgoddard's patches for "Call get_traits() in the resource tracker" and "Add get_traits() method to ComputeDriver" are obseleted with the update_provider_tree() work, correct? | |
| 15:26:53 | fried_rice | leakypipes Eventually, but when I asked him about it, apparently he's wanting to move forward more quickly than that. | |
| 15:27:16 | fried_rice | leakypipes Right now he's working toward what's described in his blueprint. | |
| 15:27:33 | fried_rice | leakypipes And that stuff will coexist with update_provider_tree until it doesn't. | |
| 15:28:11 | leakypipes | hmm, ok | |
| 15:28:17 | fried_rice | leakypipes Though xen is counting on using update_provider_tree, and I just found out vmware is as well. | |
| 15:28:48 | leakypipes | fried_rice: yeah, my preference for sure would be to have everyone on update_provider_tree() | |
| 15:28:49 | leakypipes | asap | |
| 15:28:51 | fried_rice | leakypipes I didn't love the idea of that redundant/extra compute driver method coming into existence for such a limited use and (hopefully) limited time... | |
| 15:28:54 | fried_rice | yeah, same | |
| 15:29:02 | leakypipes | k, at least we're on the same page. | |
| 15:29:11 | leakypipes | fried_rice: your series is looking great | |
| 15:29:18 | fried_rice | Thanks! | |
| 15:29:27 | leakypipes | I'm hoping we can get gibi or stephenfin on it. | |
| 15:30:41 | fried_rice | Late on a Friday... and both of them forgot their Friday nicks... | |
| 15:31:32 | leakypipes | fried_rice: well that is COMPLETELY UNACCEPTABLE. | |
| 15:32:09 | fried_rice | ikr | |
| 15:32:19 | fried_rice | At least figleaf is on board | |
| 15:34:01 | rgerganov | fried_rice, i am trying to implement update_provider_tree for the vmware driver and I'll be happy to work with you on https://review.openstack.org/#/c/520246 and the rest | |
| 15:34:04 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Cleanup redundant want_version assignment. https://review.openstack.org/535801 | |
| 15:34:34 | fried_rice | rgerganov Ah, I was looking for rado - is that not also you? | |
| 15:34:57 | rgerganov | fried_rice, well i was also looking for efried but found fried_rice :) | |
| 15:34:58 | fried_rice | gibi You can redeem yourself by reviewing the series behind leakypipes | |
| 15:35:13 | fried_rice | rgerganov I make no apologies for my Fun Friday nickname | |
| 15:36:27 | fried_rice | rgerganov I'm going to need to rebase the top of the series to account for some stuff takashin did for including request IDs in deletion calls. | |
| 15:37:00 | fried_rice | Which leaves me in kind of a bind because the bottom of the series is close to mergeable, and I don't want to rebase it and set back the review process. | |
| 15:37:16 | fried_rice | Though I guess if I do it now, as long as it's auto-rebase-able, I keep reviews... | |
| 15:37:40 | rgerganov | fried_rice, yeah understood | |
| 15:38:16 | finucannot | leakypipes: What was this now? | |
| 15:38:45 | fried_rice | finucannot Welcome! | |
| 15:38:49 | leakypipes | finucannot: starting here: https://review.openstack.org/#/c/533244/ | |
| 15:39:12 | fried_rice | finucannot Please and thank you. | |
| 15:39:21 | finucannot | Yup, I'll tackle that this evening | |
| 15:40:21 | gibi | finucannot: I'm also started looking at it, but I don't know when and where I run out of steam | |
| 15:41:17 | fried_rice | gibi finucannot Thank you for whatever you can manage. | |
| 15:41:24 | leakypipes | gibi: where's giblet today? :P | |
| 15:41:47 | leakypipes | \o/ | |
| 15:41:52 | giblet | leakypipes: sorry, I always forget | |
| 15:42:20 | fried_rice | giblet finucannot leakypipes I'm going to rebase the series real quick to get rid of the merge conflicts on the top few patches... | |
| 15:42:34 | giblet | fried_rice: thanks for the headsup | |
| 15:42:37 | leakypipes | ok dokey | |
| 15:43:04 | fried_rice | leakypipes Your +2s will ride. Only the _delete_provider patch was manual. | |
| 15:43:11 | leakypipes | ack | |
| 15:43:12 | fried_rice | Here it comes. | |
| 15:43:17 | openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.data => ProviderData https://review.openstack.org/533244 | |
| 15:43:18 | openstackgerrit | Eric Fried proposed openstack/nova master: Track associated sharing RPs in report client https://review.openstack.org/526539 | |
| 15:43:18 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_traits_for_provider https://review.openstack.org/532564 | |
| 15:43:19 | openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.populate_from_iterable https://review.openstack.org/520756 | |
| 15:43:19 | openstackgerrit | Eric Fried proposed openstack/nova master: Raise on API errors getting aggregates/traits https://review.openstack.org/526540 | |
| 15:43:20 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.set_aggregates_for_provider https://review.openstack.org/533808 | |
| 15:43:20 | openstackgerrit | Eric Fried proposed openstack/nova master: Track tree-associated providers in report client https://review.openstack.org/526541 | |
| 15:43:21 | openstackgerrit | Eric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | |
| 15:43:21 | openstackgerrit | Eric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | |
| 15:43:22 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | |
| 15:43:22 | openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._delete_provider https://review.openstack.org/535463 | |
| 15:43:23 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | |
| 15:43:23 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | |
| 15:43:24 | openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | |
| 15:43:27 | rgerganov | cool | |
| 15:43:28 | fried_rice | leakypipes giblet finucannot ^ done. Thanks. | |
| 15:43:32 | finucannot | (y) | |
| 15:44:01 | leakypipes | fried_rice: and you just killed your clean check run ;) | |
| 15:44:05 | fried_rice | rgerganov I still haven't addressed your comments. I can start on that now. But I also had some other stuff I was gonna do to those WIPs today. | |
| 15:44:07 | leakypipes | but alas, c'est la vie | |
| 15:44:13 | fried_rice | leakypipes Ah, dang, that too :( | |
| 15:45:28 | rgerganov | fried_rice, no rush, I will head out soon. Will ping you on monday at 1300 UTC | |
| 15:46:01 | fried_rice | rgerganov Roger wilco. At 1400 is the scheduler meeting, where some of this stuff might get discussed, if you're interested in joining. | |
| 15:46:16 | rgerganov | ah, thanks for letting me know, I will consider it | |
| 15:47:00 | fried_rice | rgerganov https://wiki.openstack.org/wiki/Meetings/NovaScheduler -- feel free to add agenda items if you think of something that needs to be addressed. | |
| 15:47:08 | rgerganov | ok, thanks | |
| 15:50:57 | openstackgerrit | Merged openstack/nova master: Fix format in flavors.rst https://review.openstack.org/535777 | |
| 15:51:14 | leakypipes | rgerganov: I mean... what ELSE would you rather do on a Monday afternoon other than spend time with me and fried_rice? ;) | |
| 15:52:57 | rgerganov | leakypipes, lol | |
| 15:53:04 | fried_rice | Thanks giblet! It's all downhill from here. | |
| 15:53:59 | cfriesen | anyone feel like a fairly quick code review? https://review.openstack.org/#/c/484381/ has been sitting with a single +2 for a couple weeks now | |
| 15:54:24 | cfriesen | ^ this is related to instance evacuation with PCI devices | |
| 15:54:33 | leakypipes | cfriesen: evacuate? PCI devices? oh hell, sign me up! | |
| 15:54:49 | cfriesen | leakypipes: it's under 20 lines. :) | |
| 15:54:57 | leakypipes | cfriesen: I'm looking at it :) | |
| 15:55:05 | cfriesen | sweet, thanks | |
| 15:55:48 | giblet | fried_rice: I have left like 15 minutes then boardgame night... | |
| 15:56:01 | fried_rice | ooo :) | |
| 15:56:18 | fried_rice | cfriesen How does this actually fix anything? | |
| 15:56:44 | fried_rice | cfriesen Oh, it passes in a thing that's being checked by something that happened in a different patch? | |
| 15:57:20 | fried_rice | got it. | |
| 15:57:24 | cfriesen | fried_rice: not actually my patch, but I think it's passing in a thing that something else already in the code is looking for | |
| 15:58:13 | finucannot | fried_rice: Yup. Something we already do for one code path (cold migration, resize) should now being done for another (evacuation) | |
| 15:58:20 | fried_rice | cfriesen Yeah, I see _update_port_binding_for_instance takes a migration kwarg | |
| 15:58:36 | leakypipes | cfriesen: +Wallaby'd | |
| 15:58:49 | cfriesen | leakypipes: awesome, thanks | |
| 15:59:08 | fried_rice | cfriesen Left a passive-aggressive +0 with a nit. | |
| 15:59:49 | cfriesen | lol | |