| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-17 | |||
| 09:42:29 | kashyap | stephenfin: It's still WIP, I need to fix the 11 or so broken tests | |
| 09:42:58 | kashyap | But thought I'd put it out there, as we should it'll alleviate the performance impact that the recent "Meltdown" CVE fixes cause. | |
| 09:43:11 | kashyap | The commit message tells it all (I mean, all) :-) | |
| 09:47:06 | stephenfin | kashyap: Sounds good | |
| 09:48:18 | bauzas | stephenfin: just in case, you could also be interested in https://review.openstack.org/#/c/528832/ | |
| 09:48:20 | kashyap | stephenfin: Just to note --- next two days I'm a bit sporadic in my availability, Friday night, I'lll be back home | |
| 09:48:31 | bauzas | stephenfin: ;) | |
| 09:56:42 | BKaminski | There any etiquette on adding someone as a reviewer to a commit if you know they know that code well? | |
| 09:58:03 | kashyap | BKaminski: Sure, it's fine. | |
| 09:58:28 | BKaminski | Alrighty, thanks :) | |
| 09:59:38 | kashyap | BKaminski: E.g. sometimes I run this command: git shortlog -nse nova/$File-of-Interest | |
| 09:59:46 | kashyap | To get a sense of who might know a certain area | |
| 10:00:03 | kashyap | Then check if they're still active, and add them to Cc. | |
| 10:00:03 | BKaminski | Ah that does maek sense | |
| 10:00:28 | kashyap | (I do it for mailing lists based projects mostly, as it requires explicit Cc) | |
| 10:00:47 | kashyap | But obviously, the trick applies for any Git-based project | |
| 10:00:58 | BKaminski | That makes sense.. i'll give it a go just to get it on a couple of peoples radars that I know worked on this code, since XenAPI code is kind of hard to catch a reviewer on I think :D | |
| 10:01:42 | kashyap | Yup | |
| 10:04:00 | BKaminski | Last commit into .Xenapi was Aug 2017 .. whew... | |
| 10:05:43 | BKaminski | OH nevermind.. December.. i apparently had a temporary brain to vision disease there hehe | |
| 10:14:00 | openstackgerrit | Chen Hanxiao proposed openstack/nova master: _cleanup_resize: remove rbd swap disk if resize to flavor without swap https://review.openstack.org/534711 | |
| 10:15:37 | gmann | ameeda: sure, i was away today. ll check soon | |
| 10:16:20 | ameeda | gmann: thank you ! | |
| 10:16:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix openstackdocstheme options for api-ref https://review.openstack.org/534712 | |
| 10:16:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove crud from 'conf.py' https://review.openstack.org/534713 | |
| 10:28:16 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: QEMU native LUKS decryption for volumes https://review.openstack.org/523958 | |
| 10:37:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | |
| 10:38:44 | openstackgerrit | sahid proposed openstack/nova master: libvirt: disconnect volume from host during detach https://review.openstack.org/515008 | |
| 10:53:25 | openstackgerrit | sahid proposed openstack/nova master: live-mig: Add claims and proper resource tracking https://review.openstack.org/244489 | |
| 11:08:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy https://review.openstack.org/500544 | |
| 11:08:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove duplicate 'vnc' config opt descriptions https://review.openstack.org/534724 | |
| 11:57:11 | openstackgerrit | sahid proposed openstack/nova master: libvirt: set emulator threads on isolated host cpus https://review.openstack.org/510897 | |
| 11:57:11 | openstackgerrit | sahid proposed openstack/nova master: libvirt: rework _get_vpcu_total to return online pCPUs https://review.openstack.org/509730 | |
| 12:08:32 | Rambo | Good mornig,everyone, Can you help me to review the spec ?The link is https://review.openstack.org/#/c/532410/ | |
| 12:08:47 | Rambo | Thank you very much | |
| 12:08:47 | Rambo | Another is :https://review.openstack.org/#/c/532407/ | |
| 12:27:09 | sean-k-mooney | stephenfin: hi o/ if jaypipes want any changes ill add the link to the pull request in the iptools patch. its currently in the commit message. is that ok. alternitivly i can do a quick respin now but we will have to wait a while for the gate to come back. | |
| 12:28:29 | jaypipes | sean-k-mooney: I'm cool with what you've done | |
| 12:28:46 | jaypipes | sean-k-mooney: mostly so I can just blame you if anything messes up :P | |
| 12:29:42 | sean-k-mooney | jaypipes: :) well if anything does come up ill fix it but it think its good based on my testing and the ci | |
| 12:32:52 | jaypipes | sean-k-mooney: now if only you could get rid of this chest congestion and cough for me... | |
| 12:33:29 | sean-k-mooney | jaypipes: may i suggest irish coffee + a good spicy curry | |
| 12:33:44 | sean-k-mooney | also drugs lots of drugs and rest | |
| 12:33:53 | jaypipes | sean-k-mooney: lol. my boss, who's british, suggested whiskey as well. | |
| 12:34:35 | jaypipes | sean-k-mooney: also, I have the curry handled ;) https://twitter.com/jaypipes/status/951974933835399169 | |
| 12:35:52 | sean-k-mooney | jaypipes: haha ya i saw that tweet. i dont know what people did for coldes before spicy food was commonplace in europe/america but its pretty effectiv | |
| 12:37:50 | sean-k-mooney | on a slightly different tangent. for https://review.openstack.org/#/c/465160/ we were waiting for the intel nfv ci to run. that shoudl be up before the ptg however the ci-worker vm i was doing the os-vif work in was created to allow me to replicate how the nfv ci would work. | |
| 12:38:29 | sean-k-mooney | if i get time later today ill try and test the latest version uploaded by tetsuro and see if i can upload the logs somewhere | |
| 12:39:06 | sean-k-mooney | my question is is that sufficent or do we want to leave this to rocky when the ci should be back | |
| 12:40:23 | jaypipes | sean-k-mooney: heh, I stumbled across that patch again yesterday closing out old browser tabs and wondered what the latest was on it. | |
| 12:41:10 | jaypipes | sean-k-mooney: I don't consider it to be a high priority, frankly. If that needs to bump to Rocky as we wait for functional ci, I'm very much ok with that | |
| 12:42:31 | sean-k-mooney | jaypipes: ok Tetsuro seams to have a serise of patches that build on it to be a more complete solution so proably better to wait for the whole set instead of just have the first patch | |
| 12:43:20 | jaypipes | sean-k-mooney: ya | |
| 12:44:59 | sean-k-mooney | cool thats one thing i can take of my too do list for today. so jay if you are happy with https://review.openstack.org/#/c/534307/ do you want me to propose a 1.8.1 release to the release repo with that commit | |
| 12:47:58 | jaypipes | sean-k-mooney: +2 from me. I'll let stephenfin +Wallaby it. | |
| 12:50:48 | sean-k-mooney | jaypipes: cool, its parent is not the had of master so it will create a merge commit with a new sha so ill wait for it to be merged the ill update this https://github.com/openstack/releases/blob/master/deliverables/queens/os-vif.yaml | |
| 12:51:10 | sean-k-mooney | should i use version: 1.8.1 or 1.9.0 | |
| 12:51:27 | ameeda | jaypipes: can you please check my comments here ? "https://review.openstack.org/#/c/526900/" | |
| 12:52:40 | jaypipes | ameeda: I did. I still do not understand your response on https://review.openstack.org/#/c/526900/19/nova/utils.py. | |
| 12:54:16 | ameeda | I am sorry, I meant by that, the image has key called "value" , so I filter the request to make sure that I will not change another key limitations. | |
| 12:55:02 | jaypipes | ameeda: why does the image have a key called "value"? that doesn't make sense. | |
| 12:55:44 | ameeda | seriously I don't know, but that what I found in the code | |
| 12:56:30 | sean-k-mooney | it forced reboots are awsome... brb | |
| 12:57:13 | ameeda | jaypipes: you can see that here also "https://review.openstack.org/#/c/526900/20/nova/tests/functional/regressions/test_bug_1117923.py" Line 114 | |
| 12:58:16 | jaypipes | ameeda: that's only because you are hard-coding the key to "value" on line 73. | |
| 12:59:05 | ameeda | oh sorry ! yes I got that, so I have to remove the key!="value" ? | |
| 12:59:36 | jaypipes | ameeda: yessir | |
| 13:00:16 | ameeda | jaypipes: so the code should truncates all values of keys ? | |
| 13:00:34 | jaypipes | ameeda: even then, though, keep in mind the REST API for compute will limit any input from users to 255 characters. I understand that the image metadata values are not set through the REST API, though | |
| 13:00:59 | jaypipes | ameeda: no, I'm saying you should *not* truncate the values in that utils module function. | |
| 13:01:27 | ameeda | jaypipes: yes that what I would to say. | |
| 13:01:44 | jaypipes | ameeda: rely on the REST API to filter out user-supplied values >255 chars in length and allow non-user-supplied metadata values (like those coming from Glance) to be passed as-is to Nova's database. | |
| 13:02:31 | ameeda | jaypipes: what you guess me to write ? how I can do that ? | |
| 13:03:51 | jaypipes | ameeda: other than the test case change (don't hard-code the key to 'value'), the only change you need to make is in here: | |
| 13:03:52 | jaypipes | https://review.openstack.org/#/c/526900/20/nova/utils.py | |
| 13:04:22 | jaypipes | ameeda: simply remove original line 983 and change line 984 to use "value" instead of "new_value" | |
| 13:05:34 | ameeda | that will be acceptable, so you can give me +2 :D ? | |
| 13:05:34 | jaypipes | ameeda: left notes in the review for you. | |
| 13:05:44 | ameeda | jaypipes: thanks | |
| 13:11:09 | ameeda | jaypipes: its good to name the new key as "new_key" rather than "value" ? | |
| 13:12:20 | jaypipes | ameeda: call the key something realistic that would be set by Glance. | |
| 13:13:12 | ameeda | "new_key_from_glance" for example ? | |
| 13:14:21 | ameeda | jaypipes: its fine ? | |
| 13:15:39 | jaypipes | ameeda: how about something realistic, like "trusted_certificates" and make the value of the metadata item 2K of random bytes. | |
| 13:17:02 | ameeda | I have to do 2k random bytes by code or hard coded ? | |
| 13:17:37 | openstackgerrit | Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346 | |
| 13:17:38 | openstackgerrit | Matthew Booth proposed openstack/nova master: Expose driver_block_device fields as attributes https://review.openstack.org/528362 | |
| 13:17:38 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | |
| 13:17:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363 | |
| 13:17:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029 | |
| 13:17:40 | openstackgerrit | Matthew Booth proposed openstack/nova master: Use real block_device_info data in libvirt tests https://review.openstack.org/527916 | |
| 13:18:38 | openstackgerrit | Merged openstack/python-novaclient master: Add missing spaces in `nova list --changes-since` help https://review.openstack.org/533575 | |
| 13:20:11 | ameeda | jaypipes : this code is okay for you ? "import random def randomBytes(n): return bytearray(random.getrandbits(8) for i in range(n))" | |
| 13:22:21 | jaypipes | ameeda: sure, that's fine. | |
| 13:22:40 | ameeda | Thanks ! | |
| 13:23:01 | jaypipes | np | |
| 13:35:36 | zioproto | sdague: sorry yesterday I had to leave and I did not answer. The version of Openstack is Newton | |
| 13:39:47 | ameeda | jaypipes: sorry for inconvenience, should I build new server from snapshot image ?, I can't find any details can help me when I use api.get_server(created_server['id']) , please check the log to see what I got http://paste.openstack.org/show/646510/ | |
| 13:46:48 | ameeda | jaypipes: ? | |
| 13:48:46 | edmondsw | gibi we respun https://review.openstack.org/#/c/422512/ for a comment from stephenfin and lost your +2. Please take another look when you get a chance. Thanks! | |