| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-16 | |||
| 11:05:50 | stephenfin | sean-k-mooney: I am | |
| 11:07:17 | sean-k-mooney | stephenfin: i pushed a patch for the nova unit tests but i looks like pyrote2 may leak on python2 based on matthew thode's comment on https://review.openstack.org/#/c/532987/ | |
| 11:07:31 | sean-k-mooney | https://github.com/svinota/pyroute2/pull/443 | |
| 11:08:39 | openstackgerrit | nafeiyang proposed openstack/nova master: z/VM driver: add snapshot function https://review.openstack.org/534240 | |
| 11:08:44 | stephenfin | sean-k-mooney: So that explains our "too many open files issue", I guess | |
| 11:09:09 | sean-k-mooney | since rodolfo like to test thing when he wrote the pyroute 2 implementation he almost wrote a ip tools impl in the functional tests https://github.com/openstack/os-vif/blob/master/os_vif/tests/functional/internal/command/ip/test_impl_pyroute2.py#L28-L94 | |
| 11:09:38 | stephenfin | sean-k-mooney: So I guess we can revert/disable the pyroute2 path until a new version is released | |
| 11:09:43 | sean-k-mooney | stephenfin: what i was thing was i could make that an actully conforming implementation to the api and we could merge and make it the defalut | |
| 11:09:59 | stephenfin | We can't rely on that being released before the deadline | |
| 11:10:58 | sean-k-mooney | well i was going to do it now. if i dont have it finished and up for review by this evening ill submit a reviert for rodolfos patch | |
| 11:11:11 | stephenfin | sean-k-mooney: But why not keep what we had, in that case? The reason to switch to pyroute2 was that it used the netlink protocol in Python, rather than wrapping existing command-line tools | |
| 11:11:30 | stephenfin | Before integrating pyroute2, we _were_ using subprocess | |
| 11:11:55 | stephenfin | Well, processutils | |
| 11:12:05 | openstackgerrit | Merged openstack/nova master: update_cell allows more than once cell to have the same db/transport url https://review.openstack.org/518556 | |
| 11:12:25 | sean-k-mooney | yes though really the api is 3 fucntion add device delete device and set properties on device so its really small | |
| 11:13:48 | stephenfin | sean-k-mooney: Cool. If you get it finished then let me know and I'll review | |
| 11:14:19 | stephenfin | We can mark the processutils variant as immediately deprecated and switch to pyroute2 once a new version is released | |
| 11:14:38 | sean-k-mooney | give me an hour or so and i should have a second driver working and a config option that default to iptools instead of pyroute 2 done. ill ping you the review when its up | |
| 11:14:58 | gibi | cdent: I will check it later today | |
| 11:15:01 | sean-k-mooney | stephenfin: ya that was my reasoning too | |
| 11:15:06 | cdent | thanks gibi | |
| 11:15:25 | cdent | If I have it figured out before then, I'll let you know | |
| 11:20:02 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Retry few times when creating the initial connection to libvirtd. https://review.openstack.org/416928 | |
| 11:23:23 | cdent | stephenfin: see my second set of comments on https://review.openstack.org/#/c/534223/ I don't think your suggestion works (at least not for me) | |
| 11:25:32 | stephenfin | Oh, maybe not | |
| 11:27:45 | stephenfin | cdent: Right you are. I retract my -1 | |
| 11:28:06 | cdent | stephenfin: do you still think I should change the default list? | |
| 11:28:30 | stephenfin | cdent: I don't think so. We haven't switched to py36 in CIs yet (I think?), so it doesn't need to run by default | |
| 11:34:28 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 11:34:28 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] use simple FaultWrapper https://review.openstack.org/533752 | |
| 11:36:50 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: QEMU native LUKS decryption for volumes https://review.openstack.org/523958 | |
| 11:38:42 | mdbooth | stephenfin: Please could you kick this back into the gate for me? https://review.openstack.org/#/c/529028/ Previously failed, then rebased. | |
| 11:38:56 | stephenfin | mdbooth: Done | |
| 11:39:04 | mdbooth | stephenfin: Thanks | |
| 11:40:05 | mdbooth | Hmm, that patch series is starting to descend into merge conflict hell. | |
| 12:13:51 | mdbooth | How do I hate thee? Let me count the ways. | |
| 12:14:17 | mdbooth | Actually, I'm out of fingers :/ | |
| 12:15:08 | lyarwood | mdbooth: it did | |
| 12:15:11 | lyarwood | <https://matrix.devlab.redhat.com/_matrix/media/v1/download/redhat.com/ZOkiHajvlKvFxQUcknOXyfhJ> | |
| 12:15:11 | lyarwood | * mdbooth sent a long message: mdbooth_2018-01-16_12:13:39.txt | |
| 12:15:23 | mdbooth | lyarwood: Hehe, yeah. | |
| 12:17:03 | mdbooth | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7519 | |
| 12:17:09 | mdbooth | There down to... | |
| 12:17:12 | mdbooth | except Exception: pass | |
| 12:17:17 | mdbooth | Yes, really | |
| 12:17:56 | mdbooth | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7519-L7530 | |
| 12:21:38 | openstackgerrit | Lajos Katona proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 12:36:05 | cdent | Does anyone recall if nova/objects/ec2.py is used any more. It seems only in tests | |
| 12:37:25 | cdent | hard to be clear | |
| 12:40:42 | cdent | (╯°□°）╯︵ ┻━┻ | |
| 12:45:52 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | |
| 12:45:54 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | |
| 12:49:17 | alex_xu | cdent: just found there still have a lot of returns by searching 'ec2' in the source code | |
| 12:49:49 | cdent | alex_xu: yes, but at least some of that is dead (only some) | |
| 12:49:53 | cdent | and it is hard to tell which | |
| 12:50:39 | cdent | alex_xu: I'm trying to work on the "less imports" goal implied by this bug https://bugs.launchpad.net/nova/+bug/1743120 and it is ... messy | |
| 12:50:40 | openstack | Launchpad bug 1743120 in OpenStack Compute (nova) "placement inadvertently imports many python modules it does not need" [Low,In progress] - Assigned to Chris Dent (cdent) | |
| 12:51:59 | alex_xu | cdent: yea, I guess nova/api/openstack/__init__.py is source of evil :) | |
| 12:52:19 | cdent | i was able to get some of it: https://review.openstack.org/#/c/533797/ | |
| 12:52:43 | cdent | registering objects is also a culprint | |
| 12:54:37 | alex_xu | interesting, put it in my review list, I still have circle import in the nova api, hope to get some clue | |
| 12:56:36 | cdent | alex_xu: another source of trouble is conf, it tends to imports lots of stuff that isn't always needed. but I reckon the main culprit is code in __init__.py being common | |
| 12:57:40 | gibi | cdent: you have to rebase your patch https://review.openstack.org/#/c/533797 to have this revert in your history https://review.openstack.org/#/c/533190/ | |
| 12:57:49 | alex_xu | cdent: yea...__init__.py... | |
| 12:58:03 | cdent | gibi: ah cool, thanks | |
| 12:58:15 | gibi | cdent: this was last | |
| 12:58:20 | gibi | cdent: this was last Friday's fun | |
| 12:58:36 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] use simple FaultWrapper https://review.openstack.org/533752 | |
| 12:58:47 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 12:59:36 | cdent | ah | |
| 13:03:54 | cdent | yup, that fixed it gibi, thanks | |
| 13:04:00 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Refactor WSGI apps and utils to limit imports https://review.openstack.org/533797 | |
| 13:04:12 | cdent | I guess I started this branch longer ago than I thought | |
| 13:15:45 | zioproto | sdague: ping, are you around ? | |
| 13:21:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | |
| 13:21:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 13:21:51 | bauzas | folks loving to see how vGPUs are possible with libvirt, the series is up for reviews https://review.openstack.org/#/c/528832/10 | |
| 13:22:33 | bauzas | there are still some corner cases (at least for suspend and migrations), but that's something I'll provide by next changes | |
| 13:22:55 | bauzas | gibi: stephenfin: in case you're interested in ^ | |
| 13:23:13 | sdague | zioproto: for a little bit, what's up? | |
| 13:23:25 | openstackgerrit | Merged openstack/os-vif master: Git ignore .stestr https://review.openstack.org/533699 | |
| 13:32:39 | zioproto | sdague: hey, you have been metioned on openstack-dev, make sure you look at the thread [oslo][oslo.log] JSON logs are missing the request ID | |
| 13:33:08 | zioproto | sdague: please read the thread (5 emails so far) and tell me if you have some important info for me :) | |
| 13:33:21 | zioproto | sdague: thanks ! | |
| 13:34:27 | mvenesio | Hi guys, i'm trying to configure nova and rabbitmq to use SSL with trusted certificates, but doing the configuration as is in the ssl security guide im getting the "[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed" error when nova tries to connect with rabbitmq, any idea about what can be wrong ? | |
| 13:34:39 | openstackgerrit | sean mooney proposed openstack/os-vif master: adds iptools driver for ip commands https://review.openstack.org/534307 | |
| 13:35:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | |
| 13:35:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make sure that functional test triggered on sample changes https://review.openstack.org/533210 | |
| 13:36:00 | sean-k-mooney | stephenfin: ^ that is not done yet but need to run in to town for a bit. ill fix it up when i get back. if i dont have it working by this evening ill revert the original pyroute2 patch. | |
| 13:36:37 | sean-k-mooney | stephenfin: actully ill propose the revert now just ot have it in the gate but ill -1 it until this evening | |
| 13:37:46 | openstackgerrit | sean mooney proposed openstack/os-vif master: Revert "Migrate from 'ip' commands to 'pyroute2'" https://review.openstack.org/534308 | |
| 13:43:50 | sdague | zioproto: I didn't really touch the json log formatter, though it wouldn't be too hard to add I don't think | |
| 13:47:45 | openstackgerrit | sahid proposed openstack/nova master: hardware: only take into account small pages https://review.openstack.org/532168 | |
| 13:55:47 | Spazmotic | Poor XenAPI drivers, no love hehe | |
| 13:55:51 | zioproto | sdague: should I open a bug then ? | |
| 13:57:21 | openstackgerrit | Matthew Edmonds proposed openstack/nova master: Add taskflow to requirements https://review.openstack.org/533779 | |
| 13:57:28 | sdague | zioproto: are you sure that request_id isn't in there? | |
| 13:57:48 | sdague | because in looking at the code, it looks like it should be a key under the 'context' key, if it exists | |
| 13:58:31 | zioproto | it is not there | |
| 13:58:36 | zioproto | I even shared my all config in the thread | |