Posted	Nick	Remark
#openstack-nova - 2018-01-12
21:52:22	mriedem	if prep_resize is called > len(hosts) then you'd know right?
21:52:32	mriedem	or max_attempts or whatever
21:54:08	figleaf	prep_resize will be called once for each attempted migration
21:54:27	figleaf	select_destinations is called from the task
22:14:51	mriedem	figleaf: i think you were right about _revert_allocation,
22:15:10	mriedem	i think that deletes the allocation for the migration record on the source node, and overwrites the instance allocation to only be on the source node,
22:15:30	mriedem	i remember why you were hitting the format issue where the reschedules on build thought we were doubling up again when claiming on the alterante,
22:15:44	mriedem	and it was because we hit that before the compute had removed the allocation the instance had on the failed node
22:15:55	mriedem	https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4091
22:16:02	mriedem	"either way we need to cleanup any allocations created # by the scheduler for the destination node."
22:16:25	mriedem	so yeah, that's why on the reschedule, claim_resources doesn't think we're doubling, because the instance doesn't have a claim on the old failed dest node
22:17:03	figleaf	mriedem: yeah, that was the racy part that I fixed by moving it earlier before the cast
22:17:39	figleaf	I ran some traces, and set_and_clear_allocations() is being called for each reschedule
22:22:14	openstackgerrit	Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
22:22:28	figleaf	mriedem: ^^ if you still have brain cycles
22:22:59	fried_rice	figleaf It occurs to me I should be prepping the agenda for the sched meeting. Is ^ the only remaining thing for alternates?
22:23:58	figleaf	fried_rice: yes
22:24:08	fried_rice	k
22:27:39	mriedem	figleaf: comments inline,
22:27:52	mriedem	figleaf: plus a question about ordering, something for probably superdan to look at on monday for a 2nd opinion
22:30:03	figleaf	mriedem: ok, thx
22:30:21	figleaf	mriedem: now turn off your brain and enjoy your holiday
22:45:41	openstackgerrit	Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436
22:48:27	ildikov	mriedem: if you have any homework for me too lemme know otherwise have fun!!! :)
22:50:02	mriedem	can't think of any
22:50:27	mriedem	melwitt: i updated the novaclient release patch to depend on the top of the series for the novaclient removal changes, once those are merged we'd just need to modify the hash in the release patch and then that should be good to go
23:27:26	openstackgerrit	Eric Fried proposed openstack/nova master: ProviderTree.snapshot => ProviderSnapshot https://review.openstack.org/533244
#openstack-nova - 2018-01-15
00:49:41	prometheanfire	nova doesn't look like it supports the new os_vif https://review.openstack.org/532987
01:01:55	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Fix allocation_candidates not to ignore shared RPs https://review.openstack.org/533396
01:01:56	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437
01:25:27	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: [placement] Fix resource provider delete https://review.openstack.org/529519
01:36:51	openstackgerrit	Wangpan proposed openstack/nova stable/pike: Handle glance exception during rotating instance backup https://review.openstack.org/533439
02:02:40	openstackgerrit	Huang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
02:09:29	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
02:47:44	openstackgerrit	Huang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
03:03:34	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc https://review.openstack.org/528201
03:04:00	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520
04:16:32	openstackgerrit	Chen Hanxiao proposed openstack/nova master: test: Use assertEqual() instead of assertXXXEqual() https://review.openstack.org/533493
05:06:05	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
05:09:40	openstackgerrit	Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
05:27:11	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for resource class API https://review.openstack.org/524506
05:27:24	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for resource class API https://review.openstack.org/524506
05:47:16	openstackgerrit	Huang Rui proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
06:00:02	openstackgerrit	Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
06:45:02	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination https://review.openstack.org/528601
06:45:02	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Add support for the 2.57 microversion https://review.openstack.org/528128
06:45:03	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168
06:56:38	openstackgerrit	jichenjc proposed openstack/nova master: WIP: Add zvm CI information https://review.openstack.org/533512
07:33:17	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state https://review.openstack.org/531117
07:33:18	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table https://review.openstack.org/530429
07:35:59	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination https://review.openstack.org/516168
08:06:25	ameeda	Hi
08:06:42	ameeda	how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"
08:57:59	bauzas	morning Novaers
08:58:12	bauzas	busy days
08:58:18	gibi	morning bauzas
08:59:30	bauzas	:)
09:16:10	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Add missing spaces in `nova list --changes-since` help https://review.openstack.org/533575
09:18:55	ameeda	bauzas: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"
09:19:05	ameeda	gibi: how can I update image properties in regression test function ? "self.image["properties"] = {key: value}"
09:25:24	bauzas	ameeda: you'd like to test some specific image properties ?
09:25:45	bauzas	is that in a unit test or a functional test ?
09:26:04	bauzas	if so, you'd mock the image
09:28:44	ameeda	bauzas: this is functional test, I want to update image properties then check if the value is changes "truncates" or not.
09:29:12	bauzas	ameeda: if that's for a functional test, you should just pass a specific image
09:29:31	openstackgerrit	Édouard Thuleau proposed openstack/nova master: Update plugs Contrail methods to work with privsep https://review.openstack.org/533212
09:31:51	ameeda	bauzas: you can see what I do here "http://paste.openstack.org/show/644825/"
09:32:57	ameeda	bauzas: I have to check if image properties of original image is same as image properties of snapshot image.
09:33:58	ameeda	bauzas: so I have to update image['properties'] , but I did that like this " image['properties']={key: value}, it doesn't works
09:35:17	Spazmotic	morning friends
09:35:52	bauzas	ameeda: I'd rather generate an image that would contain the property I'd like to test, and check eventually what I give
09:35:55	bauzas	s/give/get
09:36:07	bauzas	morning
09:37:15	ameeda	bauzas: when I tried to do client api.post_image(image) that give me API not found
09:37:18	openstackgerrit	Lee Yarwood proposed openstack/nova stable/pike: Handle glance exception during rotating instance backup https://review.openstack.org/533439
09:37:32	bauzas	ameeda: there is a fake Glance service that you can use for your purpose https://github.com/openstack/nova/blob/master/nova/tests/unit/image/fake.py
09:37:54	bauzas	then, you need to stub that service in the functional test
09:38:36	ameeda	bauzas: thank you for your time. do you have an example of stub ?
09:38:50	bauzas	like https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L1369
09:39:19	ameeda	bauzas: thanks!
09:39:30	bauzas	that should give you a "fake Glance" where you could create an image like you wish and pass the image ref to the Nova call you wish
09:40:21	bauzas	ameeda: HTH
09:40:56	ameeda	bauzas: let me check , I will ask you if I have another question :$
09:40:58	ameeda	Thanks
09:42:08	bauzas	ameeda: np and good luck
09:46:12	ratailor	Can anyone review https://review.openstack.org/#/c/498334/
09:46:22	ratailor	It goes in merge conflict every now and then..
09:49:16	mdbooth	ratailor: I'll look fwiw.
09:55:44	Spazmotic	whew... that was a good meal
09:57:52	Spazmotic	Did Gerritt go through any major changes in the past year? I logged in to make my first commit in a long time and old commits were gone
09:58:00	Spazmotic	wondering if i just accidentallied an ew user ㅋㅋㅋㅋ
09:58:48	Spazmotic	Not that it matters too terribly.. just curious
10:08:07	mdbooth	Spazmotic: Don't think so. Were they just abandoned for you?
10:08:21	Spazmotic	Possible.. was also a whole different release so maybe just something there.
10:10:13	Spazmotic	i'll pull up the commit some time later to see just how dumb I am.. too lazy and full now :D
10:10:39	Spazmotic	Cheat day.. so many carbs.. so many
10:36:42	ameeda	bauzas: Thank you very much, its work !!
10:36:50	ameeda	Regarding this gerrit https://review.openstack.org/#/c/528385
10:36:53	bauzas	cool
10:37:03	ameeda	I have another issue

Earlier   Later