| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-01-09 | |||
| 17:33:31 | dansmith | but maybe just upload and we can talk about it concretely | |
| 17:33:34 | bauzas | nevermind, I'll upload | |
| 17:33:40 | bauzas | sure, just working on the tests now | |
| 17:34:41 | bauzas | efried: +Wd | |
| 17:34:45 | efried | thx | |
| 17:35:02 | openstackgerrit | Merged openstack/nova master: Add an additional description for 'token_ttl' https://review.openstack.org/532007 | |
| 17:35:30 | dansmith | mriedem: did you check that this is actually using multiple cells? https://review.openstack.org/#/c/517273/39/nova/tests/functional/compute/test_migration_list.py | |
| 17:38:48 | mriedem | dansmith: i think he copied that from your instance list tests, but it doesn't look like it explicitly creates multiple cells | |
| 17:39:22 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/functional/compute/test_instance_list.py#L25 | |
| 17:39:24 | mriedem | he needs that | |
| 17:39:27 | mriedem | good point | |
| 17:39:29 | dansmith | but I set | |
| 17:39:32 | dansmith | yeah :) | |
| 17:39:39 | mriedem | removed my +2 | |
| 17:39:54 | mriedem | lay down the -1 | |
| 17:40:05 | dansmith | I done did | |
| 17:44:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: add tests to check multipath in iscsi/fc volume connectors https://review.openstack.org/532272 | |
| 17:47:23 | mriedem | dansmith: per https://review.openstack.org/#/c/517273/39/nova/db/sqlalchemy/api.py@4410 did you want to hold up https://review.openstack.org/#/c/514904/ ? | |
| 17:47:49 | dansmith | no I just wanted to make the comment to sound like I'm paying attention | |
| 17:47:54 | mriedem | heh, ok | |
| 19:15:20 | openstackgerrit | Mark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532287 | |
| 19:15:20 | openstackgerrit | Mark Goddard proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116 | |
| 19:15:21 | openstackgerrit | Mark Goddard proposed openstack/nova master: Add has_any_traits() to provider tree https://review.openstack.org/532289 | |
| 19:15:21 | openstackgerrit | Mark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | |
| 19:15:22 | openstackgerrit | Mark Goddard proposed openstack/nova master: Call get_traits() in the resource tracker https://review.openstack.org/532290 | |
| 19:31:44 | efried | mgoddard Let me know if you want to chat about ^ | |
| 20:13:14 | mriedem | wait wait wait, | |
| 20:13:18 | mriedem | johnthetubaguy has a minion? | |
| 20:15:23 | openstackgerrit | Merged openstack/nova master: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763 | |
| 20:18:37 | rybridges | Hey Guys! Have a really quick question. Related to this spec: https://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/quiesced-image-snapshots-with-qemu-guest-agent.html | |
| 20:19:17 | rybridges | Is that QEMU guest agent that is mentioned something that a user would install on their own instance? Or is that something that we (as operators) would install on the hypervisor itself? | |
| 20:20:29 | mriedem | rybridges: it's in the image | |
| 20:20:44 | mriedem | ‘hw_qemu_guest_agent=yes’ property and ‘hw_require_fsfreeze=yes’ property is set on the image metadata, and QEMU Guest Agent is installed and enabled in the instance | |
| 20:20:54 | mriedem | s/in the instance/in the image/ | |
| 20:21:12 | mriedem | the image metadata is just telling nova that the image has the guest agent and requires fsfreeze | |
| 20:21:14 | mriedem | prior to snapshot | |
| 20:24:09 | rybridges | ok so the part i am confused about is "QEMU Guest Agent is installed and enabled in the instance" | |
| 20:24:20 | rybridges | so this means we would bake the QEMU Guest Agent into the image itself | |
| 20:24:33 | rybridges | such that when we boot an instance, the QEMU Guest Agent will automatically come up and be enabled | |
| 20:25:33 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api https://review.openstack.org/271047 | |
| 20:25:44 | ildikov | mriedem: ^^ | |
| 20:26:12 | mriedem | rybridges: yes | |
| 20:26:20 | mriedem | that's my understanding, nova doesn't inject something into the image | |
| 20:26:25 | openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI https://review.openstack.org/526094 | |
| 20:33:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations https://review.openstack.org/517273 | |
| 20:33:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add index(updated_at) on migrations table. https://review.openstack.org/531132 | |
| 20:33:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | |
| 20:34:08 | mriedem | dansmith: i addressed the 2 addressable comments in the migration multi-cell lister patch ^ | |
| 20:38:09 | rybridges | ok thanks mriedem | |
| 20:38:34 | mriedem | rybridges: https://www.sebastien-han.fr/blog/2015/02/09/openstack-perform-consistent-snapshots-with-qemu-guest-agent/ ? | |
| 20:38:42 | mriedem | old blog but probably still good | |
| 20:41:15 | mriedem | stvnoyes: finally got that snapshot test passing http://logs.openstack.org/86/531386/7/check/tempest-full/eca51c5/job-output.txt.gz#_2018-01-09_19_34_20_731609 | |
| 20:41:17 | mriedem | but failed in teardown | |
| 20:41:38 | mriedem | http://logs.openstack.org/86/531386/7/check/tempest-full/eca51c5/job-output.txt.gz#_2018-01-09_20_01_02_052268 | |
| 20:41:41 | mriedem | hmm, failed to delete the volume, | |
| 20:42:20 | stvnoyes | i never like it when problems happen in teardown... | |
| 20:42:25 | mriedem | but the test is explicitly deleting the volume and cascading it's snapshot delete https://review.openstack.org/#/c/266605/24/tempest/api/compute/volumes/test_attach_volume.py@417 | |
| 20:42:36 | mriedem | smcginnis: does the volume cascading delete stuff work? | |
| 20:42:52 | smcginnis | mriedem: Why do I feel like this is a trick question? | |
| 20:43:27 | mriedem | maybe i don't know what's possible, but, | |
| 20:43:38 | mriedem | i create a volume-backed instance and create a snapshot of it, which also creates a snapshot of the volume, | |
| 20:43:57 | mriedem | at the end of the test, i do a delete volume with cascade=True so i don't have to explicitly delete the volume snapshot | |
| 20:44:05 | mriedem | assuming that's OK? | |
| 20:44:37 | smcginnis | mriedem: So from Cinders perspective that's just a volume with a snapshot. So yeah, that should work if you pass cascade=True and it should delete any child snapshots on volume deletion. | |
| 20:45:30 | mriedem | weird, don't even see the error in the c-api logs | |
| 20:45:37 | mriedem | oh here we go | |
| 20:46:45 | mriedem | damn c-api log doesn't really tell me anything | |
| 20:47:24 | mriedem | OH | |
| 20:47:25 | mriedem | i see | |
| 20:47:31 | mriedem | INFO cinder.api.openstack.wsgi [None req-57d5906a-2c27-4546-8fbd-21d355fd886d tempest-AttachVolumeMultiAttachTest-336010326 tempest-AttachVolumeMultiAttachTest-336010326] https://10.0.1.221/volume/v3/1e7533c90d794cf8a7463d9a7473244e/volumes/42c444d7-4b3a-42f0-a2d6-3fe652814e05?cascade=True returned with HTTP 202 | |
| 20:47:39 | mriedem | that's the one i'm doing and it's a 202 | |
| 20:47:51 | mriedem | INFO cinder.api.openstack.wsgi [None req-4afc5bd6-64cd-444b-9d7f-51e87a67c0e4 tempest-AttachVolumeMultiAttachTest-336010326 tempest-AttachVolumeMultiAttachTest-336010326] https://10.0.1.221/volume/v3/1e7533c90d794cf8a7463d9a7473244e/volumes/42c444d7-4b3a-42f0-a2d6-3fe652814e05 returned with HTTP 400 | |
| 20:48:01 | mriedem | that's the one that tempest teardown is doing becaues i'm not waiting for my call to complete | |
| 20:48:02 | mriedem | drats | |
| 20:48:30 | smcginnis | Oh, so it's trying to delete the volume without cascade while your call is still cleaning up? | |
| 20:48:52 | mriedem | yeah | |
| 20:48:55 | mriedem | i just need to add a waiter | |
| 20:49:01 | mriedem | easy peasy | |
| 20:49:31 | mriedem | ildikov: i don't know why but your api update says it's in merge conflict | |
| 20:50:09 | ildikov | mriedem: maybe because the shared_targets patch didn't get through the gate due to zuul issues or smth? | |
| 20:50:52 | ildikov | mriedem: I didn't want to rebase until that's merged... | |
| 20:51:01 | mriedem | yeah that's fine, i'm going to update this tempest patch | |
| 20:51:57 | ildikov | I only changed the top patch and downloaded the whole chain fresh before | |
| 20:52:09 | ildikov | I will check on zuul and see where things are | |
| 20:57:13 | mriedem | 5: (529695,5) Use volume shared_targets to lock during attach/detach (8h17m/++++~+~++++/rem:1h56m) | |
| 20:57:29 | mriedem | #5 in the gate so should be merged soonish | |
| 20:57:56 | mriedem | it's only been there for 8.5 hours already.. | |
| 21:00:25 | mriedem | ildikov: ok i guess i'll start working on adding tests for the new flows when the microversion is high enough and multiattach is True | |
| 21:02:49 | ildikov | mriedem: ok, I'm not touching the chain then | |
| 21:03:04 | ildikov | mriedem: the unit and functional tests are fixed in the latest version | |
| 21:03:10 | ildikov | at least it worked for me... | |
| 21:14:10 | mriedem | mdbooth: damn, i ran that isolated test thing, 178 tests in my worker list to comb through :( | |
| 21:14:20 | mriedem | the bisect analyzer couldn't figure it out | |
| 21:15:45 | mriedem | although, i guess the idea is you can continue to wittle the results down with the smaller set of tests each time | |
| 21:23:40 | openstackgerrit | Merged openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64 https://review.openstack.org/530965 | |
| 21:33:43 | openstackgerrit | Merged openstack/nova master: Use volume shared_targets to lock during attach/detach https://review.openstack.org/529695 | |
| 21:38:20 | openstackgerrit | Hongbin Lu proposed openstack/nova master: placement: add API reference for create inventory https://review.openstack.org/511342 | |
| 21:42:28 | openstackgerrit | Ed Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize https://review.openstack.org/526436 | |
| 21:42:50 | edleafe | mriedem: ^^ addressed your concerns, and then some | |
| 22:14:52 | openstackgerrit | Merged openstack/nova stable/pike: doc: Add configuration index page https://review.openstack.org/531042 | |