| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-12-15 | |||
| 13:45:03 | Adri2000 | bauzas: I assume a tabular output like this is nnot meant to be parsed by a script or by an ansible playbook.. | |
| 13:46:49 | Adri2000 | bauzas: openstack-ansible currrently automatically runs create_cell with the rabbitmq nodes etc as a parameter. if the list of rabbitmq nodes changes (like you add or remove a node of your rabbit cluser), the create_cell command is run again (but with different parameters because of the rabbitmq nodes list) | |
| 13:46:58 | Adri2000 | and it creates a duplicate cell | |
| 13:47:15 | openstack | Launchpad bug 1736731 in openstack-ansible "os_nova might create a duplicate cell1" [High,Confirmed] - Assigned to Jean-Philippe Evrard (jean-philippe-evrard) | |
| 13:47:15 | Adri2000 | (https://bugs.launchpad.net/openstack-ansible/+bug/1736731 if you're interested) | |
| 13:47:37 | Adri2000 | anyway, we figured openstack-ansible should check whether the cell already exists, if it does, run update_cell instead | |
| 13:47:46 | Adri2000 | and that's why I need the cell id... | |
| 13:48:58 | Adri2000 | for the record, the triple folks had a similar bug and fixed it with a beautiful | sed | awk parsing: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ebcaabcc5c5d2840128b3609c82c4a70a81ea0a0 | |
| 13:49:47 | Adri2000 | but I'm not very happy with that solution :( | |
| 13:51:33 | Adri2000 | bauzas: does it even make sense that nova allows two different cells having the same name? | |
| 13:52:32 | bauzas | Adri2000: for your first concern, I understand your point | |
| 13:53:36 | bauzas | for the second, lemme see if it's possible | |
| 14:02:40 | mriedem | bauzas: artom's request_specs.spec column increase is ready to go imo https://review.openstack.org/#/c/528012/ | |
| 14:02:54 | bauzas | mriedem: ack, looking | |
| 14:03:32 | bauzas | mriedem: jay said litterally no performance impact for the alter, right? | |
| 14:03:49 | mriedem | that's what i think i heard yeah | |
| 14:06:54 | artom | bauzas, the caveat was that it's only for InnoDB | |
| 14:07:08 | artom | So I'm a bit worried we might be screweing over some non-InnoDB folks | |
| 14:07:36 | artom | But I understood that we only really support MySQL, and therefore InnoDB | |
| 14:09:03 | bauzas | artom: well, myisam seems weird for nova tables :p | |
| 14:09:25 | bauzas | of course, it could be for other engines but AFAIK, we only support innodb | |
| 14:10:36 | bauzas | anyway | |
| 14:10:40 | openstackgerrit | Takashi NATSUME proposed openstack/nova stable/pike: [placement] Fix an error message in API validation https://review.openstack.org/526465 | |
| 14:11:29 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [cellv2] Improve getting BDMs in multiple cells https://review.openstack.org/521400 | |
| 14:12:06 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Fix getting placement request ID https://review.openstack.org/523606 | |
| 14:13:17 | artom | bauzas, MyISAM seems weird for anything, really | |
| 14:13:30 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Deduplicate functional test code https://review.openstack.org/526227 | |
| 14:13:32 | artom | Is there a workload where it would actually be better? | |
| 14:14:20 | maciejjozefczyk | mriedem: Please take a look on this patch https://review.openstack.org/#/c/520024/. We spoke about it during summit | |
| 14:18:12 | mriedem | it's on my list. i see gibi has been looking at it. | |
| 14:19:09 | maciejjozefczyk | mriedem: yes, related test that failed eariler has been fixed with some change related to ironic | |
| 14:19:19 | maciejjozefczyk | thanks :) | |
| 14:20:38 | giblet | maciejjozefczyk: ahh so the failing test is not blocking it any more, that helps | |
| 14:20:45 | maciejjozefczyk | giblet: yea | |
| 14:20:51 | giblet | maciejjozefczyk: I just opened the patch will look it through shortly | |
| 14:20:59 | maciejjozefczyk | giblet: ;) | |
| 14:24:11 | bauzas | artom: FK != MyIsam ;) | |
| 14:24:31 | bauzas | so indeed :p | |
| 14:34:58 | artom | bauzas, seriously, it doens't have foreign keys? | |
| 14:35:17 | artom | I seem to recall still being able to do JOINs with MyISAM though | |
| 14:35:23 | artom | I guess those don't depend on FKs? | |
| 14:35:30 | artom | Like I said, my SQL isn't too hot | |
| 14:35:49 | bauzas | artom: of course, denormalized works | |
| 14:36:06 | bauzas | mriedem: FWIW https://stackoverflow.com/questions/3516290/any-pitfalls-of-converting-mysql-text-field-to-mediumtext | |
| 14:36:25 | bauzas | only a client possible impact about memory usage | |
| 14:36:26 | bauzas | but meh | |
| 14:36:55 | giblet | maciejjozefczyk: left a small nit in https://review.openstack.org/#/c/520024 . Ping me when you fixed it and I will +2 the patch | |
| 14:37:31 | maciejjozefczyk | giblet: ok :) thanks | |
| 14:38:44 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: update_cell allows more than once cell to have the same db/transport url https://review.openstack.org/518556 | |
| 14:41:01 | openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance https://review.openstack.org/516899 | |
| 14:41:44 | bauzas | artom: mriedem: +Wd with a comment | |
| 14:43:07 | mriedem | ack thanks | |
| 14:43:27 | mriedem | bauzas: so before i even think about backports and releasing this in stable branches, | |
| 14:43:59 | mriedem | let me know now before i do that what kind of freakouts your internal deployment team is going to have if it's released with the wrong version | |
| 14:44:20 | mriedem | i'm assuming they want a minor version update | |
| 14:44:23 | mriedem | so 16.1.0 for pike | |
| 14:47:13 | lyarwood | mriedem: I don't see why they would have issues with this as a release or minor bump tbh | |
| 14:47:15 | bauzas | mriedem: good point | |
| 14:47:48 | bauzas | a DB alter is at least a minor change, not a .z | |
| 14:47:56 | bauzas | but I think it's acceptable for us | |
| 14:49:25 | openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Update resources once in update_available_resource https://review.openstack.org/520024 | |
| 14:49:58 | maciejjozefczyk | giblet: ping :) you're right | |
| 14:50:03 | maciejjozefczyk | giblet: updated | |
| 14:50:09 | giblet | maciejjozefczyk: looking... | |
| 14:53:16 | artom | bauzas, lyarwood, so dansmith was saying that we can release it as a .z, and people who don't know about it won't do the db sync | |
| 14:53:28 | giblet | maciejjozefczyk: thanks, +2 | |
| 14:53:42 | artom | And they'll get the migration on their next major upgrade like everyone else | |
| 14:54:03 | artom | But people who are affected will have one more step in their .z upgrade path | |
| 14:54:07 | maciejjozefczyk | giblet: thanks too ;) | |
| 14:54:09 | lyarwood | artom: right, the NVR really doesn't change that for us, but it's still a minor release bump change as bauzas highlighted. | |
| 14:55:04 | artom | lyarwood, ah, I see | |
| 14:55:30 | artom | In any case, it's not like our deployment tooling/packaging does 'db sync' on yum update, so I think we're good | |
| 14:55:56 | lyarwood | artom: yup indeed | |
| 14:59:28 | mriedem | so after your red hat meeting, what have you agreed the rest of us must do? | |
| 14:59:31 | mriedem | minor bump? | |
| 14:59:51 | artom | Well, we'd like a interpretative-dance-off | |
| 14:59:58 | artom | But we'll settle for minor bump | |
| 15:00:03 | mriedem | i seem to remember the rdo / rhosp tooling used to do a full db sync on a minor update or something | |
| 15:00:28 | mriedem | idk, but last time we backported something like this and i didn't use the proper semver scheme i got in trouble | |
| 15:00:54 | mriedem | from frank in L3 RHOSP QE | |
| 15:01:06 | bauzas | mriedem: it's just the fact we don't package by numbering with semversioning | |
| 15:01:18 | bauzas | I know, it's sad | |
| 15:09:37 | mriedem | andreykurilin_: seems we should deprecate get_resource_manager_extra_kwargs within novaclient | |
| 15:09:52 | mriedem | used to call hooks to get extra boot kwargs to pass to POST /servers | |
| 15:10:10 | mriedem | which is likely broken since 2.1 in the server | |
| 15:10:55 | andreykurilin_ | mrieden: give me a sec to look what get_resource_manager_extra_kwargs is :) | |
| 15:13:24 | andreykurilin_ | mriedem: actually, not sure that it is broken. it looks like not used at all | |
| 15:13:31 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: WIP: Add support for the 2.57 microversion https://review.openstack.org/528128 | |
| 15:13:54 | mriedem | andreykurilin_: i mean, if someone did have a hook and they passed extra arguments in the request body to POST /servers, | |
| 15:13:55 | mriedem | it would fail | |
| 15:14:03 | mriedem | because we have strict schema checking on the request body | |
| 15:14:45 | mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L59 | |
| 15:16:20 | andreykurilin_ | mriedem: yes. but get_resource_manager_extra_kwargs iterates over hooks which were added via add_resource_manager_extra_kwargs_hook. And I do not see any calls for that method. Since add_resource_manager_extra_kwargs_hook is documented as CLI helper, It should not be used outside the novaclient and I suppose we can just remove both of these methods without deprecation | |
| 15:17:09 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 15:18:17 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient master: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 15:19:01 | andreykurilin_ | mriedem: btw, https://review.openstack.org/#/c/424256 is waiting for your review ;) | |
| 15:19:22 | mriedem | ok | |
| 15:19:45 | mriedem | fun | |
| 15:19:45 | mriedem | btw, single bed at the ptg hotel, it'll be like living in the dorms in college again | |
| 15:20:04 | andreykurilin_ | lol | |