Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-11-14
15:10:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Validate new image via scheduler during rebuild https://review.openstack.org/519662
15:12:19 efried jaypipes So I'm clear, does ProviderTree include the resources, or just the provider hierarchy?
15:12:49 openstackgerrit Ilya Shakhat proposed openstack/nova master: Initialize osprofiler in uWSGI application https://review.openstack.org/519664
15:13:14 sean-k-mooney efried: i think the full tree with the resouces. at least that is what i had assumed at the PTG
15:13:36 jaypipes jianghuaw_: for now, yes, that's the plan. eventually, a generic device manager may also get called... but that's later on.
15:13:36 jianghuaw_ jaypipes, do you have a rough plan on when will start to add the interface of update_inventory()?
15:13:50 efried sean-k-mooney That would make sense if the method is called update_inventory
15:13:55 jaypipes efried: no, inventory records are kept in the ProviderTree for each resource class the provider provides
15:14:24 jianghuaw_ jaypipes, just wonder if it's proper time to start n-rp work for vgpu in XenAPI.
15:16:02 openstackgerrit Xuanzhou Perry Dong proposed openstack/nova master: Check for volume size https://review.openstack.org/519666
15:16:10 efried jianghuaw_ If you do, you'll have to base it on the series in progress, starting at https://review.openstack.org/#/c/377138/
15:17:35 jianghuaw_ efried, thanks. yes I have been looking at this series of patches.
15:18:26 efried jianghuaw_ But also note that we (jaypipes, alex_xu, me, etc.) haven't yet written the GET /allocation_candidates affordance for nrp.
15:18:52 efried Which could make the scheduling results... unpredictable.
15:19:56 jianghuaw_ efried, I see. I had some testing today. I understood n-rp has not been completed yet. But wonder if we can do things in parallel.
15:20:14 sean-k-mooney efried: is the numbered traits syntax for associating tratis and resouce requests that was discussed at the summit still going ahead for pike.
15:20:29 sean-k-mooney sorry queens
15:20:40 efried jianghuaw_ To some extent, in the sense that more than one person can be proposing patches for the various pieces of functionality; but in this case, they should probably be proposed on that same series. Which can get confusing for rebases.
15:21:09 efried sean-k-mooney Yes, and good progress has been made there. At this point it's stalled waiting for the big refactor series starting at https://review.openstack.org/#/c/516778/
15:21:50 sean-k-mooney efried: good to hear is the requesting traits via flavours work integrated with this also
15:21:57 jianghuaw_ efried, understood.
15:22:41 efried sean-k-mooney Yes. The code to parse granular resources & traits from flavor extra specs, pass to the scheduler, pass to GET /allocation_candidates, parse in placement from the querystring, and pass to the internal methods - all that is done.
15:23:15 efried sean-k-mooney The remaining piece is to make said internal methods actually Do The Right Thing with that information, which will bump the placement microversion; and then switch on the support from the scheduler side.
15:23:48 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Validate new image via scheduler during rebuild https://review.openstack.org/519672
15:24:32 efried sean-k-mooney You can see that stuff here: https://review.openstack.org/#/q/topic:bp/granular-resource-requests
15:25:16 sean-k-mooney efried: ah ok, so yes good progress is certenly apt. that will make my verified boot friend very happy to hear once i translate it for them.
15:27:37 sean-k-mooney jaypipes: on that note im going to split all the stateful traits into seperate patches. i know currently we do not want to standardies stateful traits so until we come to a dession on how to model the state of capablities ill advise the use of CUSTOM_ traits
15:30:08 jaypipes jianghuaw_: I'd appreciate another week to get more n-r-p stuff merged.
15:30:32 jaypipes sean-k-mooney: there's no such thing as a stateful trait... I'll respond to you on those patches.
15:31:05 jianghuaw_ jaypipes: cool. Thanks.
15:31:31 sean-k-mooney jaypipes: :) i know but without inventing another entity to tag ever resouce provider with and request every where we request a trait im inventing that term untill we have something better
15:32:20 sean-k-mooney jaypipes: but for now ill reduce the scope of those patches to just capabilities with no state implied as you suggesed in the patch reviews previously
15:32:41 jaypipes sean-k-mooney: whether or not a particular trait is applied to a specific resource provider is not relevant to what the trait represents.
15:32:46 jaypipes sean-k-mooney: that's all I'm saying.
15:33:23 jaypipes sean-k-mooney: if a node supports UEFI boot mode, then it supports UEFI boot mode. Whether or not that node is *booted* using UEFI boot mode is entirely a different thing.
15:34:43 jianghuaw_ jaypipes, I'd appreciate if you can have time to review these patches again: https://review.openstack.org/#/c/512965 https://review.openstack.org/#/c/516217/
15:34:45 sean-k-mooney jaypipes: yep understood traits solves the fomer. i had hoped it could be used to solve the later but if we want to use something else for that then that is fine too so long as we can eventually solve both
15:41:17 crlb Hello jaypipes, can I ask you about change #516796?
15:41:43 openstackgerrit Matt Riedemann proposed openstack/nova stable/ocata: Validate new image via scheduler during rebuild https://review.openstack.org/519681
15:41:46 efried sean-k-mooney What patches are we talking about?
15:42:35 sean-k-mooney efried: https://review.openstack.org/#/q/status:open+project:openstack/os-traits+branch:master+topic:verified_boot
15:43:10 efried sean-k-mooney Thanks. We had a discussion along these lines with the ironic folks too. Did you see the summary in the ML?
15:43:29 sean-k-mooney efried: also https://review.openstack.org/#/c/514737/ but im less concured about that one but it does better illistrate the type of configuration associated with the capablities that we would like to model eventurally
15:44:00 sean-k-mooney efried: no but i was aware that disscution was going to take place
15:45:02 efried sean-k-mooney Here's the summary -- and there's a link to the video recording if you want to sit through the whole thing (and see costumes): http://lists.openstack.org/pipermail/openstack-dev/2017-November/124200.html
15:46:24 sean-k-mooney efried: oh cool thanks. ya i will try and let it play in the background to get up to speed. that said im not sure how much time i will have on this or any topic going forword
15:46:53 efried understood
15:49:13 openstackgerrit Matt Riedemann proposed openstack/nova stable/newton: Validate new image via scheduler during rebuild https://review.openstack.org/519684
15:49:49 mriedem dansmith: bauzas: https://review.openstack.org/#/q/I11746d1ea996a0f18b7c54b4c9c21df58cc4714b
15:50:05 mriedem tristanC: any other way you want to advertise this?
15:51:20 tristanC mriedem: could we get +2 on the patches as well as the related change on stable/newton?
15:51:41 jianghuaw_ mriedem, could you suggest what I should do to move forward these two patches? https://review.openstack.org/#/q/topic:vdiStream+(status:open+OR+status:merged)+project:+openstack/nova
15:52:01 mriedem tristanC: that's why i pinged dan and sylvain
15:52:06 mriedem they are stable core
15:52:16 mriedem and master branch core for that matter...
15:52:50 tristanC does the pre-OSSA update looks good to you?
15:53:05 mriedem tristanC: the etherpad?
15:53:21 tristanC yes, https://etherpad.openstack.org/p/ofe4voc7sg
15:53:22 mriedem etherpad looks fine
15:53:30 sean-k-mooney hum... on the plus side my openstack --os-cloud devstack-admin --os-region RegionOne compute service list --host vhost-user --service nova-compute -c ID -f value issue also happens on ubuntu. on the negitive side it also happens on ubuntu ...
15:53:53 mriedem sean-k-mooney: what issue?
15:54:18 tristanC mriedem: thanks!
15:54:31 mriedem jianghuaw_: do you mean regarding the blueprint?
15:54:38 sean-k-mooney mriedem: devstack is failing for me with "Didn't find service registered by hostname after 60 seconds" checking for the nova compute service to be registered
15:55:02 jianghuaw_ mriedem, yes.
15:55:03 jaypipes sean-k-mooney: apologies, keep getting ripped away :(
15:55:10 mriedem sean-k-mooney: does the hostname match what's getting created via the discover_hosts CLI?
15:55:24 mriedem discover_hosts CLI is what creates the host mappings in the cell in the api db
15:55:46 sean-k-mooney mriedem: ill check the conductor console auth and scheduer are registered
15:55:48 mriedem jianghuaw_: i wish you would have asked several weeks ago, before the spec freeze
15:56:03 jaypipes crlb: yessir
15:56:22 openstackgerrit Eric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure https://review.openstack.org/519464
15:56:51 jianghuaw_ mriedem, that's a shame. I thought I asked here to get reviewing on the patches.
15:57:46 jianghuaw_ mriedem, I thought that's spec-less BP.
15:58:14 mriedem jianghuaw_: it is a specless bp, but i generally consider new bp approval freeze to be at the same time as the spec freeze, which was october 19
15:58:16 mriedem nearly a month ago
15:58:30 mriedem it's my fault for not being clear about that,
15:58:43 mriedem but also, specless blueprints are supposed to be brought up in the weekly nova meeting to get discussion and approval
15:58:52 jianghuaw_ mriedem, sorry. That's my fault.
15:58:57 openstack Launchpad bug 1727266 in OpenStack Compute (nova) "archive_deleted_instances is not atomic for insert/delete" [Undecided,In progress] - Assigned to Surya Seetharaman (tssurya)
15:58:57 tssurya dansmith : thanks for the review I will address the comments soon, and yes you are right about the integrity issue with regards to us ending up with a different list of uuids than what we actually deleted, the same problem also exists between the list of records inserted into the shadow tables and the list archived - we had a bug reported ; https://bugs.launchpad.net/nova/+bug/1727266
15:59:13 tssurya dansmith : maybe we need to first query for the list of records whose deleted flag is set; use that list to insert into the shadow tables, archive from the actual tables and also return the same list for deleting the instance_mappings and request specs ?
15:59:48 mriedem jianghuaw_: https://docs.openstack.org/nova/pike/contributor/blueprints.html#specs "When a blueprint does not require a spec it still needs to be approved before the code which implements the blueprint is merged. Specless blueprints are discussed and potentially approved during the Open Discussion portion of the weekly nova IRC meeting. See trivial specifications for more details."
16:00:17 dansmith tssurya: just about to jump on a call so I can't really process that in my head at the moment, so can you put it in the review for me to read when I circle back?
16:00:23 jianghuaw_ mriedem, got it. Thanks.
16:00:33 tssurya dansmith : yes of course
16:00:42 crlb jaypipes I'm running tox locally and getting no errors. However, on the review, Zuul, Dell, and Xen, appear to give errors that I don't understand. Is there something else I should be doing?
16:00:50 dansmith tssurya: thanks
16:01:38 mriedem tristanC: +2s on https://review.openstack.org/#/q/I11746d1ea996a0f18b7c54b4c9c21df58cc4714b
16:01:40 tristanC dansmith: thanks, appreciated the fast review!
16:01:41 dansmith mriedem: tristanC I just hit the last one
16:01:46 dansmith heh, yep
16:01:48 mriedem dansmith: thanks
16:02:05 mriedem i will assume bauzas is on the same call
16:02:08 jaypipes crlb: how are you running tox locally?
16:02:15 jaypipes crlb: do this: tox -epy27,pep8
16:02:23 jaypipes crlb: and you'll see the same errors.
16:02:31 tristanC i'm waiting for vmt +2 on the ossa (https://review.openstack.org/519686) to send the advisory
16:04:54 mriedem ack
16:05:35 bauzas mriedem: thanks for helping with https://review.openstack.org/#/c/519662/

Earlier   Later