| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-27 | |||
| 14:05:31 | mriedem | belmoreira: ok - the key thing being that you leave one compute at ocata until all of the other pike computes have reported their information | |
| 14:06:04 | mriedem | belmoreira: and you'd need some tooling to verify that is done, like querying placement for all active instances to make sure they show up with allocations | |
| 14:08:41 | belmoreira | mriedem ok. thanks | |
| 14:09:04 | bauwser | mriedem: https://review.openstack.org/#/c/515530/2/nova/conductor/manager.py@831 are you sure we can't have a rebuild where host=None ? I thought it was | |
| 14:09:18 | mriedem | bauwser: not for "rebuild" | |
| 14:09:27 | bauwser | mmmm | |
| 14:09:38 | bauwser | okay, then nevermind my -1, I'll changeit | |
| 14:09:49 | mriedem | bauwser: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2948 | |
| 14:09:56 | mriedem | rebuild wants to bypass the scheduler | |
| 14:10:15 | bauwser | that was my only concern, I was wanting to make sure that we were rebuilding by using the right image, which is image_ref | |
| 14:10:23 | bauwser | I mean, the target image | |
| 14:10:25 | mriedem | see the plethora of comments in the rebuild_intsance method i added recently about all of the fun conditionals and in what cases we get there from the voodoo in the api | |
| 14:10:32 | bauwser | yeah | |
| 14:10:33 | mriedem | bauwser: yeah that's a long-standing bug | |
| 14:10:45 | mriedem | "new image for rebuild!? sure, what the hell, we trust you!" | |
| 14:11:02 | bauwser | yeah :( | |
| 14:11:16 | bauwser | I thought we were checking the image even for a rebuild | |
| 14:11:39 | bauwser | the evacuate is a special case because we can pass a destination as a target on the CLI | |
| 14:11:53 | bauwser | while rebuild is not | |
| 14:12:05 | mriedem | https://bugs.launchpad.net/nova/+bug/1667667 | |
| 14:12:07 | openstack | Launchpad bug 1667667 in OpenStack Compute (nova) "Rebuilding instance ignores image's property hw_disk_bus" [Low,In progress] - Assigned to 赵明俊 (falseuser) | |
| 14:12:19 | bauwser | I wonder what a true use ris | |
| 14:12:23 | bauwser | user is* | |
| 14:12:45 | bauwser | wait, you said we use instance.host right? | |
| 14:12:52 | mriedem | bauwser: for "rebuild" | |
| 14:12:54 | bauwser | so, we're *always* rebuilding on the same host ? | |
| 14:12:54 | mriedem | yes | |
| 14:12:59 | mriedem | for "rebuild" yes | |
| 14:13:04 | bauwser | WAAAAAAAAT | |
| 14:13:11 | bauwser | a world is failling down to me | |
| 14:13:17 | mriedem | rebuild != evacuate | |
| 14:13:21 | bauwser | that I know | |
| 14:13:40 | bauwser | I just thought we were just finding another host unless you allow the rebuild on the same host | |
| 14:13:57 | mriedem | that wasn't the bug, it was this one https://bugs.launchpad.net/nova/+bug/1664931 | |
| 14:13:59 | openstack | mriedem: Error: malone bug 1664931 not found | |
| 14:16:27 | bauwser | mriedem: okay, looks like I just forgot | |
| 14:16:38 | bauwser | mriedem: then, we need to tackle ^ | |
| 14:16:53 | bauwser | the patch is still valid in my mind | |
| 14:17:40 | mriedem | fried_rice: sdague: https://review.openstack.org/#/c/492247/ | |
| 14:19:16 | fried_rice | mriedem These get handled by passing them to KSA. | |
| 14:19:35 | fried_rice | mriedem But I'll see if cfg.DeprecatedOpt has a way for me to fill out 'since' and 'reason'. | |
| 14:19:36 | mriedem | fried_rice: the options themselves aren't called out as deprecated, | |
| 14:19:39 | mriedem | or when they were deprecated | |
| 14:19:52 | mriedem | fried_rice: you'd mark the nova opts as deprecated | |
| 14:19:55 | mriedem | in their definition | |
| 14:19:59 | mriedem | as normal | |
| 14:20:15 | fried_rice | ah, okay, will do. | |
| 14:20:23 | mriedem | but, i'm not done with this review yet, | |
| 14:20:24 | mriedem | so hold up | |
| 14:22:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | |
| 14:22:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820 | |
| 14:22:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | |
| 14:22:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860 | |
| 14:23:52 | openstackgerrit | Merged openstack/nova-specs master: Remove barbican from scope of ksa adapter work https://review.openstack.org/511524 | |
| 14:27:08 | openstackgerrit | Jianghua Wang proposed openstack/nova master: rt: Implement XenAPI get_inventory() method https://review.openstack.org/339204 | |
| 14:28:52 | jianghuaw | bauzas, leakypipes: ^ | |
| 14:29:23 | mriedem | fried_rice: ok comments inline | |
| 14:29:28 | fried_rice | mriedem Thanks | |
| 14:29:58 | jianghuaw | bauzas, thanks for spotting the issue. | |
| 14:32:53 | openstackgerrit | Merged openstack/nova master: Convert IVS VIF plugging / unplugging to privsep. https://review.openstack.org/515196 | |
| 14:34:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | |
| 14:34:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | |
| 14:34:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860 | |
| 14:34:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820 | |
| 14:42:44 | openstackgerrit | Merged openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | |
| 14:43:58 | bauwser | jianghuaw: friday nick FWIW | |
| 14:47:31 | openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247 | |
| 14:47:43 | fried_rice | mriedem See if those responses make sense ^ | |
| 14:48:59 | openstackgerrit | Merged openstack/nova master: rp: Remove RP.get_traits() method https://review.openstack.org/509027 | |
| 15:03:02 | fried_rice | leakypipes superdan https://review.openstack.org/#/c/499826/ please if you have a sec. (I'm trying to win cdent's prize.) (And the race to 1.11.) | |
| 15:07:55 | jianghuaw | bauwser, thanks:-) | |
| 15:11:59 | leakypipes | fried_rice: I'm trying to win the same prize :) | |
| 15:12:16 | leakypipes | fried_rice: damn it. | |
| 15:12:16 | fried_rice | leakypipes Oh, if that de-orm stuff counts, you're gonna win. | |
| 15:12:27 | leakypipes | fried_rice: nah, the n-r-p series adds 1.11 | |
| 15:12:38 | leakypipes | it's ok, though. I can rebase easy enough. | |
| 15:12:58 | fried_rice | leakypipes Yeah, we had like seven different 1.11 patches in flight. | |
| 15:13:06 | leakypipes | yeah it's cool :) | |
| 15:13:14 | leakypipes | I mean.. cool as in I know we did :) | |
| 15:13:19 | leakypipes | not that I relish rebasing | |
| 15:13:36 | fried_rice | leakypipes It made me think there ought to be a way to automate it. But that way lies madness. | |
| 15:13:50 | leakypipes | fried_rice: indeed | |
| 15:15:03 | mriedem | fried_rice: you didn't update the placement api-ref https://review.openstack.org/#/c/499826/ | |
| 15:15:09 | mriedem | time to -1? | |
| 15:15:31 | fried_rice | mriedem I thought it was because that guy already documented the missing link | |
| 15:16:00 | cdent | le sigh. so much rebase. | |
| 15:16:21 | mriedem | https://developer.openstack.org/api-ref/placement/#id2 ? | |
| 15:16:32 | fried_rice | mriedem Yeah, not. | |
| 15:16:38 | mriedem | fried_rice: just roll it on top | |
| 15:16:44 | mriedem | but know that i'm watching, always watching | |
| 15:16:45 | fried_rice | mriedem Will do. | |
| 15:17:03 | leakypipes | that reminds me I need to update the n-r-p REST API patch to amend the devref docs | |
| 15:17:08 | fried_rice | mriedem leakypipes I *was* thinking there should be some kind of "add a microversion checklist" internal doc for devs. | |
| 15:17:23 | mriedem | fried_rice: there are docs on adding microversions, | |
| 15:17:27 | mriedem | for both compute and placement | |
| 15:21:03 | mriedem | fried_rice: this is the doc for compute microversions https://docs.openstack.org/nova/pike/contributor/microversions.html | |
| 15:21:24 | mriedem | fried_rice: maybe add something here? https://docs.openstack.org/nova/pike/contributor/microversions.html#other-necessary-changes | |
| 15:21:56 | fried_rice | mriedem Remind me where the source for the api-ref docs is? | |
| 15:21:58 | mriedem | and this for placement https://docs.openstack.org/nova/pike/contributor/placement.html#microversions | |
| 15:22:03 | mriedem | nova/api-ref? | |