Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-10-26
17:16:39 openstackgerrit Vladyslav Drok proposed openstack/nova master: rbd: flatten images when unshelving https://review.openstack.org/457886
17:39:58 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
17:39:58 openstackgerrit Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
17:39:59 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
17:39:59 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159
17:40:00 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
17:40:29 edleafe mriedem: jaypipes: ^^ implemented SchedulerLimits for Selection
17:43:10 gibi mriedem: I've left my report about the notification subteam on the today's meeting agenda as I cannot participate.
17:43:28 mriedem gibi: ok, thanks
17:47:46 mriedem edleafe: thanks, soft -1 on the new comment that got added
17:47:54 mriedem since i'm working on making that comment partially untrue
17:53:54 jaypipes edleafe: cheers. will review shortly.
17:59:02 edleafe mriedem: well, since Jay wanted it recorded, I thought I'd include it, but I can easily remove it
17:59:13 mriedem jaypipes: i assumed he meant recorded in gerrit
17:59:33 edleafe mriedem: and Ill remove the mixin
18:00:02 edleafe Hmmm... when I'm researching code behavior, Gerrit isn't where I look
18:01:42 mriedem idk
18:01:42 mriedem so leave a generic comment about us having to include limits in this thing because they are per-alternative host which isn't the same thing as limits in reqspec and filter_properties
18:06:36 edleafe I removed it. It's not like adding it there will suddenly unlock the secrets of Nova to future generations of coders :)
18:07:25 mriedem right - i will still have to re-learn limits everytime i need to look at any of this
18:10:42 cdent jaypipes: since you were in that stack recently, you have time to blip in the spec tune up? https://review.openstack.org/#/c/509136/
18:32:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Use the RequestSpec when getting scheduler_hints in compute https://review.openstack.org/515461
18:32:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Pass RequestSpec to ConductorTaskAPI.build_instances https://review.openstack.org/515495
18:39:41 cfriesen repeat of earlier question since nobody answered it before...In _post_live_migration() at https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6075 why are we calling self._update_scheduler_instance_info() rather than self._delete_scheduler_instance_info() ? Seems logical that we would want to tell the scheduler "hey, this instance isn't here anymore".
18:40:17 jaypipes cdent: done
18:40:22 cdent thanks
18:42:26 mriedem cfriesen: it's likely wrong
18:42:39 mriedem cfriesen: i don't see post_live_migration_at_destination calling _update_scheduler_instance_info either
18:44:40 lbragstad mriedem: i'm reading some of nova's policy documentation - is this a typo? https://github.com/openstack/nova/blob/master/nova/policies/security_groups.py#L35
18:44:48 lbragstad s/not/now/ /
18:45:54 mriedem lbragstad: no,
18:46:10 mriedem because you can still add/remove a security group to a server
18:46:17 mriedem via the addSecurityGroup API action on the server resource
18:46:35 mriedem https://developer.openstack.org/api-ref/compute/#add-security-group-to-a-server-addsecuritygroup-action
18:46:41 lbragstad mriedem: ok - cool, just double checking
18:46:53 mriedem we could probably deprecate that...
18:47:04 mriedem we deprecated things like addFixedIP and addFloatingIP in pike
18:47:14 mriedem because you can do those in neutron via the port associated with the instance
18:47:45 mriedem and all nova is doing is getting the ports for the instance and the security group and updating the port to use the secgroup
18:47:49 mriedem that's stuff you could do in neutron
18:48:08 mriedem i can't remember if alex_xu proposed removing the secgroup actions as well
18:48:48 lbragstad yeah - i was just double checking because as i was reading it i wasn't sure if it was suppose to be deprecated or not and was a type
18:48:51 lbragstad typo*
18:54:54 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Allow _set_allocations to delete allocations https://review.openstack.org/501051
18:54:55 openstackgerrit Chris Dent proposed openstack/nova master: Include project_id and user_id in AllocationList.get_all_by_consumer_id https://review.openstack.org/512420
18:54:55 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Limit number of attempts to delete allocations https://review.openstack.org/507224
18:54:56 openstackgerrit Chris Dent proposed openstack/nova master: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073
18:54:56 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Symmetric GET and PUT /allocations/{consumer_uuid} https://review.openstack.org/510626
18:55:52 cdent jaypipes: ^ that ought to have it squashed and address the issues (I think)
18:56:08 jaypipes cdent: awesomesauce. thanks man. will review shortly.
19:01:40 openstackgerrit Merged openstack/nova-specs master: Fix issues for post-allocations spec https://review.openstack.org/509136
19:17:07 cdent that’s the end of my day
19:22:43 edleafe mriedem: so tests get messy without the ComparableVersionedObject. Is there a strong objection to keeping it in Selection?
19:27:21 efried cfriesen Could it be because we don't want to delete allocations from a shared RP, at least in theory?
19:32:54 smatzek I'm seeing some VM spawn issues in the Trove gate and am wondering if anyone has seen similar behavior. Trove spins up VMs in the nova-compute in devstack as part of its CI. 10-20% of the time now I'm seeing the VMs get stuck in spawn. It looks like the VM is started in libvirt and then Nova hangs out in this timer and never leaves. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2824
19:56:08 openstackgerrit Eric Fried proposed openstack/nova master: Enable _get_usages_by_provider_and_rc not filter on the resource class id https://review.openstack.org/514649
19:56:08 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Add _get_providers_with_any_resource method https://review.openstack.org/514197
19:56:09 openstackgerrit Eric Fried proposed openstack/nova master: Add ProviderSummaryList object https://review.openstack.org/514198
19:56:09 openstackgerrit Eric Fried proposed openstack/nova master: Add _get_traits_by_rp_ids method https://review.openstack.org/511184
19:56:10 openstackgerrit Eric Fried proposed openstack/nova master: Add AggregatedProviderSummary and AggregatedProviderSummaryList objects https://review.openstack.org/514200
19:56:10 openstackgerrit Eric Fried proposed openstack/nova master: Add more caches for the ProviderSummary and ProviderSummaryList https://review.openstack.org/514199
19:56:11 openstackgerrit Eric Fried proposed openstack/nova master: Add as_allocation_request_obj method to AggregatedProvierSummary obj https://review.openstack.org/514651
19:56:11 openstackgerrit Eric Fried proposed openstack/nova master: Add has_resources method to the AggregatedProviderSummary object https://review.openstack.org/514650
19:56:12 openstackgerrit Eric Fried proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766
19:56:32 efried alex_xu ^ I uncovered a bug, so I WIP'd the bottom change - see notes in commit message.
19:56:34 mikal jaypipes: Mr Finucane and I have a question for you on https://review.openstack.org/#/c/515196 when you have a moment.
19:58:06 cfriesen efried: mriedem: thanks, just wanted to make sure it wasn't something I missed
19:59:03 bfife kashyap: ping, bug#1706083. In Newton after an upgrade, I'm not seeing the proper cache value assigned to ephemeral ceph-backed storage on newly created instances. I've traced it to this commit
20:04:07 jaypipes mikal: done
20:06:50 mikal jaypipes: thanks man
20:13:33 mriedem edleafe: why would the tests care?
20:13:39 mriedem because of equality checks?
20:14:06 edleafe yeah
20:14:20 mriedem hmm, i think in other tests we have some types of compare_obj methods
20:14:31 mriedem which compare the fields
20:14:41 edleafe comparing the expected selection with the one that the filter_scheduler returns
20:15:21 mriedem i don't have a real strong objection to leaving it though
20:15:25 mriedem i just thought it was unused
20:15:53 edleafe Yeah, we went through this back in PS 5-7
20:16:07 mriedem the good old PSs
20:16:24 edleafe I had an explicit __eq__ method, and Jay wanted me to use the mixin instead
20:16:43 mriedem i think the mixin would be better than our own __eq__ sure
20:16:48 mriedem since that's what it's for
20:17:09 openstackgerrit Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239
20:17:10 openstackgerrit Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159
20:17:10 openstackgerrit Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854
20:17:10 edleafe ok, here it comes...
20:17:11 openstackgerrit Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358
20:17:11 openstackgerrit Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357
20:19:53 mriedem lgtm
20:20:22 openstackgerrit Merged openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168
20:43:01 mriedem bauzas: interested about your thoughts on this when you're up https://bugs.launchpad.net/nova/+bug/1727855
20:43:02 openstack Launchpad bug 1727855 in OpenStack Compute (nova) "conductor rebuild_instance does not properly handle image_ref if request_spec is not provided" [Low,Triaged]
20:58:41 dansmith mriedem: jaypipes I was hoping we could avoid merging that object until we had all the patches above it settled,
20:58:49 dansmith since we've changed it like a hundred times already
20:59:38 mriedem oh i see
20:59:40 jaypipes dansmith: it's dependent on mriedem's https://review.openstack.org/#/c/513931 anyway.
20:59:40 mriedem yeah that's fair
20:59:58 mriedem mine is actually fixing a perf thing, but yeah
21:00:05 mriedem jaypipes: maybe we convert to +1s

Earlier   Later