| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-10-09 | |||
| 14:12:50 | mriedem | thta's probably dead code now anyway | |
| 14:12:57 | mriedem | we delete the bdms when we delete the instance | |
| 14:13:25 | mriedem | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1891 | |
| 14:14:16 | mriedem | so given that, how about just removing that part in a follow up | |
| 14:14:21 | mriedem | rather than move it in this one | |
| 14:14:50 | stephenfin | Yup, let's do that so | |
| 14:15:16 | gibi | OK, I can push a followup | |
| 14:19:39 | mriedem | also just fyi https://github.com/openstack/nova/commit/5674e7646d106751b27d191e3334d9e6ebe9ab1b was newton, | |
| 14:19:47 | mriedem | so it should be safe to make that assumption from the queens compute | |
| 14:19:51 | mriedem | that the db api is doing what we want | |
| 14:20:12 | gibi | mriedem: ack | |
| 14:21:59 | mriedem | stephenfin: cool, thanks for hitting those | |
| 14:29:40 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix minor input items from previous patches https://review.openstack.org/506416 | |
| 14:29:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Add CellMapping.get_by_project_id() query method https://review.openstack.org/509002 | |
| 14:29:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Merge build requests into the sortmaster 9000 https://review.openstack.org/508595 | |
| 14:29:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Make get_instance_objects_sorted() be smart about cells https://review.openstack.org/509003 | |
| 14:30:43 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: PCI NUMA Policies https://review.openstack.org/361140 | |
| 14:31:00 | stephenfin | jaypipes: Fancy taking another shot at the PCI NUMA policies spec? ^ | |
| 14:31:39 | jaypipes | stephenfin: I'll take a look in a bit, sure | |
| 14:33:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix typo in test_prep_resize_errors_migration https://review.openstack.org/510591 | |
| 14:33:45 | mriedem | gibi: ^ :) | |
| 14:39:04 | gibi | mriedem: looking... | |
| 14:39:58 | dansmith | that was all gibi's fault anyway | |
| 14:40:26 | gibi | but now it is fixed and everybody is happy :) | |
| 14:40:31 | mriedem | heh | |
| 14:40:32 | dansmith | heh | |
| 14:41:10 | mriedem | melwitt: btw, i plan on starting draft slides for the pike update this week | |
| 14:45:26 | dansmith | I've seen several volume related issues causing gate resets this morning | |
| 14:48:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: add ProviderTree.is_inventory_empty https://review.openstack.org/480957 | |
| 14:58:14 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Use neutron's new port binding API https://review.openstack.org/375580 | |
| 14:59:42 | openstackgerrit | Merged openstack/nova master: Fix instance_get_by_sort_filters() for multiple sort keys https://review.openstack.org/510203 | |
| 14:59:54 | mriedem | dansmith: https://review.openstack.org/#/c/509899/ | |
| 15:00:02 | mriedem | but that's not showing up in http://status.openstack.org/elastic-recheck/index.html | |
| 15:00:07 | mriedem | b/c the page is busted for some reason | |
| 15:00:09 | mriedem | probably new gerrit | |
| 15:00:16 | dansmith | mriedem: ah okay I had looked | |
| 15:00:36 | mriedem | they don't send you 10 emails for a month before that happens? | |
| 15:00:50 | mriedem | most of my email now is school spam | |
| 15:00:53 | efried | dansmith To be clear, by "hamstringing" you mean settling on the param being an allocations object versus some other thing we would have more time to think about and design? | |
| 15:01:19 | dansmith | efried: no, passing allocations into the virt driver is not a huge deal, | |
| 15:01:22 | bauzas | mriedem: just one name : strike | |
| 15:01:35 | dansmith | efried: but if libvirt gets an rp uuid and a count into spawn right now, what does it do? | |
| 15:01:38 | mriedem | bauzas: oh i see | |
| 15:01:56 | alex_xu | efried: jaypipes thanks for taking care the trait spec | |
| 15:01:59 | bauzas | grrrrrr | |
| 15:02:08 | efried | dansmith Well, it *can* ignore the new param and just use flavors. | |
| 15:02:24 | efried | dansmith Or, if it has the time and resources, it can implement the thing that consumes the allocations. | |
| 15:02:26 | dansmith | efried: sure, but what purpose have you served by doing that for no reason? | |
| 15:02:41 | efried | Because of the ability to do that second thing. | |
| 15:02:49 | bauzas | efried: dansmith: saw your conversation, yeah I'll just use the flavor for that | |
| 15:02:56 | efried | dansmith PowerVM also has use for it, FWIW. | |
| 15:03:15 | efried | Because we're hamstrung by the PCI manager, and the sooner we can move to generic RPs, the better. | |
| 15:03:20 | dansmith | efried: fine, so add that thing, I'm fine with that, I'd just like not to linearize the libvirt stuff behind it | |
| 15:03:25 | dansmith | efried: go for it | |
| 15:03:48 | efried | dansmith Oh, totally. I don't think it serializes anything. I'll see if I can hit it. Thanks. | |
| 15:05:34 | mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22device-mapper%3A%20reload%20ioctl%20on%5C%22%20AND%20%20%20message%3A%5C%22failed%3A%20Invalid%20argument%5C%22%20AND%20%20%20tags%3A%5C%22screen-c-vol.txt%5C%22&from=7d | |
| 15:05:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: utils: Replace 'utf8' with oslo.utils equivalent https://review.openstack.org/466799 | |
| 15:07:52 | sean-k-mooney | mriedem: just an fyi, i mentioned this to jay and dan earlier but i have asked for the intel nfv ci to be swapped to silent mode. | |
| 15:08:31 | sean-k-mooney | mriedem: ssh to gerrit seams to have been restored but logs are not being uploaded and jobs are failing so i am guessing we are still being blocked form connecting to some sites | |
| 15:09:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rework man pages https://review.openstack.org/502105 | |
| 15:09:16 | sean-k-mooney | mriedem: i have asked for the vpn and ssh logins so i can review the local copy of the log and see if i can determin what is needed to restore the ci to a working state | |
| 15:10:07 | sean-k-mooney | mriedem: but ya just an fyi i did not want to have it spaming every patchset when i know its currently broken | |
| 15:13:06 | mriedem | sean-k-mooney: ok | |
| 15:17:20 | dansmith | jaypipes: are you rebasing your nrp set? | |
| 15:17:47 | jaypipes | dansmith: on to the no-orm-resource-providers series, yes. | |
| 15:18:03 | jaypipes | dansmith: and in the process I'll be fixing up requested things on the n-r-p patches | |
| 15:18:08 | dansmith | jaypipes: okay, does it have to go at the end? | |
| 15:18:21 | dansmith | there's a ton of stuff to do still in the de-orm set | |
| 15:18:22 | bauzas | jaypipes: I'm tempted to +2 eventually your no-orm bottom change :) | |
| 15:18:46 | dansmith | and it's kinda unfortunate to have to chew all of that before we can make any progress on nrp :/ | |
| 15:18:53 | jaypipes | dansmith: lemme see if there's a middle patch I could go from... one sec | |
| 15:19:14 | dansmith | jaypipes: or maybe a reasonable re-ordering of the lower set so you could tack on earlier or something | |
| 15:21:36 | jaypipes | dansmith: https://review.openstack.org/#/c/509035 is where I could tie on n-r-p. I suppose I could re-order to have that one land earlier in the series. | |
| 15:22:12 | dansmith | might be good if it's not too much work | |
| 15:23:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix sending legacy instance.update notification https://review.openstack.org/510603 | |
| 15:25:24 | sean-k-mooney | johnthetubaguy: o/ | |
| 15:25:35 | johnthetubaguy | sean-k-mooney: hi | |
| 15:26:10 | sean-k-mooney | johnthetubaguy: QQ im just looking at the compute manager class in the pre live migration fuction https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/compute/manager.py#L5542-L5557 | |
| 15:26:39 | sean-k-mooney | johnthetubaguy: this is where we will have to consume the new neutron port bining api above the virt drivers correct | |
| 15:26:45 | jaypipes | dansmith: ok, I'll see what I can do | |
| 15:27:11 | dansmith | jaypipes: regardless, I've +2d a bunch of the early part of that de-orm set | |
| 15:27:31 | dansmith | so if our gate was working at all, we could merge those soonish | |
| 15:28:01 | sean-k-mooney | johnthetubaguy: so instead of getting current bindings with self.network_api.get_instance_nw_info(context, instance) i will need to create the destingation port bindings and the activate them later | |
| 15:28:22 | sean-k-mooney | johnthetubaguy: just trying to make sure https://review.openstack.org/#/c/375580/5/specs/queens/approved/neutron-new-port-binding-api.rst is accurate | |
| 15:28:33 | johnthetubaguy | sean-k-mooney: it calls through to here today: https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L327 | |
| 15:28:56 | johnthetubaguy | https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/network/neutronv2/api.py#L327 | |
| 15:30:13 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove dead code of api.fault notification sending https://review.openstack.org/505164 | |
| 15:30:47 | sean-k-mooney | johnthetubaguy: right so that si called on line https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/compute/manager.py#L5556 | |
| 15:31:12 | gibi | stephenfin, mriedem: could you check back to https://review.openstack.org/#/c/505164 I updated the reno based on stephenfin's excellent suggestions | |
| 15:31:17 | johnthetubaguy | sean-k-mooney: yes, that's the one | |
| 15:31:41 | johnthetubaguy | sean-k-mooney: but should be no changes to the compute manager, only changes in the network layer | |
| 15:33:07 | sean-k-mooney | johnthetubaguy: well what i wanted to check is where is the xml generated for the remote node is it is the prelivemigration on line 5547 or after the networking call on 5556 | |
| 15:34:03 | sean-k-mooney | i had the perception that i might need to change the order of those calls also im currently trace through the code to confim though | |
| 15:35:49 | johnthetubaguy | sean-k-mooney: for the XML stuff, its all about adding the correct details into migrate_data so this method gets it correct: https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/virt/libvirt/driver.py#L6357 | |
| 15:37:41 | sean-k-mooney | ah cool thanks that is what i was looking for. i can trace out how that gets populated now that i know where to look | |
| 15:39:18 | johnthetubaguy | sean-k-mooney: have a look at this bit: https://github.com/openstack/nova/blob/664322cae7fcb76ed27b3afd7a7b6434e6e23229/nova/virt/libvirt/driver.py#L6930 | |
| 15:58:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance. |
|
| 15:58:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.create https://review.openstack.org/483969 | |
| 15:58:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance. |
|
| 15:58:38 | sean-k-mooney | johnthetubaguy: right so that is part of the virt diriver prelive migration function which is called before setup_networks_on_host which is why i taught i might need to swap the order of those calls | |