Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-27
21:55:14 mriedem the only thing you share,
21:55:22 mriedem is your love of groveling for the royal family
21:55:29 mriedem there are no other benefits
21:55:36 cfriesen_ our love of beer, more like.
21:55:44 mriedem germans don't love beer?
21:55:51 cfriesen_ I didn't say it was exclusive
21:56:02 mriedem but germans can't love the royalty the same way
21:56:20 cfriesen_ half the british royalty was german anyway
21:56:46 mriedem oh breeding
21:57:07 mriedem i plan to marry my daughter to a fellow in the next county
21:57:17 mriedem for the inter-county alliance
21:57:24 mriedem against NE iowa
22:09:22 takashin Spec cores, would you review https://review.openstack.org/#/c/489029/ ? It got one +2.
22:09:50 openstackgerrit Merged openstack/nova-specs master: Move pike implemented specs https://review.openstack.org/500369
22:59:02 openstackgerrit Merged openstack/nova master: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/502236
23:03:15 cfriesen_ is there a reason why nova uses named indexes in the DB rather than using "index=True" as part of the Column definition?
23:31:36 mriedem_away easier to change them later if needed
23:31:39 mriedem_away cfriesen_: ^
23:31:48 mriedem_away since different backends name them if you do it automatically
23:32:30 mriedem although i think in recent years we just identify an index by the columns in it
#openstack-nova - 2017-09-28
00:04:57 openstackgerrit Merged openstack/nova master: Fix policy check performance in 2.47+ https://review.openstack.org/507948
01:20:42 yikun hi, I submit Queue bp about pagination for migrations and instance-actions.
01:20:47 yikun These bps have approved previously in newton, but didn't implemented yet,
01:20:52 yikun now I move these to queens, could anyone have a look? thanks : )
01:20:57 yikun https://review.openstack.org/#/c/506030/
01:21:02 yikun https://review.openstack.org/#/c/507762/
01:21:14 yikun thanks for your review.
03:28:19 openstackgerrit Merged openstack/nova master: doc: make host aggregates examples more discoverable https://review.openstack.org/507950
04:47:49 mikal I think I found a bug in unittest.mock
05:47:27 openstackgerrit jichenjc proposed openstack/nova master: remove CONF.vendordata_driver https://review.openstack.org/501510
06:17:04 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146
06:18:37 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient stable/pike: Updated from global requirements https://review.openstack.org/493187
06:22:04 openstackgerrit Merged openstack/nova stable/pike: Handle deleted instances when refreshing the info_cache https://review.openstack.org/506183
06:34:30 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146
06:36:01 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient stable/pike: Updated from global requirements https://review.openstack.org/493187
06:40:32 openstackgerrit jichenjc proposed openstack/nova master: check query param for server groups function https://review.openstack.org/500347
06:56:25 openstackgerrit jichenjc proposed openstack/nova master: check query param for used_limits function https://review.openstack.org/499091
06:58:42 openstackgerrit jichenjc proposed openstack/nova master: check query param for used_limits function https://review.openstack.org/499091
07:02:20 openstackgerrit jichenjc proposed openstack/nova master: fix race condition of instance host https://review.openstack.org/494458
07:02:36 openstackgerrit jichenjc proposed openstack/nova master: propagate OSError to MigrationPreCheckError https://review.openstack.org/469779
07:02:58 openstackgerrit jichenjc proposed openstack/nova master: WIP: only allow TLS v1.2 in nova servers https://review.openstack.org/459504
07:10:11 openstackgerrit jichenjc proposed openstack/nova master: WIP: conf: remove deprecated 'project_id_regex' opt https://review.openstack.org/501057
07:10:37 openstackgerrit jichenjc proposed openstack/nova master: Check root disk size when doing resize in API https://review.openstack.org/484664
07:30:28 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix inconsistency of 'NOTE:' description https://review.openstack.org/508074
07:31:59 openstackgerrit Merged openstack/nova stable/pike: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506754
07:33:05 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/489029
07:44:40 openstackgerrit Merged openstack/nova stable/pike: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507552
07:59:51 openstackgerrit jichenjc proposed openstack/nova master: Add 400 as error code for resource class delete https://review.openstack.org/508080
08:07:52 openstackgerrit jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083
08:23:40 openstackgerrit jichenjc proposed openstack/nova master: remove CONF.vendordata_driver https://review.openstack.org/501510
08:25:38 openstackgerrit jichenjc proposed openstack/nova master: Add description for reousrce class creation https://review.openstack.org/508083
08:27:57 johnthetubaguy alex_xu are you working with lei-zh on https://review.openstack.org/#/c/468797?
09:00:14 openstackgerrit Merged openstack/nova stable/pike: Refactor ServerMovingTests for non-move tests https://review.openstack.org/507195
09:14:00 gmann oomichi: are you ok with create_or_update_* in this https://review.openstack.org/#/c/504439/11 ?
09:18:12 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks https://review.openstack.org/507202
09:18:12 openstackgerrit Matthew Booth proposed openstack/nova master: Make etree.tostring() emit unicode everywhere https://review.openstack.org/507488
09:18:31 bhagyashris avolkov: Hi,
09:18:53 avolkov bhagyashris: hi
09:18:58 mdbooth stephenfin: I wrote the test you asked for on https://review.openstack.org/#/c/507488/
09:19:02 mdbooth Then I unwrote it :)
09:19:19 mdbooth Can you have a quick look at my reply in case I misunderstood?
09:20:13 bhagyashris avolkov: I just want to discuss regarding the patch: https://review.openstack.org/#/c/409644/ I have respond to your comment can you please take some in sights
09:35:15 avolkov bhagyashris: left a comment there
09:35:38 bhagyashris avolkov: Thank you :)
09:42:08 bhagyashris avolkov: I will fix the review comment thank you for review :)
09:45:10 openstackgerrit Ghanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101
09:48:07 artom lyarwood, around?
09:48:24 artom The -W can come off https://review.openstack.org/#/c/499208/ I think, right?
09:48:34 artom Since https://review.openstack.org/#/c/468514/ landed
09:49:52 artom Same for https://review.openstack.org/#/c/468319/
09:59:13 openstackgerrit Ghanshyam Mann proposed openstack/nova-specs master: Spec for API extensions policy removal https://review.openstack.org/508101
10:01:28 lyarwood artom: hey yeah
10:01:32 lyarwood artom: ack looking
10:35:52 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
11:17:57 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116
11:25:20 openstackgerrit Chris Dent proposed openstack/nova master: Do not monkey patch eventlet in unit tests https://review.openstack.org/507923
11:25:21 openstackgerrit Chris Dent proposed openstack/nova master: Do not setup conductor in BaseAPITestCase https://review.openstack.org/508120
11:25:21 openstackgerrit Chris Dent proposed openstack/nova master: DNM: Don't monkey patch eventlet in functional https://review.openstack.org/506668
11:33:46 mdbooth cdent: Remind me, were you proposing removing eventlet from tests?
11:33:57 cdent I was yes
11:34:18 cdent there are monkey_patch calls at the top of the unit and functional trees
11:34:26 cdent removing the one at the top of unit is no problem
11:34:39 cdent the one at the top of functional is a problem, but limited
11:34:59 mdbooth cdent: Data point: I've used eventlet in tests explicitly a couple of times because its locking primitives can be killed with Ctrl-C, whereas the regular python ones can't.
11:35:14 cdent used explicitly: great
11:35:23 mdbooth This has no impact on the test usually, but is really useful when you're debugging it
11:35:25 cdent it’s the global monkey patching that i think is bad news
11:36:13 mdbooth Cool, just thought I'd bring it up
11:36:26 cdent yeah, thanks.
11:37:09 cdent In my digging around it looks like there’s still a fair amount of tests under unit that ought to be under functional, but I’m pretty sure I don’t want to fall in that hole (yet)
11:40:26 cdent yeah, I grepped for ‘start_service’ as sort of an initial feel around and the boundary has been permeated
11:45:35 cdent johnthetubaguy, stephenfin : can you guys weigh in on https://review.openstack.org/#/c/469048/ it’s some placement docs that have been languishing for a long time
11:46:16 cdent and this is a test that’s also been languishing, adds a bit more coverage: https://review.openstack.org/#/c/485209/
11:46:37 cdent gibi: you too on both of those
11:51:31 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Send traits to ironic on server boot https://review.openstack.org/508116
12:05:23 sdague ok, the qemu >= 2.10 patch should really really be ready this time - https://review.openstack.org/#/c/505673/ - stephenfin, bauzas, johnthetubaguy if anyone wants to take a quick look
12:10:04 mdbooth Any chance of some eyes on this: https://review.openstack.org/#/c/507202/
12:10:20 mdbooth It's a data corruptor with no current mitigation other than "don't do that"
12:10:57 mdbooth The dependent patch is an annoying python 3-ism
12:11:46 mdbooth That's unfair, it's a bug in the libvirt python bindings, and a questionable default choice in the lxml python bindings

Earlier   Later