Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-04
21:25:41 leakypipes superdan: ++ from me on those split patches.
21:26:18 leakypipes mriedem: ok, will look at those later this evening. thanks for the heads up.
21:36:16 mriedem oh i see where i was confused by something in the tests - when we 'double stuff' in the scheduler during the move claim, we keep the source and dest compute node allocations along with the shared storage provider allocation, but we don't sum the shared storage allocation, like we would if we resized to the same host
21:36:36 mriedem noticed that from this test
21:36:37 mriedem https://review.openstack.org/#/c/490085/7/nova/tests/unit/scheduler/client/test_report.py@361
21:37:20 mriedem superdan: when we were talking about handling resize to same host the other day for https://review.openstack.org/#/c/490085/ didn't we say we thought that we should sum the disk even if it's shared?
21:38:09 mriedem you can see that sum for disk happen on the same host in test_claim_resources_success_resize_to_same_host_with_shared
21:38:26 mriedem but we don't sum disk if it's on different hosts, from test_claim_resources_success_move_operation_with_shared
21:56:51 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Get auth from context for glance endpoint https://review.openstack.org/490057
22:11:31 openstackgerrit Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
22:14:52 fried_rice mordred ^^ I *think* will pass tox now, and I *think* will pass sdague's https://review.openstack.org/490031
22:31:22 superdan mriedem: not sure what you mean.. we don't sum anything for different hosts
22:31:31 superdan mriedem: you saying we don't claim against the shared storage again?
#openstack-nova - 2017-08-05
00:17:01 mriedem dansmith: yes if we're moving from source host A to dest host B and they are sharing storage on provider C, we don't sum the disk_gb allocation between the flavors for the move
00:17:22 mriedem apparently intentionally but i'm not sure why now
05:07:53 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711
06:40:35 openstackgerrit Michael Still proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229
06:40:36 openstackgerrit Michael Still proposed openstack/nova master: Move execs of touch to privsep. https://review.openstack.org/489190
06:40:36 openstackgerrit Michael Still proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166
06:40:37 openstackgerrit Michael Still proposed openstack/nova master: Move execs of tee to privsep. https://review.openstack.org/489438
06:40:37 openstackgerrit Michael Still proposed openstack/nova master: Move libvirts dmcrypt support to privsep. https://review.openstack.org/490737
06:40:38 openstackgerrit Michael Still proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972
06:40:39 openstackgerrit Michael Still proposed openstack/nova master: Refactor libvirt.utils.execute() away. https://review.openstack.org/489816
06:40:39 openstackgerrit Michael Still proposed openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486
11:54:00 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
20:06:41 openstackgerrit Maciej Kucia proposed openstack/nova master: SR-IOV passthrough: Check PF only if VF is enabled https://review.openstack.org/476642
20:08:19 openstackgerrit Maciej Kucia proposed openstack/nova master: Update pci device fields from deleted object https://review.openstack.org/426243
23:00:32 openstackgerrit Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
23:07:13 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Base _ContextAuthPlugin on BaseIdentityPlugin https://review.openstack.org/491203
#openstack-nova - 2017-08-06
01:23:27 efried_WEEKEND mordred To make https://review.openstack.org/#/c/490057/ work we're gonna have to reimplement nova.context._ContextAuthPlugin :(
02:49:39 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408
03:51:39 openstackgerrit Michael Still proposed openstack/nova master: Move libvirts dmcrypt support to privsep. https://review.openstack.org/490737
03:51:40 openstackgerrit Michael Still proposed openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486
05:48:34 openstackgerrit Spencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766
06:09:09 openstackgerrit Spencer Yu proposed openstack/python-novaclient master: Fix reservation_id not supported by Nova API https://review.openstack.org/468444
06:56:14 openstackgerrit Danfly proposed openstack/nova master: update availablity_zone in the instances table when live-migration successes https://review.openstack.org/491226
11:14:35 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
18:37:07 mordred efried_WEEKEND: joy
18:54:06 slaweq mordred: hello
18:54:25 slaweq if You would have a while, I pushed 2 patches to shade
18:54:54 slaweq both about QoS support, one with functional tests and one which fixes small issue from previous commits
18:55:05 slaweq thx in advance for Your review :)
18:55:42 mordred woot - will look now - I was also just noticing the ipv6 bug - so exciting to learn that netifaces.AF_INET6 doesn't exist in some places :)
18:56:55 slaweq mordred: yep, I want to check this bug
18:57:02 slaweq and sorry for writing in wrong window :)
18:57:19 mordred slaweq: np- there are plenty of windows we're in
#openstack-nova - 2017-08-07
00:42:57 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/491282
00:49:26 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/490859
00:51:47 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/488086
00:53:38 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/491296
01:49:43 openstackgerrit Alex Xu proposed openstack/nova master: placement: filtering the resource provider id when delete trait association https://review.openstack.org/489205
02:20:45 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Live migration failed in xapi pool https://review.openstack.org/489451
03:37:12 openstackgerrit Danfly proposed openstack/nova master: update availablity_zone in the instances table when live-migration successes https://review.openstack.org/491226
04:40:44 openstackgerrit Danfly proposed openstack/nova master: update availablity_zone in the instances table when live-migration successes https://review.openstack.org/491226
04:41:21 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/491340
05:50:59 openstackgerrit Alex Xu proposed openstack/nova master: placement: the common method to filter resource providers by traits https://review.openstack.org/489206
06:59:57 openstackgerrit Alex Xu proposed openstack/nova master: placement: add traits support to get resource_providers with shared https://review.openstack.org/478464
06:59:57 openstackgerrit Alex Xu proposed openstack/nova master: placement: the common method to filter resource providers by traits https://review.openstack.org/489206
07:36:40 bauzas good morning Nova
07:46:35 gibi good morning
09:12:42 openstackgerrit Vladyslav Drok proposed openstack/nova master: [placement] Add api-ref for allocation_candidates https://review.openstack.org/481112
09:12:43 openstackgerrit Vladyslav Drok proposed openstack/nova master: [placement] Make placement_api_docs.py failing https://review.openstack.org/480924
09:12:43 openstackgerrit Vladyslav Drok proposed openstack/nova master: [placement] Add api-ref for usages https://review.openstack.org/480563
09:12:44 openstackgerrit Vladyslav Drok proposed openstack/nova master: [placement] Add api-ref for RP allocations https://review.openstack.org/450550
09:12:44 openstackgerrit Vladyslav Drok proposed openstack/nova master: [placement] Add api-ref for RP usages https://review.openstack.org/450105
09:16:38 openstackgerrit Danfly proposed openstack/nova master: update availablity_zone in the instances table after live-migration https://review.openstack.org/491226
09:30:23 cdent gibi: I decided to take a page from your testing and do random stuff and find bugs. Seen these: https://bugs.launchpad.net/nova/+bug/1708961 https://bugs.launchpad.net/nova/+bug/1708958
09:30:25 openstack Launchpad bug 1708961 in OpenStack Compute (nova) "migration of single instance from multi-instance request spec fails with IndexError" [Undecided,New]
09:30:26 openstack Launchpad bug 1708958 in OpenStack Compute (nova) "disabling a compute service does not disable the resource provider" [Low,New]
09:37:34 bauzas cdent: gibi: that doesn't help but I'm pretty concerned by how we just missed https://bugs.launchpad.net/nova/+bug/1708961
09:37:35 openstack Launchpad bug 1708961 in OpenStack Compute (nova) "migration of single instance from multi-instance request spec fails with IndexError" [Undecided,New]
09:38:06 bauzas cdent: gibi: that is a serious blocker to me
09:38:18 cdent bauzas: yeah, I think we’ve got some gaps in testing.
09:38:43 bauzas it's more than that IMHO
09:39:19 bauzas I remember being super cautious during reviews about how we tried to make sure that num_instances was equal or not to the list of instances...
09:39:21 gibi bauzas: nice findings
09:39:50 bauzas but we totally forgot to take care of move operations
09:40:24 cdent careful review is important, but it shouldn’t be a substitute for real tests
09:40:33 bauzas gibi: cdent: about https://bugs.launchpad.net/nova/+bug/1708958 we have ComputeFilter for that
09:40:34 openstack Launchpad bug 1708958 in OpenStack Compute (nova) "disabling a compute service does not disable the resource provider" [Low,Confirmed]
09:40:37 cdent if we have to rely on careful review, then we need better tests
09:41:00 bauzas cdent: I specifically asked for conservative testing about that
09:41:13 bauzas anyway, it's done now
09:41:22 cdent bauzas: yeah, 1708958, as I say on the bug report, isn’t a functionality bug, more a “in what way do we want this data to be correct"
09:45:24 bauzas cdent: just made a comment in the bug report to clarify what I want
09:45:40 bauzas cdent: I don't want placement to have nova-specifisms
09:45:53 gibi I mean, cdent, nice findings
09:45:54 cdent yes
09:45:57 bauzas cdent: but I'd love placement to consider inventory freshness
09:45:59 gibi I'm sooo slow today
09:47:13 cdent bauzas: I think the issue is simpler than that. The choice is really: should disabling a hypervisor cause (something in nova) to delete the resource provider
09:47:23 cdent I think it should
09:47:34 cdent since if a service is diabled it is not providing resources
09:48:21 bauzas cdent: that would be one option, I agree
09:48:26 gibi cdent: it is not that simple. As disabling a host doesn't mean that the VMs running on that host freed up all the resources
09:48:43 gibi cdent: so that host still providing resources to existing VMs
09:48:54 bauzas gibi: from a placement perspective, we don't care about the space that RP has
09:49:14 cdent bauzas: actaully gibi’s right: we want to use allocations to indicate quota use
09:49:19 bauzas gibi: unless *cough cough* we have shared resources from that honst :)
09:49:30 cdent and we can’t delete an rp (or inventory) if there are allocations in use

Earlier   Later