| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-20 | |||
| 14:47:58 | sdague | the functional parts of the patch should be ready for review - https://review.openstack.org/#/c/485602/1/nova/api/openstack/requestlog.py | |
| 14:48:21 | sdague | yeh, I'll put that as stretch goal | |
| 14:48:55 | mriedem | is there any existing oslo.middleware stuff that all/most services use that we could do the auto enable thing in there so everyone else gets it for free? | |
| 14:49:00 | mriedem | and doesn't have to copy the solution around? | |
| 14:49:11 | mriedem | noting that today is release freeze for oslo lis | |
| 14:49:13 | mriedem | *libs | |
| 14:49:22 | sdague | I don't think that there is | |
| 14:49:29 | mriedem | https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/request_id.py ? | |
| 14:50:08 | sdague | maybe, not everyone uses that | |
| 14:50:26 | sdague | but, regardless, I don't think we could get it in and through that process | |
| 14:50:33 | mriedem | sure, | |
| 14:50:34 | sdague | in the time alloted | |
| 14:50:42 | sdague | one of the challenges about fixed time boxes | |
| 14:50:46 | dansmith | ...with 146 things in the check queue | |
| 14:50:48 | mriedem | so maybe that's the other thing for queens is moving this into oslo.middleware so others can just pick it up from there | |
| 14:50:48 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Remove check_detach https://review.openstack.org/446671 | |
| 14:50:49 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 14:52:14 | jangutter | Newbie question: https://review.openstack.org/#/c/485382/ failed a check in the gate (last time it failed a different check). Does this kinda thing happen often when upping requirements.txt? | |
| 14:59:43 | sdague | mriedem: yeh, it's kind of going to depend on the way wsgi bits are done, which is not standardized | |
| 15:00:02 | sdague | honestly, the ideal might be if oslo.service actually abstracted this stuff away | |
| 15:00:13 | sdague | but... that's got other challenges | |
| 15:05:39 | dansmith | melwitt: remind me why those need to be remotable? https://review.openstack.org/#/c/410945/58/nova/objects/quotas.py@62 | |
| 15:07:32 | dansmith | like, I thought we had removed all of the quota calls by this point that need to be done from compute or non-db-having services | |
| 15:09:31 | gibi | mriedem: I cannot joint to the nova meeting today. Could you cover the notification subteam part? | |
| 15:10:11 | mdbooth | melwitt: Addressed your comments on this patch with a test: https://review.openstack.org/#/c/479801/ | |
| 15:10:30 | mdbooth | Jenkins -1 is bogus, btw. Rechecked it, but following patch has passed. | |
| 15:11:13 | mdbooth | melwitt: Incidentally following patch is https://review.openstack.org/#/c/485601/ which is a minor cleanup to your quotas patch | |
| 15:11:38 | mdbooth | s/minor/trivial/ | |
| 15:22:17 | mriedem | gibi: sure | |
| 15:23:00 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 15:27:07 | mriedem | sdague: are you going to recap the plan to the ML? | |
| 15:27:20 | gibi | mriedem: thanks | |
| 15:27:28 | openstackgerrit | Merged openstack/nova master: placement: alloc candidates only shared resources https://review.openstack.org/484900 | |
| 15:28:13 | mriedem | jaypipes: do we need anything in here to get released in os-traits today? https://review.openstack.org/#/q/os-traits+status:open | |
| 15:28:16 | mriedem | because today is the big day | |
| 15:28:26 | openstackgerrit | Merged openstack/python-novaclient master: Adjust test_resize_down_revert to account for counting quotas https://review.openstack.org/484152 | |
| 15:28:44 | sdague | mriedem: I can | |
| 15:28:44 | mriedem | maybe the reqs update | |
| 15:28:59 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Read datapath_type from VIF object https://review.openstack.org/474914 | |
| 15:28:59 | sdague | I'm going to figure out test failures first | |
| 15:29:00 | jaypipes | mriedem: nope | |
| 15:29:11 | mriedem | ok i'll get the req update in and then release it | |
| 15:29:17 | jaypipes | mriedem: danke | |
| 15:33:14 | mriedem | sdague: another thing to consider, report a bug for this request id logging thing and then we can tag it pike-rc-potential for tracking | |
| 15:33:18 | mriedem | i'm starting to tag things for the rc | |
| 15:35:11 | jaypipes | sean-k-mooney: ralonsoh's https://review.openstack.org/#/c/474914/ is good to go. feel free to +2 if agree. | |
| 15:35:19 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/485634 | |
| 15:35:41 | ralonsoh | jaypipes, sean-k-moone: thanks! | |
| 15:35:53 | mriedem | jaypipes: sean-k-mooney: ralonsoh: does ^ need to be in an os-vif release for pike? | |
| 15:35:57 | mriedem | because we released os-vif yesterday | |
| 15:36:11 | jaypipes | mriedem: I don't believe so, no. | |
| 15:36:25 | mriedem | ok, it's also dependent on a neutron change with -1s and test failures | |
| 15:36:37 | jaypipes | mriedem: right. | |
| 15:36:59 | jaypipes | mriedem: os-vif was good yesterday when it was released. | |
| 15:37:01 | ralonsoh | mriedem, jaypipes: well, this patch solves a bug for OVS userspace | |
| 15:37:21 | mriedem | ralonsoh: at this point it's not going to get released for pike | |
| 15:37:28 | mriedem | unless it's later backported | |
| 15:37:31 | ralonsoh | mriedem; no, not now | |
| 15:37:51 | sdague | mriedem: sure | |
| 15:38:25 | jaypipes | ralonsoh: as mriedem said, there is a dependent neutron patch that would need to be merged for that os-vif patch to even be workable though. | |
| 15:38:26 | sean-k-mooney | mriedem: need no nice to have definetly | |
| 15:39:07 | jaypipes | ralonsoh: well, I shouldn't say "even be workable". I meant "even be useful". | |
| 15:39:35 | ralonsoh | jaypipes: yes, this bug needed changes in 4 projects. I don't think is going to land in Pike | |
| 15:39:48 | jaypipes | cdent: hey, just to repeat what I said on that bug report... really excellent investigative work on that sorted(sharing_providers.items()..) thing. | |
| 15:40:08 | jaypipes | cdent: I had spent hours looking at the SQL generated going to myself "there's nothing wrong with this SQL... :(" | |
| 15:40:18 | cdent | thanks jaypipes, it was really because of gibi | |
| 15:40:21 | jaypipes | cdent: and your comment sparked a renewed look at the JOIN order. | |
| 15:40:31 | cdent | he had pasted up things to look at and started wondering “why is that different" | |
| 15:40:37 | sean-k-mooney | mriedem: it would be good to backport https://review.openstack.org/#/c/474914 all the way to ocata but not sure if we can due to ovo chagnes | |
| 15:40:47 | cdent | also having the gabbi test (which makes things easier for me to toy with) helped | |
| 15:40:48 | jaypipes | well, thank you cdent and gibi both :) | |
| 15:41:23 | jaypipes | I have a feeling that little patch may fix some of the odd random NoValidHosts failures we were seeing intermittently. | |
| 15:41:58 | jaypipes | since it produces an incorrect false negative on providers meeting requested resources when including shared resources. | |
| 15:43:22 | cdent | jaypipes: you’ve seen today’s bug that gibi found, yes? | |
| 15:43:33 | cdent | I’ve now become expectant of him finding one every day | |
| 15:43:52 | jaypipes | cdent: :( | |
| 15:44:02 | jaypipes | cdent: you mean the "init alloc_reqs earler" one?> | |
| 15:44:05 | cdent | yeah | |
| 15:44:25 | cdent | It’s not :( it’s :). Find them now when they are fresh and new before they go hurt someone. | |
| 15:44:41 | mriedem | final os-traits release https://review.openstack.org/485722 | |
| 15:44:43 | mriedem | bauzas: ^ | |
| 15:45:07 | bauzas | mriedem: looking | |
| 15:47:08 | gibi | cdent, jaypipes: I guess I will fail on the bug / day expectation as I will be out tomorrow | |
| 15:47:24 | cdent | I will try to stand in for you | |
| 15:47:28 | jaypipes | gibi: that's no excuse. we expect at least one bug a day now. | |
| 15:47:41 | gibi | cdent, jaypipes: however there is one more for today https://bugs.launchpad.net/nova/+bug/1705487 | |
| 15:47:42 | openstack | Launchpad bug 1705487 in OpenStack Compute (nova) "placement logs an ERROR when PUT /allocation result in an invalid inventory" [Undecided,New] | |
| 15:48:18 | gibi | cdent, jaypipes: I'm hesitant if this is just a logging thing or something a bit deeper | |
| 15:48:26 | cdent | gibi: yay! more bugly goodness. | |
| 15:48:40 | jaypipes | gibi: looking ... | |
| 15:49:38 | gibi | jaypipes, cdent: If I'm not mistaken then the exception is coming from here https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L1607 | |
| 15:50:15 | gibi | jaypipes: can be that it is connected to the fact that I'm using shared custom resource | |
| 15:50:53 | jaypipes | gibi: do you have a test case for that newest bug? I'm not entirely sure how an invalid resource class can be allocated by the scheduler, but perhaps it could. | |
| 15:51:18 | gibi | jaypipes: not yet unfortunately and I have to leave soon. | |
| 15:51:40 | jaypipes | gibi: ah, I see now... it's a race condition that we should retry on instead of logging an exception I guess | |
| 15:52:31 | gibi | jaypipes: I can try to craft the test case on Monday | |
| 15:52:49 | jaypipes | gibi: cool. enjoy your long weekend! :) | |
| 15:53:11 | gibi | jaypipes: thanks! | |
| 16:00:54 | openstackgerrit | Jay Pipes proposed openstack/nova master: Remove improper LOG.exception() calls in placement https://review.openstack.org/485726 | |
| 16:00:56 | jaypipes | gibi: fixed already :) ^^ | |