| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-19 | |||
| 16:38:49 | cdent | mriedem: I think I fixed https://review.openstack.org/#/c/485263/ | |
| 16:39:16 | sean-k-mooney | jangutter: can you click the rebase button on https://review.openstack.org/#/c/485125 so that the commit id wont change when it merges | |
| 16:40:07 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Improve OVS Representor VF Lookup https://review.openstack.org/485125 | |
| 16:40:19 | sean-k-mooney | jangutter: im going to create a patch to the release repo to tag that commit for the 1.6.1 release of os-vif | |
| 16:40:31 | jangutter | sean-k-mooney: done | |
| 16:41:10 | sean-k-mooney | jangutter: cool ill just check locally but now it should be able to merge without a merge commit being created | |
| 16:44:15 | openstackgerrit | John Haan proposed openstack/nova-specs master: Support volume_type with BDM paramter https://review.openstack.org/466595 | |
| 16:47:04 | ralonsoh | cdent, edleafe: thanks for your reviews in https://review.openstack.org/#/c/483451/. I posted my reply | |
| 16:48:27 | melwitt | counting instances is in the gate \o/ \o/ \o/ | |
| 16:49:24 | mriedem | f yeah | |
| 16:49:36 | mriedem | melwitt: are you going to cleanup the 'remove refresh-quotas cli' change todya? | |
| 16:49:43 | mriedem | if not, i can whack at that | |
| 16:50:17 | melwitt | mriedem: yes, gonna hit that next | |
| 16:50:29 | mriedem | awesome | |
| 16:51:55 | mriedem | sheet, cellsv2 meeting in 9 minutes | |
| 16:51:58 | mriedem | dansmith: you want me to run it? | |
| 16:52:35 | dansmith | ugh | |
| 16:52:36 | dansmith | mriedem: melwitt do we have things to talk about other than the obvious/ | |
| 16:52:55 | dansmith | obvious being "get the quotas shit merged" | |
| 16:52:59 | mriedem | i don't have anythign that's not in the etherpad | |
| 16:53:14 | mriedem | https://etherpad.openstack.org/p/nova-pike-cells-v2-todos | |
| 16:53:30 | melwitt | heh, yeah. I don't have anything else at the moment | |
| 16:53:34 | mriedem | the uuids apis are +W now too | |
| 16:54:04 | melwitt | today is the best day | |
| 16:55:17 | dansmith | let's just punt then because I'm covered up in other stuff | |
| 16:55:31 | dansmith | except not so much | |
| 16:56:33 | melwitt | sounds cool | |
| 16:57:46 | dansmith | it's so not | |
| 16:58:08 | melwitt | I mean punting sounds cool | |
| 16:58:13 | melwitt | :) | |
| 16:58:20 | mriedem | packstack on mitaka sounds f'ing awesome | |
| 16:58:27 | mriedem | like crowbar on folsom | |
| 16:58:31 | melwitt | I ran packstack for kilo a few days ago and ... it worked | |
| 17:06:05 | openstackgerrit | John Haan proposed openstack/nova-specs master: Support volume_type with BDM paramter https://review.openstack.org/466595 | |
| 17:08:20 | mriedem | sdague: bauzas: jaypipes: easy one to keep quotas series going https://review.openstack.org/#/c/446242/ | |
| 17:08:43 | bauzas | I saw the big quotas patch in the gate | |
| 17:08:49 | bauzas | cool | |
| 17:10:21 | melwitt | yaaay | |
| 17:13:30 | openstackgerrit | John Haan proposed openstack/nova-specs master: Support volume_type with BDM paramter https://review.openstack.org/466595 | |
| 17:14:08 | bauzas | mriedem: since we didn't added a relnote for https://review.openstack.org/#/c/416521/63 do you think we should at least add a note saying that the 'reserved' QS is no longer accepted in Pike as per https://review.openstack.org/#/c/446242/41 ? | |
| 17:14:16 | bauzas | dansmith: melwitt: ^ | |
| 17:14:37 | mriedem | bauzas: it is accepted | |
| 17:14:39 | mriedem | it's just ignored | |
| 17:15:00 | mriedem | the end cloud user isn't going to read the release notes, they are going to read the api reference | |
| 17:15:06 | mriedem | and the api doesn't change | |
| 17:15:12 | bauzas | mriedem: sure, I meant telling people that if they use it, it won't no longer be something we check | |
| 17:15:22 | bauzas | meh, good point | |
| 17:15:23 | mriedem | no, that's just noise imo | |
| 17:15:31 | bauzas | it's more an API doc | |
| 17:15:32 | dansmith | and we're not reserving so ignoring it is reasonable right? | |
| 17:15:45 | mriedem | yeah this is all internal tomfoolery | |
| 17:16:02 | mriedem | as i noted in there, i'll propose removing that query parameter with a microversion in queens | |
| 17:16:03 | dansmith | if we improved boot performance, you'd see the same behavior | |
| 17:16:03 | dansmith | reserved amounts are transient | |
| 17:16:03 | dansmith | it's noise, IMHO | |
| 17:19:33 | bauzas | mriedem: dansmith: can't find the API reference for that API endpoint FWIW | |
| 17:19:39 | bauzas | am I blind ? | |
| 17:19:48 | mriedem | limits | |
| 17:19:56 | mriedem | another way to think of that is if the cloud used the noop quota driver, | |
| 17:19:57 | melwitt | the used limits API is read only, it's just showing "reserved" usage | |
| 17:20:02 | mriedem | there wouldn't be reservations | |
| 17:20:17 | mriedem | https://developer.openstack.org/api-ref/compute/?expanded=show-rate-and-absolute-limits-detail | |
| 17:20:33 | bauzas | https://developer.openstack.org/api-ref/compute/#show-rate-and-absolute-limits | |
| 17:20:34 | mriedem | https://developer.openstack.org/api-ref/compute/?expanded=show-rate-and-absolute-limits-detail#limits-limits | |
| 17:20:37 | bauzas | yeah | |
| 17:20:57 | bauzas | so my question is, should we take the opportunity to remove 'reserved' from the API doc $ | |
| 17:20:59 | bauzas | ^ | |
| 17:21:19 | mriedem | no | |
| 17:21:30 | mriedem | because the api doc is true for liberty deployments | |
| 17:21:37 | mriedem | which aren't using counting quotas | |
| 17:21:41 | melwitt | yeah, like I thought that would require a microversion to just remove it from the API | |
| 17:21:46 | bauzas | oh right | |
| 17:21:52 | bauzas | we would need to microversion | |
| 17:21:59 | melwitt | since we're not reserving, "reserved" is 0 technically | |
| 17:22:01 | mriedem | jesus yes that's what i said in the patch itself | |
| 17:22:05 | melwitt | lol | |
| 17:22:29 | jaypipes | mriedem: done. | |
| 17:22:40 | mriedem | https://review.openstack.org/#/c/446242/41/nova/api/openstack/compute/used_limits.py@a65 | |
| 17:23:07 | bauzas | argh, jaypipes beated me up | |
| 17:23:40 | bauzas | mriedem: melwitt: for my knowledge, when did we stopped using that flag? | |
| 17:23:49 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | |
| 17:23:50 | mriedem | https://review.openstack.org/#/c/416521/ | |
| 17:23:53 | mriedem | in there ^ | |
| 17:24:02 | mriedem | the last reservable resource was instances, | |
| 17:24:13 | mriedem | and that change changes instnaces from a reservable resource to a countable resource | |
| 17:24:15 | melwitt | I don't understand how we're not using it, we're just correctly saying it's zero | |
| 17:24:17 | mriedem | hence reserved is no longer used | |
| 17:24:33 | mriedem | melwitt: i think he's asking which change made reserved vestigial | |
| 17:24:37 | melwitt | instead of letting it potentially show old unused reservations | |
| 17:24:41 | openstackgerrit | Merged openstack/nova master: Correct the description of 'disable-log-reason' api-ref https://review.openstack.org/480209 | |
| 17:24:41 | mriedem | it's this gd beast https://review.openstack.org/#/c/416521/63/nova/quota.py | |
| 17:24:43 | melwitt | oh | |
| 17:25:17 | bauzas | yeah just saw https://review.openstack.org/#/c/416521/63/nova/quota.py@139 | |
| 17:25:43 | bauzas | melwitt: yeah, what mriedem said | |
| 17:26:02 | melwitt | I guess we could leave it there and it would still be 0 because in nova/quota.py reserved is hardcoded to 0 | |
| 17:26:03 | bauzas | melwitt: I just wondered when we began ignoring that API flag | |
| 17:26:25 | bauzas | I'm definitely not a quota expert :( | |
| 17:27:10 | melwitt | with each resource change from ReservableResource -> CountableResource in nova/quota.py we return reserved=0 for that resource since reserving is no longer possible | |
| 17:28:54 | bauzas | anyway, time to bail out \o | |
| 17:31:09 | melwitt | bah, counting instances failed in the gate on yet another unrelated func test "Authentication error" | |