Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-14
20:41:21 melwitt okay. there's almost no info in the log
20:44:07 mriedem well, it's got to be something in here https://review.openstack.org/#/c/416521/58..60/nova/objects/instance.py
20:44:12 mriedem it's serializing the server response
20:44:13 mriedem and blowing up
20:44:55 mriedem but no idea what
20:46:00 melwitt I'm googling
20:50:48 melwitt I notice almost all the other methods use the @db.select_db_reader_mode decorator instead of what I used @db_api.pick_context_manager_reader
20:50:58 melwitt dunno if that could be a thing
20:51:06 mriedem well,
20:51:11 mriedem why would it just be that one test too?
20:51:17 mriedem for the personality (injected) files
20:53:01 mriedem https://review.openstack.org/#/c/416521/58..60/nova/conductor/manager.py ?
20:53:19 mriedem no nvm
20:55:36 melwitt it's weird how there's almost no info in the logging of that
20:57:38 mriedem oh it's in File "tempest/lib/services/compute/limits_client.py", line 26, in show_limits
20:58:43 mriedem so something to GET /limits is blowing up
21:01:52 mriedem so that would call QUOTAS.get_project_quotas,
21:02:10 mriedem which would eventually call through to _instances_cores_ram_count
21:02:24 mriedem which calls objects.InstanceList.get_counts
21:02:44 melwitt I think it makes that call with usages=False though which wouldn't count
21:03:05 melwitt unless this is a call to used_limits rather than limits
21:03:15 melwitt they'e both /limits
21:03:24 mriedem yeah it's an extension
21:03:28 melwitt so I guess must be
21:03:49 mriedem are the results from the db queries in the instance object actual primitives?
21:03:55 mriedem 'ram': project_result[2] or 0}}
21:03:55 mriedem 'cores': project_result[1] or 0,
21:03:55 mriedem counts = {'project': {'instances': project_result[0] or 0,
21:03:58 mriedem or are they sqla objects?
21:04:24 melwitt I'm using func.count, func.sum so they're supposed to be integers but this is the first time I've used the func functions
21:04:38 mriedem https://review.openstack.org/#/c/416521/58..60/nova/objects/instance.py@1425
21:04:42 mriedem should that be filter_by?
21:04:42 melwitt I based it off stuff I found in sqlalchemy/api.py
21:04:58 melwitt no based on what I copied
21:05:19 mriedem where is filter_by defined?
21:05:36 melwitt I was trying to do like this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2192
21:07:15 mriedem you need some leakypipes
21:08:23 melwitt yeah. I think I'm gonna just log what I'm returning from get_counts() and see what kind of garbage might be in there for that test
21:11:03 melwitt filter_by is a method on the query, like query.filter_by(...)
21:11:45 mriedem yup
21:12:07 mriedem https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1835 is similar to what you're doing
21:12:53 melwitt yeah, that's exactly what I was looking at. that's the existing instance quota refresh sync function
21:16:50 openstackgerrit melanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota https://review.openstack.org/477700
21:16:53 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
21:16:54 openstackgerrit melanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota https://review.openstack.org/477699
21:16:57 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
21:16:58 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
21:17:05 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
21:17:10 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
21:17:23 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: WIP: test against the counting quotas change https://review.openstack.org/484048
21:30:13 openstackgerrit Jan Gutter proposed openstack/os-vif master: Improve OVS Representor Lookup https://review.openstack.org/484051
21:33:52 mriedem blarg, we added tags to build request for no reason
21:34:08 mriedem and/or started passing tags to conductor for no reason when we already had them in the build request
21:34:09 mriedem double blarg
21:52:05 mriedem superdan: i know you're looking for something to review at 4pm on a friday https://review.openstack.org/#/c/469800/
22:53:48 openstackgerrit Davanum Srinivas (dims) proposed openstack/nova master: [WIP] Getting rid of crud around castellan options https://review.openstack.org/484036
23:08:01 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/484067
23:48:47 openstackgerrit Merged openstack/nova master: Default reservations=None in Cells v1 and conductor APIs https://review.openstack.org/483917
#openstack-nova - 2017-07-15
00:01:40 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/484067
01:03:51 mriedem melwitt: AHA http://logs.openstack.org/21/416521/61/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/1328370/logs/screen-n-api.txt.gz#_Jul_14_22_13_44_084898
01:03:58 mriedem counts = {'project': {'instances': 2, 'ram': Decimal('128'), 'cores': Decimal('2')}}
01:04:00 mriedem they aren't ints
01:04:27 mriedem maybe because it's not going through the models stuff
01:08:45 melwitt gdi. well, at least it's clear now. gonna look into why that's sometimes the case
01:09:00 melwitt makes me wonder why the existing query I copied doesn't do that
01:09:10 mriedem just do this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L853
01:09:16 mriedem field: int(results[idx] or 0)
01:09:23 mriedem ^ is from using .sum also
01:09:35 mriedem my guess is because of something to do with using model queries or not
01:09:39 mriedem vs straight sqla
01:09:41 mriedem but idk
01:09:45 melwitt yeah, I assumed I'd have to use int()
01:09:54 melwitt ohh.. yeah maybe
01:10:00 mriedem i was going to push the change assuming you and james were out galavanting
01:10:34 melwitt heh. not galavanting yet :)
01:13:03 melwitt I like the way jaypipes did this a lot more. I was working on it late last night/this morning and couldn't think how to enumerate over the fields in a good way
01:22:15 openstackgerrit melanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota https://review.openstack.org/477700
01:22:18 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
01:22:19 openstackgerrit melanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota https://review.openstack.org/477699
01:22:22 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
01:22:23 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
01:22:30 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
01:22:35 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
01:34:19 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.51 microversion https://review.openstack.org/483149
01:34:19 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.50 - fix quota class sets resource usage https://review.openstack.org/483060
04:25:16 openstackgerrit Merged openstack/nova master: Remove 'create_rule_default' https://review.openstack.org/479773
11:42:31 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:01:16 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/484067
12:02:36 openstackgerrit Davanum Srinivas (dims) proposed openstack/nova master: [WIP] Getting rid of crud around castellan options https://review.openstack.org/484036
14:19:57 openstackgerrit zhangdaolong proposed openstack/python-novaclient master: Fix the inappropriate parameter name https://review.openstack.org/480826
16:12:21 openstackgerrit zhangdaolong proposed openstack/python-novaclient master: Add sub command volume-attachment https://review.openstack.org/484147
16:47:54 openstackgerrit Merged openstack/nova master: Updated from global requirements https://review.openstack.org/484067
16:59:26 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add resize down test which also verifies quota changes https://review.openstack.org/484151
16:59:26 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add functional test for resize-confirm plus quota validation https://review.openstack.org/483559
16:59:27 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: DNM: run resize tests against counting quotas 15 times each https://review.openstack.org/484152
16:59:48 mriedem melwitt: bauzas: ^ will run resize up + confirm and resize down + revert 15 times each, single tenant, in serial, against the counting quotas change
16:59:53 mriedem to sniff out any issues with leaking quotas
17:08:08 openstackgerrit Chris Dent proposed openstack/nova master: [placement] cover deleting standard trait https://review.openstack.org/484153
17:08:09 openstackgerrit Chris Dent proposed openstack/nova master: [placement] cover deleting a custom resource class in use https://review.openstack.org/484154
17:22:26 openstackgerrit Chris Dent proposed openstack/nova master: [placement] cover deleting a custom resource class in use https://review.openstack.org/484154

Earlier   Later