Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-12
23:18:37 mriedem this could potentially move there for the RT claim stuff
23:18:41 mriedem or wherever
23:18:43 melwitt yeah
23:18:53 melwitt fine by me. makes my life easier too
23:19:11 mriedem i'll probably poke the ops list first to be safe
23:19:20 mriedem dansmith: agree i assume? ^
23:19:49 dansmith mriedem: I'd rather you not but whatever
23:19:56 mriedem so sneaky remove?
23:20:07 dansmith bugfix, imho
23:20:36 melwitt yeah. the bug where video ram usage wasn't ever decremented, that was a bug from whenever the feature was added to ... like last month
23:20:50 melwitt so I'm guessing around 5 years at least
23:20:59 dansmith dat bug yo
23:21:08 melwitt I assume people can't have cared about it too much
23:21:31 dansmith only people with video ram called out too
23:22:57 mriedem https://review.openstack.org/#/c/456050/
23:23:02 mriedem was the recent fix
23:23:51 dansmith rage quit!
23:24:03 melwitt lol
23:24:05 mriedem ok so maybe i just remove it and mark it related to that bug, and bug 1704012 and the counting quotas series
23:24:06 openstack bug 1704012 in OpenStack Compute (nova) "hw_video:ram_max_mb is tracked for quota but not compute node resource provider allocations" [Undecided,New] https://launchpad.net/bugs/1704012
23:24:22 melwitt I do that so often. open a link from the chat window and try to close the browser tab and close the channel tab
23:24:51 melwitt (with ctrl w)
23:25:31 dansmith melwitt: it wasn't even mentioned in the commit message, nor was the quota bit tested specifically, AFAICT
23:25:42 dansmith er, mriedem ^
23:27:26 mriedem so,
23:27:38 mriedem can my commit message to remove it just say, "hey, what's that behind you!"
23:27:53 melwitt lol
23:28:32 mriedem melwitt: you want me to do it and you rebase on top or you just handle it?
23:28:57 melwitt mriedem: yeah, you can do it
23:29:00 mriedem ok
23:29:41 dansmith mriedem: yes, yes it can
23:29:48 melwitt you can have that glory
23:30:02 melwitt I'm still trying to think about multi create
23:39:15 melwitt mriedem: yeah, I think you're right about the multi create thing. in compute/api, we're in the place where we haven't yet returned anything to the user. so if we bail with OverQuota, there should be no instances left that were created as a result of the request
23:39:33 melwitt it should be as if it never happend
23:39:53 mriedem slide of hand
23:39:55 mriedem *slight
23:40:03 melwitt looks like would have to clean up request specs and build requests too.
23:40:12 mriedem yeah
23:40:19 mriedem similar issue in conductor
23:40:24 melwitt yeah
23:56:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Stop counting hw_video:ram_max_mb against quota https://review.openstack.org/483133
23:56:01 mriedem dansmith: melwitt: ^
23:59:38 melwitt mriedem: cool
23:59:46 melwitt also, I think I finished replying to your other comments
#openstack-nova - 2017-07-13
00:00:11 mriedem yup
00:00:24 melwitt k.
00:00:41 melwitt think I gonna try to go outdoors now
00:01:35 mriedem i'm going to go berate my family for awhile
00:02:15 melwitt heh
00:06:27 mriedem alex_xu: when you're around, i've got the novaclient change up for the 2.50 microversion but a todo question in there about how we want to handle the python api if at all https://review.openstack.org/#/c/483060/3/novaclient/v2/quota_classes.py
00:06:43 mriedem otherwise the functional tests i added for the cli are all passing, so i'd just need to remove the WIP from the commit message
00:48:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
00:49:00 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
00:49:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
00:50:08 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
00:54:06 openstackgerrit Merged openstack/nova master: Trivial: Remove unnecessary format specifier https://review.openstack.org/481574
00:58:45 openstackgerrit Merged openstack/nova master: api-ref: Fix parameters in server-security-groups https://review.openstack.org/476434
00:59:19 openstackgerrit Merged openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847
01:11:07 openstackgerrit Merged openstack/nova master: Remove nova.api.extensions.server.extensions usage https://review.openstack.org/481494
01:11:46 openstackgerrit Merged openstack/nova master: Stop using deprecated 'message' attribute in Exception https://review.openstack.org/482014
01:12:21 openstackgerrit Merged openstack/nova master: Fix a missing classifier https://review.openstack.org/478733
01:12:56 openstackgerrit Merged openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774
01:13:32 openstackgerrit Merged openstack/nova master: Fix parameters and description for os-volume_attachments https://review.openstack.org/480832
01:14:07 openstackgerrit Merged openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
01:14:44 openstackgerrit Merged openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201
01:22:46 openstackgerrit Merged openstack/os-vif master: fix read the representor phys_port_name https://review.openstack.org/480213
01:31:12 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.51 microversion https://review.openstack.org/483149
01:46:16 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
01:54:59 mriedem melwitt: i hope the outdoors was enjoyable. i've finished all of the non-test parts of https://review.openstack.org/#/c/416521/ now - found another thing in the compute manager
01:55:03 mriedem easy thing
01:55:53 mriedem i also found 2 more places in the compute manager code that was cleaning up deleted instances but wasn't accounting for that video ram thing with adjust ram quota :)
02:10:54 alex_xu mriedem: I guess your concern about strict parameters is that it may break the backward-compatible?
02:11:17 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo. https://review.openstack.org/483159
02:11:56 alex_xu it sounds ok we strict parameters in the new microversion. So when the developer upgrade their client code to new microversion, they should check whether there is any interface change in the sdk interface
02:13:27 alex_xu mriedem: and we have parameter change in the some microversion https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L76
02:13:45 mriedem alex_xu: yeah we'd leave **kwargs for microversion 2.0 to 2.49 and then have strict kwargs for 2.51
02:13:48 mriedem *2.50
02:13:55 alex_xu gmann: fyi, mriedem already have a patch for the 2.50 in python-novaclient
02:14:09 mriedem i also identified some issues in the 2.50 api change
02:14:13 mriedem mostly docs
02:14:25 mriedem https://review.openstack.org/#/c/467999/
02:15:29 alex_xu mriedem: thanks, I can fix that
02:22:04 gmann alex_xu, mriedem thanks for client patch
02:22:26 gmann alex_xu, you are fixing api comments? or should i
02:22:55 mriedem my eyes are going to dry up and fall out so i'm going to be afk
02:23:38 alex_xu gmann: I can handle that
02:23:46 gmann alex_xu, thanks
02:32:41 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo. https://review.openstack.org/483162
03:10:28 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159
03:21:38 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483162
03:34:00 openstackgerrit Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170
03:34:11 alex_xu gmann: mriedem ^
03:54:34 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159
04:09:34 openstackgerrit Merged openstack/nova master: improve notification short-circuit https://review.openstack.org/482497
06:00:23 openstackgerrit jichenjc proposed openstack/nova master: add description for supports_migrate_to_same_host https://review.openstack.org/481483
07:05:26 openstackgerrit Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170
07:19:58 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
07:48:50 openstackgerrit Alex Szarka proposed openstack/nova master: Raise a real Exception instead of direct Exception call https://review.openstack.org/482200
08:07:49 jangutter sean-k-mooney: would you have an example handy on that alternate way to set the bridge name in a VIF? (something about trunk ports, I think...)

Earlier   Later