| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-10 | |||
| 09:20:17 | ildikov | stephenfin: hi :) | |
| 09:20:26 | stephenfin | ildikov: Morning :) | |
| 09:21:26 | ildikov | stephenfin: just wanted to give you a heads up that there are a few positive review comments on the swap_volume change: https://review.openstack.org/#/c/456971/ | |
| 09:21:40 | ildikov | stephenfin: in case that would help with reviewing it :) | |
| 09:24:38 | stephenfin | ildikov: Can't do any harm :) I'll take a shot again today, but I can't make any promises | |
| 09:24:46 | stephenfin | (just setting expectations) | |
| 09:25:53 | ildikov | stephenfin: thanks | |
| 09:27:02 | ildikov | stephenfin: Matt is basically fine with the patch; and it's also not that easy to find people in the core team who're familiar with this part of the code, so I thought to ping people first who reviewed related code changes earlier | |
| 09:27:26 | ildikov | stephenfin: so no pressure, but it would be a big help :) | |
| 09:27:59 | stephenfin | ildikov: I must be missing something, but why didn't he +2 it himself? | |
| 09:28:34 | ildikov | stephenfin: he uploaded the last patch set with some more tests | |
| 09:28:50 | openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform instance-live_migration_pre notification https://review.openstack.org/482070 | |
| 09:32:13 | gmann | alex_xu, can you check this -https://review.openstack.org/#/c/467999/9 | |
| 09:32:40 | alex_xu | gmann: yea, I will review before the end of day | |
| 09:33:19 | gmann | alex_xu, thanks | |
| 09:33:29 | alex_xu | gmann: np, thanks for the patch | |
| 09:42:36 | openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform instance-live_migration_post notification https://review.openstack.org/480119 | |
| 09:55:18 | openstackgerrit | bhavani proposed openstack/nova master: Stop using deprecated 'message' attribute in Exception https://review.openstack.org/482014 | |
| 11:18:54 | andreykurilin | sdague: hi! Have a minute? Can you check one small patch to novaclient which fixes discoverign versionsand unblocks gates? (It is already have one +2) | |
| 11:19:07 | sdague | sure, url? | |
| 11:19:29 | andreykurilin | https://review.openstack.org/#/c/479818/ | |
| 11:35:18 | sean-k-mooney | moshele: hi moshele i just responded in the review but yes using something like openstack port create --binding-profile | |
| 11:35:20 | sean-k-mooney | '{"capabilities": ["hw-tc-offload"]}' --vnic_type direct --network private port1. | |
| 11:35:27 | sean-k-mooney | works for me | |
| 11:37:14 | moshele | sean-k-mooney: you want me to add a TODO comment in the code for now? | |
| 11:41:48 | sean-k-mooney | moshele: https://review.openstack.org/#/c/398265/ should probably be rebased ontop of https://review.openstack.org/#/c/466051 | |
| 11:42:43 | sean-k-mooney | moshele: if we open a todo comment we should also log a bug to track its completeion | |
| 11:44:00 | sean-k-mooney | moshele: does libvirt/ethtool currently expose the hw-tc-offload or switchdev feature flag | |
| 11:57:38 | moshele | sean-k-mooney: ok bye the way we have CI ready http://52.169.200.208/13/480213/3/check-os-vif/OVS_HW_offload/08d10ee/ | |
| 11:57:52 | moshele | s/bye/by | |
| 11:58:21 | sean-k-mooney | moshele: oh cool and you started with the 2 most value test sets +1 | |
| 11:59:08 | sean-k-mooney | moshele: will you be adding a full temest compute or networking run or leaving it at the scenario tests? | |
| 12:00:03 | moshele | sean-k-mooney: I think the scenario covers all we need for now | |
| 12:01:20 | sean-k-mooney | moshele: yep they should we only ran the other tests as nova wanted that before giveing voteing rights | |
| 12:03:27 | bhagyashris | cdent: Hi, Thanks for new release of gabbi. Actually I am just trying to chcek response object with sample.json (expected response) for the placement functional gabbi test "confirm the correct post" but i am getting the error as "Unable to match $ as <@sample.json, got" after running the test. | |
| 12:04:05 | bhagyashris | cdent: I am checking like: response_json_paths: | |
| 12:04:06 | bhagyashris | $: <@sample.json | |
| 12:44:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 12:44:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 12:44:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764 | |
| 12:57:59 | bhagyashris | cdent: Hi, Thanks for new release of gabbi. Actually I am just trying to chcek response object with sample.json (expected response) for the placement functional gabbi test "confirm the correct post" but i am getting the error as "Unable to match $ as <@sample.json, got" after running the test. | |
| 12:58:05 | bhagyashris | <bhagyashris> $: <@sample.json | |
| 12:58:05 | bhagyashris | cdent: I am checking like: response_json_paths: | |
| 12:59:06 | cdent | the file sample.json needs to be in the same directory as the yaml file, and it of course needs to have the correct content in it | |
| 12:59:19 | cdent | can you paste your yaml file and sample.json somewhere? | |
| 12:59:54 | bhagyashris | yamal | |
| 12:59:56 | bhagyashris | - name: confirm the correct post | |
| 12:59:57 | bhagyashris | $.: <@sample.json | |
| 12:59:57 | bhagyashris | response_json_paths: | |
| 12:59:57 | bhagyashris | content-type: application/json | |
| 12:59:57 | bhagyashris | request_headers: | |
| 12:59:57 | bhagyashris | GET: /resource_providers/$ENVIRON['RP_UUID'] | |
| 13:01:01 | bhagyashris | cdent: sample.json http://paste.openstack.org/show/614909/ | |
| 13:03:23 | cdent | bhagyashris you’ll want to change sample.json so that name and uuid are “$ENVIRON[‘RP_UUID’]” and $ENVIRON[‘RP_NAME’] and also use the environ in the url paths too? | |
| 13:04:56 | cdent | bhagyashris: but also, based on the error message it looks like you don’t have the latest gabbi installed | |
| 13:05:58 | bhagyashris | cdent: I have pulled new gabbi test and install on my machine | |
| 13:06:37 | cdent | bhagyashris: are you running the tests with tox? if so, it will be using the gabbi in the virtualenv | |
| 13:07:31 | bhagyashris | cdent: and regarding the name and uuid temporarily I have hard coded the name and uuid in the fixtures.py | |
| 13:07:45 | cdent | ah, okay | |
| 13:08:06 | bhagyashris | cdent: yeah like tox -e functional | |
| 13:08:28 | cdent | then in that case you need to install the new gabbi with '.tox/functional/bin/pip install -U gabbi’ | |
| 13:10:49 | bhagyashris | cdent: ok. trying | |
| 13:11:51 | bhagyashris | AssertionError: unable to extract JSON from test results | |
| 13:11:51 | bhagyashris | cdent: got error: raise AssertionError('unable to extract JSON from test results') | |
| 13:13:58 | cdent | bhagyashris: instead of $. you $ | |
| 13:14:00 | bhagyashris | cdent: working :) | |
| 13:14:07 | bhagyashris | cdent: yeah | |
| 13:14:10 | cdent | :) | |
| 13:15:23 | bhagyashris | cdent: I just one question How should I access name and uuid "$ENVIRON[‘RP_UUID’]" and $ENVIRON[‘RP_NAME’] in sample.json | |
| 13:15:48 | cdent | bhagyashris: I’ll change your paste to show you, one sec | |
| 13:15:58 | bhagyashris | cdent: ok | |
| 13:20:31 | cdent | bhagyashris: http://paste.openstack.org/show/614916/ | |
| 13:22:56 | bhagyashris | cdent: Thanks a lot. :) | |
| 13:23:47 | cdent | bhagyashris: keep me posted on how it’s going, will be interesting to see how it works out | |
| 13:28:13 | bhagyashris | cdent: ok. and one more thing I guess keeping the sample.json in other folder will cause problem right so is it ok that response.json in same folder? | |
| 13:29:54 | cdent | the way the file reading works is that it needs to be in the same directory as the yaml file or any directory within that directory | |
| 13:31:24 | bhagyashris | cdent: ok. Thanks for info. | |
| 13:36:30 | andreykurilin | sdague: thanks | |
| 13:38:06 | sdague | andreykurilin: no prob, thanks for building the patch | |
| 13:42:37 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-evacuate notification https://review.openstack.org/480119 | |
| 13:44:53 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-evacuate notification https://review.openstack.org/482148 | |
| 13:45:35 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-live_migration_post notification https://review.openstack.org/480119 | |
| 13:55:39 | edleafe | Scheduler subteam meeting in 5 minutes in #openstack-meeting-alt | |
| 14:01:01 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in cast_as_call.py https://review.openstack.org/477730 | |
| 14:01:35 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_remote_consoles.py https://review.openstack.org/478423 | |
| 14:01:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Verify parameters in os-migrations.inc https://review.openstack.org/474879 | |
| 14:01:59 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201 | |
| 14:02:14 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in server-security-groups https://review.openstack.org/476434 | |
| 14:02:28 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add missing parameters in limits.inc https://review.openstack.org/475640 | |
| 14:02:40 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix a missing classifier https://review.openstack.org/478733 | |
| 14:03:15 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847 | |
| 14:03:27 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374 | |
| 14:03:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276 | |
| 14:03:56 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use URIOpt https://review.openstack.org/479215 | |
| 14:04:44 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Amend the "list-show-all-server-migration-types" spec https://review.openstack.org/460847 | |
| 14:05:39 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix quota class set APIs https://review.openstack.org/467999 | |
| 14:16:02 | mriedem | o/ | |
| 14:21:16 | openstackgerrit | sean mooney proposed openstack/os-vif master: set mtu on all code paths https://review.openstack.org/469951 | |
| 14:31:48 | dansmith | jaypipes: can you legitimify my comment here? https://review.openstack.org/#/c/476631/19 | |
| 14:32:37 | mriedem | dansmith: we're talking about it in the scheduler meeting | |