Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-23
13:33:16 leakypipes bauwser: I'm mostly focused on the code in the placement-allocation-requests patch series.
13:33:32 bauwser that's something I'm reviewing now
13:34:04 leakypipes cool, thank you sir
13:34:29 bauwser edleafe: so I guess you'll rebase placement-claims on top of leakypipes's branch ?
13:35:03 bauwser leakypipes: FWIW, saw 2 patches merged by June 20, so I'm looking at them first
13:56:52 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
13:56:52 openstackgerrit melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481
14:48:32 openstackgerrit Jay Pipes proposed openstack/nova master: move resources_from_request_spec() to utils https://review.openstack.org/476629
14:48:33 openstackgerrit Jay Pipes proposed openstack/nova master: Add uuid to scheduler's HostState object https://review.openstack.org/476630
14:48:33 openstackgerrit Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631
14:48:34 openstackgerrit Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632
14:48:34 openstackgerrit Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
14:49:15 openstack Launchpad bug 1688673 in OpenStack Compute (nova) "cpu_realtime_mask handling is not intuitive" [Undecided,New]
14:49:15 cfriesen_ sdague: I added a review to bug https://bugs.launchpad.net/nova/+bug/1688673, not sure why the link wasn't automatically added.
14:50:39 sdague cfriesen_: I think the fact that you didn't add closes-bug on the first iteration
14:50:51 cfriesen_ sdague: seems likely
14:51:07 sdague cfriesen_: ok, make sure to mark in progress as well
14:51:29 sdague because I'm building another script that's going to unassign all the not in progress bugs
14:51:30 cfriesen_ sdague: done
14:53:39 cfriesen_ anyone know if sahid is on holidays or something?
14:54:34 leakypipes cfriesen_: sahid doesn't hang out on public IRC any more. only RH internal IRC.
14:54:43 leakypipes cfriesen_: he responds to review comments, though.
14:55:35 cfriesen_ leakypipes: ah, okay. thanks
14:55:44 leakypipes cfriesen_: or email of course
15:08:07 bauwser leakypipes: shit, your gerrit topic name is different from one series to another
15:08:11 bauwser that confused me
15:08:41 bauwser bp/placement-allocation-request vs. bp/placement-allocation-request*s*
15:09:22 bauwser leakypipes: you should probably upload again that branch https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/placement-allocation-request and change the topic
15:09:37 bauwser so we could just look over at https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/placement-allocation-requests
15:10:34 bauwser and FWIW I thank matt and dan for having reviewed https://review.openstack.org/#/c/473377/9/nova/objects/resource_provider.py that :p
15:12:35 openstackgerrit Eric Fried proposed openstack/nova master: Adopt new pypowervm power_off APIs https://review.openstack.org/476945
15:20:26 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453
15:33:44 openstackgerrit Jay Pipes proposed openstack/nova master: Remove code that produces warning in modern Python https://review.openstack.org/476952
15:51:39 dtantsur edleafe: hi! is https://review.openstack.org/#/c/473627/ enough for this feature to work? I may try to get a patch against ironic with depends-on to try it.
15:51:50 dtantsur (though probably on Monday, as it's nearly EOD here)
16:24:58 openstackgerrit Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631
16:24:59 openstackgerrit Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
16:24:59 openstackgerrit Jay Pipes proposed openstack/nova master: Add uuid to scheduler's HostState object https://review.openstack.org/476630
16:25:00 openstackgerrit Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632
16:27:08 leakypipes efried, edleafe: addressed your comments (thanks!) from the reviews above.
16:27:22 efried ack
16:27:32 efried leakypipes FYI, still working my way through the series.
16:27:56 leakypipes efried: you definitely need a casual Friday nick.
16:28:09 leakypipes and with a name like Eric Fried, you have many options.
16:28:13 efried leakypipes My name anagrams to fried_rice
16:28:20 leakypipes :)
16:28:23 leakypipes perfect.
16:32:09 dtp lol
16:33:59 openstackgerrit Maciej Kucia proposed openstack/nova master: WIP Introduced class PciDeviceAddress https://review.openstack.org/476972
16:34:00 openstackgerrit Maciej Kucia proposed openstack/nova master: WIP Introduced PciDeviceAddressPattern class https://review.openstack.org/476973
16:36:57 cfriesen_ I've got a proposed change (https://review.openstack.org/#/c/461456) to treat "hw:cpu_realtime_mask" in the flavor extra-specs as a bitmask rather than an implied exclusion mask. If anyone is opinionated on this please feel free to review it. (Personally I think the implicit "all cpus are realtime" is confusing and illogical.)
16:40:17 mriedem edleafe: DictOfStringsField does not validate the value is not null
16:40:18 mriedem http://paste.openstack.org/show/613526/
16:41:04 openstackgerrit Ildiko Vancsa proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
16:43:47 dtp mriedem i see your -2 on https://review.openstack.org/#/c/464280/; should i still look it over?
16:44:59 mriedem dtp: i think you already looked at the os-services one once
16:45:11 mriedem dtp: the -2 is procedural
16:45:33 mriedem once i'm done with the os-hypervisors change on top and it's generally ok with reviewers, then we can merge them in order or squash them
16:45:50 mriedem i just didn't want another microversion slipping in between
16:46:03 dtp sounds good. i'll look at the other two!
16:49:10 cfriesen_ mriedem: speaking of microversions...https://review.openstack.org/#/c/435141 is ready I think.
16:51:42 mriedem dtp: the hypervisors one just needs the unit tests done, which i'll do whilst flying today
16:52:00 mriedem cfriesen_: ok
16:52:12 dtp ok
16:58:04 mriedem flight is delayed 2 hours for maintenance and the connection was 2 hours, so will probably miss the connection to china, so maybe i'll just be hanging out in an airport reviewing code for the next 24 hours
16:59:23 mriedem artom: do you want to just fix this quick or patch it on top? https://review.openstack.org/#/c/415622/55/nova/exception.py
17:00:07 superdan mriedem: ouch
17:01:15 mriedem those 2 spaces in the middle of the error message? i know.
17:01:31 mriedem maybe i'll catch a ride down to portland for the evening
17:03:17 superdan mriedem: where are you?
17:05:38 artom mriedem, the space? Bah, might as well fix it
17:05:56 mriedem artom: just fix it quick and i'll re-+2
17:05:59 mriedem superdan: in MSP right now
17:06:05 mriedem was supposed to leave about an hour ago
17:06:13 mriedem superdan: connecting in seattle
17:06:13 superdan ah
17:06:24 mriedem had a 2 hour connection, now it's going to be like a 2 minute connection
17:06:27 superdan that's what I meant, where are you going to be
17:06:47 superdan mriedem: well, yeah if you end up in PDX we'll be glad to show you a good time :P
17:07:06 artom mriedem, done
17:07:19 artom mriedem, is Huawei bringing you in to the motherland?
17:07:24 mriedem artom: yup
17:07:36 openstackgerrit Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622
17:07:39 openstackgerrit Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387
17:07:48 openstackgerrit Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
17:07:50 openstackgerrit Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021
17:17:02 melwitt dtp made me confused about the compute node marker thing again
17:17:40 melwitt does passing the marker mean return the one with the marker or the one after it?
17:18:01 superdan should be after it
17:18:10 melwitt okay, then that makes sense
17:18:39 melwitt ah "select = select.where(cn_tbl.c.id > marker)"
17:18:59 melwitt PHEW
17:38:52 dtp thanks melwitt for clearing that up
18:02:45 dtp are the api-ref files read by normies or are they just for nova devs?
18:13:30 cfriesen_ dtp: anyone coding to the HTTP API
18:13:44 dtp thanks
18:13:46 cfriesen_ but that could be end-users, not openstack devs
18:23:20 mriedem cfriesen_: some small issues in https://review.openstack.org/#/c/435141/ but +2
18:28:39 openstackgerrit Merged openstack/nova master: Remove code that produces warning in modern Python https://review.openstack.org/476952
18:37:16 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.48: Standardization of VM diagnostics https://review.openstack.org/473228

Earlier   Later