| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-07 | |||
| 14:35:25 | kashyap | The command sequence in quotes | |
| 14:35:25 | sdague | kashyap: what was your intent with the free calls? | |
| 14:35:48 | sdague | kashyap: sure, I guess I'm just not sure what you were asking for as "improvement" | |
| 14:35:51 | kashyap | Just to see if dropping 'needless' things in the caches will show what's the bare-minimal memory occupation | |
| 14:36:12 | sdague | but thats FS cache right? | |
| 14:36:27 | sdague | that's not going to impact any program mem usage | |
| 14:37:59 | kashyap | sdague: That's freeing page cache | |
| 14:38:10 | sdague | kashyap: yes | |
| 14:38:43 | sdague | kashyap: sorry, I guess I'm just not sure what you are asking when you asked about "improvement" | |
| 14:38:50 | sdague | what were you expecting? | |
| 14:38:56 | sdague | that you wanted me to verify | |
| 14:39:24 | kashyap | sdague: I think I erroneously thought it'll have effect on program memory usage | |
| 14:39:41 | kashyap | So just talking out loud, your brain spelled my stupidity out. | |
| 14:39:41 | openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581 | |
| 14:47:13 | openstackgerrit | Jianghua Wang proposed openstack/nova master: Fix the race condition with novnc https://review.openstack.org/470798 | |
| 15:00:35 | openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for aggregates https://review.openstack.org/470932 | |
| 15:00:35 | openstackgerrit | Andrey Volkov proposed openstack/nova master: [WIP] [placement] Add api-ref for allocations https://review.openstack.org/470933 | |
| 15:08:08 | openstackgerrit | Baodong (Robert) Li proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.openstack.org/471815 | |
| 15:12:18 | mriedem | good lord there are just way too many config options for libvirt live migratoin | |
| 15:12:19 | mriedem | *migration | |
| 15:12:32 | mriedem | the help for some of them even reference things that no longer exist, which is helpful | |
| 15:14:39 | openstackgerrit | Gábor Antal proposed openstack/nova master: Move rebuild notification tests into separate method https://review.openstack.org/451789 | |
| 15:20:00 | kashyap | mriedem: How many are you counting? | |
| 15:20:13 | mriedem | "a bazillion" is what my email to the ML is going to say | |
| 15:20:32 | kashyap | Heh, everything looks useful when you read one-by-one, doesn't it | |
| 15:21:00 | mriedem | sent | |
| 15:21:19 | mriedem | i took some artistic freedoms in language toward the end | |
| 15:21:24 | kashyap | :-) | |
| 15:21:54 | kashyap | But yeah, more seriously, exposing every frelling knob that libvirt has (which explicitly *doesn't* make policy decisions, by design) is not desirable | |
| 15:22:13 | kashyap | Must probaby turn some of them into defaults | |
| 15:23:30 | mriedem | s/landmine/minefield/ d'oh | |
| 15:23:45 | mriedem | well i'll see if i can cleanup some of these options | |
| 15:23:47 | mriedem | help-wise | |
| 15:24:02 | dansmith | landfill? | |
| 15:24:15 | mriedem | tire fire | |
| 15:24:54 | jaypipes | mriedem: there's way too many Nova config options for libvirt live migration because there's way too many configuration options for libvirt live migration. period... | |
| 15:25:52 | mriedem | the heart wants what it wants jay | |
| 15:25:58 | mriedem | and it wants mfing config options | |
| 15:26:10 | kashyap | The Nova time-outs and re-tries seemed to be the ones that can be removed? | |
| 15:26:25 | gbarros | mriedem I see that you +2 mhenkel's vif patch. Could you take a peek at the blueprint also pls? | |
| 15:26:40 | gbarros | mriedem https://blueprints.launchpad.net/nova/+spec/opencontrail-nova-vif-plugin | |
| 15:26:42 | kashyap | Err, before someone jumps on me, "removed" as in ... "can they be reconsiderd" | |
| 15:27:47 | mriedem | gbarros: as in approve the bp? | |
| 15:27:51 | mriedem | btw, -2 on the stable/ocata backport | |
| 15:27:56 | mriedem | we don't backport features | |
| 15:28:20 | gbarros | mriedem, on the bp, if it looks ok to you. | |
| 15:28:38 | gbarros | mriedem, ack on -2 for the backport. It was worth a shot :) | |
| 15:29:27 | openstackgerrit | Baodong (Robert) Li proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.openstack.org/471815 | |
| 15:29:57 | gbarros | mriedem, on the backport I'm mostly wanting to see if it will pass CI. | |
| 15:30:06 | jaypipes | kashyap: if there was a stable and consistently-converging live-migration interface in libvirt, those options wouldn't be needed. :) | |
| 15:30:09 | mriedem | gbarros: approved the bp, i forgot about that one | |
| 15:30:14 | gbarros | mriedem ty! | |
| 15:30:20 | cdent | jaypipes: i'm a bit confused and concerned about your lack of concern on the conusmer uuid thing, especially if the fix is doing and update or insert instead of what's there now? | |
| 15:30:24 | kashyap | jaypipes: Nod... | |
| 15:30:36 | mriedem | gbarros: mhenkel: now you just need to get jaypipes to review the chnage | |
| 15:30:37 | jaypipes | cdent: I'm not concerned *for that patch*. | |
| 15:30:38 | mriedem | *change | |
| 15:31:01 | jaypipes | cdent: nobody other than Nova is yet writing allocations. we can add a patch in the future to handle that situation. | |
| 15:31:14 | kashyap | jaypipes: I also wonder if this can be elided - 'live_migration_inbound_addr' | |
| 15:31:28 | jaypipes | cdent: I don't want to hold things up endlessly trying to figure out the perfect solution for everything in the future, that's all. | |
| 15:31:51 | jaypipes | cdent: especially since we're running out of time quickly for Pike. | |
| 15:33:09 | cdent | jaypipes: agreed it would be nice to get this done, but this doesn't need a perfect solution, it just needs normal SQL... | |
| 15:33:57 | cdent | I think the code has a bug. Not an architecture confusion (like over in the how to deal with complex allocations thread). Those are different types of concerns. | |
| 15:34:07 | gbarros | jaypipes, at your convenience :) https://review.openstack.org/#/c/441183/ | |
| 15:34:31 | jaypipes | cdent: would you mind taking a looksie at melwitt's https://review.openstack.org/#/c/469634/10 test failure on _test_sync_traits()? | |
| 15:35:01 | jaypipes | cdent: why can't this be done in a patch after the one in question? | |
| 15:35:25 | cdent | jaypipes: we fixed that late last night with: https://review.openstack.org/#/c/471508/ | |
| 15:35:55 | openstackgerrit | Gábor Antal proposed openstack/nova master: Move rebuild notification tests into separate method https://review.openstack.org/451789 | |
| 15:35:56 | cdent | jaypipes: we can, that would be fine, but we have to agree to do so | |
| 15:37:27 | gabor_antal | sfinucan, oomichi: Would you please give back +2 on https://review.openstack.org/#/c/451789 ? I had to rebase it manually. | |
| 15:37:29 | jaypipes | cdent: I agree to do so. :) | |
| 15:37:38 | jaypipes | cdent: ok, cool (on the testsync traits thing) | |
| 15:38:11 | cdent | awesome, thanks jaypipes, that's more than I hoped for | |
| 15:38:19 | jaypipes | gbarros: you know what would make reviewing that easier? more than 0 lines of documentation on the opencontrail vif plugin repo :) | |
| 15:38:57 | gbarros | jaypipes, tell me about it :) mhenkel keeps telling me it's fully documented... somewhere... :) | |
| 15:40:05 | gbarros | mhenkel, could you help us out by pointing out the docs? Maybe a link to it in the readme? | |
| 15:40:21 | jaypipes | mriedem, gbarros: I thought I remembered some conversation where we wanted to make "vhostuser_vrouter_plug" mention contrail specifically before we merged this patch? | |
| 15:40:52 | jaypipes | gbarros: or is vhostuser_vrouter_plug already in the Neutron vif details and we can't change it? | |
| 15:40:58 | mriedem | jaypipes: the latter | |
| 15:41:07 | mriedem | see my question about that in the 2nd to last patch set | |
| 15:41:16 | mriedem | their plugin now registers with contrail in the name, | |
| 15:41:21 | gbarros | jaypipes, I believe there is a TODO on that? | |
| 15:41:22 | mriedem | but the vif details thing is already baked into neutron | |
| 15:41:23 | openstackgerrit | Merged openstack/nova master: Revert "Remove Babel from requirements.txt" https://review.openstack.org/471498 | |
| 15:41:26 | mriedem | yeah i added the todo | |
| 15:42:05 | jaypipes | gbarros: yeah, totes, there's a TODO, was just seeing if I remembered reading a discussion about it correctly :) | |
| 15:42:25 | jaypipes | gbarros: I'm getting old and can't remember all the things. | |
| 15:43:40 | gbarros | jaypipes, you're ahead of me there, I could never remember all the things. | |
| 15:45:38 | jaypipes | mhenkel, gbarros: +W'd. | |
| 15:45:45 | mriedem | i don't understand this https://github.com/openstack/nova/blob/7815108d4892525b0047c787cbd2fe2f26c204c2/nova/virt/libvirt/driver.py#L568 | |
| 15:45:51 | mriedem | live_migration_tunneled is a boolean | |
| 15:45:53 | mriedem | so why would it be None? | |
| 15:46:04 | mriedem | if Falsey or True | |
| 15:46:06 | mriedem | god | |
| 15:46:30 | jaypipes | mriedem: the default before the option came into existence? | |
| 15:46:37 | mriedem | it might have been a string | |
| 15:46:44 | mriedem | that's my guess, so i'm checking history | |
| 15:47:00 | jaypipes | ya | |
| 15:47:47 | mriedem | nope it was always boolean https://github.com/openstack/nova/commit/621594fc41d0e07fd63dfe7c3c5cfee9edc380ad#diff-f4019782d93a196a0d026479e6aa61b1R171 | |
| 15:48:07 | mriedem | oh but not default | |