Earlier  
Posted Nick Remark
#openstack-nova - 2017-05-31
10:03:41 andymccr egonzalez: can you link the bug once it's created - i'll add our logs too
10:03:50 openstackgerrit Huan Xie proposed openstack/nova master: XenAPI: Remove bittorrent.py which is already deprecated https://review.openstack.org/468273
10:13:32 openstack Launchpad bug 1694666 in OpenStack Compute (nova) "metadata service PicklingError: Can't pickle <class 'sqlalchemy.orm.session.Session'>" [Undecided,New]
10:13:32 egonzalez andymccr, https://bugs.launchpad.net/nova/+bug/1694666
10:17:26 andymccr egonzalez: thanks!
10:40:41 sfinucan alex_xu: You might look at https://review.openstack.org/#/c/399613/ today. It's the only patch in that series that still needs a +2, and you've already reviewed the rest
10:58:53 openstackgerrit Sean Dague proposed openstack/nova master: Send request_id on neutron calls https://review.openstack.org/468356
11:11:09 openstackgerrit Merged openstack/nova master: Added nova objects for intance diagnostics https://review.openstack.org/434745
11:11:41 openstackgerrit Merged openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480
11:43:23 bauzas cdent: edleafe: jaypipes: sfinucan: stupidly forgot that I was normally on PTO today, so I won't be there today
11:50:29 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923
12:13:57 openstackgerrit Merged openstack/nova master: XenAPI: nova-compute cannot restart after manually delete VM https://review.openstack.org/467926
12:14:45 openstackgerrit Merged openstack/nova master: Changing deleting stale allocations warning to debug https://review.openstack.org/468519
12:20:20 dims bauzas : easy one if you get a chance please peek - https://review.openstack.org/#/c/468743/
12:27:42 openstack Launchpad bug 1694666 in OpenStack Compute (nova) "metadata service PicklingError: Can't pickle <class 'sqlalchemy.orm.session.Session'>" [Undecided,New]
12:27:42 sfinucan dims: Is https://bugs.launchpad.net/nova/+bug/1694666 in any way related to that?
12:27:48 sfinucan that being
12:27:51 sfinucan https://review.openstack.org/#/c/468743/
12:29:10 sfinucan I +W'd that, given that sdague's comments were address and it otherwise looked a-ok
12:31:38 dims sfinucan : thanks! no it was a badly written test (not the Pickling error thingy)
12:35:30 openstackgerrit Hong Hui Xiao proposed openstack/nova master: VMware: Check if network is ready on cluster host https://review.openstack.org/467589
12:37:31 openstackgerrit Gábor Antal proposed openstack/nova master: Make docstring comments more consistent in rpcapi.py https://review.openstack.org/380344
12:38:59 alex_xu sfinucan: yea, I will try
12:39:14 sfinucan alex_xu: Ta
12:39:55 alex_xu sfinucan: also an easy one to get rid of the useless warning in the test https://review.openstack.org/#/c/468614/
12:41:27 alex_xu Kevin_Zheng: I still didn't see the last patch for this series https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/support-tag-instance-when-boot, is the last patch in the same topic?
12:43:32 Kevin_Zheng alex_xu: thanks for asking, I was quite busy recently and didn't got chance to update it
12:44:17 Kevin_Zheng But since the 3rd one is almost Ok, I will update the 4th one tomorrow
12:45:27 alex_xu Kevin_Zheng: cool, thanks, no worries, just want to ensure i'm not missing something
12:45:41 alex_xu nova api meeting is in 15 mins
12:47:25 sfinucan alex_xu: Done and dusted
12:48:34 alex_xu sfinucan: thanks
12:52:52 edleafe jaypipes: sorry, didn't have much time yesterday between meetings and such
12:53:04 edleafe jaypipes: what is the status of that odd os-traits bug?
13:00:27 alex_xu nova api meeting is running at #openstack-meeting-4
13:24:08 cdent edleafe: I'm reviewing in the https://review.openstack.org/#/q/topic:bp/placement-claims-4 stack. Is it just the first two that matter for now?
13:24:46 cdent and what of the older topic matters: https://review.openstack.org/#/q/topic:bp/placement-claims
13:26:24 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923
13:30:07 jaypipes edleafe: have not looked at it since yesterday
13:30:40 jaypipes efried: awesome review on the provider tree patch. was working into the wee hours fixing that up. just rebasing to master now and will push a new patch shortly.
13:39:57 edleafe cdent: those two are the current focus. After getting feedback that operators are indeed (mis-)using the host_subset_size, I need to remove that change from the stack
13:40:31 cdent edleafe: k, I'll not bother with the rest for now then, moving on to os-traits
13:40:35 cdent thanks
13:41:46 openstackgerrit Merged openstack/nova master: Do not rely on dogpile internals for mocks https://review.openstack.org/468743
13:44:32 cdent jaypipes: left some comments on the traits syncing stuff. I don't understand why need a cache at all?
13:46:11 jaypipes cdent: it was a convenient place to put the sync routine and it matches the resource class cache.
13:46:43 cdent sure, but the resource class cache is needed because we have some stuff in db, and some stuff not in db
13:46:46 cdent not true with traits
13:46:56 jaypipes yes, I'm aware of that
13:47:07 cdent so...?
13:47:09 jaypipes cdent: it was a convenient place to put the sync routine and it matches the resource class cache.
13:47:15 jaypipes cdent: it was a convenient place to put the sync routine and it matches the resource class cache.
13:47:16 jaypipes cdent: it was a convenient place to put the sync routine and it matches the resource class cache.
13:47:28 cdent yeah, that's completely meaningless :)
13:47:32 jaypipes lol, sorry :)
13:47:35 cdent you can say it ten more times
13:47:41 jaypipes didn't mean to repeat that.
13:47:59 cdent :)
13:48:03 jaypipes serves me right for trying to do two things at once :)
13:48:16 cdent only two? that's pretty good discipline
13:49:01 jaypipes cdent: anyway, did you see the original patch from one of alex_xu's colleagues that added a new placement-manage CLI tool to do trait syncs?
13:49:11 cdent yes
13:49:23 cdent we don't want that
13:49:24 jaypipes cdent: so you're aware of the impetus for me doing this, then.
13:49:42 jaypipes cdent: how do you propose to do the syncing?
13:49:57 cdent I'm aware of why you want to have a sync happen in an automatic fashion, but it ought to be possible to do it without the cache
13:50:03 cdent one sec
13:50:26 mriedem sfinucan: i added cfriesen to your series here https://review.openstack.org/#/q/topic:bp/reserve-numa-with-pci - i'd like his review on that before i do
13:50:41 mriedem moshe would probably also be good
13:50:58 jaypipes cdent: oh, it's totally possible to do it without the cache. I just figured the trait cache would be useful in the same way the rc cache is
13:51:11 cdent jaypipes: that's my question: what's the point of the cache?
13:51:37 cdent " I don't understand why need a cache at all?"
13:51:38 jaypipes cdent: just consistency with the resource classes and a convenient place to put the sync thing, like I said.
13:51:47 jaypipes cdent: consistency with rcs
13:52:04 jaypipes cdent: where would you put the auto-sync thing?
13:52:30 jaypipes cdent: feel free to push a patch that doesn't use a cache. I'm happy to review it.
13:52:52 cdent instead of _ensure_trait_cache have _ensure_trait_sync which checks a global boolean to know if sync happend, get rid of all the code in the trait cache file except for the sync method
13:54:13 cdent jaypipes: I'll be happy to push something, but just as a point of order, I don't think it should be incumbent on me to prove why you shoudn't add a piece of code that doesn't appear necessary. It should be on you to prove that it is (beyond consistency).
13:55:15 jaypipes cdent: fair enough
13:55:50 cdent jaypipes: usually you have very good reasons so I was prepared to take this on trust, but I've stumbled to find the reason, thus the questions
13:56:36 jaypipes cdent: I liked the symmetry of it, nothing more.
13:57:06 cdent okay, thanks, given that I'll push an alternate
13:58:16 jaypipes cool beans.
13:58:21 jaypipes cdent: thanks!
13:58:42 cdent so many layers of hell
13:59:25 xyang1 mriedem: hi, question regarding the merge deadline. I only see a Nova spec deadline published here: https://releases.openstack.org/pike/schedule.html Does that mean all code patches have the same merge deadline, Pike-3, regardless of its priority?
14:06:33 mriedem xyang1: yes
14:06:59 mriedem xyang1: https://wiki.openstack.org/wiki/Nova/Pike_Release_Schedule
14:07:21 xyang1 mriedem: thanks. That means we have more time to fix the ScaleIO CI issues
14:07:25 mriedem yup
14:11:57 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.live_migration_rollback notification https://review.openstack.org/402124
14:34:39 openstackgerrit Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677
14:40:30 openstackgerrit Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677
14:45:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
14:46:49 mriedem mgagne: ^ rebased for you, put some todos in there too
14:49:58 mgagne working on it
14:50:59 gabor_antal Hey there, can I get a little help with this ? https://review.openstack.org/#/c/469038/ Currently, on functional-py35 fails due to the inspect library cannot find any frame, however with python 2.7 everything works fine. does someone have any idea? thanks in advance
14:51:45 openstackgerrit Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250
14:56:21 openstackgerrit Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
14:58:30 openstackgerrit Merged openstack/nova master: Avoid lazy-load error when getting instance AZ https://review.openstack.org/468147

Earlier   Later