| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-30 | |||
| 17:42:52 | jaypipes | np :) | |
| 17:43:21 | jaypipes | edleafe, bauzas, cdent, mriedem: reviews appreciated on https://review.openstack.org/#/c/462769/. thanks much in advance! | |
| 17:43:51 | cdent | jaypipes: in the queue | |
| 17:46:10 | cdent | jaypipes: when nirvana happens will the virt driver be authoritative for things in the ProviderTree, or will stuff like PCI devices still sometimes come from places like nova.conf? I ask because I was somewhat surprised to read "passed to the virt driver", instead of "from" | |
| 17:53:52 | jaypipes | cdent: good question. I'm torn. | |
| 17:58:22 | melwitt | first quotas patch is approved \o/ hallelujah | |
| 18:03:30 | mriedem | melwitt: did i persuade jaypipes otherwise? | |
| 18:03:41 | jaypipes | mriedem: yes | |
| 18:04:01 | mriedem | melwitt: i think https://review.openstack.org/#/c/446239/12/nova/quota.py@172 is valid though | |
| 18:04:07 | mriedem | but could be a separate patch | |
| 18:05:18 | mriedem | smcginnis and i have been trying to book flights to china all day, it's not going well | |
| 18:05:31 | mriedem | what was $2100 became $7K within an hour | |
| 18:05:41 | smcginnis | more like minutes. | |
| 18:07:04 | melwitt | mriedem: ah, right. that was a remnant from when I was considering putting the backward compat quota_usage_get_all* calls in _get_usages() or something like that | |
| 18:08:02 | melwitt | quota_usage_get_all* puts 'project_id' and 'user_id' in the dict it returns | |
| 18:08:25 | mriedem | yeah i was looking for that but you must have removed it | |
| 18:08:33 | mriedem | anyway, i'd just cleanup that docstring in a follow up change | |
| 18:09:31 | melwitt | which makes me wonder if I should mirror that to keep the contents similar. I didn't think about it because nothing uses the 'project_id' and 'user_id' keys | |
| 18:12:22 | mriedem | melwitt: if the caller doesn't care i don't see why we would | |
| 18:12:36 | mriedem | melwitt: btw, https://review.openstack.org/#/c/468559/ fixes a regression in cells v2 since newton, would be nice to get that backported | |
| 18:12:48 | mriedem | if we're quick about it i could even hold up the newton/ocata releases i requested last week | |
| 18:13:03 | melwitt | k, looking | |
| 18:13:04 | mriedem | oh nvm those were approved today | |
| 18:13:29 | mriedem | https://review.openstack.org/#/c/468549/ was the regression test patch btw | |
| 18:14:54 | clarkb | mriedem: supposedly they track your browser and such for things like that | |
| 18:15:07 | clarkb | mriedem: so uh maybe try private browsing and use linux | |
| 18:15:22 | clarkb | (supposedly OSes you pay for imply they can charge you higher rates) | |
| 18:18:34 | melwitt | mriedem: nice job on the func test. how did you make the servers go to ERROR state? | |
| 18:19:51 | melwitt | oh, nvm. just saw the comment about no compute service. derp | |
| 18:20:09 | mriedem | clarkb: didn't think about that | |
| 18:24:19 | mriedem | too late now, already booked | |
| 18:24:24 | mriedem | will have to remember that for next time though | |
| 18:29:58 | cr0wrx | anyone here familiar with any way to pull back memory dumps from instances? I don't believe it's currently a feature in nova but wanted to double check (or possibly someone knows of another project that might be aiming to do this) | |
| 19:01:34 | jaypipes | mriedem: question for you... I've now recheck'd this patch (https://review.openstack.org/#/c/462770/) a few times. keep getting failures, but I'm pretty sure the failures are completely unrelated to my patch. would you mind taking a look and verifying that it's not my patch that is causing these failures? :) | |
| 19:01:50 | mriedem | sure | |
| 19:02:50 | mriedem | jaypipes: looks like it is just your patch http://logs.openstack.org/70/462770/7/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/05083f7/logs/devstacklog.txt.gz#_2017-05-30_18_14_47_542 | |
| 19:02:53 | mriedem | devstack setup fails | |
| 19:03:28 | jaypipes | mriedem: it *is* my patch? | |
| 19:03:44 | mriedem | yeah | |
| 19:03:56 | mriedem | https://review.openstack.org/#/c/462770/7/nova/objects/resource_provider.py@31 | |
| 19:04:36 | mriedem | well, | |
| 19:04:41 | jaypipes | :( edleafe, turns out the auto-module-import thing ain't working.. | |
| 19:04:42 | mriedem | it's something in os-traits importing things from django? | |
| 19:04:45 | mriedem | right | |
| 19:04:49 | mriedem | os-traits is fubar'ed | |
| 19:05:10 | edleafe | jaypipes: it's not? Since when? | |
| 19:05:21 | mriedem | edleafe: see the stracktrace in ^ | |
| 19:05:25 | mriedem | *stacktrace | |
| 19:07:08 | sean-k-mooney | mriedem: not directly looking at the os-traits code i dont see any reference to dango | |
| 19:07:10 | openstackgerrit | Merged openstack/nova master: libvirt: mark some Image backend methods as abstract https://review.openstack.org/448142 | |
| 19:07:35 | edleafe | could the __name__ be messed up somehow in the tests? | |
| 19:07:43 | sean-k-mooney | mriedem: its form this import https://github.com/openstack/os-traits/blob/b169eb4a8e13c74673b54512d0577088aa3cc81d/os_traits/__init__.py#L16 | |
| 19:08:12 | mriedem | for loader, name, is_pkg in pkgutil.walk_packages(package.__path__): | |
| 19:08:30 | sean-k-mooney | mriedem: yes on line 52 https://github.com/openstack/os-traits/blob/b169eb4a8e13c74673b54512d0577088aa3cc81d/os_traits/__init__.py#L52 | |
| 19:09:43 | mriedem | sure, i don't know what python black magic it's doing, but it looks like it's walking some packages it shouldn't be | |
| 19:09:53 | mriedem | and it's failing on these changes in nova, logstash confirms that | |
| 19:10:16 | mriedem | https://review.openstack.org/#/c/462770/ i mean | |
| 19:10:44 | sean-k-mooney | mriedem: its trying to import all submodules of os-traits when you import a parent module | |
| 19:11:14 | edleafe | mriedem: yeah, adding them to the proper namespace | |
| 19:12:47 | edleafe | no idea how the django_util tests got into the os-traits module | |
| 19:13:28 | openstackgerrit | Merged openstack/nova master: Add check_deltas() and limit_check_project_and_user() to Quotas https://review.openstack.org/446239 | |
| 19:15:22 | jaypipes | edleafe: would you mind giving that a whirl at fixing? | |
| 19:16:50 | edleafe | jaypipes: sure, but running out in about 15 minutes for a little while | |
| 19:21:14 | jaypipes | edleafe: k, thanks! | |
| 19:30:30 | edleafe | jaypipes: running out now. Haven't found anything yet | |
| 20:00:20 | melwitt | jaypipes: do you know what's the deal with this patch's blueprint? I see that people have reviewed it including you, but the blueprint isn't in Approved state | |
| 20:00:23 | melwitt | https://review.openstack.org/#/c/441183/ | |
| 20:01:49 | jaypipes | melwitt: I'm not sure, no.. | |
| 20:02:19 | melwitt | k | |
| 20:04:45 | openstackgerrit | Merged openstack/nova master: Fix MarkerNotFound when paging and marker was found in cell0 https://review.openstack.org/468559 | |
| 20:06:41 | melwitt | neat, we get merge messages now | |
| 20:08:44 | melwitt | mriedem: have you heard of this blueprint before? https://blueprints.launchpad.net/nova/+spec/opencontrail-dpdk-support there are some reviews on the patch but the bp not approved yet | |
| 20:11:46 | mriedem | melwitt: nope | |
| 20:11:58 | mriedem | i see one patch | |
| 20:12:59 | melwitt | yeah, someone asked about it internally and I see a lot of reviews on the patch, so was surprised to find the bp not approved | |
| 20:14:00 | melwitt | but if no one's heard of it before, it seems like some steps were missed there | |
| 20:15:33 | melwitt | mriedem: just to be complete, is that a thing that needs a bp? adding a new VIF plugin? I assumed so | |
| 20:21:09 | mriedem | melwitt: i think it's a specless blueprint for sure | |
| 20:21:16 | mriedem | it's feature support for a new networking backend | |
| 20:22:01 | mriedem | this is probably chalked up to the contributor not knowing the process | |
| 20:22:15 | mriedem | i.e. bring up the specless blueprint in the weekly meeting to get yay or nay o nit | |
| 20:22:59 | melwitt | yeah, that is my guess as well | |
| 20:32:49 | efried | mriedem If we merge https://review.openstack.org/#/c/443189/ before Thursday, we can add powervm-nova-compute-driver to the Done list for pike ;-) | |
| 20:32:54 | mriedem | melwitt: so on this marker not found bug, i'm working on backporting to newton, but i might not have to - cell0 existed but it doesn't look like we actually populated it in newton | |
| 20:33:35 | mriedem | efried: p-2 is 6/8 | |
| 20:33:39 | mriedem | not this thursday | |
| 20:33:42 | mriedem | and FF is in july sometime | |
| 20:33:51 | efried | mriedem Sure, but numbers. | |
| 20:33:55 | mriedem | so your suggestion is not tempting me atm | |
| 20:34:17 | efried | Sigh. Okay. I'll have to find something more tempting to tempt you with. Beer? | |
| 20:34:34 | melwitt | mriedem: hm, interesting. I can't recall what we were doing before. I guess just legacy behavior, putting the instance in a cell straight away and leaving it there if it failed the schedule, single cell only | |
| 20:36:54 | mriedem | melwitt: yeah i think this is when it started to move things to cell0 https://github.com/openstack/nova/commit/bcbfee183e74f696085fcd5c18aff333fc5f1403 | |
| 20:37:20 | mriedem | which would explain why my functional test is blowing up on newton | |
| 20:39:35 | mriedem | kind of sucks we actually ever look in cell0 when listing instances since we know it's never populating | |
| 20:39:37 | mriedem | *populated | |
| 20:39:54 | melwitt | ah, yeah | |
| 21:04:09 | mriedem | melwitt: why do we still need separate methods for this? https://review.openstack.org/#/c/457857/12/nova/objects/instance_group.py | |
| 21:04:19 | mriedem | was that the staticmethod thing with mock? i thought that was fixed | |
| 21:06:30 | melwitt | mriedem: I can't remember what that was about, but I got errors when I tried to combine the db reader decorator with the remotable one | |
| 21:06:50 | mriedem | ok | |