| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-25 | |||
| 14:16:53 | efried | Like a 412 response, mebbe | |
| 14:17:03 | jaypipes | efried: it does. | |
| 14:17:23 | mriedem | sdague: ok going to also want dansmith to review this | |
| 14:17:29 | sdague | mriedem: sure | |
| 14:17:34 | jaypipes | efried: there is a unique constraint on resource provider name which will throw a 409. | |
| 14:17:52 | efried | jaypipes Ah, good deal. So I don't have to use that semaphore; I can just catch-and-ignore the 409. | |
| 14:17:53 | jaypipes | efried: and then there is a generation field on the resource provider that is used to catch concurrent updates. | |
| 14:18:02 | jaypipes | efried: look for ConcurrentUpdateDetected in the placement code. | |
| 14:18:30 | efried | jaypipes But of course I don't have to read the placement code to find this out, cause it's documented in the placement API ref, right? | |
| 14:18:49 | jaypipes | efried: you mean like this does already? :) https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L388-L400 | |
| 14:18:52 | openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | |
| 14:19:15 | jaypipes | efried: placement api-ref is ongoing. avolkov is working on that. | |
| 14:19:19 | efried | jaypipes Perfect, thanks. Missed that on my first couple read-throughs ;-) | |
| 14:19:30 | jaypipes | avolkov: can you link efried your api-ref patch series so he can review please? | |
| 14:19:43 | efried | (course I didn't know I was looking for 409, so I forgive myself) | |
| 14:19:46 | jaypipes | efried: I live to serve. | |
| 14:19:52 | efried | (though the comment is eminently helpful) | |
| 14:20:37 | dansmith | mriedem: had to rebase again ^ | |
| 14:20:44 | efried | jaypipes I'm still gonna have to come back atcha when it comes to identifying the shared-ness of my resource; but baby steps. | |
| 14:20:51 | avolkov | efried: jaypipes: https://review.openstack.org/#/c/449765/ | |
| 14:21:03 | mriedem | dansmith: i bet you can do some horse trading with sdague on his context patch | |
| 14:21:24 | jaypipes | efried: resources aren't shared :) resource providers are decorated with the MISC_SHARES_VIA_AGGREGATE trait. | |
| 14:21:39 | avolkov | efried: jaypipes: and built version http://docs-draft.openstack.org/96/467596/2/check/gate-placement-api-ref-nv/7cd3495//placement-api-ref/build/html/ | |
| 14:22:00 | jaypipes | efried: https://review.openstack.org/#/q/topic:cd/placement-api-ref+status:open | |
| 14:22:20 | mriedem | dansmith: the rebase is gone | |
| 14:22:22 | mriedem | *wrong | |
| 14:22:40 | jaypipes | efried: you'll notice we use a similar strategy for most resource creation in the placement client: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L784-L789 | |
| 14:22:43 | mriedem | but thanks for the stat padding | |
| 14:22:58 | mriedem | oh wait | |
| 14:23:04 | mriedem | yeah, | |
| 14:23:05 | mriedem | wrong again | |
| 14:23:44 | efried | avolkov jaypipes Thanks y'all. | |
| 14:24:06 | dansmith | mriedem: okay, I'm doing like six things at once, so I'll look again in a sec | |
| 14:25:30 | danpawlik | mriedem: http://imgur.com/g5Mo9KT | |
| 14:26:49 | jaypipes | dansmith: only six? | |
| 14:27:26 | dansmith | jaypipes: I can only count that high | |
| 14:28:03 | danpawlik | mriedem: I don't have ant problems to install new nvidia drivers if vendor is not set | |
| 14:28:24 | danpawlik | mriedem: I try to install the newest drivers | |
| 14:29:25 | dansmith | mriedem: oh, I don't get why git keeps dropping that removal | |
| 14:29:27 | mriedem | danpawlik: ok | |
| 14:29:46 | mriedem | dansmith: you can blame it on the rain, but you can't blame it on git | |
| 14:29:56 | mriedem | sdague: question/comment in https://review.openstack.org/#/c/467995/ | |
| 14:30:04 | openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware https://review.openstack.org/467998 | |
| 14:30:11 | sdague | mriedem: looking | |
| 14:32:03 | dansmith | mriedem: well, it just drops that hunk without calling it a conflict, so I'll blame it anyway | |
| 14:32:28 | openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | |
| 14:32:37 | dansmith | maybe we could merge this and avoid me chasing rebases | |
| 14:32:49 | sdague | mriedem: answered | |
| 14:33:20 | sdague | the constructor for oslo.context in the from_ methods use the original class | |
| 14:33:24 | mriedem | https://s-media-cache-ak0.pinimg.com/236x/75/c1/dc/75c1dcb4c3ab545deeb1f192eef3c0af.jpg?noindex=1 | |
| 14:33:28 | mriedem | just a bunch of hunks | |
| 14:33:39 | sdague | so that's how we still end up with nova context | |
| 14:33:44 | sdague | after the super call | |
| 14:33:50 | sdague | links in review | |
| 14:34:43 | mriedem | # TODO(sdague): also context has show_deleted, we should | |
| 14:34:46 | mriedem | also or oslo? | |
| 14:35:19 | mriedem | dansmith: i've been your huckleberry for weeks on this one | |
| 14:36:18 | sdague | mriedem: heh, yeh | |
| 14:36:22 | sdague | I can fix the typo | |
| 14:37:36 | openstackgerrit | Sean Dague proposed openstack/nova master: Have nova.context use super from_context https://review.openstack.org/467995 | |
| 14:37:40 | mriedem | alex_xu: jaypipes: re-confirming, but when deleting a service we don't actually delete the compute_nodes record, | |
| 14:37:45 | mriedem | nothing actually deletes the compute_nodes record | |
| 14:37:48 | mriedem | https://review.openstack.org/#/c/467220/4//COMMIT_MSG | |
| 14:40:04 | openstackgerrit | Matt Rabe proposed openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774 | |
| 14:41:11 | danpawlik | mriedem: new drivers install correctly. I will add mention about windows and vendor_id | |
| 14:41:23 | danpawlik | in release notes soon | |
| 14:43:25 | edleafe | jaypipes: got a minute (or 10) to talk about https://review.openstack.org/#/c/465171/ ? | |
| 14:43:51 | jaypipes | edleafe: on call for 15, then free. | |
| 14:44:15 | edleafe | jaypipes: okee dokee | |
| 14:46:24 | cdent | edleafe: ping me when you start, I'd like to ride along please | |
| 14:46:41 | edleafe | cdent: roger that | |
| 14:47:32 | sdague | mriedem: the context bits look good to you now? | |
| 14:47:59 | sdague | given that we're blocking a constraint update on that | |
| 14:48:10 | mriedem | sdague: +1 until dansmith can take a look | |
| 14:48:19 | sdague | ok, cool | |
| 14:48:38 | dansmith | mriedem: sdague: I got a call starting in a few and then I'll look | |
| 14:48:45 | sdague | dansmith: sounds good | |
| 14:48:48 | sdague | thank you | |
| 14:49:02 | sdague | mriedem: I have an orthoginal (but related question) | |
| 14:49:27 | sdague | for nova to be a good player in global request id, and accept them, we need https://review.openstack.org/#/c/467998/ | |
| 14:49:33 | alex_xu | mriedem: yea, i think so. and interesting bug, add it into review list | |
| 14:49:39 | sdague | which is going to cause an extra http header to emit | |
| 14:49:50 | sdague | microversion? | |
| 14:49:57 | mriedem | alex_xu: i'm fixing the test in that one | |
| 14:50:10 | sdague | alex_xu might also want to weigh in there | |
| 14:50:46 | mriedem | sdague: i tend to say yes, otherwise how do you know if the cloud has the header or not? | |
| 14:50:48 | mriedem | however, | |
| 14:51:03 | mriedem | do we hook in something that removes the header for requests < new microversion? | |
| 14:51:10 | sdague | nope | |
| 14:51:22 | mriedem | otherwise the new microversion is only signaling | |
| 14:51:27 | sdague | correct | |
| 14:51:42 | sdague | also, it depends on code version on the server and if they follow our upper constraints | |
| 14:52:04 | sdague | it's definitely a little messy, and mostly annoying we didn't do this a long time ago | |
| 14:52:16 | mriedem | sdague: we can't require a new minimum version of oslo.middleware? | |
| 14:52:39 | sdague | maybe, I can look at the force on the requirements side | |
| 14:52:48 | sdague | we could land it with the requirements force | |
| 14:55:16 | mriedem | you want oslo.middleware>=3.27.0 it looks like | |
| 14:55:20 | mriedem | for https://github.com/openstack/oslo.middleware/commit/0e3dbba0d9d373fbfa9e28897cd33377e2491d32 | |
| 14:56:32 | sdague | yep | |
| 14:56:40 | alex_xu | emm...any special reason for not having a microversion? | |