| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-27 | |||
| 15:23:33 | mriedem | mdbooth: god i'd love to remove all of this bdm v1 code | |
| 15:23:56 | mdbooth | mriedem: Hehe | |
| 15:24:03 | zioproto | I try with command line to force /dev/sdb | |
| 15:24:08 | zioproto | but it ignores me | |
| 15:24:16 | mriedem | zioproto: the libvirt driver ignores the device name you pass in | |
| 15:24:22 | mriedem | when attaching a volume, or booting from volume | |
| 15:24:30 | mdbooth | mriedem: How would we deprecate it? | |
| 15:24:42 | lyarwood | with fire? | |
| 15:24:47 | zioproto | but there must be a bug that assigned this /dev/hda name | |
| 15:24:52 | mriedem | mdbooth: i think we'd start by deprecating the legacy bdm v1 fields in the api | |
| 15:24:55 | zioproto | cant be both /dev/sda and /dev/hda | |
| 15:25:17 | mdbooth | lyarwood: Well the mechanism would be to take off and nuke it from orbit, of course. I meant the prior communication. | |
| 15:25:42 | mriedem | mdbooth: but that's like microversion 2.50 at this point, and unless we raise minimum microversions in the api that never goes away, | |
| 15:25:50 | mriedem | and even if we did, it would probably take a long time before we could remove it | |
| 15:26:11 | mriedem | zioproto: so the guest xml says it's /dev/sda? | |
| 15:26:19 | mriedem | but the bdm attachment table shows it as hda? | |
| 15:26:26 | sfinucan | sdague: If I want to capture logging, which fixture do I need to use? | |
| 15:26:47 | mriedem | zioproto: can you tell if they performed a swap volume on the instance? there should be an instance action recorded for it | |
| 15:26:58 | sfinucan | I saw a comment on one of mriedem's patches to not mock oslo.log, but I can't find said patch | |
| 15:27:31 | mdbooth | sfinucan: Interesting. I was about to say I've just mocked the log object before. | |
| 15:27:46 | mriedem | zioproto: actually it looks like we don't record an instance action event for swap volume | |
| 15:27:47 | mriedem | damn | |
| 15:28:04 | zioproto | I know that this volume was imported, not created with openstack | |
| 15:28:12 | mriedem | sfinucan: mdbooth: OutputStreamCapture i htink | |
| 15:28:14 | mriedem | *think | |
| 15:28:20 | mriedem | zioproto: imported? | |
| 15:28:22 | mriedem | via cinder? | |
| 15:28:23 | zioproto | it is some machine converted from vmware or something | |
| 15:28:30 | sfinucan | mriedem: ta | |
| 15:29:02 | mdbooth | mriedem: volume-only image? | |
| 15:29:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove compatibility code for flavors https://review.openstack.org/460377 | |
| 15:30:09 | sdague | sfinucan: actually, I think we buried the hook for that | |
| 15:31:00 | mriedem | sfinucan: i was actually curious too which fixture sdague was talking about | |
| 15:31:04 | mriedem | since we have a few that seem related | |
| 15:31:06 | sdague | nova_fixtures.StandardLogging() would give us a fixture with self.logger that we can pull on | |
| 15:31:16 | sdague | but we didn't assign a reference to get back to it | |
| 15:31:48 | mriedem | so the base test case needs to store self.logger = self.useFixture(nova_fixtures.StandardLogging()).logger? | |
| 15:31:50 | mriedem | right? | |
| 15:32:04 | mriedem | and then i can do self.assertIn('foo', self.logger.info)? | |
| 15:32:23 | johnthetubaguy | mriedem: dansmith: was the ping I missed about the duplicate hostnames thing in os-services? I think I was really asking about FQDN vs hostname. There wouldn't be duplicate FQDNs. | |
| 15:32:33 | mriedem | oh self.logger.output | |
| 15:32:50 | openstackgerrit | Sean Dague proposed openstack/nova master: Expose StandardLogging fixture for use https://review.openstack.org/460642 | |
| 15:32:50 | dansmith | johnthetubaguy: okay, when do we use hostnames that aren't fqdns? | |
| 15:32:57 | dansmith | johnthetubaguy: not for service registration, AFAIK | |
| 15:33:04 | sdague | mriedem: or that ^^^ | |
| 15:33:30 | johnthetubaguy | dansmith: oh, I thought we default to hostname rather than fqdn, that might just be me getting all mixed up | |
| 15:33:41 | sdague | mriedem: I thought it had gotten exposed | |
| 15:33:41 | dansmith | johnthetubaguy: not that I've ver seen | |
| 15:34:01 | sdague | but apparently not, but there is a whole mechanism for it being captured, so we should us that instead of mocks | |
| 15:34:03 | zioproto | mriedem: so it was two disks from vmware. We converted this disks to glance images, and then to cinder volumes. | |
| 15:34:15 | johnthetubaguy | dansmith: ok, thats probably just my confusion then, seems fine to assume no duplicate fqdn's | |
| 15:34:41 | openstackgerrit | Samantha Blanco proposed openstack/nova master: Remove flavor-rxtx policy https://review.openstack.org/444036 | |
| 15:34:57 | dansmith | johnthetubaguy: ack | |
| 15:35:32 | mriedem | zioproto: ok, the device name won't be stored in the cinder volumes anyway, only the mountpoint meta in cinder, but that's set by nova when the volume is attached | |
| 15:36:05 | mriedem | on a complete tangent, it seems like we should be recording instance actions for swap volume, since that's a thing that happens mostly out of band from a nova api pov | |
| 15:36:11 | mriedem | since cinder initiates it via retype | |
| 15:38:15 | mriedem | dansmith: btw, https://review.openstack.org/460377 turned out to be kind of a beast | |
| 15:38:34 | dansmith | sweet | |
| 15:38:39 | johnthetubaguy | dansmith: so we don't really use the fqdn in here: https://github.com/openstack/nova/blob/master/nova/conf/netconf.py#L55 although I could be reading the docs wrongly: https://docs.python.org/2/library/socket.html#socket.gethostname | |
| 15:39:06 | dansmith | johnthetubaguy: but that's for things like telling other computes how to contact us | |
| 15:39:12 | dansmith | johnthetubaguy: not related to service identity, AFAIK | |
| 15:39:28 | johnthetubaguy | dansmith: we use the conf to register the service though, I thought | |
| 15:39:32 | dansmith | oh, host | |
| 15:39:47 | dansmith | sorry, I was reading the lines wrong, and thought you were talking about the storage_ip | |
| 15:39:55 | johnthetubaguy | dansmith: ah, doh | |
| 15:40:13 | dansmith | johnthetubaguy: so, yeah I guess they could configure it to be wrong | |
| 15:40:16 | mdbooth | zioproto: Assuming that the instance in question was created (from Nova's pov) from an image, does if have hw_architecture defined? | |
| 15:40:29 | mdbooth | zioproto: Is it a 32bit arch by any chance? | |
| 15:40:33 | dansmith | johnthetubaguy: but again, if they have dupes, we'll fail consistency checks AFAIK | |
| 15:40:56 | johnthetubaguy | dansmith: well, not in cells v1, its a different DB, I think | |
| 15:41:05 | dansmith | johnthetubaguy: but it's all merged at the top | |
| 15:41:11 | dansmith | johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L81-L84 | |
| 15:41:28 | dansmith | johnthetubaguy: you'll still end up with all the services up there, right? else none of those APIs will work | |
| 15:41:31 | johnthetubaguy | dansmith: good point, it must be like that today | |
| 15:41:43 | zioproto | mdbooth: <type arch='x86_64' machine='pc-i440fx-xenial'>hvm</type> | |
| 15:41:51 | johnthetubaguy | dansmith: seems we are covered either way then, cool | |
| 15:42:04 | mdbooth | zioproto: I mean does the glance image have a hw_architecture image property? | |
| 15:42:18 | dansmith | johnthetubaguy: just like getting rid of these ambiguous id-using apis, if we have people with dupes here, we might as well flush them out :) | |
| 15:42:23 | zioproto | So I tried booting with only 1 volume attached, and the attach the second volume later. But I get libvirtError: Operation not supported: disk bus 'ide' cannot be hotplugged. | |
| 15:42:59 | johnthetubaguy | dansmith: seems a good opportunity, it can only be creating strange subtable bugs in other places | |
| 15:43:08 | dansmith | johnthetubaguy: if even possible, yeah | |
| 15:43:39 | zioproto | mdbooth: no, but now I see it has hw_disk_bus='ide' | |
| 15:43:44 | zioproto | so maybe hda comes from there | |
| 15:43:45 | mdbooth | boom! | |
| 15:44:25 | zioproto | but the volume created from that image does not have this property | |
| 15:44:29 | zioproto | at least I cant find it | |
| 15:44:48 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288 | |
| 15:45:14 | mdbooth | zioproto: It's looking at the glance image | |
| 15:45:36 | zioproto | can I remove the property from the glance image ? | |
| 15:45:47 | mdbooth | Actually, no. It's looking at the glance image metadata, which will have been stored invisibly with the volume. | |
| 15:46:19 | zioproto | mdbooth: in the cinder database ? | |
| 15:46:28 | mdbooth | Yes | |
| 15:46:46 | mdbooth | I don't think anything exposes it, though | |
| 15:46:50 | mdbooth | But I could be wrong | |
| 15:47:50 | mriedem | yeah the glance image meta is stored all over the place... | |
| 15:48:11 | mdbooth | So that's why it's ide | |
| 15:48:17 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove **kwargs passing in payload __init__ https://review.openstack.org/418489 | |
| 15:48:19 | mdbooth | Why does it fail to boot? | |
| 15:48:23 | mriedem | and when you snapshot a server with volumes attached, the bdm meta goes into the image snapshot meta | |
| 15:49:16 | zioproto | cant find this ide metadata doing select * from volume_glance_metadata where volume_id=uuid | |