Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-04-27
00:49:39 mordred cool- looking forward to it
00:51:02 mordred efried: oh great - I missed that you'd pushed that up - I'll read it first thing
00:58:11 mriedem mordred: yeah, except ops are always talking about doing it
00:58:18 mriedem because we don't have LTS or whatever
01:16:55 mriedem dansmith: oh fun, uncovered a bug removing all of this flavor object compat code for the main cell db,
01:17:13 mriedem when sending a flavor delete notification, we lazy-load the projects which results in a FlavorNotFound b/c we just deleted that flavor
01:23:42 mriedem looks like that's due to https://review.openstack.org/#/c/445697/
02:53:33 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Remove compatibility code for flavors https://review.openstack.org/460377
02:55:46 morgan huh I saw my name here
02:55:51 morgan what did I miss?
02:56:00 morgan can't find it in the backlog ATM.
03:48:31 RiteshPaiboina who jaypipes
04:18:02 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050
04:18:03 openstackgerrit falseuser proposed openstack/nova master: [BugFix]Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
05:15:37 openstackgerrit Kiseok Kim proposed openstack/nova master: Fixed a broken link in API Plugins document https://review.openstack.org/460398
05:58:21 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050
06:20:37 openstackgerrit 龚肖 proposed openstack/nova master: Add mock check and fix uuid's use in test. https://review.openstack.org/459501
06:44:45 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050
06:44:46 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
06:58:33 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(2/4) https://review.openstack.org/459569
07:00:27 openstackgerrit 龚肖 proposed openstack/nova master: Add mock check and fix uuid's use in test. https://review.openstack.org/459501
07:04:14 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050
07:13:43 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Release the memory quota for video ram when deleting an instance. https://review.openstack.org/456050
07:40:46 openstackgerrit jichenjc proposed openstack/python-novaclient master: Remove 1.1 extension comment https://review.openstack.org/459503
07:54:32 openstackgerrit jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805
07:54:33 openstackgerrit jichenjc proposed openstack/nova master: use plain routes list for hypervisor endpoint instead of stevedore https://review.openstack.org/459235
07:54:33 openstackgerrit jichenjc proposed openstack/nova master: Use plain routes list for hosts endpoint instead of stevedore https://review.openstack.org/459231
08:00:18 openstackgerrit Mikhail Feoktistov proposed openstack/nova master: Add is_vz_container function https://review.openstack.org/445947
08:08:03 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: Delete existing allocations for move operations or retries https://review.openstack.org/460433
08:08:05 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
08:16:20 openstackgerrit Shunli Zhou proposed openstack/nova master: Periodically load nova.conf https://review.openstack.org/460437
08:55:59 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor https://review.openstack.org/460455
09:22:10 openstackgerrit Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124
09:26:42 openstackgerrit Abhishek Sharma M proposed openstack/nova master: Catching OverQuota Exception https://review.openstack.org/460305
09:42:48 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
09:42:49 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
09:47:47 openstackgerrit NidhiMittalHada proposed openstack/python-novaclient master: Nova volume-attach doesn't care for device name https://review.openstack.org/454048
09:50:36 openstackgerrit John Garbutt proposed openstack/nova master: Add description to policies in migrations.py https://review.openstack.org/459727
09:51:43 openstackgerrit Matthew Booth proposed openstack/nova master: Add context comments to _handle_base_image https://review.openstack.org/334956
09:51:43 openstackgerrit Matthew Booth proposed openstack/nova master: Don't check for file type in _find_base_file https://review.openstack.org/334958
09:51:44 openstackgerrit Matthew Booth proposed openstack/nova master: Rename _handle_base_image to _mark_in_use https://review.openstack.org/334957
10:03:29 johnthetubaguy sfinucan: did you look to see if someone has got the change to bump the oslo.policy minimum up yet?
10:09:52 openstackgerrit John Garbutt proposed openstack/nova master: Sensibly wrap policy help messages https://review.openstack.org/460097
10:27:11 cdent johnthetubaguy, alex_xu: if you have spare brain this improvement to placement and resource tracker wants eyes: https://review.openstack.org/#/c/448791/ (and above)
10:27:40 johnthetubaguy I have my head in policy right now, but I should do something different soon
10:28:10 cdent if you've been in policy I would be very surprised if you have spare brain
10:31:42 openstackgerrit John Garbutt proposed openstack/nova master: Ensure sample policy help text correctly wrapped https://review.openstack.org/460097
10:33:12 openstackgerrit John Garbutt proposed openstack/nova master: Ensure sample policy help text correctly wrapped https://review.openstack.org/460097
10:38:11 sfinucan johnthetubaguy: I did not, but I figure we can
10:38:38 johnthetubaguy sfinucan: I tried a few things out, and pushed a new version of your patch
10:38:51 sfinucan johnthetubaguy: Yup. +1d it. Works fine for me locally now
10:38:53 sfinucan Thanks :)
10:38:56 johnthetubaguy https://review.openstack.org/460097 that is
10:39:47 johnthetubaguy sfinucan: cool, yeah, did a rebase to drop all that observable messy, whoop
10:40:13 sfinucan johnthetubaguy: admin_or_owner, admin_api, and network:attach_external_network are the only ones left. Two of those are being deprecated, right?
10:40:41 johnthetubaguy sfinucan: there are loads left still, full list is in the BP: https://blueprints.launchpad.net/nova/+spec/policy-docs
10:40:45 sfinucan Oh, there's a couple more, actually, but I've seen patches around a few
10:40:48 sfinucan Yup - my bad
10:41:31 johnthetubaguy sfinucan: I don't believe any are deprecated as such, the API may be deprecated, but the policy doesn't die till we remove the API (after a theoretical version bump, etc)
10:42:27 sfinucan johnthetubaguy: Sound fair. What was your call on the patches that split some policies, btw? 'os_compute_api:os-flavor-rxtx' was one, iirc
10:42:37 sfinucan Can we do that (split a policy into multiple policies)
10:43:47 johnthetubaguy sfinucan: I think I added comments on most of that patches now, most of they don't look like they need splitting, the problem is the rules they remove with no deprecation cycle or warning
10:45:02 johnthetubaguy sfinucan: I basically asked them to talk to the nova-api subteam somehow, to describe what their intent is, I suspect I just don't understand it as its not described in their bug
10:45:26 sfinucan Yeah, I was more focussed on the latter. So basically we need to follow the same migration policy as config opts, right?
10:45:34 sfinucan i.e. deprecate one cycle, remove the next
10:45:58 johnthetubaguy sfinucan: Ideally, its just a config file, so the same rules apply, but the bad bit is we have non of the infrastructure, well almost non
10:46:14 johnthetubaguy s/non/none/
10:46:33 sfinucan Looks like oslo.policy rules need 'deprecated_X' options so
10:47:30 johnthetubaguy sfinucan: yeah, something like that, its just not been done yet, its a bit tricky
10:48:10 johnthetubaguy you can use rule alias and a manual log message though, to get 90% there
10:49:03 johnthetubaguy but a whole load of the slits were not protecting APIs, there were only protecting API extensions, so its a bit odd
10:58:39 mdbooth sfinucan: Keen eyes :) Thanks for restoring that +2
10:59:43 sfinucan *re-reviewed, even
11:21:46 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Attach and detach encryptors during swap_volume https://review.openstack.org/460244
11:24:21 alex_xu cdent: already added that to my review list
11:24:36 cdent alex_xu: thanks!
11:25:02 alex_xu np!
11:28:05 openstackgerrit John Garbutt proposed openstack/nova master: Update description to policies in remaining flavor APIs https://review.openstack.org/460509
11:31:18 openstackgerrit John Garbutt proposed openstack/nova master: Update description to policies in remaining flavor APIs https://review.openstack.org/460509
11:40:30 openstackgerrit Sergey Nikitin proposed openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480
11:40:31 openstackgerrit Sergey Nikitin proposed openstack/nova master: Added nova objects for intance diagnostics https://review.openstack.org/434745
11:40:33 openstackgerrit Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540
11:40:36 openstackgerrit Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613
11:44:06 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515
12:15:10 openstackgerrit Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124
12:29:18 openstackgerrit Shunli Zhou proposed openstack/nova master: Periodically load nova.conf https://review.openstack.org/460437
12:37:50 mdbooth jaypipes: Could I convince you to turn a -1 into a +2? https://review.openstack.org/#/c/334956/
12:39:27 jaypipes mdbooth: looking now.
12:47:32 edleafe /win 13
12:47:36 edleafe doh!
12:50:42 jaypipes mdbooth: if you're so confident about all of the always-True or always-False conditionals, why not just remove all the code that can never be reached, and flatten down all the conditionals?
12:50:55 mdbooth jaypipes: That's the next patch
12:51:00 jaypipes oh, duh :)
12:51:09 mdbooth I could squash them, but it seemed a bit hard to follow
12:52:19 mdbooth jaypipes: https://review.openstack.org/#/c/334957/
12:52:32 jaypipes mdbooth: already on it. :)
12:52:36 mdbooth Thanks
12:58:22 jaypipes mdbooth: whole series +Wallaby'd.
13:02:57 mdbooth jaypipes: Sweet, thanks
13:03:07 jaypipes mdbooth: for you? any time :)

Earlier   Later