| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-10 | |||
| 19:23:32 | leakypipes | cdent: yes. | |
| 19:26:12 | cdent | imma need to try this stuff myself leakypipes | |
| 19:26:31 | leakypipes | cdent: np | |
| 19:36:44 | leakypipes | JayF: thx for the reviews on the ironic patch. responded to your query on the latest revision. | |
| 19:37:24 | JayF | leakypipes: it's fine, "valid -1 on a jaypipes nova patch" will make a fine line on my resume ;) | |
| 19:37:34 | leakypipes | JayF: lmao | |
| 19:39:27 | JayF | leakypipes: re: your comment, that's exactly what I suspected, but wanted to be sure. Also get_inventory() will only ever be called on nodes that pass get_available_resources() which guarantees all our logic guarding nodes in maintenance/wrong states/etc will be intact | |
| 19:39:55 | leakypipes | JayF: correct. node_is_available() gates any call to get_inventory() | |
| 19:44:12 | cdent | leakypipes: does it fail consistently? does it only fail when you run all the tests? | |
| 19:44:36 | leakypipes | cdent: fails consistently when I run all unit tests. lemme try running it singularly. | |
| 19:44:38 | cdent | in other words, works for me when I test just that file and also a) make sure I don't have an /etc/nova/nova.conf and -r my tox | |
| 19:45:26 | cdent | I resisted this fixture. I figured we should just keep on doing the wsgi-intercept thing everywhere. | |
| 19:50:08 | leakypipes | cdent: yeah, fails when I just run tox -epy27 -- test_fixtures | |
| 19:50:23 | cdent | interesting, wfm | |
| 19:50:29 | cdent | i'm running all of them now | |
| 19:51:00 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | |
| 19:51:00 | openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | |
| 19:51:01 | openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | |
| 19:51:01 | openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | |
| 19:51:02 | openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | |
| 19:51:02 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | |
| 19:51:03 | openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | |
| 20:01:50 | cdent | GET /resource_providers?resources=VCPU:24 | |
| 20:07:55 | cdent | leakypipes: works when running all too | |
| 20:08:17 | cdent | do you have any evidence from the fixture of the internal failure (the exception within the 500) | |
| 20:19:42 | leakypipes | cdent: none :( | |
| 20:20:03 | cdent | you done a fresh tox? | |
| 20:21:09 | cdent | :( I dunno. | |
| 20:31:17 | cdent | leakypipes: I gotta go, if/when you figure it out I'm curious to know. I think it's just you though: unit tests passed in the gate for that commit | |
| 20:31:31 | leakypipes | yeah... | |
| 20:31:39 | leakypipes | cdent: I'll let ya know what I discover. | |
| 20:34:06 | tonyb | sfinucan: np | |
| 20:37:06 | openstackgerrit | Rafael Folco proposed openstack/nova master: Raising http codes on old microversion https://review.openstack.org/444497 | |
| 20:37:06 | openstackgerrit | Rafael Folco proposed openstack/nova master: DELETE all inventory for a resource provider https://review.openstack.org/416669 | |
| 20:51:32 | openstackgerrit | John Griffith proposed openstack/nova master: Add Cinder API version detection https://review.openstack.org/444465 | |
| 21:19:59 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 21:20:40 | efried | thorst_afk ^^ addressed comments. Hoping for that +1 before you disappear into babyland. | |
| 21:20:50 | thorst_afk | efried: k | |
| 21:33:35 | efried | harlowja Another TaskFlow-havin' change set, if you're interested ^^ | |
| 21:33:41 | harlowja | cools | |
| 21:34:01 | efried | harlowja Be sure to read thorst's commentary ;-) | |
| 21:34:47 | harlowja | kk | |
| 21:35:43 | harlowja | woah, lots of commentary | |
| 21:35:44 | harlowja | lol | |
| 21:36:16 | harlowja | hopefully taskflow has helped some :-P | |
| 21:36:33 | efried | harlowja As you can see, we definitely dig it. | |
| 21:36:49 | harlowja | ya, i mean i don't like having all the LinearFlow and such objects | |
| 21:37:02 | harlowja | i was going to try to make it more natural, but haven't quite figured that out | |
| 21:37:02 | harlowja | ha | |
| 21:37:32 | harlowja | it'd be interesting to do something like | |
| 21:37:48 | efried | harlowja I was telling thorst yesterday - I've had a TODO for a long time to rework our TaskFlow usage into a much more complicated unordered parallel flow with appropriate interdependencies. | |
| 21:37:59 | efried | He basically said, "You had my veto at 'complicated'" | |
| 21:38:13 | harlowja | lol | |
| 21:38:51 | harlowja | ya, if i could i'd somehow plug what taskflow in at more of the language level | |
| 21:39:11 | efried | harlowja FYI, this is the flow I was talking about: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L384 | |
| 21:39:41 | harlowja | so that somehow u could give say a set of interconnected functions to some kind of object and it would try to extrapolate the flow(s) | |
| 21:40:16 | efried | harlowja You basically have that, with provides/requires. And I'm sure it works perfectly with no bugs. | |
| 21:40:17 | harlowja | ya, it'd be interesting to try to make such kind of functions more elegant | |
| 21:40:25 | harlowja | well i was thinking of something like | |
| 21:40:48 | efried | But I've fiddled with it a little bit and remember finding it a bit complicated to figure out how to set up the right engine/flow so it would actually be useful and run stuff in parallel. | |
| 21:41:26 | harlowja | b() | |
| 21:41:26 | harlowja | `def a(): | |
| 21:41:27 | harlowja | now given a, is there a way to 'decompile' that into a corresponding set of linear flows (for example) | |
| 21:41:27 | harlowja | c()` | |
| 21:41:27 | harlowja | def b(): | |
| 21:41:47 | efried | harlowja You're talking about static analysis of the code, though? | |
| 21:41:51 | harlowja | sort of | |
| 21:42:12 | efried | My knee-jerk is that you'd be passing the 80/20 point there ;-) | |
| 21:42:18 | harlowja | fair enough | |
| 21:42:19 | harlowja | ha | |
| 21:43:14 | harlowja | afaik the parallelism, basiclaly if u have things that can run in parallel (determined by ordering relationships); then changing the engine will run them in parallel (if there is no paralleism possible, then changing the engine won't do much) | |
| 21:44:43 | efried | harlowja Well, we did do some of that, down in pypowervm. You may actually get a kick out of this: https://github.com/powervm/pypowervm/blob/develop/pypowervm/utils/transaction.py#L498 | |
| 21:45:04 | efried | (thorst_afk we were just talkin about ya) | |
| 21:45:15 | harlowja | interesting | |
| 21:45:52 | harlowja | anything in taskflow that may make such stuff easier/more pretty/other? | |
| 21:47:08 | harlowja | seems like that FeedTask could just be a nestedflow? | |
| 21:47:17 | efried | harlowja To be honest, given what it does, I don't see a whole lot of improvement. | |
| 21:47:20 | harlowja | k | |
| 21:47:34 | efried | What's a nestedflow? | |
| 21:47:50 | harlowja | root_flow = flow("root") | |
| 21:47:56 | harlowja | root_flow.add(task1, task2...) | |
| 21:48:03 | harlowja | root_flow.add(nested_flow) | |
| 21:48:09 | harlowja | where nested_flow is yet another flow | |
| 21:48:49 | efried | harlowja Yeah, that's how we use it. | |
| 21:48:54 | harlowja | oh, k | |
| 21:49:02 | efried | https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L454 | |
| 21:49:17 | efried | The aforementioned | |
| 21:50:26 | harlowja | kk | |
| 21:53:51 | figleaf | leakypipes: just catching up on scrollback. I ran tests on that patch and didn't get any errors | |
| 21:54:04 | leakypipes | figleaf: yeah, it's weird.. :) | |
| 21:54:53 | figleaf | leakypipes: well, Gerrit like is, so... :) | |
| 21:55:05 | figleaf | s/like is/likes it | |
| 21:55:13 | leakypipes | yeah, I saw that :) | |
| 21:56:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | |
| 22:06:53 | cfriesen | has anyone run into an issue with libvirt (version 1.2.12) reporting "operation failed: domain is no longer running" if you pause the instance while the migration is running (to force completion)? It seems to be fixed in libvirt 1.2.17. I'm looking at the libvirt code, but I figured I'd ask... | |
| 22:17:37 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Allow live migrate paused instance when post copy is enabled https://review.openstack.org/444517 | |
| 22:29:00 | melwitt | dansmith: your thoughts would be appreciated on the consoleauth token upcall patch https://review.openstack.org/#/c/415922/ I was wondering whether it makes sense to also reject requests for connect_info too since it seemed possible it wouldn't be usable | |
| 22:29:28 | melwitt | or if I'm not understanding that right | |
| 22:39:35 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Move __init__.py https://review.openstack.org/444522 | |
| 22:39:35 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Combine the two auth.py files https://review.openstack.org/444521 | |