Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-25
12:48:21 openstackgerrit Sean Dague proposed openstack/nova master: Generate log error message if keystone looks funny https://review.openstack.org/438049
12:58:30 openstackgerrit Sean Dague proposed openstack/nova master: api/metadata/vendordata_dynamic: don't import Requests for its constants https://review.openstack.org/434339
15:40:30 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add additional-default-policy-roles spec https://review.openstack.org/427872
18:04:56 mriedem miss_hypothermia: i saw your remove check_attach patch failed some bfv tests in the grenade job, looks like some bdm is invalid error
18:09:52 miss_hypothermia mriedem: I saw that too
18:10:16 miss_hypothermia mriedem: I couldn't figure it out yet what exactly the problem is
18:10:47 miss_hypothermia mriedem: does that test run in other jobs as well BTW?
18:10:55 mriedem miss_hypothermia: i know what it is
18:11:03 mriedem http://logs.openstack.org/58/335358/41/check/gate-grenade-dsvm-neutron-multinode-ubuntu-xenial/d3194cc/logs/subnode-2/old/screen-n-cpu.txt.gz?level=TRACE#_2017-02-24_23_47_29_665
18:11:13 mriedem the pike api is reserving the bfv volume and putting it into 'attaching' status
18:11:21 mriedem the instance is running on the ocata n-cpu node
18:11:34 mriedem where check_attach is still a thing down in nova/virt/block_device.py
18:11:47 mriedem and check_attach fails because the volume is in 'attaching' status from the reserve call in the pike api
18:11:52 mriedem and then, kablammo!
18:12:01 mriedem so you're going to have to add that service version thing back in
18:12:50 miss_hypothermia Ohhh ok, forgot about the mixed env from this perspective
18:13:22 mriedem yeah
18:13:23 mriedem me too
18:13:33 mriedem i'm happy the test caught this though
18:14:00 miss_hypothermia But we're still fine from unreserve perspective so I will add that part back and we should be good to go
18:14:17 mriedem agree
18:14:19 miss_hypothermia mriedem: +1, me too!
18:14:36 mriedem btw, you're still hypothermic?
18:14:45 mriedem it's 13F where i'm going
18:16:22 miss_hypothermia Still sitting in an air conditioned place, but 13F sounds waaaay worse for sure! :/ :S
21:02:27 openstackgerrit Sean Dague proposed openstack/nova master: Generate log error message if keystone looks funny https://review.openstack.org/438049
21:06:26 imad_ Hi all, I am getting the following error in libvirt "unable to execute QEMU command 'query-cpu-definitions': The command query-cpu-definitions has not been found"
21:06:38 imad_ Does anyone have any idea?
21:34:30 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach/detach Cinder flow https://review.openstack.org/330285
21:34:31 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_attach https://review.openstack.org/335358
21:37:59 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach/detach Cinder flow https://review.openstack.org/330285
21:38:00 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_attach https://review.openstack.org/335358
21:40:24 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach/detach Cinder flow https://review.openstack.org/330285
21:40:25 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_attach https://review.openstack.org/335358
23:06:00 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach/detach Cinder flow https://review.openstack.org/330285
23:06:01 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_attach https://review.openstack.org/335358
#openstack-nova - 2017-02-26
00:00:31 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_attach https://review.openstack.org/335358
00:00:31 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach/detach Cinder flow https://review.openstack.org/330285
04:52:24 openstackgerrit yuhui proposed openstack/nova master: Add Apache License Content in index.rst https://review.openstack.org/436397
04:56:41 openstackgerrit yuhui proposed openstack/nova master: Add Apache License Content in index.rst https://review.openstack.org/436397
06:10:51 openstackgerrit Danfeng proposed openstack/nova master: Fix typos detected by toolkit misspellings. https://review.openstack.org/438232
12:14:23 openstackgerrit Sean Dague proposed openstack/nova master: api/metadata/vendordata_dynamic: don't import Requests for its constants https://review.openstack.org/434339
15:36:01 miss_hypothermia mriedem: I fixed the issues and added a small test too for the service version check
15:36:33 miss_hypothermia mriedem: smcginnis had a question about when to clean up the code, I hope that's the last issue we need to figure out there and otherwise the fix is good to go :)
15:39:46 mriedem ok i'll take a look
15:43:46 mriedem miss_hypothermia: you're right, it's pike-eol
15:44:53 miss_hypothermia mriedem: ok, cool, tnx
15:56:57 openstackgerrit Kevin Benton proposed openstack/os-vif master: [wip] https://review.openstack.org/438272
16:13:12 mriedem miss_hypothermia: found some test issues
16:15:50 miss_hypothermia mriedem: I'll check the patch if you added comments about it there
16:16:27 mriedem yup still going
16:20:49 miss_hypothermia mriedem: did you find anything that's complicated enough to talk about it here?
16:21:08 mriedem it's not really complicated, just an oversight, but actually something i brought up long long ago i think
16:21:20 mriedem cinder.API.check_attach would raise InvalidVolume,
16:21:41 mriedem we're now calling cinder.API.reserve_volume, which raises InvalidInput if cinder gives a 400
16:22:03 mriedem the tests were mocked to raise InvalidVolume from reserve_volume, but that's not actually what would happen in reality
16:22:23 mriedem so _validate_bdm needs to handle both InvalidVolume and InvalidInput
16:23:38 miss_hypothermia mriedem: oh, ok, so one extra error handling and fix mock in the test
16:23:55 miss_hypothermia mriedem: I will fix it in the afternoon, when I get to the airport
16:24:13 miss_hypothermia thanks for pointing it out
16:25:58 smcginnis mriedem, miss_hypothermia: Commented on there, but if we only care about Ocata talking to newer versions, I'm having a brain block as to why we need to wait for pike-eol.
16:27:15 mriedem smcginnis: you know master is pike now right?
16:27:23 smcginnis mriedem: Yes.
16:27:25 mriedem smcginnis: this is a change to the nova api in pike
16:27:37 mriedem so ocata computes won't have the change introduced here
16:27:45 smcginnis mriedem: And we need to support pre-pike that does not have this change.
16:27:46 mriedem but pike computes will
16:28:03 smcginnis mriedem: So once pre-pike is gone, it's all on the new api.
16:28:24 mriedem which would be ocata-eol, i get what you're saying now
16:28:39 smcginnis mriedem: OK, so I'm not completely insane?
16:28:44 mriedem no
16:28:47 mriedem just partialy
16:28:50 mriedem *partially
16:28:53 smcginnis I can live with that.
16:29:40 mriedem i acked in the review
16:29:43 mriedem miss_hypothermia: comments are in
16:32:49 mriedem i'm going to go numb my brain in front of the tv for awhile now
16:33:48 smcginnis I'm going to go numb my brain and work on my taxes.
17:02:37 miss_hypothermia mriedem: smcginnis: Tnx
17:03:20 miss_hypothermia mriedem: smcginnis: I'll numb my brain at airports and airplanes :)
17:17:22 smcginnis miss_hypothermia: Safe travels!
17:28:00 miss_hypothermia smcginnis: thanks!
18:45:11 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach/detach Cinder flow https://review.openstack.org/330285
18:45:12 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_attach https://review.openstack.org/335358
23:31:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle conflicts for os-assisted-volume-snapshots https://review.openstack.org/429476
23:31:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle VolumeBDMIsMultiAttach in os-assisted-volume-snapshots https://review.openstack.org/429413
#openstack-nova - 2017-02-27
01:15:54 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/438309
01:40:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove check_attach https://review.openstack.org/335358
01:40:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement new attach/detach Cinder flow https://review.openstack.org/330285
01:41:34 mriedem johnthetubaguy: i'm +2 on https://review.openstack.org/#/c/335358/ remove check_attach now
01:41:35 mriedem let's do it
02:26:03 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova master: Remove usage of config option verbose https://review.openstack.org/432271
02:35:16 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436
03:19:11 openstackgerrit Jianghua Wang proposed openstack/nova master: XenAPI: device tagging https://review.openstack.org/333781
03:41:31 openstackgerrit Nguyen Hung Phuong proposed openstack/nova master: Remove mox from nova/tests/unit/test_configdrive2.py https://review.openstack.org/322754
05:18:47 openstackgerrit foundjem proposed openstack/nova master: adding more stuffs in the first-file https://review.openstack.org/438331
08:40:47 openstackgerrit Kevin Benton proposed openstack/os-vif master: [wip] https://review.openstack.org/438272
10:26:30 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova master: [WIP] Remove mox from unit/api/openstack/compute/admin_only_action_common.py https://review.openstack.org/438416
10:26:30 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova master: Remove mox from nova/tests/unit/api/openstack/compute/test_create_backup.py https://review.openstack.org/435610
10:54:30 ildikov johnthetubaguy: o/

Earlier   Later