| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-16 | |||
| 07:07:26 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 07:07:27 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | |
| 08:39:14 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480 | |
| 08:39:16 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 08:39:17 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Added nova objects for intance diagnostics https://review.openstack.org/434745 | |
| 08:39:17 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | |
| 08:52:32 | openstackgerrit | Anh Tran proposed openstack/nova master: Remove mox stubs in api/openstack/compute/test_server_reset_state.py https://review.openstack.org/320826 | |
| 08:55:43 | openstackgerrit | Huan Xie proposed openstack/nova master: Fix live migrate with XenServer https://review.openstack.org/424428 | |
| 09:06:51 | openstackgerrit | Jens Rosenboom proposed openstack/nova master: Fix novncproxy for python3 https://review.openstack.org/434666 | |
| 09:30:40 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480 | |
| 09:30:42 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 09:30:44 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | |
| 09:55:59 | openstackgerrit | jichenjc proposed openstack/python-novaclient master: Avoid limit=-1 description https://review.openstack.org/434781 | |
| 09:56:55 | openstackgerrit | jichenjc proposed openstack/python-novaclient master: Avoid limit=-1 description https://review.openstack.org/434781 | |
| 09:57:35 | BobBall | mriedem_afk: We've update the patch and provided some comments to your questions. The Bridge driver is nova-net only and can be deprecated. Our Neutron integration only supports the OVS driver. | |
| 11:03:35 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add polcy-docs spec https://review.openstack.org/433010 | |
| 11:15:32 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 11:34:58 | openstackgerrit | John Garbutt proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | |
| 11:35:06 | openstackgerrit | John Garbutt proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | |
| 11:35:51 | openstackgerrit | Roman Podoliaka proposed openstack/nova master: db: remove unused EngineFacadeFixture https://review.openstack.org/434843 | |
| 12:15:25 | betherly | hi all! having devstack issues with the nova-api not starting. does anyone know why or how i can fix this? | |
| 12:19:31 | sdague | betherly: devstack questions probably better for #openstack-qa, we can do the debug over there if you like | |
| 12:20:06 | betherly | sdague: many thanks! ill ask again in that channel! | |
| 12:26:54 | openstackgerrit | John Garbutt proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | |
| 12:57:57 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 13:02:40 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 13:30:50 | mriedem | BobBall: ok, but the xen vif bridge driver could be used during a live migration with nova-net in ocata right and then that would need to work (not get that KeyError). granted that's only nova-net with cells v1 in ocata. | |
| 13:32:31 | mriedem | BobBall: also, if the vif driver is deprecated we should change the default for the vif_driver config option since that's the default right now - but let's do that for pike | |
| 13:33:44 | mriedem | BobBall: also the xenserver ci is failing on https://review.openstack.org/#/c/424428/ | |
| 13:33:48 | BobBall | mriedem: Theoretically, sure... but tbh I would be quite surprised if live migration was the only thing broken when using xenapi with nova-net and cells v1 - it's a specialised use case of a specialised use case. If we can get the current change merged then at least we could backport a fix if customers do identify this as an issue. | |
| 13:34:24 | mriedem | sure, but a simple in check to avoid the KeyError is pretty simple right? | |
| 13:35:02 | BobBall | Indeed. Avoiding the KeyError is trivial - I just can't promise it will work | |
| 13:35:57 | BobBall | CI was broken by an update to Cirros version today... but I thought it was resolved now. | |
| 13:42:46 | mriedem | Details: {u'message': u"Cannot 'createImage' instance e0197e39-f124-4f50-980a-d60c0cfef623 while it is in task_state image_uploading", u'code': 409} | |
| 13:42:49 | mriedem | yeah looks unrelated | |
| 13:45:27 | mriedem | as you say maybe we just handle the KeyError in a follow up patch and backport it, let me see the diff from my review | |
| 13:47:04 | BobBall | I've just fixed the key error (inline) can can push a patch - just running pep8 to make sure I haven't done something stupid | |
| 13:47:41 | BobBall | As we don't have a +2 from John and the CI will need a recheck anyway I'm quite happy to push this and replace the existing change? | |
| 13:48:14 | BobBall | Sorry for not spotting the CI had returned -1: The change is owned by a team member from PRC and I'm not getting CI vote reports | |
| 13:48:24 | BobBall | Happy to go with whatever route you recommend on this one ofc | |
| 13:52:17 | mriedem | BobBall: +2 on it now | |
| 13:52:26 | mriedem | i left comments but those can be dealt with in a follow up | |
| 13:52:32 | BobBall | I'll put the KeyError fix in a follow up. | |
| 13:52:33 | mriedem | johnthetubaguy: are you still happy with https://review.openstack.org/#/c/424428/ ? | |
| 13:53:03 | mriedem | BobBall: i'm good if you want to push that change up now too | |
| 13:54:33 | BobBall | mriedem: Do you want me to change the default driver as well in this follow on change? (i.e. is the follow-on destined for Pike, or do you want to try and approve for Ocata?) | |
| 13:54:57 | mriedem | BobBall: the default vif_driver change won't be backported | |
| 13:55:11 | mriedem | the keyerror thing could be for ocata, so i'd leave those separate | |
| 13:55:21 | BobBall | Will do. | |
| 13:56:45 | mriedem | bauzas: lyarwood: i'm going to request a newton release, it contains an online data migration (not a schema migration) to fix a bug when upgrading from mitaka. i was just going to version this as 14.0.4 but wanted to ask first since last time we had a db migration there was a frackus at red hat about it not being a minor version update | |
| 13:56:58 | mriedem | *fracas | |
| 13:57:24 | johnthetubaguy | mriedem: I duno, I dug into that whole 'nicira-iface-id' a few times, annoyed I didn't see the whole bridge thing, that makes more sense though, make the doubt whether I am happy with it | |
| 13:57:52 | mriedem | johnthetubaguy: sounds like BobBall has a fix locally for the keyerror thing which could go into that patch now if we want | |
| 13:57:56 | BobBall | BTW - we can't continue the loop if the network doesn't have a mapping - this must be fatal; we can return the exception No mapping from source network though | |
| 13:57:59 | mriedem | doesn't matter to me, might as well if it's ready | |
| 13:58:14 | johnthetubaguy | mriedem: yeah, duno, just a .get() would fix it | |
| 13:58:26 | mriedem | johnthetubaguy: that's true, it would result in the exception | |
| 13:58:35 | BobBall | I've added a .get() and then an "if neutron_id is None or neutron_id not in ..." as my fix, and a UT to make sure it raises. | |
| 13:58:47 | bauzas | p!spy | |
| 13:58:49 | johnthetubaguy | yeah | |
| 13:59:01 | mriedem | BobBall: the existing "if neutron_id not in vif_uuid_map.keys():" will handle the None case | |
| 13:59:19 | johnthetubaguy | +1 mriedem | |
| 13:59:21 | mriedem | i think the get() is all we need | |
| 13:59:33 | lyarwood | mriedem: hey sorry, yeah I think that was more because someone missed that the migration had already landed before we GA'd | |
| 13:59:42 | BobBall | Well a dictionary *could* have None in the keys... but I agree that's very unlikely. | |
| 13:59:58 | BobBall | and would be indicative of a totally different bug. | |
| 14:00:17 | mriedem | i don't think it would happen in this case because of https://review.openstack.org/#/c/424428/11/nova/virt/xenapi/vmops.py@2390 | |
| 14:00:19 | BobBall | I just like to be more verbose and be sure that we know that None is an error rather than two errors potentially resulting in a weird pass | |
| 14:00:50 | mriedem | i'm fine if you want to be cautious | |
| 14:01:16 | BobBall | So shall I post a follow-up or a replacement? | |
| 14:01:46 | lyarwood | mriedem: https://review.openstack.org/#/c/408725/ right? | |
| 14:02:17 | mriedem | lyarwood: yeah | |
| 14:02:25 | mriedem | BobBall: might as well do a replacement | |
| 14:02:32 | mriedem | new patch set on the existing change | |
| 14:02:42 | mriedem | i'll be around to shephard it into ocata | |
| 14:03:34 | bauzas | mriedem: well, not sure if it would be a .z version | |
| 14:04:04 | mriedem | it's not a new feature | |
| 14:04:04 | BobBall | Will do. Just running another couple of tests to make sure I didn't do something really stupid. | |
| 14:04:09 | bauzas | mriedem: in case we need more than just upgrading the packages | |
| 14:04:18 | bauzas | mriedem: yeah, I know | |
| 14:04:30 | mriedem | bauzas: it's basically there to catch any upgrade issues from mitaka to newton | |
| 14:04:33 | bauzas | mriedem: but I wonder how we could signal that just upgrading is not enough | |
| 14:04:36 | mriedem | not from upgrading from 14.0.3 to 14.0.4 | |
| 14:04:48 | mriedem | because if you hit this bug on upgrade to newton you're already broken | |
| 14:04:50 | lyarwood | bauzas: we can document this in our own releasenotes tbh | |
| 14:04:57 | bauzas | mmmm | |
| 14:05:07 | mriedem | bauzas: upgrading is enough, this is the 13.0.0->14.0.4 case | |
| 14:05:12 | mriedem | not 14.0.3->14.0.4 | |
| 14:05:16 | bauzas | I see | |
| 14:05:19 | lyarwood | yeah I'm fine with this being in a 14.0.4 release tbh | |
| 14:05:19 | bauzas | well | |
| 14:05:27 | bauzas | mriedem: then okay | |
| 14:05:29 | openstackgerrit | Thomas Bechtold proposed openstack/nova master: Log exception when hypervisor version check fails https://review.openstack.org/434927 | |
| 14:05:59 | bauzas | mriedem: if people just do 14.0.3 to .4, they don't need to call the online data migration, yup ? If so, +1 with me | |
| 14:06:24 | bauzas | sorry, I misunderstood the impact then | |
| 14:08:26 | mriedem | that's fine, this was a confusing one | |
| 14:13:00 | mriedem | BobBall: johnthetubaguy: i'm going to be away for awhile, would be good if john can be happy with the change once it's posted, then i'll handle the +W and backport stuff when i'm in the office later | |
| 14:13:32 | BobBall | Thanks mriedem. Should be posted in ~15 minutes I guess (just waiting for stack.sh to complete then I can test) | |
| 14:21:25 | nicodemus_ | hello | |
| 14:21:36 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | |