| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-10 | |||
| 14:08:30 | kashyap | I can't find the approved Mitaka Gerrit review for historical discussion | |
| 14:08:36 | mriedem | diana_clarke: i think you would need to replace OS_TENANT_ID with OS_PROJECT_ID in your openrc file | |
| 14:08:53 | mriedem | diana_clarke: if you're using the openrc from devstack, it might just be something we need to fix in devstack | |
| 14:09:17 | diana_clarke | mriedem: exactly, I'm using the openrc from devstack, so perhaps it needs to be fixed. | |
| 14:09:27 | mriedem | kashyap: http://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/expose-quiesce-unquiesce-api.html | |
| 14:09:44 | kashyap | mriedem: Yeah, I saw that, but the Gerrit discussion itself. Maybe it's linked in there | |
| 14:10:23 | openstackgerrit | Gábor Antal proposed openstack/nova master: Update hacking version https://review.openstack.org/389338 | |
| 14:10:23 | openstackgerrit | Gábor Antal proposed openstack/nova master: Enable global hacking checks and removed local checks https://review.openstack.org/431030 | |
| 14:10:49 | kashyap | No, it isn't. I only see the other, related spec that was approved https://review.openstack.org/#/c/126966/ ("Quiesce filesystems with QEMU guest agent during image snapshot") | |
| 14:11:29 | mriedem | kahshttps://review.openstack.org/#/c/237881/ | |
| 14:11:34 | mriedem | kashyap: ^ | |
| 14:12:04 | kashyap | mriedem: Perfect! How did you find it? | |
| 14:12:13 | gabor_antal | johnthetubaguy: can you please give your +2 back? I had to rebase https://review.openstack.org/#/c/431030 | |
| 14:12:32 | mriedem | kashyap: looked up the hash on the file in the nova-specs repo | |
| 14:13:55 | gabor_antal | Vek: could please give your +2 back too? https://review.openstack.org/#/c/431030 | |
| 14:29:45 | lyarwood | mriedem: just reading over the notes from the nova meeting yesterday that I missed thanks to my ISP having an outage. Do you think you will have time next week to cut a stable/newton release before the PTG? | |
| 14:30:18 | mriedem | lyarwood: hopefully | |
| 14:31:00 | lyarwood | mriedem: cool, I'm out Monday but if there's anything I can do to help that long just let me know | |
| 14:31:06 | lyarwood | along* | |
| 14:31:37 | mriedem | will do | |
| 14:35:19 | jroll | mriedem: I think we'll have time for this in pike, if you want to approve it. made decent progress on the ironic side in ocata. https://blueprints.launchpad.net/nova/+spec/ironic-boot-from-volume | |
| 14:35:24 | mriedem | superdan: want to hit this ocata backport and the one after it? https://review.openstack.org/#/c/430306/ | |
| 14:35:36 | superdan | yup | |
| 14:36:09 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Initiate network changes from source during live migration https://review.openstack.org/404607 | |
| 14:38:56 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Send service token along with user tokens https://review.openstack.org/426933 | |
| 14:40:52 | mriedem | jroll: done | |
| 14:41:08 | mriedem | johnthetubaguy: you can drop the -2 on this now https://review.openstack.org/#/c/215385/ | |
| 14:41:54 | johnthetubaguy | mriedem: jroll: -2 removed | |
| 14:42:20 | jroll | mriedem: johnthetubaguy: you rock, thanks | |
| 14:43:33 | mriedem | lyarwood: i think i'm going to hold https://review.openstack.org/#/c/431530/ out of rc2 since it's latent | |
| 14:43:49 | mriedem | lyarwood: but good if that fixes it, i remember takashi tried to fix that and we had to revert his fix | |
| 14:45:35 | lyarwood | mriedem: yup np and thanks, hopefully that's enough this time. https://review.openstack.org/#/c/427808/ hasn't landed yet btw, I'll try to get another tempest core to ack now. | |
| 14:46:34 | mriedem | lyarwood: well.... | |
| 14:46:35 | mriedem | oh, | |
| 14:46:43 | mriedem | i guess we only enable that test starting in ocata | |
| 14:46:59 | mriedem | i was going to say, you'd break stable/mitaka, but we don't run the test there | |
| 14:49:20 | lyarwood | mriedem: yup, that reminds me I still haven't landed https://review.openstack.org/#/c/427602/ | |
| 14:50:10 | mriedem | ah so that's why the ceph job has been red for weeks :) | |
| 14:50:22 | mriedem | good thing we made it non-voting for other brokenness before that | |
| 14:52:06 | lyarwood | yeah sorry about that, the lack of fire from the job no longer voting means I keep dropping this | |
| 15:01:17 | openstackgerrit | Chris Friesen proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/431775 | |
| 15:02:25 | cfriesen | ^ the "flavor information in nova show output" spec from yesterday's discussion | |
| 15:03:39 | mriedem | cfriesen: can you please just cleanup the existing review? | |
| 15:03:43 | mriedem | rather than post a new one | |
| 15:04:23 | mriedem | https://review.openstack.org/#/c/265282 | |
| 15:04:52 | mriedem | also, did you know there was a claude friesen? | |
| 15:10:18 | cfriesen | mriedem: I started by cherry-picking the existing review...oh, did I change the Change-Id maybe? | |
| 15:10:34 | mriedem | cfriesen: most likely | |
| 15:10:49 | mriedem | although cherry-picking should preserve that | |
| 15:10:54 | mriedem | i would have just done a git review -d | |
| 15:10:56 | mriedem | but either words | |
| 15:10:59 | mriedem | *works | |
| 15:11:52 | cfriesen | didn't even know about "git review -d". :) | |
| 15:13:01 | openstackgerrit | Chris Friesen proposed openstack/nova-specs master: add spec for instance flavor API https://review.openstack.org/265282 | |
| 15:13:46 | artom | cfriesen, you're not alone, I was like a year into my Openstack work when I saw a colleague use it | |
| 15:14:30 | cfriesen | I cherrypicked and then squashed some stuff on top and forgot to preserve the old change-id. That newer one ^ should be the right one. | |
| 15:16:31 | mriedem | cool thanks | |
| 15:16:41 | mriedem | i'm nowhere near ready to review pike specs yet, | |
| 15:16:45 | mriedem | but it's good to get those ducks in a row | |
| 15:17:10 | cfriesen | speaking of specs...did anything happen in Ocata for this? https://blueprints.launchpad.net/nova/+spec/memory-bw | |
| 15:17:40 | cfriesen | looks like parts of it got merged and parts were abandoned | |
| 15:20:42 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run https://review.openstack.org/432344 | |
| 15:23:16 | mriedem | first, did we have an ocata midcycle? i'm totally drawing a blank | |
| 15:23:29 | mriedem | i guess not | |
| 15:23:31 | mriedem | because of the short release | |
| 15:23:48 | mriedem | cfriesen: we said at the newton midcycle that we weren't going to do the memory bandwidth tracking stuff in nova | |
| 15:25:02 | mriedem | cfriesen: see http://lists.openstack.org/pipermail/openstack-dev/2016-August/100600.html | |
| 15:25:06 | mriedem | "* Future of compute host metrics monitoring in Nova" | |
| 15:25:24 | mriedem | http://docs.openstack.org/developer/nova/policies.html?highlight=monitoring#metrics-gathering | |
| 15:28:43 | cfriesen | mriedem: thanks for the links | |
| 15:32:37 | cfriesen | mriedem: is there any coalescing around a new standard metrics gathering tool? | |
| 15:34:45 | mriedem | cfriesen: not that i'm aware of, | |
| 15:34:49 | mriedem | there are lots of metrics gathering tools, | |
| 15:34:56 | mriedem | i'm sure there are probably at least 3 competing big tent projects | |
| 15:36:04 | mriedem | cfriesen: might be worth asking the telemetry and/or watcher teams, | |
| 15:36:11 | mriedem | edleafe is involved with watcher so he might have some tips | |
| 15:37:15 | edleafe | cfriesen: I'd ask in #openstack-watcher | |
| 15:37:23 | edleafe | oops! my manners | |
| 15:38:51 | figleaf | heh | |
| 15:40:03 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove main_db flavor compatibility https://review.openstack.org/431722 | |
| 15:40:03 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove flavor_* functions from db/api https://review.openstack.org/431752 | |
| 15:40:04 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove straggling use of main db flavors in cellsv1 code https://review.openstack.org/432352 | |
| 15:40:14 | mriedem | random question - why do we even have this decorator on compute_api.delete when it won't enforce anything? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2152 | |
| 15:40:43 | mriedem | i think everything in here will eval to False https://github.com/openstack/nova/blob/master/nova/compute/api.py#L130 | |
| 15:40:54 | mriedem | so we'll never get InstanceInvalidState | |
| 15:42:24 | cfriesen | mriedem: is there no way to assert that the vm_state/task_state must be None? | |
| 15:42:40 | mriedem | that's not what None means there | |
| 15:42:42 | cfriesen | but yeah, that does seem pointless on the delete operation | |
| 15:42:48 | mriedem | None for that decorator means, i don't care about vm_state or task_state | |
| 15:42:54 | cfriesen | mriedem: yeah, I see that. | |
| 15:43:15 | cfriesen | mriedem: but what if I wanted to ensure that it actually was None? | |
| 15:43:49 | cfriesen | wait, I guess vm_state should be something else | |
| 15:44:02 | mriedem | then you pass in (None,) | |
| 15:45:03 | sfinucan | mriedem: We can't remove the floating IP nova-manage commands until we remove cells v1 and nova-network, correct? https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L305-L308 | |
| 15:45:52 | mriedem | sfinucan: corect | |
| 15:45:53 | mriedem | *correct | |
| 15:45:55 | mriedem | i already tried | |
| 15:45:56 | mriedem | and gave up | |
| 15:46:00 | mriedem | b/c devstack uses those | |
| 15:46:11 | sfinucan | mriedem: aww :( | |