Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-18
08:12:32 gmann Kevin_Zheng: yea, thats true. did we force to use both ?
08:12:42 Kevin_Zheng In nova it is impossible to decide which dir belongs to which key
08:13:14 Kevin_Zheng well I think it needs further discussion and maybe a BP for next cycle
08:13:47 Kevin_Zheng but the current implementation of whitelist bp is just kept current behaviour
08:14:01 Kevin_Zheng since it is already broken IMO
08:15:18 alex_xu gmann: the db layer done that https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2111
08:17:17 Kevin_Zheng Yeah, but as we discussed before, the key could be messed, because I was putting asc for key2 and key1 should be with defalt desc but the acutal response will be asc for key1 and defult desc for key2
08:17:30 Kevin_Zheng IMO it is a bug
08:17:51 Kevin_Zheng Still, out of the scope of the BP, I thinks
08:18:04 gmann alex_xu: but it append at end and all sort_dir are being mixed if not provided for any key in between
08:18:48 Kevin_Zheng I think we should strict user to provide both, just my opinion
08:19:00 gmann hummm
08:19:52 Kevin_Zheng or it should be handeled in a different way
08:20:01 Kevin_Zheng like key value pairs
08:20:16 Kevin_Zheng two list is imposible to handle
08:20:54 gmann i think we can do while fetching them from req
08:21:53 gmann but yea its out of scope of this BP, ll not block on this
08:22:04 gmann something we can fix later
08:22:10 Kevin_Zheng yeah
08:22:32 gmann alex_xu: Kevin_Zheng about whitelist for sort_key, its not matching with spec one ?
08:23:14 Kevin_Zheng I will check, too many fields and possible to miss one or two :)
08:24:54 alex_xu yea, we didn'i miss anyone
08:25:07 alex_xu oops, hope we didn't miss anyone
08:25:57 gmann alex_xu: Kevin_Zheng i thin we missed in spec seems: created_at', 'updated_at',
08:26:39 gmann but those seems very valid one so should be ok to add in code
08:27:06 Kevin_Zheng yeah will do after writing the doc
08:27:11 alex_xu gmann: created_at and updated_at are in the line 271 and 272
08:27:44 gmann alex_xu: yea in code its there but not in spec :)
08:27:58 alex_xu gmann: oops, I guess we miss that
08:28:17 gmann Kevin_Zheng: can just put those in spec but may be later no big deal as there will not be any objection on those
08:28:33 alex_xu gmann: +1 for update spec
08:29:01 Kevin_Zheng yeah, might be a cleanup after code done
08:29:57 openstackgerrit Vladik Romanovsky proposed openstack/nova: libvirt: expose virtual interfaces with vlans to metadata https://review.openstack.org/405954
08:29:57 openstackgerrit Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951
08:30:12 gmann 'updated_at' should be fine right ? i remember some discussion we had on this when this will be null at initial time
08:30:34 gmann i hope we do not default it to created_at
08:32:39 alex_xu gmann: updated_at and created_at looks like fine to me, that are in the API representation.
08:32:55 gmann ok
08:52:18 openstack Launchpad bug 1657366 in OpenStack Compute (nova) "sort_key and sort_dir combination are not being honored in correct way" [Undecided,New] - Assigned to Ghanshyam Mann (ghanshyammann)
08:52:18 gmann alex_xu: Kevin_Zheng just logged that as bug in case we forget - https://bugs.launchpad.net/nova/+bug/1657366
08:52:36 alex_xu gmann: cool
08:52:43 Kevin_Zheng Thanks
09:18:28 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760
09:21:13 openstackgerrit sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260
09:21:14 openstackgerrit sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261
09:27:47 openstackgerrit sahid proposed openstack/nova: objects: remove related pining from __init__ of InstanceNUMATopology https://review.openstack.org/408242
09:27:48 openstackgerrit sahid proposed openstack/nova: objects: remove cpu_topology from __init__ of InstanceNUMATopology https://review.openstack.org/408240
09:27:48 openstackgerrit sahid proposed openstack/nova: objects: remove pagesize from __init__ of InstanceNUMATopology https://review.openstack.org/408241
09:33:32 Kevin_Zheng alex_xu: should we strict sort_dir now?
09:33:51 alex_xu Kevin_Zheng: we shouldn't strict anything now
09:34:34 Kevin_Zheng right, let me check what api_layer will do if bad dir provided
09:36:10 Kevin_Zheng nothing, so I guess 500 will raise?
09:37:35 Kevin_Zheng hmm 400 so we are good
09:39:36 gmann Kevin_Zheng: alex_xu we can strict for enum(desc, asc)
09:39:55 gmann Kevin_Zheng: alex_xu can we do date-time for created_at etc in https://review.openstack.org/#/c/420494/
09:40:18 Kevin_Zheng I think the current bp is about to not limit those
09:40:32 gmann Kevin_Zheng: in case you can run non date-time string for created_at and it 500
09:40:46 Kevin_Zheng and we already response 400 for sort dir
09:41:01 gmann Kevin_Zheng: not limiting but i doubt it 500 currently same for created_at
09:41:02 Kevin_Zheng didnt dive too deep to find where that happened though
09:41:18 gmann Kevin_Zheng: on sort_dir yes that why we can do on schema side, no need to go deep to get 400
09:45:01 gmann Kevin_Zheng: alex_xu here - https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2489
09:45:07 gmann we can just do on schema side
09:47:52 Kevin_Zheng I tested created at
09:48:01 Kevin_Zheng it will not return 500
09:50:24 gmann then we should make this also 400 like other strict validation in that patch, same for launched_at and terminated_at?
09:50:51 Kevin_Zheng yeah
09:51:03 Kevin_Zheng I think it will be ok with the current path
09:51:39 Kevin_Zheng will be a strict limit with microversion afterwards. I think thats the plan, if I rememered correctly
09:51:56 Kevin_Zheng the current is about to not affect current behavior
09:56:29 tovin07 jaypipes, i rebase this patch (OSprofiler in Nova), could you review it? https://review.openstack.org/#/c/254703/ thanks!
09:57:07 tovin07 because it conflict with recent merged
09:59:53 openstackgerrit Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413
10:02:19 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Fix a parameter in os-availability-zone.inc https://review.openstack.org/417233
10:02:48 openstackgerrit Vasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975
10:03:02 openstackgerrit Vasyl Saienko proposed openstack/nova: Generate necessary network metadata for ironic port groups https://review.openstack.org/388756
10:13:36 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
10:16:05 gmann Kevin_Zheng: opps, i mis read about created_at return 500, if not 500 then it should not be modified as you said. thanks
10:16:25 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760
10:18:14 openstackgerrit zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880
10:35:45 openstackgerrit Béla Vancsics proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225
10:37:29 openstackgerrit Claudiu Belu proposed openstack/nova: Hyper-V PCI Passthrough https://review.openstack.org/420614
10:49:48 openstackgerrit Claudiu Belu proposed openstack/nova: Adds CPUFeaturesField to ImageMetaProps https://review.openstack.org/420960
11:02:03 openstackgerrit Alvaro Lopez Garcia proposed openstack/nova: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250
11:04:03 openstackgerrit Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964
11:05:10 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
11:05:15 openstackgerrit Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926
11:05:39 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707
11:10:43 alex_xu Kevin_Zheng: yea, that is the plan
11:31:13 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters https://review.openstack.org/420626
11:32:57 openstackgerrit Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961
11:32:57 openstackgerrit Sylvain Bauza proposed openstack/nova: Add ComputeNodeList.get_all_by_uuids method https://review.openstack.org/418134
11:38:03 tdurakov gibi: hi, are you around?
11:44:39 gibi tdurakov: hi
11:45:25 openstack Launchpad bug 1657428 in OpenStack Compute (nova) "Nova sends notifications with different timestamp formats" [Undecided,New]
11:45:25 tdurakov gibi: smth related to notifications subteam, I believe: https://bugs.launchpad.net/nova/+bug/1657428
11:46:14 gibi tdurakov: you are right, this is notification problem
11:46:41 gibi tdurakov: I will look into this bug
11:46:51 gibi tdurakov: thanks for notifying
11:48:34 tdurakov gibi, this one shouldn't be a big deal, do you need my help fixing this?

Earlier   Later