| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-17 | |||
| 13:20:12 | openstackgerrit | Lee Yarwood proposed openstack/nova: Compute: Reset bdm connection_info during LM rollback https://review.openstack.org/338929 | |
| 13:20:13 | openstackgerrit | Lee Yarwood proposed openstack/nova: Live migration of instances with encrypted volumes https://review.openstack.org/389608 | |
| 13:24:51 | jaypipes | *yawn* | |
| 13:26:56 | jaypipes | cdent: thx :) | |
| 13:27:21 | openstackgerrit | Chris Dent proposed openstack/nova: A demo script for updating resource inventory https://review.openstack.org/382613 | |
| 13:37:32 | openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] ignore me - trying experimental jobs https://review.openstack.org/421209 | |
| 13:38:29 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 13:40:12 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 13:40:40 | openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 13:41:26 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 13:47:52 | openstackgerrit | garyk proposed openstack/nova: VMware: retry network lookup if network not ready https://review.openstack.org/391778 | |
| 13:48:47 | mdbooth | I think it's fallen into the 'nobody really understands this code' hole, though. | |
| 13:49:20 | mdbooth | All the CI we have thinks it's good. | |
| 13:52:45 | kashyap | mdbooth: In such cases, shouldn't one just merge it, and not leave it in limbo? As the author, you understand it the deepest, and you're more than willing to explain any question to anyone. | |
| 13:53:06 | kashyap | I think it should simply be merged if there are no regressions, or obvious repurcussions -- which there are none at the moment. | |
| 13:54:27 | kashyap | Let's see what MattR has to say when he's here. He's usually quite clear with his stance. | |
| 13:56:05 | tdurakov | PaulMurray paul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov andreas_s abhishekk mrhillsman raj_singh wznoinsk siva_krishnan hi folks, live-migration subteam meeting in 5 minutes on #openstack-meeting-3 | |
| 13:57:01 | huanxie2 | Hi all, I made a very small patch to correct the comment message about input param's data type https://review.openstack.org/#/c/419308/could you help have a review, thanks a lot | |
| 14:02:24 | jaypipes | huanxie2: approved it. thx for the fix. | |
| 14:02:46 | huanxie2 | Thanks jaypipes :) | |
| 14:02:50 | jaypipes | np | |
| 14:04:49 | huanxie2 | I also made another patch to fix the waiting vif-plug-event timeout problem when rescuing a VM https://review.openstack.org/#/c/413469/, could you also have a review if possible? | |
| 14:06:02 | jaypipes | huanxie2: yes, will do shortlyu. | |
| 14:08:05 | huanxie2 | Many thanks jaypipes | |
| 14:10:38 | mriedem | jaypipes: i took a look at your aggregate map patch, comments inline | |
| 14:11:02 | jaypipes | mriedem: already responded... | |
| 14:11:06 | mriedem | ok | |
| 14:11:09 | jaypipes | mriedem: thx, great review comments. | |
| 14:11:17 | mriedem | school is closed up here today so i'm going to be on and off | |
| 14:11:38 | mdbooth | mriedem: Snow day? | |
| 14:11:44 | jaypipes | mriedem: thx for letting me know. trying to perform a bunch of my day-job duties today :( (management stuff) | |
| 14:11:45 | mriedem | ice dsay | |
| 14:11:47 | mriedem | *day | |
| 14:13:32 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571 | |
| 14:13:32 | mdbooth | mriedem: I'm still banging on https://review.openstack.org/#/c/383859/ btw | |
| 14:14:41 | mdbooth | I just updated it. sfinucan had asked for some docs, and I noticed an additional potential race while I was writing them. I've fixed the race and added docstrings. | |
| 14:15:17 | mdbooth | Jenkins thinks it's good, and I've run the updated patch against devstack nfs, which still passes. | |
| 14:17:12 | lyarwood | mdbooth: quick nit on that review around your use of os.path.ismounted | |
| 14:17:39 | mdbooth | The race was: if we lose and regain our libvirt connection, when we re-initialise the mount state we couldn't be certain that there were no ongoing operations from before we lost the connection. | |
| 14:17:40 | lyarwood | mdbooth: still looking at the rest, started there given the other change I'm working on | |
| 14:18:06 | mdbooth | lyarwood: Thanks for looking! | |
| 14:19:46 | tdurakov | johnthetubaguy: hi, are you around? | |
| 14:20:19 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | |
| 14:23:06 | mdbooth | lyarwood: That raises a follow-on question about is_mounted, btw. | |
| 14:23:23 | mdbooth | I'm going to tread carefully around that rabbit hole :) I don't want to go down it. | |
| 14:24:49 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | |
| 14:25:14 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Strict pattern match query parameters https://review.openstack.org/420494 | |
| 14:25:38 | mriedem | mdbooth: ack. are you ok with the latest version of https://review.openstack.org/#/c/312488/ now? | |
| 14:26:00 | lyarwood | mdbooth: I assume your going to ask if it did that check before right? | |
| 14:26:06 | lyarwood | you're* | |
| 14:26:27 | mdbooth | mriedem: Just checking again. I was nearly ok with with it last time iirc. | |
| 14:27:15 | mdbooth | lyarwood: I responded to your comment. | |
| 14:28:23 | lyarwood | mdbooth: yup good point | |
| 14:30:28 | diana_clarke | mriedem: Let me know if there is anything you want help with, given ice day and all. In particular, is there anything I can help with wrt what tripleo needs from nova? | |
| 14:30:56 | diana_clarke | man pages etc | |
| 14:31:31 | mriedem | ok, hm | |
| 14:31:53 | openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot.error notification https://review.openstack.org/411791 | |
| 14:31:54 | mriedem | it would be nice to have man page entries for the cells v2 commands | |
| 14:32:16 | mriedem | in here http://docs.openstack.org/developer/nova/man/nova-manage.html | |
| 14:32:45 | diana_clarke | mriedem: yeah, I saw the ask in the nova-cells-v2 wiki, which is why I asked. I no one is doing that, I can take that on. | |
| 14:33:03 | diana_clarke | typo: *if* no one is doing that... | |
| 14:33:17 | mriedem | i don't think anyone is working on that so it's all yours | |
| 14:33:35 | mriedem | you might want to do them one at a time in a series just to make reviews easier | |
| 14:34:02 | diana_clarke | mriedem: okie, dokie. and I'll update the wiki, claiming that task | |
| 14:34:42 | mriedem | we might want to get https://review.openstack.org/#/c/420442/ merged to avoid conflicts too | |
| 14:34:50 | mriedem | sdague: super simple change https://review.openstack.org/#/c/420442/ | |
| 14:35:17 | sdague | mriedem: bam | |
| 14:37:36 | mriedem | thanks emeril | |
| 14:38:25 | mriedem | sean-k-mooney: do you know if we can re-use _get_vif_name in here https://review.openstack.org/#/c/410737/ ? i.e. is the device field set on that type of vif for vhostuser? | |
| 14:39:44 | mriedem | i guess the vif does have a devname, "devname":"tap96429488-f7" | |
| 14:39:50 | mriedem | but it's not what's needed here i guess | |
| 14:43:24 | markus_z | tdurakov: sorry, I missed the meeting | |
| 14:44:03 | tdurakov | markus_z: ping me once update the hook | |
| 14:45:06 | markus_z | tdurakov: I pushed the teardown pkoniszewski asked for in ps42. https://review.openstack.org/#/c/347471/ | |
| 14:45:21 | tdurakov | acked, let me check it again | |
| 14:45:28 | markus_z | thanks! | |
| 14:49:23 | sean-k-mooney | mriedem just looking now | |
| 14:50:45 | sean-k-mooney | mriedem: looking at the code the vhost-user socket name must = the name of the openvswitch port | |
| 14:51:27 | sean-k-mooney | mriedem: if we called _get_vif_name() we would have to modify neutron to generate the socket path differently | |
| 14:52:19 | sean-k-mooney | my intention was to modify neutron to pass the name of the device in the port binding | |
| 14:52:36 | sean-k-mooney | and then nave nova use that if present or fall back to generating it if not set | |
| 14:54:32 | mriedem | ok so in other words this is fine | |
| 14:55:23 | sean-k-mooney | mriedem: yes what is there is currently fine but i would like to decouple it in the future so that we dont have to ensure that neutron and nova generate the name with the same algoritim | |
| 14:56:06 | tdurakov | markus_z: done, thank you | |
| 14:56:24 | markus_z | tdurakov: yeah, thanks! | |
| 14:56:32 | tdurakov | mriedem, sdague hi, could you please take a look https://review.openstack.org/#/c/347471/43 | |
| 14:57:27 | jaypipes | sdague: well said, on the PWG thing. I won't say that publicly, of course, since I'd get my head chewed off internally. | |
| 14:58:43 | cdent | jaypipes: you must have very flexible teeth or jaw | |
| 15:03:18 | mriedem | sean-k-mooney: ok i've also gone through https://review.openstack.org/#/c/385061/ | |
| 15:10:29 | mriedem | alex_xu: your intel buddies might want to look at this https://review.openstack.org/#/c/420960/1/nova/objects/fields.py | |
| 15:10:36 | mriedem | pkoniszewski: ^ | |
| 15:12:33 | cdent | _gryf: I think that endpoint stuff is simply that I hadn't revisited that update_inventory code in a long time (perhaps 4 months?) | |
| 15:13:54 | _gryf | cdent, ok, cool | |
| 15:22:21 | alex_xu | mriedem: that sounds like that overlap with traits. in the future we can request specific trait in the image metadata, the requested trait can be cpu feature. there is the spec about request traits https://review.openstack.org/#/c/351063/3/specs/ocata/approved/request-standardized-capabilities.rst@66 | |
| 15:27:05 | pkoniszewski | thanks mriedem, i will take a look | |
| 15:31:50 | cdent | edleafe: I think you're on PTO, but if not I fixed that bug in gabbi and made a new one: https://pypi.python.org/pypi/gabbi | |
| 15:34:13 | openstackgerrit | Diana Clarke proposed openstack/nova: nova-manage docs: add cells commands prep https://review.openstack.org/421320 | |
| 15:48:26 | openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961 | |
| 15:48:26 | openstackgerrit | Sylvain Bauza proposed openstack/nova: Add ComputeNodeList.get_all_by_uuids method https://review.openstack.org/418134 | |
| 15:48:58 | bauzas | mriedem: jaypipes: folks I need to bail out for a few, but you can bite ^ | |