Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-11
07:06:03 mnestratov gokhan: looks like you need commit d4aa455d53c91c6dfebbf9a9850f7b6c3fef4545 to fix this issue
07:06:24 mnestratov gokhan: review https://review.openstack.org/#/c/182257/
07:07:35 mnestratov gokhan: there was a lot of changes merged since mitaka regarding virtuozzo support
07:09:11 gokhan thanks mnestratov, I will try it
07:09:14 mnestratov gokhan: thus, I'd recommend you to use newton
07:11:49 mnestratov gokhan: did you create a container image yourself or use our test one?
07:12:37 gokhan mnestratov: I used test one
07:13:29 mnestratov gokhan: ok, just wanted to clarify
07:16:18 gokhan mnestratov: ok firstly I will commit these changes . If it doesn't work, I will try newton
07:16:36 mnestratov gokhan: same error?
07:17:06 mnestratov oh I thought you tried already
07:17:42 gokhan no I haven't tried yet.
07:26:59 openstackgerrit Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540
07:26:59 openstackgerrit Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480
07:27:00 openstackgerrit Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613
07:27:21 openstackgerrit avnish proposed openstack/nova: Remove useless ddt requirements https://review.openstack.org/418747
08:57:21 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571
09:12:28 alex_xu bauzas: johnthetubaguy good morning, I found this patch similar to the force param on evacuate https://review.openstack.org/#/c/408955/11/nova/compute/api.py@3145, but i feel that if the instance without request_spec obj, then the API just don't the thing user expected silently. Does it sounds ok? will Hydrate a fake spec very complex?
09:13:34 bauzas alex_xu: not sure I understand your concern
09:14:23 bauzas alex_xu: FWIW, all the instances are now having a RequestSpec
09:14:26 bauzas since Newton
09:14:59 bauzas because I wrote a DB migration for creating a RequestSpec for all the already created instances
09:15:13 alex_xu bauzas: oops, we have data migration for it? I saw this comment https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3897, just thought it may still have that case
09:15:22 alex_xu bauzas: ah, got it, cool
09:15:25 bauzas alex_xu: yup, sec
09:17:24 openstackgerrit Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488
09:19:14 bauzas alex_xu: https://github.com/openstack/nova/commit/09f2d4d5ec3a699176d70c2407ced0ce7cd58197
09:20:31 openstackgerrit Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488
09:22:18 alex_xu bauzas: thanks, i see now. we probably just need some cleanup later
09:22:49 bauzas alex_xu: what's missing is that we don't delete yet the RequetSpec if the instance is deleted
09:25:00 alex_xu bauzas: is there any blocker? or we just miss it?
09:26:22 bauzas nothing but time :)
09:26:32 alex_xu bauzas: ok :)
09:30:27 openstackgerrit OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978
09:44:58 openstackgerrit Abhishek Kekane proposed openstack/nova: Use is_valid_cidr and is_valid_ipv6_cidr from oslo_utils https://review.openstack.org/320375
09:47:32 gmann alex_xu: why we want to handle _* separately in https://review.openstack.org/#/c/408571/36
09:48:27 gmann alex_xu: i mean just 400 in server.py will be enough right instead of allowing it in schema and later allow to go from strip_additional_property
09:49:17 gmann alex_xu: also how about treating that same as other additional property, just ignore
09:53:19 lyarwood_ mdbooth: morning, was anything blocking https://review.openstack.org/#/c/383859/ aside from core reviews?
09:54:24 alex_xu gmann: if we didn't put _* in the schema, they will be stripped out
09:56:37 alex_xu gmann: we have discuss it whether we can just ignore at last api meeting http://eavesdrop.openstack.org/meetings/nova_api/2017/nova_api.2017-01-04-13.00.log.html
09:56:48 alex_xu gmann: start from "13:07:35"
09:57:18 alex_xu gmann: but yes, I'm not sure people like current implement.
10:03:22 gmann alex_xu: oh yea, for db model object internal attributes.
10:04:07 gmann alex_xu: but only allow in strip_additional and later 400 should be enough may be instead of explicitly allow in original schema ?
10:06:55 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571
10:23:29 openstackgerrit zhangyujun proposed openstack/nova: Update JSON Schema for flavor access https://review.openstack.org/418683
10:40:18 mdbooth lyarwood_: Actually I've got it open right now. I was writing some docs for it at the suggestion of sfinucan and noticed a race, which I'm addressing.
10:40:27 mdbooth But basically no.
10:44:59 openstackgerrit Jiri Suchomel proposed openstack/nova: Retry few times when creating the initial connection to libvirtd. https://review.openstack.org/416928
10:45:17 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
10:46:58 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
10:49:41 openstackgerrit avnish proposed openstack/nova: Removed unnecessary utf-8 encoding https://review.openstack.org/418838
10:49:48 openstackgerrit avnish proposed openstack/python-novaclient: Removed unnecessary utf-8 encoding https://review.openstack.org/418839
10:52:45 sfinucan Morning/afternoon, folks. On this, review day, could I get some eyes on two bug fixes: https://review.openstack.org/#/c/396184/ and https://review.openstack.org/#/c/392643/
10:53:17 sfinucan Both should be somewhat self explanatory, but I'm here if anyone has any questions
10:54:33 openstackgerrit Balazs Gibizer proposed openstack/nova: Remove **kwargs passing in payload __init__ https://review.openstack.org/418489
11:15:03 openstackgerrit John Garbutt proposed openstack/nova: Populate network data in _validate_requested_network_ids https://review.openstack.org/418511
11:15:08 openstackgerrit John Garbutt proposed openstack/nova: Pass objects into _create_ports_for_instance https://review.openstack.org/418512
11:15:14 openstackgerrit John Garbutt proposed openstack/nova: Pass objects into _update_ports_for_instance https://review.openstack.org/418513
11:19:33 openstackgerrit Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488
11:20:37 openstackgerrit OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978
11:21:45 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571
11:22:08 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
11:29:03 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
11:29:11 alex_xu gmann: I feel explicity in the schema is better than hide some hacky deep into some method.
11:40:39 openstackgerrit John Garbutt proposed openstack/nova: Extract preallocate_for_instance https://review.openstack.org/418876
11:49:05 openstackgerrit zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880
11:49:50 openstackgerrit Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509
11:50:47 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
11:51:27 openstackgerrit John Garbutt proposed openstack/nova: WIP: Call pre_allocate_for_instance before scheduler https://review.openstack.org/413124
11:51:28 openstackgerrit John Garbutt proposed openstack/nova: WIP: introduce preallocate_for_instance method. https://review.openstack.org/418881
11:58:23 openstackgerrit John Garbutt proposed openstack/nova: Make allocate_for_instance take consistent args https://review.openstack.org/418024
12:06:24 openstackgerrit zhangyujun proposed openstack/nova: Update JSON Schema for flavor access https://review.openstack.org/418683
12:07:59 openstackgerrit John Garbutt proposed openstack/nova: Add and use ProcessedNetworkRequest object https://review.openstack.org/418025
12:07:59 openstackgerrit John Garbutt proposed openstack/nova: Pass objects into _validate_requested_network_ids https://review.openstack.org/418027
12:51:50 alex_xu nova api sub-team meeting is 9mins at #openstack-meeting-4
12:57:46 gmann alex_xu: i see point now, for skipping _* from strip_additional we need in schema
12:57:52 gmann alex_xu: thanks :)
12:58:23 alex_xu gmann: yea, but that is a little ugly
12:59:04 Kevin_Zheng lol
12:59:04 gmann alex_xu true, that's side effect of maintaining lot of versions and supported codes :)
12:59:34 alex_xu gmann: yea :)
13:24:21 openstackgerrit Alex Szarka proposed openstack/nova: Transform instance-exists notification https://review.openstack.org/403660
13:29:05 bauzas artom: I have a question for you in https://review.openstack.org/#/c/415520/5
13:29:18 bauzas (reviewing all the blueprints for the review day)
13:29:49 bauzas artom: at least, I put -1 because of the confusing docstring
13:32:25 bauzas artom: heh, jinx for the recheck :)
13:32:29 artom bauzas, aha! Yeah, that probably makes sense
13:33:01 artom bauzas, heh, a lot of volumes tests failed on that one, so I got worried, but it looks like it's an unrelated MySQL failure and not my code
13:33:08 bauzas zactmy
13:33:28 bauzas artom: about the first change, amirite if I think you just need to signal something ?
13:33:36 bauzas you don't really care about the value itsefl
13:34:01 bauzas if so, is the tag info something we can get from the vif info ?
13:34:44 bauzas artom: ^
13:34:47 artom bauzas, I don't think it's in vif info...
13:34:52 bauzas okay
13:35:06 bauzas if so, we need it in the signature indeed
13:35:38 artom Vif info is that weird network model class, right? If so (and IIRC it is) it's not in there
13:36:34 artom bauzas, strictly speaking, we need it as a boolean flag, so... just check whether it's in kwargs? You think that'd be better?

Earlier   Later