Earlier  
Posted Nick Remark
#openstack-cyborg - 2026-08-18
14:24:40 sean-k-mooney i realised i had them still pending
14:25:02 chandankumar ok, make sense!
14:25:27 rlandy It looks like we are already in the Reviews section - so please raise any other reviews that require attention
14:25:27 sean-k-mooney melwitt: i belive i approved your docs changes for the intel nic driver this morning
14:25:48 sean-k-mooney rlandy: sorry yes i jumped ahead
14:26:15 melwitt yes thank you sean-k-mooney
14:26:31 sean-k-mooney melwitt: are there any other open reviews you want to highlight?
14:27:04 melwitt no, not at the moment
14:27:10 gamio quick one on 1000240 - i checked the gpu driver too while looking at melanie's comment.
14:27:41 gamio both share the same root cause: device_addresses is compared exact-match against lowercase sysfs/lspci values, so a wrong-case or absent address never matches.
14:27:59 sean-k-mooney right
14:28:10 sean-k-mooney we need to normalsie the adresses when comparing
14:28:25 chandankumar one more thing https://review.opendev.org/c/openstack/cyborg/+/999939 when I added nvme device state , I think I have added a regression in fake driver, jsut wanted to highlight.
14:28:37 gamio the nic side just doesn't discover the device on the gpu side the lookup returns None and the card is registered as a pgpu instead of a vgpu _get_vgpu_type_per_pgpu's docstring is off too
14:29:00 gamio it calls the param a config address but the caller passes the discovered one.
14:29:17 gamio so rather than fixing only the nic half here, i'd keep 1000240 as is and open a bug to fix both in a follow-up. does that sound ok?
14:29:35 sean-k-mooney sure
14:29:54 sean-k-mooney im not fully folloing the code you are refint too without links
14:29:59 sean-k-mooney but if you write it up as a bug
14:30:08 sean-k-mooney we can proceed with fixing it in both places
14:31:00 sean-k-mooney also ideally were approcate we can consdier using your recenly intoduced fucntion for listing devices ectra if that makes sense
14:31:12 gamio sean-k-mooney: thanks, will do. i'll write it up as a bug with the code links and drop the number on the review.
14:31:25 sean-k-mooney i know the intel driver currenly does not use lspci and use direct sysfs access to enermerate teh devices
14:31:44 sean-k-mooney chandankumar: that one of hte comment i left on the nvme serise
14:32:02 sean-k-mooney chandankumar: i dont think you shoudl write yoru own pci device enumeration logic
14:32:15 sean-k-mooney you shoudl reuse teh get_devices funciton for the acclerator utils
14:33:05 sean-k-mooney gamio: for these bug fixes im not sure we need to rewite them to use your new util fuctions if that is invaise
14:33:11 chandankumar ok, let me go through comments
14:33:31 sean-k-mooney gamio: but next cycle im hopeing to add a PCIBusManager
14:33:46 sean-k-mooney to handel all of this for all driver so we can defer some of that to that work
14:34:15 sean-k-mooney gamio: so use your best judgement on what to keep local to the drvier for now in an easy backportabvly patch vs what tech debt to adress
14:34:16 gamio nice, that'll be a good home for all this. happy to help on the PCIBusManager next cycle, it's right in my area.
14:35:04 rlandy since we're in Bugs now ... any additional bugs to raise?
14:35:22 rlandy reference ...
14:35:25 rlandy https://bugs.launchpad.net/python-cyborgclient
14:35:25 rlandy https://bugs.launchpad.net/openstack-cyborg
14:36:45 rlandy There are two new bugs
14:37:05 rlandy #link: https://bugs.launchpad.net/openstack-cyborg/+bug/2017513
14:37:17 rlandy sync data to placement raise resource in use exception
14:37:20 rlandy from 2023
14:38:04 rlandy undecided
14:38:45 rlandy can we mark that triaged?
14:39:19 sean-k-mooney yes we can mark it as triaged
14:39:20 rlandy importance?
14:39:36 sean-k-mooney its medium to high
14:39:43 sean-k-mooney because this is a data integrety bug
14:39:57 rlandy medium to start
14:40:06 sean-k-mooney as i noted in the comments
14:40:14 sean-k-mooney nova had this exact same bug years ago
14:40:25 sean-k-mooney the fix jsut never got ported to cyborg
14:41:09 sean-k-mooney the tl;dr is even if you remove a device form the pci whitelist
14:41:25 sean-k-mooney we shoudl not remove it form placment or the devices api if it is currently allcoated
14:41:51 sean-k-mooney so we will need to modify the condocutor/cybrog-agent to do this detection on startup
14:42:11 sean-k-mooney and prevent this form happening but we can leave it there for now
14:42:51 rlandy ack - thank you ... the second untriaged bug: #link https://bugs.launchpad.net/openstack-cyborg/+bug/2163240
14:43:00 rlandy Cyborg does not retry accelerator-request-bound external event after Nova returns per-event 422 during instant ARQ bind
14:43:07 rlandy chandankumar, looks like you just created this
14:43:11 rlandy and have some patches
14:43:48 sean-k-mooney https://review.opendev.org/c/openstack/cyborg/+/999931
14:43:50 sean-k-mooney is merged
14:43:57 sean-k-mooney so this can be marked fix released
14:44:14 sean-k-mooney ah it was missing Closes-Bug:
14:44:23 sean-k-mooney so it did not auto move once merged
14:45:03 sean-k-mooney chandankumar: can you assign that to your self and update the status
14:45:18 rlandy I updated the status
14:45:28 sean-k-mooney ack
14:45:31 rlandy needs an importance
14:45:31 chandankumar sure
14:45:38 chandankumar low
14:45:52 sean-k-mooney yep
14:46:03 sean-k-mooney its more an improment to the logging then anything else
14:46:05 rlandy done
14:46:09 rlandy assigned to chandankumar
14:46:26 rlandy thank you - that is it for the untriaged bugs
14:47:00 rlandy #topic: open discussion
14:47:12 rlandy we kind of had this earlier
14:47:29 rlandy so giving a few minutes for folks to raise anything else
14:49:05 sean-k-mooney just an fyi
14:49:08 sean-k-mooney https://docs.openstack.org/cyborg/latest/contributor/release-guide.html
14:49:35 sean-k-mooney we shuld review the https://docs.openstack.org/cyborg/latest/contributor/release-guide.html#milestone-3 and rc sections
14:49:45 sean-k-mooney and prepare to do them over the next week or two
14:49:51 sean-k-mooney no action needed this week
14:50:22 sean-k-mooney but we are going to need to start doing those itmes in the next 2-3 weeks
14:50:28 sean-k-mooney thats it form me
14:50:41 rlandy anyone else?
14:51:25 rlandy #topic: Volunteers to chair next meeting
14:51:39 chandankumar I can take it
14:51:46 rlandy thank you chandankumar
14:51:54 rlandy that's all for this week
14:51:58 rlandy thank you for attending
14:52:07 rlandy #endmeeting
14:52:07 opendevmeet Meeting ended Tue Aug 18 14:52:07 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
14:52:07 opendevmeet Minutes: https://meetings.opendev.org/meetings/cyborg_irc_meeting___august_18__2026/2026/cyborg_irc_meeting___august_18__2026.2026-08-18-14.02.html
14:52:07 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/cyborg_irc_meeting___august_18__2026/2026/cyborg_irc_meeting___august_18__2026.2026-08-18-14.02.txt
14:52:07 opendevmeet Log: https://meetings.opendev.org/meetings/cyborg_irc_meeting___august_18__2026/2026/cyborg_irc_meeting___august_18__2026.2026-08-18-14.02.log.html
14:52:07 chandankumar thank you rlandy !
#openstack-cyborg - 2026-08-19
09:40:42 opendevreview chandan kumar proposed openstack/cyborg master: Add NVME device type and bump Device object to v1.4 https://review.opendev.org/c/openstack/cyborg/+/999932
09:40:43 opendevreview chandan kumar proposed openstack/cyborg master: Add device_state lifecycle field to the Device object https://review.opendev.org/c/openstack/cyborg/+/999933
09:40:43 opendevreview chandan kumar proposed openstack/cyborg master: Bump Device object to v1.3 for MDEV and PCI type support https://review.opendev.org/c/openstack/cyborg/+/1001474
10:51:02 opendevreview chandan kumar proposed openstack/cyborg master: Add device_state lifecycle field to the Device object https://review.opendev.org/c/openstack/cyborg/+/999933

Earlier   Later