Earlier  
Posted Nick Remark
#openstack-cyborg - 2026-06-24
13:21:01 opendevreview Elod Illes proposed openstack/python-cyborgclient master: DNM: gate health test https://review.opendev.org/c/openstack/python-cyborgclient/+/994725
17:47:50 sean-k-mooney melwitt: so on a releated unrelated note
17:48:35 sean-k-mooney were you thinking of lookign at functional tests for cybrog in the next few weeks? if not i will towrad the end of july
17:48:58 sean-k-mooney well proably assuming something mroe imporant doesnt come up
17:50:33 melwitt sean-k-mooney: no I wasn't thinking about anything specific and wouldn't want to take if you have something in mind you'd like to do
17:51:12 sean-k-mooney it was more i was missing them while doing some of the feature dev
17:51:20 melwitt in general, I think putting testing in place earlier than later is nice bc subsequent work all can make use of it
17:51:30 melwitt yeah, that's also my concern
17:51:51 sean-k-mooney so not speciifcly but when i fhish up the 2 things i have in flight i wanted to switch back to some testing tech debt
17:52:35 sean-k-mooney ya same so once i have tempest in a slightly better place i want to swap back to lookign at the intree testing
17:53:18 melwitt I agree with that plan
17:54:17 melwitt it's been so important in nova, I wouldn't want to be without it for feature work
17:54:24 sean-k-mooney so the lowish hanging furit woudl be to add api sample tests, but after that gabii style testing or nova style funcitonl testign would be the next nice to have in the main repo, there is also client testing ectra so lots to do
17:55:56 sean-k-mooney do i generate https://gist.github.com/SeanMooney/0bc41721481dd6e5918a4504c956f882 and https://gist.github.com/SeanMooney/36f2ef20bd5cb4c853af23c581b917fc in the past
17:56:22 sean-k-mooney to help plan adding funcitoal test to watcher but we have not made as much progess on that as i hoped
17:56:34 melwitt ah those are nice
17:56:50 sean-k-mooney i need to get the former into nova develper docs eventually
17:57:09 melwitt I liked gabbi quite a bit when I worked on placement feature stuff but in general I feel it's quite a bit more limited than what we have in nova
17:57:33 sean-k-mooney it is, its nice for testing the api but thats about it
17:57:38 melwitt yeah
17:57:45 sean-k-mooney you can do more with it but i find the absction breaks down to quickly
17:58:10 melwitt 100% agree
18:25:15 melwitt I'll do some exploration on API sample tests
18:30:43 sean-k-mooney if you derive insperation form nova please incldue https://review.opendev.org/c/openstack/nova/+/944054
18:31:25 sean-k-mooney othereise figiuring out which sample is used by which test is an otter pain :)
18:31:35 melwitt ah yeah :)
19:07:52 sean-k-mooney by the way since we dont have any testing of the sample we are going to have to assume that they may be wrong and update them form live devstack responces
19:34:22 melwitt yes
19:42:21 opendevreview melanie witt proposed openstack/cyborg master: Fix api-ref request samples containing curl commands instead of JSON https://review.opendev.org/c/openstack/cyborg/+/994815
19:42:41 sean-k-mooney ya...
19:43:19 sean-k-mooney i dont mind also having curl example but just having them is annoying
19:44:06 sean-k-mooney melwitt: if your fixing that we can proably remove https://github.com/openstack/cyborg/blob/master/.pre-commit-config.yaml#L22 as well
19:44:26 melwitt ah good catch
19:44:38 melwitt I'm gonna try something locally and to do it I need these to be consistent heh
19:44:42 sean-k-mooney i had to put that in becauses i didnt feel like fixing it before
19:45:17 sean-k-mooney i hit that curl issue when i was adding pre-commit to the repo
19:45:18 melwitt yeah. looks like we need some irrelevant-files up in here too
19:45:44 sean-k-mooney i guess this is a docs only change
19:45:51 sean-k-mooney so ya wwe shoudl not be triggerign the tempest jobs
19:45:58 melwitt haha yeah
19:46:52 sean-k-mooney that not the end of the world but definlty good to add
19:50:10 opendevreview melanie witt proposed openstack/cyborg master: Fix api-ref request samples containing curl commands instead of JSON https://review.opendev.org/c/openstack/cyborg/+/994815
19:50:10 opendevreview melanie witt proposed openstack/cyborg master: Add api-ref/ to irrelevant-files in Zuul config https://review.opendev.org/c/openstack/cyborg/+/994816
22:54:39 opendevreview melanie witt proposed openstack/cyborg master: Add API sample structural validation tests https://review.opendev.org/c/openstack/cyborg/+/994830
#openstack-cyborg - 2026-06-25
07:12:51 opendevreview Ronelle Landy proposed openstack/cyborg master: Fix incorrect set syntax in placement client logging https://review.opendev.org/c/openstack/cyborg/+/994851
07:37:45 chandankumar sean-k-mooney: Hello, https://review.opendev.org/c/openstack/cyborg/+/992722 and https://review.opendev.org/c/openstack/cyborg/+/994816 are good to go, thank you!
08:30:02 opendevreview Ronelle Landy proposed openstack/cyborg master: Fix incorrect set syntax in placement client logging https://review.opendev.org/c/openstack/cyborg/+/994851
11:01:37 sean-k-mooney chandankumar: thanks for taking a look
12:49:17 opendevreview Ronelle Landy proposed openstack/cyborg master: Fix incorrect set syntax in placement client logging https://review.opendev.org/c/openstack/cyborg/+/994851
13:06:33 opendevreview Ronelle Landy proposed openstack/cyborg master: Fix incorrect set syntax in placement client logging https://review.opendev.org/c/openstack/cyborg/+/994851
15:47:47 opendevreview melanie witt proposed openstack/cyborg master: Add API sample structural validation tests https://review.opendev.org/c/openstack/cyborg/+/994830
18:27:44 opendevreview melanie witt proposed openstack/cyborg master: Add API sample structural validation tests https://review.opendev.org/c/openstack/cyborg/+/994830
20:14:15 opendevreview melanie witt proposed openstack/cyborg master: Add API sample structural validation tests https://review.opendev.org/c/openstack/cyborg/+/994830
20:37:32 opendevreview melanie witt proposed openstack/cyborg master: Add API sample structural validation tests https://review.opendev.org/c/openstack/cyborg/+/994830
22:01:50 opendevreview melanie witt proposed openstack/cyborg master: Add API sample structural validation tests https://review.opendev.org/c/openstack/cyborg/+/994830
#openstack-cyborg - 2026-06-26
07:46:06 opendevreview Ronelle Landy proposed openstack/cyborg master: Fix incorrect set syntax in placement client logging https://review.opendev.org/c/openstack/cyborg/+/994851
08:23:52 rlandy melwitt: hi https://review.opendev.org/c/openstack/cyborg/+/994851 has passing unit tests now. Could you review again when you get a chance? thank you
11:50:05 chandank` sean-k-mooney: Hello
11:50:59 chandankumar I need to update the cleanup state diagram and few cleanups in the nvme spec.
11:51:13 chandankumar Are you still reviewing it? or will I go ahead and make updates?
11:51:17 chandankumar thank you!
11:51:31 chandankumar sorry pinged on wrong channel earlier
13:08:30 sean-k-mooney chandankumar: im lookign that the mdev sepc currntly
13:08:37 sean-k-mooney i will get to yours after
13:08:40 sean-k-mooney was at lunch
14:02:36 chandankumar sean-k-mooney: thank you, I am working on few changes
14:36:31 opendevreview chandan kumar proposed openstack/cyborg-specs master: Add generic NVMe driver spec with secure cleanup https://review.opendev.org/c/openstack/cyborg-specs/+/985349
14:37:19 chandankumar jgilaber: thank you for those valuable comments, I have addressed it, thank you!
14:37:23 chandankumar sean-k-mooney: updated
14:37:40 jgilaber thanks chandankumar I'll look again on Monday
14:37:44 chandankumar sure
14:38:05 chandankumar on pci-sim implementation side, I have 4k changes , It support nvme list on host as well as in guest
14:38:21 chandankumar it also support nvme sanitize and zero write I think
14:38:28 chandankumar I will push the changes on monday
14:39:19 sean-k-mooney ok we will need to review that carfully
14:39:22 sean-k-mooney but that is promising
14:39:40 chandankumar all vide coded
14:40:06 chandankumar but it works, I need to take a look at code and restructure it when I get time
14:40:38 sean-k-mooney yes, i did many roudn of selfe review and reinemnet befor ei push the first public verion for review ot try and get the kernel driver ot follow the upstream kernel convetions and make it robost put also protable
14:41:03 sean-k-mooney so there are two portablities target i have in mind currently
14:41:31 sean-k-mooney 1 i want to make it so the pci-sim cna work on ubutnu 2026.04, debian 13 and eventualy centos 10 stream kernel
14:41:53 sean-k-mooney the other portablity seam is it would be nice to make it work on x86_64 adn aarch64 in the future
14:42:02 chandankumar this is what I have https://paste.openstack.org/raw/bBpYnMalpXkMgsaitSKi/
14:42:19 sean-k-mooney so we may need ot factor out some compaitbality code ectra to make that work
14:43:08 sean-k-mooney ya so Phase 2 — stock nvme driver binding via reserved-memory BAR0:
14:43:10 sean-k-mooney Uses boot-time reserved memory (memmap=SIZE$START) to back VF BAR0
14:43:12 sean-k-mooney addresses with real RAM.
14:43:14 sean-k-mooney is somehtin i wanted to avoid
14:43:41 sean-k-mooney i really dint want to bring that across form the nvmevirt approch if we coudl avoid it
14:44:09 chandankumar but it is needed for showing nvme on host
14:44:18 sean-k-mooney not nessiarly
14:44:30 chandankumar I was not getting other idea so borrowed from nvmevirt
14:46:13 sean-k-mooney i belive we can allcoate a much smaller ammoutn fo memroy and then back the nvme deevice with files on disk
14:47:00 sean-k-mooney chandankumar: anyway push it for review when you think its ready for that
14:47:08 sean-k-mooney and we can dicuss that in more detail
14:47:54 chandankumar min memmap reservation: 112 KB of reserved physical RAM, one 16 KB NVMe BAR0 region per VF
14:48:10 chandankumar ok pushing
14:49:18 sean-k-mooney so the pci-sim today does not preacllotate resreved memory
14:49:35 sean-k-mooney it allcoates a small amount at runtime for the pci config space and minimal bars
14:50:19 sean-k-mooney i expect we shoudl be able ot do the same for the nvem emulation (basiclly the contole regeiseter and command/data queues)

Earlier   Later