| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2026-06-23 | |||
| 14:35:31 | sean-k-mooney | an all cell scatter gather on ever schdule is expensive | |
| 14:35:40 | sean-k-mooney | but we can do it once per scdhuler restart | |
| 14:36:01 | sean-k-mooney | we woudl just need to document that in the upgrade release note | |
| 14:36:13 | sean-k-mooney | i.e. that a schduler restart is needed after all compute are upgraded | |
| 14:36:19 | sean-k-mooney | but that kind of needed anyway for other easons | |
| 14:37:00 | sean-k-mooney | im not conviced the prefilter is correct by the way | |
| 14:37:02 | jgilaber | ack, I think I'll need to update the release note for that | |
| 14:37:10 | sean-k-mooney | we can go into this in more detail in teh review | |
| 14:37:16 | jgilaber | sure | |
| 14:37:25 | sean-k-mooney | effectivly you will ned to include the triat request in the request group | |
| 14:37:30 | sean-k-mooney | not just root reqiures | |
| 14:37:47 | sean-k-mooney | but ya lets move to bugs unless there are other questions? | |
| 14:38:11 | sean-k-mooney | melwitt: ^ might be good to get your input on too | |
| 14:38:59 | sean-k-mooney | #topic bugs | |
| 14:39:11 | sean-k-mooney | first one | |
| 14:39:17 | sean-k-mooney | #link https://bugs.launchpad.net/openstack-cyborg/+bug/2157586 | |
| 14:39:22 | sean-k-mooney | Cyborg Device Profile API rejects OWNER_CYBORG trait | |
| 14:39:46 | sean-k-mooney | this came up while reviewing chandands spec i belvie | |
| 14:39:56 | sean-k-mooney | chandankumar: do you want to expand on it | |
| 14:40:23 | chandankumar | it came from here https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992210/4//COMMIT_MSG | |
| 14:40:33 | sean-k-mooney | oh yes your right | |
| 14:40:46 | chandankumar | I was adding scenario test for pci driver to create device profile there I found that | |
| 14:40:57 | sean-k-mooney | so the tl;dr is | |
| 14:41:02 | sean-k-mooney | cybrog device profiles | |
| 14:41:10 | sean-k-mooney | cannot currently request any standard traits | |
| 14:41:26 | sean-k-mooney | such as OWNER_CYBORG | |
| 14:41:50 | sean-k-mooney | this is a limitation that we should adress | |
| 14:41:57 | chandankumar | https://github.com/openstack/cyborg/blob/master/cyborg/api/controllers/v2/device_profiles.py#L211 | |
| 14:42:40 | sean-k-mooney | https://docs.openstack.org/api-ref/accelerator/#create-device-profile | |
| 14:42:47 | sean-k-mooney | if we look at the api ref | |
| 14:43:01 | sean-k-mooney | this is the descripton of the group field | |
| 14:43:05 | sean-k-mooney | """This is a list of dictionaries to describe returned accelerator resource by users, where users use keys to describe the resource_classes or traits and values to indicate its quantity or property. This is intentionally similar to extra_specs in nova flavor, and uses the same keywords for resources and traits. The key-value pair can either be a resource/trait or a Cyborg | |
| 14:43:07 | sean-k-mooney | property. Cyborg property is of the form “accel:<key>”: “<value>”. The valid key-value pairs can be found below.""" | |
| 14:43:41 | sean-k-mooney | the grousp is a dict of string key to string value | |
| 14:43:53 | sean-k-mooney | so from an api poirnt of view this is unversioned | |
| 14:44:03 | sean-k-mooney | and the limitation to CUSTOM_ triats is undocuemnted | |
| 14:44:41 | sean-k-mooney | there is some docuemition fo the valid accel: keys https://opendev.org/openstack/cyborg-specs/src/branch/master/specs/train/implemented/device-profiles.rst#valid-accel-keys | |
| 14:44:46 | sean-k-mooney | in the orginal spec | |
| 14:45:03 | sean-k-mooney | whic we really shoudl move into the api ref | |
| 14:45:13 | sean-k-mooney | but i think we can treat this as a valid bug | |
| 14:45:19 | sean-k-mooney | do others agree? | |
| 14:46:04 | sean-k-mooney | note requesting a standard trait via the device profile i think is ok. allowing you to add standard trait via the atirbute api is not | |
| 14:46:24 | sean-k-mooney | or at least not genericlly ok so this si really about the request | |
| 14:46:42 | sean-k-mooney | auto requestign OWNER_CYBORG while releated is also sperate | |
| 14:46:49 | chandankumar | yes, you mean to say device profile should accept any triat | |
| 14:46:50 | sean-k-mooney | as that has an upgrade impact | |
| 14:46:59 | sean-k-mooney | yes | |
| 14:47:18 | sean-k-mooney | and if the triat does not eixsti in the delooymen then you will just get a schduler fialure | |
| 14:47:45 | sean-k-mooney | but we shoudl jsut check it conforms to placment trait nameign shape | |
| 14:48:11 | chandankumar | good idea, first check about trait existance and then accept | |
| 14:48:35 | sean-k-mooney | i.e [A-Z_]* | |
| 14:48:48 | sean-k-mooney | well i dont think we need to check with placmeent if the trait exists although we could | |
| 14:49:11 | sean-k-mooney | but we should validate that it conforms to placment requirement for the name of a valid triat | |
| 14:49:25 | chandankumar | ok | |
| 14:49:37 | chandankumar | I will propose a patch | |
| 14:49:45 | sean-k-mooney | we coudl decied if we ant to check with the placment api in teh implemation review | |
| 14:49:55 | sean-k-mooney | woudl folks agree this shoudl be medium? | |
| 14:50:01 | chandankumar | yes | |
| 14:50:37 | jgilaber | yes, since this can be worked around | |
| 14:50:40 | sean-k-mooney | ok done feel free to assign this to yourself if you start working on it | |
| 14:51:10 | sean-k-mooney | next bug | |
| 14:51:31 | sean-k-mooney | #topic Set literals used instead of dicts in placement_client.py LOG calls | |
| 14:51:41 | sean-k-mooney | #link https://bugs.launchpad.net/openstack-cyborg/+bug/2157892 | |
| 14:51:57 | sean-k-mooney | melwitt: you found this one | |
| 14:52:29 | melwitt | oh yes that was opened by me yesterday. just something I noticed while going over code in general | |
| 14:53:28 | sean-k-mooney | https://github.com/openstack/cyborg/blob/master/cyborg/common/placement_client.py#L313 | |
| 14:53:33 | sean-k-mooney | that looks pretty valid to me | |
| 14:53:55 | jgilaber | yes, this looks valid and a good find | |
| 14:53:56 | melwitt | yeah that should also be "%(rc_name)s" there too | |
| 14:54:07 | sean-k-mooney | its even correct like 4 lines up | |
| 14:54:09 | sean-k-mooney | https://github.com/openstack/cyborg/blob/master/cyborg/common/placement_client.py#L308 | |
| 14:54:25 | melwitt | heh yeah. not sure what happened there | |
| 14:54:42 | sean-k-mooney | im feeling like traged, low | |
| 14:54:51 | sean-k-mooney | given its only a log issue | |
| 14:54:53 | melwitt | ++ | |
| 14:55:10 | jgilaber | +1 | |
| 14:55:25 | sean-k-mooney | cool i tagged it low-haning-fruit as well | |
| 14:55:52 | sean-k-mooney | melwitt: so ya if you paln to work on it feel free to assign it to your self as normal but anything else on this? | |
| 14:56:34 | sean-k-mooney | if not we will move on | |
| 14:56:44 | melwitt | sure, no that was all on this | |
| 14:56:51 | sean-k-mooney | i need to file a bug for this but ill just note it as an fyi | |
| 14:57:00 | sean-k-mooney | i found out that our api microverison parsing is incorrect | |
| 14:57:09 | sean-k-mooney | i have the fix locally | |
| 14:57:35 | sean-k-mooney | but tl;dr cybrog was incorrectly updated to expec Openstack-Api-Version: 2.x | |
| 14:57:52 | sean-k-mooney | instead of Openstack-Api-Version: accelerators 2.x | |
| 14:58:02 | sean-k-mooney | and we later removed microvsrion pasrse as a dep | |
| 14:58:12 | sean-k-mooney | that was change 2 years ago | |
| 14:58:18 | sean-k-mooney | that was wrong and it breaks the sdk ectra | |
| 14:58:41 | opendevreview | chandan kumar proposed openstack/cyborg-specs master: Add generic NVMe driver spec with secure cleanup https://review.opendev.org/c/openstack/cyborg-specs/+/985349 | |
| 14:58:47 | sean-k-mooney | so ill file a bug to track that | |
| 14:58:54 | sean-k-mooney | last itme for today | |
| 14:59:08 | sean-k-mooney | we have notign in open dicuss | |
| 14:59:25 | melwitt | ouch. so I guess you mentioned this before but that means we lack openstacksdk job running on cyborg repo right | |
| 14:59:26 | sean-k-mooney | are there any volunteers for the next meeting | |
| 14:59:44 | sean-k-mooney | so the sdk case might have a workaround | |
| 15:00:05 | sean-k-mooney | i noticed that nova is not using the sdk its using the wraw keystone auth client | |
| 15:00:13 | sean-k-mooney | and when i tried to use a new microveriosn it broek | |
| 15:00:36 | sean-k-mooney | so i need to validate if the sdk has a workaroudn or if its only broken for keystonatuth client | |
| 15:00:57 | sean-k-mooney | but we ill need to support both shapes for the forseable future | |
| 15:01:30 | jgilaber | I can chair next week's meeting | |