Earlier  
Posted Nick Remark
#openstack-cyborg - 2026-06-09
14:29:41 sean-k-mooney one thing that would help is some ascii diagrams in the spec
14:29:46 sean-k-mooney to visually show how this works
14:30:24 sean-k-mooney we have 2 related concepts in cybrogs api devices and deployables
14:30:32 jgilaber good point I'll add some diagrams, it was confusing for me too
14:30:54 jgilaber but if I understood correctly, in cyborg the resrouce provider is created from a DriverDeployable
14:31:10 jgilaber not from a DriverDevice
14:32:19 sean-k-mooney so the only way we woudl supprot more then one mdev type per phsyica device
14:32:27 sean-k-mooney is if we were addign the VFs
14:33:00 sean-k-mooney with that said we coudl aslo suffix the pci adress in the rp name
14:33:02 sean-k-mooney with the type
14:33:09 sean-k-mooney so i think we coudl workaroudn that limiation
14:33:20 sean-k-mooney but we may want to think about the modelign more
14:33:31 sean-k-mooney in nova we started with 1 type per device
14:33:38 sean-k-mooney so that woudl eb a reasonable limiation fro v1
14:33:56 sean-k-mooney the nvidia driver didnt supprotr multipel asfar as im aware either
14:34:06 jgilaber that is my understanding yes, the simplest workaround would be one DriverDeployable for each mdev type
14:34:31 sean-k-mooney can you write up some of the options in the spec
14:34:39 sean-k-mooney and we can discuss the tradeoffs
14:34:43 jgilaber the nvidia driver just picks the first vgpu type it finds and uses that to create the rp
14:34:55 sean-k-mooney i see
14:34:57 jgilaber sure, I already have some of this but I'll expand with the diagrams
14:35:00 sean-k-mooney that less then useful
14:36:27 sean-k-mooney that comemnt was it picking the first one
14:36:41 sean-k-mooney jgilaber: did you have any other questions you wanted to raise
14:37:05 jgilaber no, thanks, the rest of the feedback was clear and I think I addressed it all
14:37:26 chandankumar thank you jgilaber
14:37:30 chandankumar moving to last review
14:37:42 chandankumar #link SRBAC: https://review.opendev.org/q/topic:%22bp/consistent-and-secure-rbac%22
14:38:04 chandankumar #link srbac spec https://review.opendev.org/c/openstack/cyborg-specs/+/991932
14:38:13 chandankumar sean-k-mooney: do you want to take it
14:38:21 sean-k-mooney sure
14:38:34 sean-k-mooney so this is one of 2 specs im planing to work on this cycle
14:38:48 sean-k-mooney part of the work was already compelted as part fo the CVE fixes
14:39:03 sean-k-mooney that focused on geting a secure baselien for api policy
14:39:16 sean-k-mooney the spec covers the 3 phases of the srbac comunity goal
14:39:29 sean-k-mooney it intnet for this cycle ist to supprot all standard roels
14:39:43 sean-k-mooney admin, manager, member, reader and service
14:39:55 sean-k-mooney i have mostly implemtned the spec already
14:40:00 sean-k-mooney including tmpest tests
14:40:08 sean-k-mooney but i woudl liek to ask for folks to review the spec
14:40:25 sean-k-mooney with attention pated to the polices/personas mapped to each api endpoint
14:40:45 sean-k-mooney basiclly ask does it make sense for this persona to eb able to call this api
14:41:08 sean-k-mooney i have 1 small bug in the cybrog patches which isll fix today/tomorrow
14:41:17 sean-k-mooney its technical debt form the cve fixes
14:41:27 sean-k-mooney that i want to think about a little more before fixing
14:41:44 sean-k-mooney the simple fix is trivali but im thinkign fo cleaning up a little more tech debt while im there
14:41:56 sean-k-mooney any questions on the effort or in general?
14:42:40 jgilaber not really, I've added the spec to my review list, I hope to get to it by the end of the week
14:42:53 chandankumar thank you for all the patches and spec, will go over the spec and have feedback there
14:42:55 sean-k-mooney in the spec i detail the timelien as well. this cycle suprpot the new polices, 2027.1 make the new polices the default and 2027.2 delete the old code
14:43:07 sean-k-mooney oh before i forget
14:43:27 sean-k-mooney after the patches on the tempest plugin i also did the ruff and pre-commit work for that repo
14:44:03 sean-k-mooney i coudl have doen that first but i had alrady written the patches :)
14:44:23 sean-k-mooney so if folk want me to do that first i can mvoe it to the front
14:45:06 sean-k-mooney one goal i have is to compelte that for all the cybrog and watcher repos
14:45:22 jgilaber I think it's fine, we don't have a lot of open patches so it won't be a problem to rebase
14:45:30 chandankumar anything is fine
14:45:42 sean-k-mooney ok ill leave it where it is for now then
14:45:51 sean-k-mooney thats all i had on that
14:46:09 chandankumar thank you sean-k-mooney!
14:46:21 chandankumar Since we donot have any bugs moving to open discussion
14:46:34 chandankumar #topic Open Discussion
14:46:46 chandankumar I see an item there
14:46:52 chandankumar #topic driver support level
14:47:08 chandankumar I think sean-k-mooney has added it
14:47:12 sean-k-mooney ya more an fyi form me
14:47:29 sean-k-mooney so im planning to start on the patch to add the supprot levels to our docs
14:47:38 sean-k-mooney either later this week or next
14:47:49 sean-k-mooney but ill try and prepare that for review before the next meeting
14:47:57 sean-k-mooney that was basiclly it
14:48:07 chandankumar thank you!
14:48:13 chandankumar Moving to last one
14:48:26 chandankumar #topic volunteer to chair next meeting
14:48:47 chandankumar Anyone wants to chair next meeting?
14:48:56 rlandy I can do it
14:49:06 rlandy haven't done one of these in a while
14:49:18 sean-k-mooney works for me, welcome back
14:49:24 chandankumar thank you rlandy !
14:49:34 rlandy no problem
14:49:38 chandankumar time to close the meeting
14:49:45 chandankumar thank you all for attending!
14:49:49 chandankumar #endmeeting
14:49:49 opendevmeet Meeting ended Tue Jun 9 14:49:49 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
14:49:49 opendevmeet Minutes: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-09-14.00.html
14:49:49 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-09-14.00.txt
14:49:49 opendevmeet Log: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-09-14.00.log.html
14:49:57 jgilaber thanks chandankumar
14:51:51 sean-k-mooney jgilaber: to your point ealier https://github.com/openstack/cyborg/blob/master/cyborg/accelerator/drivers/pci/base.py#L21
14:51:59 sean-k-mooney most of the dirver dont inherit form base
14:52:35 sean-k-mooney one of of the openquetion i have is do we want ot use a base clss or a protocol to defien the internfce
14:52:55 sean-k-mooney either works and a common base class has its advangates as woudl a mixin for the common functionatliy
14:53:57 sean-k-mooney for the new medev dirver you shoudl inherit form https://github.com/openstack/cyborg/blob/master/cyborg/accelerator/drivers/driver.py#L17
14:55:04 sean-k-mooney but in genreal i think i want to spend some time thinking about restucture the repo a bit next cycel to normalise the code base a bit
14:55:45 sean-k-mooney for exampel we shoudl not ahve any config stuff https://github.com/openstack/cyborg/blob/master/cyborg/accelerator/configuration.py outside fo https://github.com/openstack/cyborg/tree/master/cyborg/conf
14:56:00 sean-k-mooney and there shoudl not be any db code
14:56:02 sean-k-mooney https://github.com/openstack/cyborg/blob/master/cyborg/accelerator/accelerator.py
14:56:18 sean-k-mooney outside of https://github.com/openstack/cyborg/tree/master/cyborg/db
14:56:32 sean-k-mooney but i suspect at elast some fo this code is deadcode
14:57:08 sean-k-mooney so the dirver not ineritign form the base driver is just one of the peices fo tehcnial debt we need to clean up in the repo layout
14:57:24 jgilaber I'll double check but I think I have it already in my spec, but yes either way it would work

Earlier   Later