Earlier  
Posted Nick Remark
#openstack-cyborg - 2026-05-19
14:18:43 sean-k-mooney its a fully feature
14:19:03 sean-k-mooney ya it was broken form day one
14:19:04 chandankumar The image verification piece I mean? Not the whole program feature
14:19:10 sean-k-mooney so im inclidned ot remvoe it and start fresh
14:19:20 chandankumar verify_glance_signatures = True this part
14:19:25 sean-k-mooney right
14:19:42 sean-k-mooney that has never worked so im inclidne to say we shoudl treat it as a new feature
14:19:51 sean-k-mooney its not something we woudl beackport in my opiopion
14:20:02 chandankumar if we check the config, https://github.com/openstack/cyborg/blob/186cdd2b76aff57233660042f71761383285e5e8/cyborg/conf/glance.py#L56
14:20:46 chandankumar it talks about key_manager which does not implemented in cyborg and deprecated config https://github.com/openstack/cyborg/blob/186cdd2b76aff57233660042f71761383285e5e8/cyborg/conf/glance.py#L63
14:20:54 chandankumar I was not sure how to remove the code
14:21:12 chandankumar Do we want to drop the config or keep the config and raise a warning with no implemented?
14:21:42 sean-k-mooney if we remove it we will baskiclly revert the pat
14:21:51 sean-k-mooney as i said this never work
14:22:00 sean-k-mooney so there cant be any exsitng usage
14:22:53 chandankumar ok, I will work on the patch for removal
14:22:56 sean-k-mooney we woudl need to have a release note for the removal of teh feature
14:23:37 chandankumar sure
14:23:43 chandankumar that's it on this review
14:24:12 jgilaber ack let's move to the next one
14:24:14 jgilaber #link https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/988597
14:24:37 chandankumar this one is also mine, It adds uuid to cyborg tempest plugin tests for all api and scenario tests
14:25:24 chandankumar Please add this one to your review queue
14:25:44 jgilaber I'll review properly after the meeting but from a quick look lgtm, thanks for adressing this chandankumar
14:26:31 jgilaber moving on
14:26:41 jgilaber #link https://review.opendev.org/c/openstack/cyborg/+/984508
14:27:09 sean-k-mooney chandankumar: +2w on the tepemst plugin patch
14:27:14 chandankumar this one adds multinode devstack job for cyborg testing.
14:27:49 chandankumar sean-k-mooney: thank you!
14:27:50 sean-k-mooney ya i think that is also good to go ill loop back to in shortly
14:28:07 jgilaber this lgtm as well
14:28:33 jgilaber final one
14:28:34 jgilaber #link https://review.opendev.org/c/openstack/cyborg/+/987097
14:28:55 chandankumar it is from takashi to drop microversion-parse unused deps
14:29:44 sean-k-mooney is gerrit having issue loadign for ye
14:30:30 jgilaber working fine for me
14:30:34 sean-k-mooney the second change id is incroeect it shoudl have been for https://review.opendev.org/c/openstack/cyborg/+/905646
14:30:41 sean-k-mooney i just need to refresh
14:31:14 chandankumar ok
14:32:15 chandankumar that's it on review jgilaber you can move to the next section
14:32:33 jgilaber ack, thanks
14:32:34 jgilaber moving on to bugs
14:32:39 jgilaber #topic Bugs
14:32:45 jgilaber we have two today
14:32:54 jgilaber first one
14:32:55 jgilaber #link https://bugs.launchpad.net/openstack-cyborg/+bug/2152545
14:33:20 chandankumar I opened this one lspci Command Execution and Parsing Code Duplication last week to track lspci code parsing duplication
14:33:38 chandankumar since it is a tech debt
14:33:55 chandankumar sean-k-mooney is also looking to adding more tech debts
14:33:56 jgilaber I think we can treat this as a wishlist bug
14:34:00 sean-k-mooney triaged and whishlist
14:34:15 jgilaber +1, doing that now
14:34:25 sean-k-mooney i think having this as a tracker is fien i just dont know if we want to adress it as part of a larger effort
14:35:13 jgilaber we could do it both ways
14:35:33 sean-k-mooney we proably will want to do it as a genera targeted refactor
14:35:41 chandankumar yes, do smaller fixes without breaking the whole
14:36:11 sean-k-mooney with that said i have some action form the ptg to follwo up on inlcuding markign driver as experiemtnal or deprecated
14:36:28 sean-k-mooney so dependign on how we proceed with that we may decied to not fix all of them
14:37:00 sean-k-mooney i have not sat down and gone through the list of all fo them yet to see where they are but i may try to do that an propose an inital patch in the next week or two
14:37:49 chandankumar we will also discussing about moving these driver https://github.com/openstack/cyborg/blob/master/cyborg/accelerator/drivers/fpga/intel/driver.py#L42 to sub package which has binary ivolved?
14:38:17 chandankumar ok
14:39:14 jgilaber any other comment on this bug?
14:39:25 chandankumar nope
14:39:48 jgilaber ok, moving to the last one
14:39:54 jgilaber #link https://bugs.launchpad.net/openstack-cyborg/+bug/2152616
14:40:25 chandankumar we discussed about this one during python-cyborgclient fix
14:40:35 jgilaber right
14:40:38 chandankumar It would be a feature not a bug
14:40:44 jgilaber do we have a bug tracker for the client?
14:41:07 chandankumar https://bugs.launchpad.net/python-cyborgclient/
14:41:13 chandankumar yes, my bad
14:41:18 chandankumar we need to move this bug there
14:41:46 jgilaber yes, and I think it's a valid bug for the client
14:42:01 jgilaber medium importance?
14:42:09 chandankumar yes
14:42:15 sean-k-mooney medium seams fine
14:42:26 sean-k-mooney and ya we can mark it involade for cybrog and triaged for the client
14:42:50 jgilaber done, looks like we're set for today
14:42:59 jgilaber any topci for the open discussion?
14:43:22 sean-k-mooney i guess a quick update
14:43:35 chandankumar https://review.opendev.org/c/openstack/releases/+/988076: Release python-cyborgclient for Hibiscus-1 milestone have review proposed
14:43:41 chandankumar for hibiscus-1 milestone
14:44:02 sean-k-mooney the m1 release were due last week
14:44:17 sean-k-mooney we can proceed with it and we can do more release as and when needed
14:44:33 jgilaber yes I saw today that I missed the notification for that patch
14:46:16 sean-k-mooney on a seperate note i brought up https://blueprints.launchpad.net/nova/+spec/support-vfio-variant-driver-managed-mode-via-cyborg
14:46:33 sean-k-mooney in the nova metting yesterday adn we aggeed to track that as a specless blueprint
14:46:59 sean-k-mooney i have filet the corresponding cyborg blueprint https://blueprints.launchpad.net/openstack-cyborg/+spec/support-vfio-variant-driver-managed-mode and spec https://review.opendev.org/c/openstack/cyborg-specs/+/989003
14:47:33 jgilaber that is good news, thanks sean-k-mooney
14:47:33 sean-k-mooney so this is just allowing cyborg managed pci device to use vfio-vairiant drivers
14:47:40 jgilaber I'll try to review the spec this week
14:47:44 chandankumar thank you sean-k-mooney for sharing it, I will go throgh it
14:48:12 sean-k-mooney no rush
14:48:33 sean-k-mooney i will try and review the nvme and generic mdev spec later in the week as well
14:48:42 sean-k-mooney that about all i had for today
14:48:53 chandankumar Just one more update: I will be out tomorrow till May 27.
14:49:07 sean-k-mooney enjoy the break
14:49:17 jgilaber ack, enjoy the time off chandankumar!
14:49:18 chandankumar thank you!
14:49:52 jgilaber before closing, any volunteers to chair next meeting?

Earlier   Later