| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2026-04-01 | |||
| 12:31:41 | chandankumar | https://review.opendev.org/c/openstack/python-cyborgclient/+/928258/1#message-93732aabc5b3bc3dffc2e66d0022a83fa41ab037 | |
| 12:31:48 | chandankumar | tox jobs except pep8 | |
| 12:32:12 | chandankumar | https://review.opendev.org/c/openstack/python-cyborgclient/+/943714/1#message-52854be5dadc03bbadaf2a199387cb3737b92e3f | |
| 12:32:18 | sean-k-mooney | that not really the corerct fix for the python ones | |
| 12:32:29 | sean-k-mooney | alhtohg maybe that what we need to do without some other changes | |
| 12:34:04 | sean-k-mooney | we do not pin it in nova or watcher client | |
| 12:35:59 | chandankumar | yes, we did it in watcher repo for docs https://opendev.org/openstack/watcher/commit/9b5babfbcbc66c6d9298d3c8ddaf8ea42576aaf1 | |
| 12:36:02 | sean-k-mooney | oh i think i might see the issue | |
| 12:36:20 | sean-k-mooney | python-cyborgclient is missing it pyproject.toml | |
| 12:36:32 | sean-k-mooney | which means it is not proprly using pbr to build on the sable branches | |
| 12:36:49 | sean-k-mooney | the fix woudl be to add https://github.com/openstack/python-novaclient/blob/stable/2025.1/pyproject.toml | |
| 12:37:39 | sean-k-mooney | lets fix that on master | |
| 12:38:01 | chandankumar | proposing patch | |
| 12:38:03 | sean-k-mooney | and try cherry-picking it ot the older brnaches adn see if that resolves the issues | |
| 12:47:37 | opendevreview | chandan kumar proposed openstack/python-cyborgclient master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/python-cyborgclient/+/983046 | |
| 12:53:26 | chandankumar | ok | |
| 13:05:33 | chandankumar | sean-k-mooney: https://review.opendev.org/c/openstack/python-cyborgclient/+/983051/1#message-fb3303afcbd5d567f6b358030894bb0b0b67e1a8 with pyproject.toml changes, it is still failing with same error. | |
| 13:06:43 | chandankumar | Requirement already satisfied: setuptools in ./.tox/py39/lib/python3.9/site-packages (from pbr!=2.1.0,>=2.0.0->-r /home/zuul/src/opendev.org/openstack/python-cyborgclient/requirements.txt (line 4)) (82.0.0) is used there | |
| 13:07:12 | chandankumar | I think we need to avoid installing this version in pyproject.toml also | |
| 13:09:15 | sean-k-mooney | let me double check | |
| 13:09:56 | sean-k-mooney | but we shoudl not need too | |
| 13:10:02 | sean-k-mooney | we are requireign >6 | |
| 13:10:17 | sean-k-mooney | 6.somthing in pre-commit | |
| 13:10:35 | sean-k-mooney | https://github.com/openstack/python-cyborgclient/blob/master/requirements.txt#L4 is a lot lower then we actully need | |
| 13:11:29 | chandankumar | python-watcherclient uses pbr!=2.1.0,>=3.1.1 # Apache-2.0 | |
| 13:12:00 | sean-k-mooney | ya we dont nee the !=2.1.0 part | |
| 13:12:17 | sean-k-mooney | nova client just has pbr>=3.0.0 # | |
| 13:12:33 | sean-k-mooney | but our actual reqiremetnis >6.1.0 i think | |
| 13:12:59 | sean-k-mooney | or >=5.7.0 as the acual min that works with pyproject.toml | |
| 13:13:54 | sean-k-mooney | nova has >=5.8.0 in requiremets.txt | |
| 13:13:56 | sean-k-mooney | https://github.com/openstack/nova/blob/master/requirements.txt#L5C1-L5C24 | |
| 13:14:05 | sean-k-mooney | so lets go with that for now | |
| 13:14:31 | sean-k-mooney | that what they have on 2024.2 as well | |
| 13:14:33 | sean-k-mooney | https://github.com/openstack/nova/blob/stable/2024.2/requirements.txt#L5 | |
| 13:14:47 | sean-k-mooney | so we know that we at least have that aviabel | |
| 13:15:37 | chandankumar | Can I include pbr change in pyproject.toml itself ? I will keep the same in requirements and pyproject.toml | |
| 13:16:37 | sean-k-mooney | update both | |
| 13:21:51 | chandankumar | ok | |
| 13:23:14 | sean-k-mooney | there may be other work requried to fix this properly but you shoudl be abel to repoduce the issues locally just runnign tox | |
| 13:24:14 | sean-k-mooney | i makde sure this was all fixed in cybrog beofre the release but i forgot to do it for the client repo so my bad on that | |
| 14:59:36 | chandank` | sean-k-mooney: I am not able to reproduce that locally with tox -e py39 or tox -e py312 locally | |
| 15:00:05 | chandank` | I proposed https://review.opendev.org/c/openstack/python-cyborgclient/+/983073 to pin setuptools for 2025.1 | |
| 15:00:09 | chandank` | ci job passes here | |
| 15:02:28 | sean-k-mooney | so directlly im not ok wiht pins like that in genral unless they are tempeory | |
| 15:02:58 | sean-k-mooney | chandank`: policy wise project are not ment to cap or pin depencies in genreal. this is slightly diffent | |
| 15:03:19 | chandank` | yes I agree. But I am not able to get a reproducer | |
| 15:04:30 | sean-k-mooney | that is because this depend on the version of setuptools and virual env you have i think so you would likely need to repoduce on ubuntu | |
| 15:05:15 | chandank` | I tried with ubuntu noble with py312 same here. Setuptools 82.0.1 is getting installed there | |
| 15:13:24 | sean-k-mooney | yes and that is ok | |
| 15:13:58 | sean-k-mooney | on 2025.1 we have backported the change sin other repos to make it compatible | |
| 15:14:17 | sean-k-mooney | let me take a look in a few minutes | |
| 15:14:36 | sean-k-mooney | we might proceed with the pin for now to unblock things but we shoudl fix it properly | |
| 15:14:43 | sean-k-mooney | the ping woudl only be ok on stable | |
| 15:15:00 | sean-k-mooney | master need to remain unpinned | |
| 15:16:06 | chandank` | https://paste.openstack.org/raw/bHvAJfuJzCW2OXVMYhZP/ | |
| 15:16:32 | chandank` | I am pinning it on stable/2025.1 only | |
| 15:16:44 | chandank` | and will backport it to 2024.2 to ubblock CI | |
| 15:17:20 | chandank` | sure, | |
| 15:17:44 | chandank` | feel free to leave your comments based on your investigation | |
| 15:17:52 | chandank` | I will take a look tomorrow morning | |
| 15:19:51 | chandank` | 983073: [Stable-only][CI] Pin setuptools | https://review.opendev.org/c/openstack/python-cyborgclient/+/983073 for 2025.1 is the review pin for 2025.1 only | |
| 15:45:55 | sean-k-mooney | https://paste.opendev.org/show/bPESsYNpkOOQju6gLKuu/ | |
| 15:45:59 | sean-k-mooney | i can repoduce it locally | |
| 16:10:33 | sean-k-mooney | https://review.opendev.org/c/openstack/python-cyborgclient/+/983051 fixes it but i need to od that properly on master and backport it | |
| 16:11:07 | sean-k-mooney | i think we will have to squash it into https://review.opendev.org/c/openstack/python-cyborgclient/+/943715/1 and make the .gitreview patch go after to get it to pass ci | |
| 16:11:10 | sean-k-mooney | or squash all 3 | |
| #openstack-cyborg - 2026-04-02 | |||
| 07:05:21 | chandankumar | sean-k-mooney: hello, thank you for the reproducer. | |
| 07:05:45 | chandankumar | tox -e docs is still failing with Could not import extension openstackdocstheme (exception: No module named 'pkg_resources') | |
| 07:06:20 | sean-k-mooney[m] | For the docs job we did pin it | |
| 07:06:50 | sean-k-mooney[m] | Because that need a new release on stable to fix and a uc bump | |
| 07:06:58 | chandankumar | ah you are so early. | |
| 07:07:45 | sean-k-mooney[m] | I’m still waking up and watching YouTube | |
| 07:07:51 | sean-k-mooney[m] | I’ll probably start working in an hour or so | |
| 07:08:12 | chandankumar | Let me pin that in the same patch. | |
| 07:08:49 | chandankumar | for 2025.1 only and squash 3 commits together with .gitreview and tox constriants changes | |
| 07:08:56 | chandankumar | thank you! | |
| 07:12:12 | sean-k-mooney[m] | Ya that sounds reasonable | |
| 07:17:29 | opendevreview | chandan kumar proposed openstack/python-cyborgclient master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/python-cyborgclient/+/983046 | |
| 07:32:25 | opendevreview | chandan kumar proposed openstack/python-cyborgclient master: Modernize tox configuration https://review.opendev.org/c/openstack/python-cyborgclient/+/983164 | |
| 08:57:51 | opendevreview | Merged openstack/python-cyborgclient master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/python-cyborgclient/+/983046 | |
| 09:07:22 | opendevreview | chandan kumar proposed openstack/python-cyborgclient master: Modernize tox configuration https://review.opendev.org/c/openstack/python-cyborgclient/+/983164 | |
| 09:20:47 | chandankumar | sean-k-mooney 2025.1 backport needs one more revision | |
| 09:23:09 | chandankumar | ah I created a new commit https://review.opendev.org/c/openstack/python-cyborgclient/+/983172 for 2025.1 | |
| 09:23:12 | chandankumar | fixing that | |
| 09:28:40 | opendevreview | Merged openstack/python-cyborgclient master: Modernize tox configuration https://review.opendev.org/c/openstack/python-cyborgclient/+/983164 | |
| 09:33:13 | chandankumar | sean-k-mooney: for 2025.1 , I have included all of the changes in a single one https://review.opendev.org/c/openstack/python-cyborgclient/+/983051 | |
| 09:33:48 | chandankumar | including tox modernization | |
| 09:39:37 | chandankumar | ignore that, I will break into 3 | |
| 10:05:56 | sean-k-mooney | which ever actully works | |
| 10:06:21 | sean-k-mooney | if you need it to be in 1 we can live withthat but if we can merge them sepreate in a sapecific order that is preferabel | |
| 10:08:18 | chandankumar | all sorted | |
| 10:08:19 | chandankumar | now | |
| 10:08:50 | sean-k-mooney | cool ill let those run trhough ci and hopefully we can get all those merged today. thanks for working on it | |
| 10:14:54 | chandankumar | all good here https://review.opendev.org/q/project:openstack/python-cyborgclient+branch:stable/2025.1 | |
| 10:15:03 | chandankumar | once it merges, I need to do the same for 2024.2 | |
| 10:19:45 | sean-k-mooney | sounds good. 2024.2 will be eol very soon but if we have time to fix it then that fine | |
| 10:20:16 | sean-k-mooney | i know we tag branches wehn we eol them but i dont know if we do a release automaticly | |
| 10:20:35 | sean-k-mooney | we sometimes intentually do a release but there has been no change tot he branch since it was created | |
| 10:20:40 | sean-k-mooney | so there is nothing to release | |
| 10:21:45 | sean-k-mooney | ok those are all green now ill start merging them form newest to oldest over the next hour or so | |