| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2026-03-03 | |||
| 14:16:00 | sean-k-mooney | once rc1 is tagged the stabel branch will be created and master will be 2026.2 at that point | |
| 14:16:12 | sean-k-mooney | does that sound reasonabel to folks? | |
| 14:16:32 | jgilaber | sounds good, I'll review the linters series later today | |
| 14:17:03 | sean-k-mooney | thanks that proably a good segway to the reviews topic | |
| 14:17:11 | jgilaber | yep | |
| 14:17:13 | sean-k-mooney | the first being the linters serise | |
| 14:17:17 | jgilaber | #topic reviews | |
| 14:17:24 | jgilaber | #link https://review.opendev.org/q/topic:%22linters%22+is:open+project:openstack/cyborg | |
| 14:17:45 | sean-k-mooney | so the last patch in that serisee complete the move to ruff for formating | |
| 14:18:04 | sean-k-mooney | the earleir patchs are enabling sets of linter and fixign the issues found | |
| 14:18:23 | sean-k-mooney | so the last patch is just whitespace formating change and makeign sure its enfoced by the pep8 job | |
| 14:18:37 | sean-k-mooney | the eailer patchs fix the lint issues found | |
| 14:19:02 | sean-k-mooney | slighlty off topic but we agreed that i will do the saem in watcher after RC1 | |
| 14:19:22 | sean-k-mooney | but i expect to update python-cyborg client and the tempest plugin after rc1 as well | |
| 14:20:18 | sean-k-mooney | the lint changes for the other repos will not be part of the 2026.1 release as a result which is ok | |
| 14:20:40 | jgilaber | any question/comment on these patches? | |
| 14:20:41 | sean-k-mooney | if there are any concerns please let me knwo | |
| 14:21:24 | jgilaber | thanks sean-k-mooney, moving to the next review | |
| 14:21:25 | jgilaber | #link https://review.opendev.org/c/openstack/cyborg/+/978725 | |
| 14:21:42 | jgilaber | this is a fix for https://launchpad.net/bugs/1987380 | |
| 14:22:07 | bogdando[m] | it needs more work for migration paths | |
| 14:22:07 | sean-k-mooney | yep bogdando[m] started working on ^ | |
| 14:22:35 | sean-k-mooney | bogdando[m]: it might actully function as is but we need to confirm what happens in those edgcases | |
| 14:22:41 | sean-k-mooney | and proably add some testing | |
| 14:23:07 | sean-k-mooney | directionally the patch looks correct | |
| 14:23:56 | sean-k-mooney | bogdando[m]: do you have access to test this on real hardware with this issue | |
| 14:24:03 | sean-k-mooney | i.e. a sriov capable nvida gpu | |
| 14:24:24 | bogdando[m] | I am not sure there would be real migration paths, given that no functional deployments will be possible for VFs by nvidia driver until kernels support vfio variant driver?.. | |
| 14:24:53 | sean-k-mooney | so that not the limitation exactly | |
| 14:25:10 | sean-k-mooney | it was possibel to passthough the vf it just would not function correctly in the guest | |
| 14:25:17 | sean-k-mooney | my conder is not for the workload | |
| 14:25:22 | sean-k-mooney | it for the cybrog service | |
| 14:25:40 | sean-k-mooney | we need to ensure that if ther is an allcoation in place that is handeled gracefully | |
| 14:26:11 | bogdando[m] | we cannot filter out VFs in such a case? | |
| 14:26:22 | sean-k-mooney | that can be refusing the remove the resocue provider and deployable until the allcoation is deleted with a loud error message | |
| 14:26:35 | sean-k-mooney | bogdando[m]: we can but not the ones that are currently assigned | |
| 14:26:42 | bogdando[m] | ack | |
| 14:26:53 | sean-k-mooney | so nova has a protection for this for the pci tracker | |
| 14:27:01 | sean-k-mooney | if you remove a device form the devspec | |
| 14:27:04 | bogdando[m] | wrt HW to test, I could use hardware, but no way to install cyborg there yet | |
| 14:27:15 | sean-k-mooney | we will not remove it form the db until it is freeded by a vm that was assigned to it | |
| 14:27:30 | sean-k-mooney | bogdando[m]: ack that is fine for now | |
| 14:28:27 | sean-k-mooney | while we will eventually want to do more hadware based testing we can simulate the test env for the short term in unit tests | |
| 14:28:52 | sean-k-mooney | i assume the lspci data you used in the test came form a real system | |
| 14:29:08 | sean-k-mooney | thats why i was asking if you had access | |
| 14:29:13 | bogdando[m] | it looks real, yes | |
| 14:31:38 | sean-k-mooney | i didnt really have any other questions to ask | |
| 14:31:47 | bogdando[m] | simulating test env with minimal services to have placement db would be great | |
| 14:32:13 | sean-k-mooney | adding fucntional tests like nova has with the palcment fixture | |
| 14:32:20 | sean-k-mooney | is definetly soemting we shoudl build | |
| 14:32:30 | sean-k-mooney | just not in that bug fix | |
| 14:32:45 | bogdando[m] | right | |
| 14:32:55 | sean-k-mooney | the placement-fixture form placement provide a placement api backed by sqlite | |
| 14:33:15 | sean-k-mooney | which you can use in your tests witouth actully deploying placmenet seperatly | |
| 14:33:24 | sean-k-mooney | that allows you to test the end to end behavior | |
| 14:33:47 | bogdando[m] | so we can build the migration path like you noted w/o func tests yet in that patch, right? | |
| 14:34:28 | sean-k-mooney | what i think we need to do is test how cyborg handels removal of placemetn rps and deployables in general | |
| 14:34:39 | sean-k-mooney | so we can test that with the pci driver for example | |
| 14:34:53 | sean-k-mooney | then based on that we can determin how to proceed with the nvidia driver | |
| 14:35:46 | sean-k-mooney | the management of the placment inventories and deployables shoudl not be driver dependnet in general but we will need to review how that works today | |
| 14:36:05 | sean-k-mooney | if we find that will break | |
| 14:36:14 | sean-k-mooney | then we may put the fix behind a config option for now | |
| 14:36:35 | sean-k-mooney | so that you can move forward with the simple fix which will for for 99% of deployments | |
| 14:36:51 | sean-k-mooney | and we can defer the upgrade question to a sperate patch | |
| 14:37:07 | bogdando[m] | makes sense | |
| 14:38:34 | bogdando[m] | I will fence that fix with a config knob then | |
| 14:39:06 | sean-k-mooney | ack | |
| 14:39:20 | sean-k-mooney | we can discuss it more in the review | |
| 14:40:45 | jgilaber | ack thanks, any other comment on this review? | |
| 14:41:36 | jgilaber | let's move to bug triage then | |
| 14:41:43 | jgilaber | #topic Bugs | |
| 14:41:50 | jgilaber | #link https://bugs.launchpad.net/openstack-cyborg/+bug/1940511 | |
| 14:42:42 | sean-k-mooney | so this i need to build more context on | |
| 14:42:59 | sean-k-mooney | the api docs site is unfortunetlly down right now for me | |
| 14:43:19 | sean-k-mooney | openstack accelerator arq create command | |
| 14:43:36 | sean-k-mooney | isue used to create the Accleerator resouce request, this is normally only done by nova | |
| 14:43:45 | sean-k-mooney | so humans shoudl not really call this directly | |
| 14:44:48 | sean-k-mooney | https://github.com/openstack/cyborg/blob/master/api-ref/source/arqs.inc | |
| 14:45:53 | jgilaber | looking at the api the command is not correct, but the client does have a "--group-id" option | |
| 14:45:53 | sean-k-mooney | the request looks somethign like this https://github.com/openstack/cyborg/blob/master/doc/api_samples/accelerator_requests/accelerator_requests-post-curl.json | |
| 14:46:31 | sean-k-mooney | and this is the responce https://github.com/openstack/cyborg/blob/master/doc/api_samples/accelerator_requests/accelerator_requests-create-resp.json | |
| 14:46:46 | sean-k-mooney | so the comemnt is that https://github.com/openstack/cyborg/blob/master/doc/api_samples/accelerator_requests/accelerator_requests-create-resp.json#L14 | |
| 14:46:49 | sean-k-mooney | is always 0 | |
| 14:48:13 | sean-k-mooney | we likely shoudl create a repoducer | |
| 14:48:25 | sean-k-mooney | but i thinkw e need to better understand teh semantics of the api | |
| 14:48:30 | sean-k-mooney | by reviewing the related spec | |
| 14:49:40 | sean-k-mooney | i think for now we shoudl move on | |
| 14:49:53 | jgilaber | agreed, not sure if it's a real bug or not, do we mark as incomplete or we leave it as is? | |
| 14:50:11 | sean-k-mooney | lets mark it incomplete for now sure | |
| 14:50:16 | sean-k-mooney | i added the api tag | |
| 14:50:24 | jgilaber | ack thanks | |
| 14:50:26 | sean-k-mooney | it not clear if its a clinet or api bug | |
| 14:50:36 | sean-k-mooney | or neither | |
| 14:50:42 | jgilaber | let's move to the second one | |
| 14:50:43 | jgilaber | #link https://bugs.launchpad.net/openstack-cyborg/+bug/1941025 | |
| 14:51:19 | sean-k-mooney | so this is a feature reqeust | |
| 14:51:25 | sean-k-mooney | its also in the wrogn repo | |
| 14:51:35 | sean-k-mooney | it shoudl be in the python-cyborg client repo | |
| 14:51:52 | sean-k-mooney | its valid i think to supprot this in the future | |
| 14:52:35 | sean-k-mooney | i have fixed that | |