Earlier  
Posted Nick Remark
#openstack-cyborg - 2021-07-22
02:49:43 songwenping he snapshot to me. when there is accelerator, the result is []
02:50:07 songwenping when remove, the result is ok.
02:50:30 songwenping i send to you snapshot on wechat
02:50:44 xinranwang did he use specific port?
02:50:54 xinranwang songwenping: ok, thanks
02:51:22 songwenping he uses domain name
02:51:27 xinranwang let's discuss offline with him
02:51:38 xinranwang the next patch is https://review.opendev.org/c/openstack/cyborg/+/790937
02:51:45 songwenping ok
02:52:29 xinranwang songwenping: we can have a group chat with eric on wechat, please help to form the group, I dont have his wechat
02:52:32 songwenping delete trait is not relate to this oatch
02:52:42 songwenping s/oatch/patch
02:52:56 songwenping sure
02:53:31 xinranwang maybe you can have a series of patch to do this?
02:53:59 songwenping ok
02:54:16 songwenping np
02:55:01 xinranwang ok, I will review it again once the refactor is ready
02:55:05 xinranwang thanks
02:55:23 songwenping thanks
02:56:16 xinranwang the next one is https://review.opendev.org/c/openstack/cyborg/+/797403
02:56:26 xinranwang it seems the tempest gate failed again
02:56:59 songwenping yes the victoria branch is not ok
02:57:32 xinranwang we should back port the tempest bug fix to victoria, right?
02:57:55 songwenping no we cannot
02:58:11 xinranwang why
02:58:24 songwenping the tempest only has master branch
03:00:41 xinranwang so the patch still use the master's tempest code?
03:00:54 songwenping yes
03:03:49 songwenping i will look into this.
03:06:17 xinranwang sorry, I was calling by one collegue
03:06:27 xinranwang ok, thanks wenping
03:06:29 songwenping no worry
03:07:33 xinranwang that's all from my side
03:08:07 xinranwang there's another pending patch from arthurdayne, I have not look into the latest one, I will review it asap
03:08:12 xinranwang thanks arthurdayne for the update
03:08:19 xinranwang #topic AoB
03:08:30 songwenping does the pmem spec can merge?
03:08:39 songwenping in the release
03:08:53 xinranwang no, the spec freeze is pass
03:09:16 songwenping ok let's do in next release
03:09:24 songwenping we can disscuss in the PTG
03:10:00 xinranwang yes
03:10:37 songwenping nothing from my side
03:10:49 xinranwang ok, let's wrap up the meeing
03:11:06 songwenping bye
03:11:08 xinranwang take care everyone , stay safe
03:11:16 xinranwang #endmeeting
03:11:16 opendevmeet Meeting ended Thu Jul 22 03:11:16 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
03:11:16 opendevmeet Minutes: https://meetings.opendev.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-07-22-02.38.html
03:11:16 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-07-22-02.38.txt
03:11:16 opendevmeet Log: https://meetings.opendev.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-07-22-02.38.log.html
#openstack-cyborg - 2021-07-23
02:06:05 opendevreview Wenping Song proposed openstack/cyborg master: Delete trait from placement https://review.opendev.org/c/openstack/cyborg/+/790937
08:12:28 opendevreview Wenping Song proposed openstack/cyborg master: Delete trait from placement https://review.opendev.org/c/openstack/cyborg/+/790937
11:07:44 opendevreview Eric Xie proposed openstack/python-cyborgclient master: Hide the traceback when deleting a non-existent ARQ https://review.opendev.org/c/openstack/python-cyborgclient/+/802004
#openstack-cyborg - 2021-07-24
07:43:29 opendevreview Eric Xie proposed openstack/python-cyborgclient master: Add checks for showing dp with name https://review.opendev.org/c/openstack/python-cyborgclient/+/802140
#openstack-cyborg - 2021-07-26
04:48:24 opendevreview Eric Xie proposed openstack/python-cyborgclient master: Add checks for showing dp with name https://review.opendev.org/c/openstack/python-cyborgclient/+/802140
04:55:15 opendevreview Eric Xie proposed openstack/python-cyborgclient master: Hide the traceback when deleting a non-existent ARQ https://review.opendev.org/c/openstack/python-cyborgclient/+/802004
#openstack-cyborg - 2021-07-29
02:32:51 xinranwang hi all
02:33:02 brinzhang_ hi
02:33:10 songwenping_ hi all
02:33:17 brinzhang_ at 11:00, I have a meeting
02:33:43 xinranwang ok
02:33:48 brinzhang_ in each Thursday in fruture it will be happened :(
02:33:56 xinranwang let's start the meeting quickly
02:34:04 xinranwang #startmeeting
02:34:04 opendevmeet xinranwang: Error: A meeting name is required, e.g., '#startmeeting Marketing Committee'
02:34:11 xinranwang #startmeeting openstack-cyborg
02:34:11 opendevmeet Meeting started Thu Jul 29 02:34:11 2021 UTC and is due to finish in 60 minutes. The chair is xinranwang. Information about MeetBot at http://wiki.debian.org/MeetBot.
02:34:11 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
02:34:11 opendevmeet The meeting name has been set to 'openstack_cyborg'
02:34:16 xinranwang #topic roll call
02:34:41 brinzhang_ #info brinzhang
02:34:46 xinranwang #info xinranwang
02:35:45 xinranwang #topic pending patches
02:35:46 songwenping_ #info songwenping_
02:36:26 xinranwang let's go through the pending patches
02:36:49 xinranwang 1st: https://review.opendev.org/c/openstack/cyborg/+/790937
02:37:38 xinranwang I think this one is good for me. each time we delete trart for on rp, we should check if we need to delete the trait as well.
02:39:14 xinranwang brinzhang_ what do you think about this
02:39:32 xinranwang 2nd: https://review.opendev.org/c/openstack/cyborg/+/797403
02:41:45 brinzhang_ for delete the trait I think it's ok, I will review it at afternoon
02:41:59 xinranwang brinzhang_: ok, thanks
02:42:49 brinzhang_ the sec I have talked with wenping, I suggest to combine the duplicate exception
02:43:09 xinranwang what do you mean by combine
02:43:35 songwenping_ combine name exist and uuid exist exception
02:44:00 brinzhang_ yes
02:44:04 songwenping_ to resource existed exception
02:44:35 songwenping_ need we distingush them
02:45:03 xinranwang it should be 2 different exceptions
02:45:28 brinzhang_ if columns just only exist with name, using string will be better,but it'a an array now, just using arr[0] will be have a risk
02:46:06 brinzhang_ we can using log + rase exception to warning the user/developer
02:46:17 xinranwang i think the array is not for one colume, it records all duplicated columes' name
02:46:27 xinranwang so it is a array
02:47:32 brinzhang_ if so, why are you just call the first key arr[0]?
02:48:34 xinranwang we didn't use arr[0] now, the if condition is: if 'name' in ['name']
02:49:18 xinranwang calling arr[0] is a workaround because the value of the list is not 'name', but "xxxxxxname" instead
02:49:24 songwenping_ just for verify the tempest, we cannot use arr[0] in fact.
02:49:43 xinranwang songwenping_: +1
02:50:45 songwenping_ we should find why the e.columns is different, some env is ok.
02:51:12 brinzhang_ but now changed with if 'name' in e.columns[0] it will be always using the fist

Earlier   Later