| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2021-04-08 | |||
| 02:31:53 | brinzhang | the releted patch has already fixed, see bug 1922183 | |
| 02:31:55 | openstack | bug 1922183 in Cyborg (OpenStack) wabllaby "tempest failed with test_get_and_delete_device_profile" [Undecided,New] https://launchpad.net/bugs/1922183 | |
| 02:32:20 | xinranwang | this is already the roll back patch, right? | |
| 02:32:50 | brinzhang | xinranwang: do we need to switch to use launchpad now? there is no related with the commit and the bug now | |
| 02:32:51 | brinzhang | https://review.opendev.org/c/openstack/cyborg/+/784207 | |
| 02:33:29 | brinzhang | xinranwang: yes, you can see the fixed patch here https://review.opendev.org/q/topic:%22bug%252F1922183%22+(status:open%20OR%20status:merged) | |
| 02:33:44 | xinranwang | ok, cool | |
| 02:34:08 | xinranwang | i have no objection to switch to laundpad | |
| 02:34:12 | brinzhang | we just need to backport that fix until wallaby, it's enough | |
| 02:34:44 | brinzhang | ok, let's review and merge the switch patch, ok? | |
| 02:35:10 | swp20 | yes, the tempest test case is introduced from wallaby. | |
| 02:35:20 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Switch using Launchpad instead of Storyboard https://review.opendev.org/c/openstack/cyborg/+/784207 | |
| 02:35:23 | brinzhang | https://review.opendev.org/c/openstack/cyborg/+/784207 | |
| 02:36:25 | xinranwang | ok, cool | |
| 02:36:44 | brinzhang | xinranwang, swp20: thanks | |
| 02:36:54 | swp20 | cool | |
| 02:36:57 | xinranwang | and please review chenke's patch https://review.opendev.org/c/openstack/cyborg/+/784021 | |
| 02:37:50 | xinranwang | any other things? | |
| 02:38:03 | chenke | i will review the switch launchpad story | |
| 02:38:04 | brinzhang | I left commit, this is need to re wrods the commit title, it looks blurry | |
| 02:38:22 | xinranwang | I think he has resubmit another one | |
| 02:38:29 | brinzhang | I mean chenke's patch | |
| 02:38:30 | chenke | brinzhang xinranwang already update. | |
| 02:39:07 | chenke | that's sundar's patch Leftover problems. | |
| 02:39:14 | brinzhang | chenke: I think we just to say "using List instead of xxx ", how about? | |
| 02:39:45 | brinzhang | chenke: yeah, I just want to know what was happened when I see the commit tittle | |
| 02:39:58 | openstackgerrit | Merged openstack/cyborg-tempest-plugin master: Add device profiles test case for device_profile APIs https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/785142 | |
| 02:40:54 | chenke | brinzhang. Agree your idea. What do you think the new title? | |
| 02:41:50 | swp20 | 'set' object is not subscriptable | |
| 02:42:00 | swp20 | i test in py3 env | |
| 02:42:09 | xinranwang | uncompatibility of data type? | |
| 02:42:14 | chenke | swp20 yes. | |
| 02:42:48 | chenke | maybe sundar didn't test this else switch. actually this is a very python problem. | |
| 02:42:55 | brinzhang | Using List to avoid uncompatibility data type | |
| 02:43:12 | brinzhang | How do you think? | |
| 02:43:46 | xinranwang | Using List to avoid incompatible data type | |
| 02:43:59 | swp20 | we can use pop | |
| 02:44:02 | brinzhang | nice | |
| 02:45:02 | brinzhang | Agree swp20 | |
| 02:45:03 | chenke | OK | |
| 02:45:24 | brinzhang | may we will reduce one data change | |
| 02:45:24 | chenke | Using List to avoid incompatible data type | |
| 02:45:53 | xinranwang | ok, cool | |
| 02:46:28 | brinzhang | xinranwang, chenke: what do you think swp20's advice? | |
| 02:46:43 | brinzhang | "we can use pop" | |
| 02:47:27 | xinranwang | good advice | |
| 02:47:31 | xinranwang | +1 for that | |
| 02:47:41 | xinranwang | since the length is 1 | |
| 02:47:56 | chenke | msg = msg % {'code': list(event_codes)[0], | |
| 02:47:56 | chenke | 'inst': events[0]["server_uuid"]} | |
| 02:48:43 | chenke | pop will change the data. I think just list transfer it is enough. | |
| 02:48:51 | brinzhang | yes, using pop we will have a better efficiency than list | |
| 02:49:05 | xinranwang | if the var"event_codes" is not used somewhere after, we can use pop | |
| 02:49:20 | brinzhang | xinranwang: yes | |
| 02:49:26 | xinranwang | otherwise we'd better keep it no changable | |
| 02:49:37 | brinzhang | https://review.opendev.org/c/openstack/cyborg/+/784021 | |
| 02:50:35 | brinzhang | after enent_codes, there is not used somewhere, we directly raised and end of the interface | |
| 02:50:41 | chenke | yes. | |
| 02:52:28 | brinzhang | so, let's use pop instead of list, is it ok? chenke | |
| 02:52:33 | xinranwang | what do you think chenke | |
| 02:52:34 | chenke | ye | |
| 02:52:37 | openstackgerrit | chenker proposed openstack/cyborg master: Using pop method to avoid incompatible data type https://review.opendev.org/c/openstack/cyborg/+/784021 | |
| 02:52:48 | chenke | please see the update patch | |
| 02:52:48 | brinzhang | cool, I have nothing else | |
| 02:52:57 | xinranwang | cool | |
| 02:53:03 | xinranwang | thanks for the quick update | |
| 02:53:10 | xinranwang | anything else? | |
| 02:53:13 | swp20 | cool | |
| 02:53:22 | swp20 | nothing from myside | |
| 02:53:25 | chenke | haha | |
| 02:53:42 | chenke | me too. | |
| 02:53:59 | xinranwang | if nothing else, let's wrap up the meeting | |
| 02:54:20 | xinranwang | #endmeeting | |
| 02:54:22 | openstack | Meeting ended Thu Apr 8 02:54:20 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 02:54:23 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-04-08-02.06.html | |
| 02:54:24 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-04-08-02.06.txt | |
| 02:54:25 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-04-08-02.06.log.html | |
| 02:54:26 | xinranwang | thanks guys | |
| 02:54:33 | xinranwang | have a good day! | |
| 02:56:17 | swp20 | bye | |
| 02:57:36 | chenke | bye guys. | |
| 07:11:35 | openstackgerrit | Merged openstack/cyborg master: Using pop method to avoid incompatible data type https://review.opendev.org/c/openstack/cyborg/+/784021 | |
| 07:11:55 | openstackgerrit | Merged openstack/cyborg master: Switch using Launchpad instead of Storyboard https://review.opendev.org/c/openstack/cyborg/+/784207 | |
| 07:12:38 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Remove personal name in the docs https://review.opendev.org/c/openstack/cyborg/+/785314 | |
| 07:17:58 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Remove personal name in the docs https://review.opendev.org/c/openstack/cyborg/+/785314 | |
| 07:35:13 | openstackgerrit | Wenping Song proposed openstack/cyborg master: Remove TODO tag https://review.opendev.org/c/openstack/cyborg/+/785315 | |
| 08:05:11 | openstackgerrit | Wenping Song proposed openstack/cyborg master: Add ut for nova returns HTTP 207 with event code other than 422 https://review.opendev.org/c/openstack/cyborg/+/785336 | |
| 08:22:57 | openstackgerrit | Wenping Song proposed openstack/cyborg master: Add ut for placement API https://review.opendev.org/c/openstack/cyborg/+/785340 | |
| #openstack-cyborg - 2021-04-09 | |||
| 01:29:22 | openstackgerrit | Wenping Song proposed openstack/cyborg master: Add ut for nova returns HTTP 207 with all event code 400 https://review.opendev.org/c/openstack/cyborg/+/785336 | |
| 08:12:14 | openstackgerrit | Merged openstack/cyborg master: Remove personal name in the docs https://review.opendev.org/c/openstack/cyborg/+/785314 | |
| 08:55:51 | hberaud | brinzhang_: o/ | |
| 08:56:24 | brinzhang_ | hberaud: hi | |
| 08:56:47 | hberaud | Please can you have a look ASAP to this last minute RC patch https://review.opendev.org/c/openstack/releases/+/785344 | |
| 08:56:51 | hberaud | brinzhang_: ^ | |
| 09:00:08 | brinzhang_ | hberaud:ok, I would like to backport the lastest patch for wallaby, please wait and update the hash after it merged | |
| 09:00:21 | hberaud | ack | |
| 09:00:39 | brinzhang_ | xinranwang: please allow https://review.opendev.org/c/openstack/cyborg/+/785395 this patch merged to Wallaby | |
| 09:00:39 | hberaud | backport is already on the rails? | |
| 09:01:32 | brinzhang_ | 20 minute almost | |
| 09:01:57 | xinranwang | brinzhang_: done | |