Earlier  
Later
New Search
Posted Nick Remark
#openstack-cyborg - 2020-06-18
09:29:15 shaohe_feng do you means use openstacksdk instead of keystone adapter?
09:29:20 efried yes
09:29:40 efried We started doing that cutover in nova. It was a pretty simple transition.
09:29:51 efried We did it for placement, and got most of the way there for ironic.
09:30:04 efried let me find those patches...
09:30:13 shaohe_feng sounds good.
09:31:36 shaohe_feng currently, I can not get the image endpoint from keystone adapter
09:32:15 shaohe_feng And for the service_catalog is empty.
09:34:07 efried Here's a good place to start poking: https://github.com/openstack/nova/blame/master/nova/utils.py#L1053
09:35:32 shaohe_feng let me read up ti.
09:36:45 shaohe_feng is it convenience to change the current keystone adapter to openstacksdk
09:36:55 shaohe_feng how many effort?
09:37:15 shaohe_feng such as how many days?
09:37:26 efried "It depends" :P
09:38:03 efried The transition from ksa should be very easy, ~1d (of course blown out across many calendar days for review cycle etc)
09:38:33 efried When we cut placement over, the transition involved very little code.
09:39:33 shaohe_feng sounds good. does placement call glance?
09:40:10 shaohe_feng I see your ksa code, there are some special handle for image?
09:40:29 efried No, sorry, what I mean is:
09:40:29 efried For a given $service that $your_project calls via the API, if today you're using ksa to get a handle on that API, transitioning to calling $service via sdk is easy.
09:40:55 efried We did this for $service=placement from $your_project=nova.
09:40:55 efried I'm suggesting you do it for $service=glance from $your_project=glance
09:41:04 efried sorry
09:41:16 efried I'm suggesting you do it for $service=glance from $your_project=cyborg
09:41:50 efried https://github.com/openstack/nova/commit/5601c82915a2d745ee600a4ca4c0e7215206dbb6 <== Here's what I was referring to earlier. Nova got rid of that chunk of ugliness. Your shortest path may be to subsume the same change.
09:43:02 efried You'll need to bump your ksa minimum to 3.3.0 (which I guess had already happened by the time ^ went in)
09:44:08 shaohe_feng OK, any special extra configure in conf file for it?
09:45:14 efried I don't think so. In fact, I think you should be able to leave the [glance] section *empty* and it should "just work"
09:45:52 efried Here's the commit that cut nova over to using the sdk for placement: https://github.com/openstack/nova/commit/2a2379a63cab4414676882c068d25163874cf08e
09:45:52 efried It was built on top of the commit(s) that introduced get_sdk_adapter, which I linked above. But you can see, once that was in place, this change was very simple.
09:46:13 shaohe_feng that's good. this is more easy for deployer with less configure.
09:46:23 efried In fact, on the code side, it consisted only of s/get_ksa_adapter/get_sdk_adapter/ -- the rest was just test fixups.
09:46:52 shaohe_feng https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/common/utils.py#L185
09:47:31 shaohe_feng ^ in your early code, you do some extra handle for image.
09:47:47 efried Oh, yeah, that's super stale. See the commit above for things you can do at a minimum to clean that up.
09:47:56 shaohe_feng after sdk, can we remove it?
09:48:09 shaohe_feng OK
09:48:33 efried Yeah, if you cut over to sdk, you wouldn't need get_endpoint *or* the things that call it.
09:49:01 shaohe_feng sounds good. let me try.
09:49:13 efried Hey, cyborg already has get_sdk_adapter :P https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/common/utils.py#L135
09:49:35 efried you may want to just make sure it's in sync with what's in nova.
09:50:37 efried by the way, long-term, you'll want to use the higher-level interfaces that sdk provides to talk to glance, rather than the REST primitives. Depending how much bandwidth you have, and how disruptive whatever you're working on is going to be, you may be able to do some of that now.
09:51:59 efried https://docs.openstack.org/openstacksdk/latest/user/resources/image/v2/image.html
09:52:23 efried Again, the folks in #openstack-sdks would be delighted to help you with this.
09:53:12 shaohe_feng good thanks
09:53:36 efried mordred (US) and gtema (EU I think) would be good resources there.
09:53:44 shaohe_feng Is sdk compatible with ksa?
09:54:37 efried Yes, at its lowest level, sdk is simply a wrapper around ksa. That's why the placement thing worked (s/get_ksa_adapter/get_sdk_adapter/). But the sdk builds on that so you can do things more powerfully than just the REST primitives.
09:55:05 efried ...on a per-service basis.
09:55:35 shaohe_feng yes, we should use sdk.
09:55:55 efried If you're familiar with the legacy python-*client projects -- openstacksdk is supposed to replace all of those and be a one-stop shop for that kind of usage, with a (mostly) common interface across all the services.
09:56:35 efried That was a multi-year mission that I was a part of before I had to leave. mordred should still be excited about it, I think.
09:57:04 shaohe_feng Does that mean SDK is more easy to use than python client?
09:57:09 shaohe_feng OK, thanks.,
09:57:18 shaohe_feng have a nice day.
09:57:24 efried you too
09:57:24 efried good luck!
10:53:56 openstackgerrit Shogo Saito proposed openstack/cyborg master: Programming support (v2 Deployable API) https://review.opendev.org/698190
11:48:25 openstackgerrit Pratik Raj proposed openstack/cyborg master: optimize size and time using --no-cache-dir https://review.opendev.org/736651
11:49:11 openstackgerrit Pratik Raj proposed openstack/cyborg-tempest-plugin master: optimize size and time using --no-cache-dir https://review.opendev.org/736653
21:29:16 openstackgerrit Monty Taylor proposed openstack/cyborg master: Remove api_servers references https://review.opendev.org/736843
21:29:17 openstackgerrit Monty Taylor proposed openstack/cyborg master: Remove deprecated cyborg.image.download.modules https://review.opendev.org/736844
21:45:55 openstackgerrit Monty Taylor proposed openstack/cyborg master: Remove api_servers references https://review.opendev.org/736843
21:45:55 openstackgerrit Monty Taylor proposed openstack/cyborg master: Remove deprecated cyborg.image.download.modules https://review.opendev.org/736844
21:45:56 openstackgerrit Monty Taylor proposed openstack/cyborg master: Removed unused image api methods https://review.opendev.org/736849
#openstack-cyborg - 2020-06-19
07:54:21 openstackgerrit Merged openstack/python-cyborgclient master: Remove future imports https://review.opendev.org/723167
07:54:22 openstackgerrit Merged openstack/python-cyborgclient master: Use unittest.mock instead of third party mock https://review.opendev.org/720981
08:10:17 openstackgerrit Merged openstack/cyborg master: Remove future imports https://review.opendev.org/716910
08:27:33 openstackgerrit Merged openstack/cyborg master: Use unittest.mock instead of third party mock https://review.opendev.org/716916
08:27:35 openstackgerrit Merged openstack/cyborg master: add ut for get arqs list https://review.opendev.org/723865
09:33:13 openstackgerrit Brin Zhang proposed openstack/cyborg master: hacking: force explicit import of python's mock https://review.opendev.org/716920
#openstack-cyborg - 2020-06-20
15:35:07 openstackgerrit Monty Taylor proposed openstack/cyborg master: WIP Use openstacksdk for glance https://review.opendev.org/737137
15:51:22 openstackgerrit Monty Taylor proposed openstack/cyborg master: Remove api_servers references https://review.opendev.org/736843
15:51:23 openstackgerrit Monty Taylor proposed openstack/cyborg master: Remove deprecated cyborg.image.download.modules https://review.opendev.org/736844
15:51:23 openstackgerrit Monty Taylor proposed openstack/cyborg master: Removed unused image api methods https://review.opendev.org/736849
15:51:24 openstackgerrit Monty Taylor proposed openstack/cyborg master: WIP Use openstacksdk for glance https://review.opendev.org/737137
#openstack-cyborg - 2020-06-21
04:12:14 openstackgerrit jacky06 proposed openstack/cyborg master: Remove all usage of six library https://review.opendev.org/725928
#openstack-cyborg - 2020-06-22
03:48:07 openstackgerrit Merged openstack/cyborg master: hacking: force explicit import of python's mock https://review.opendev.org/716920
#openstack-cyborg - 2020-06-26
04:26:37 openstackgerrit jacky06 proposed openstack/cyborg master: Remove all usage of six library https://review.opendev.org/725928
#openstack-cyborg - 2020-06-28
02:15:18 openstackgerrit wangzhh proposed openstack/cyborg-specs master: Add Attribute API specification. https://review.opendev.org/738331
02:17:19 openstackgerrit wangzhh proposed openstack/cyborg-specs master: Add Attribute API specification. https://review.opendev.org/738331
02:19:53 openstackgerrit wangzhh proposed openstack/cyborg-specs master: Add Attribute API specification. https://review.opendev.org/738331
03:46:19 openstackgerrit Merged openstack/cyborg master: Remove api_servers references https://review.opendev.org/736843
03:53:13 openstackgerrit Merged openstack/cyborg master: Remove deprecated cyborg.image.download.modules https://review.opendev.org/736844
03:53:14 openstackgerrit Merged openstack/cyborg master: Removed unused image api methods https://review.opendev.org/736849
04:28:04 openstackgerrit wangzhh proposed openstack/cyborg-specs master: Add Attribute API specification. https://review.opendev.org/738331
#openstack-cyborg - 2020-06-29
11:54:11 openstackgerrit Wenping Song proposed openstack/cyborg master: Add instance project_id for arq https://review.opendev.org/738427
#openstack-cyborg - 2020-06-30
02:32:03 openstackgerrit Wenping Song proposed openstack/cyborg master: Add instance project_id for arq https://review.opendev.org/738427
#openstack-cyborg - 2020-07-01
07:40:24 openstackgerrit Merged openstack/cyborg-specs master: Remove .placeholder https://review.opendev.org/723792
07:41:11 openstackgerrit Wenping Song proposed openstack/cyborg-specs master: Add Inspur® FPGA driver specification. https://review.opendev.org/730760
07:49:48 openstackgerrit Wenping Song proposed openstack/cyborg-specs master: Add Inspur® FPGA driver specification. https://review.opendev.org/730760
13:50:07 openstackgerrit wangzhh proposed openstack/cyborg-specs master: Add Attribute API specification. https://review.opendev.org/738331
#openstack-cyborg - 2020-07-02
03:01:32 Yumeng hi s_shogo,s_shogo,brinzhang_
03:01:44 s_shogo Hi Yumeng
03:02:08 Yumeng hi songwenping__
03:02:18 brinzhang_ hi Yumeng
03:02:18 Yumeng s_shogo: how are you doing?
03:02:20 songwenping__ Hi Yumeng
03:03:02 Yumeng let's wait a few minutes for others to join.^^
03:04:33 s_shogo Yumeng Good, thank you.

Earlier   Later