Earlier  
Later
New Search
Posted Nick Remark
#openstack-cyborg - 2020-04-09
03:17:34 Yumeng so there also left Brin's patches https://review.opendev.org/#/q/owner:zhangbailin%2540inspur.com+status:open
03:18:49 Yumeng and mine two: arq refactor https://review.opendev.org/#/c/696089/, and add policy role https://review.opendev.org/#/c/699102/
03:19:31 Yumeng please help to review! not big change.
03:20:15 Yumeng chenke: do you have any pending patches?
03:20:37 chenke oh. no patch for me. But a patch needs us wo notice.
03:20:37 xinranwang Ok, will review them.
03:20:44 chenke https://review.opendev.org/#/c/718584/1/cyborg/conductor/manager.py
03:21:31 chenke This patch seems help cyborg to sync data with placement. We should consider whether it's needed or not.
03:23:54 xinranwang Yes, I just saw this.
03:24:38 xinranwang IMO, it is reasonable.
03:25:45 Yumeng +1 agree with Brin's comment. xinranwang: do we plan to decouple placement report in next release?
03:26:34 chenke It looks okay, but needs further analysis.
03:27:17 xinranwang I think it depends on users' demand, if we want cyborg run as a standalone project, yes, we should decouple them
03:29:42 chenke It looks okay, but needs further analysis. To be honest, the current piece of code looks a bit redundant. About placement reporting and cyborg database update are mixed together. But I have no better idea about decoupling them.
03:30:50 xinranwang chenke: yes, that's what I am thinking too. If we want decouple them, it will generate more redundant code, because both of them need to do the diff.
03:32:46 chenke Ye. seems no better code to make report and sync cyborg db. Let's these code stay as it is.
03:32:50 Yumeng emmm,seems a problem to choose a less evil one. let's keep it as one topic of the PTG.
03:33:26 Yumeng #topic AoB
03:33:35 Yumeng Anything else?
03:33:35 brinzhang https://review.opendev.org/#/c/718584/1/cyborg/conductor/manager.py are you talking this patch?
03:33:54 Yumeng yes brinzhang
03:34:24 xinranwang Yumeng: Sure, btw, do we have ptg etherpad where we can put the topic in, I'd like add some :)
03:34:47 brinzhang I dont think we should keep current logical, if so, maybe when we do next cycle to add a device, we cannot get the device occupied in obj
03:35:45 chenke Hi brin. "we cannot get the device occupied in obj" means what?
03:35:48 Yumeng xinranwang: ok, will let you know later. I will discuss with Sundar, and maybe we can create one!
03:36:03 xinranwang chenke: I think this patch does solve problems, it does not change the main logic, just revert the cyborg DB. I think it is useful.
03:36:25 chenke Agree.
03:36:28 brinzhang IMHO, the logic of the current code in this file makes it complicated to read. If possible, I hope to be able to refactor it.
03:36:31 xinranwang Yumeng: thanks！
03:36:53 brinzhang xinranwang, right, it just resolve the problem, not change any logical
03:37:16 chenke brinzhang. Agree. If we have better solution. I want to talk about it.
03:37:42 Yumeng brinzhang: yes. let's discuss it more detaily.
03:37:45 brinzhang Yumeng: We can take https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:unittest.mock to PTG
03:38:03 xinranwang brinzhang: Yes, we are trying to find a way to decouple the code. There is still some gaps. We'd better let it be like it is(the main logic) in this release, and we can discuss in PTG.
03:38:18 brinzhang Sundar think we cannot do this right now, but whatever we shuold do sooner or later
03:39:12 brinzhang yes xinranwang, https://review.opendev.org/#/c/718584 isnot change it's logical, we can looked into later
03:39:20 Yumeng ok. I will paste the PTG etherpad later. let's add topics.
03:39:44 brinzhang https://review.opendev.org/#/c/717519/.
03:39:53 brinzhang https://review.opendev.org/#/c/717520/
03:40:29 brinzhang above two patches, I think we should merge, because of droped py27 from Cyborg
03:40:50 brinzhang many projects are done of this cleanup
03:41:08 xinranwang Another thing: There is still some operations are not supported in nova like shelve/unshelve. I'd like to investigate it and do this part in next release if possible. I will add this topic to PTG etherpad too.
03:41:42 Yumeng Great! Thanks Xinran!
03:41:53 Yumeng will review them Brin.
03:41:59 Yumeng if nothing else. Let's wrap up this meeting and I'll see you all again next week
03:42:20 Yumeng Thank you all. have a good day!
03:42:29 xinranwang Thanks Yumeng
03:42:33 xinranwang Bye bye all
03:42:34 Yumeng Bye
03:42:42 Yumeng #endmeeting
03:42:44 openstack Meeting ended Thu Apr 9 03:42:42 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
03:42:45 openstack Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-04-09-03.05.html
03:42:46 openstack Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-04-09-03.05.txt
03:42:47 openstack Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-04-09-03.05.log.html
03:42:48 s_shogo bye
07:27:40 openstackgerrit Brin Zhang proposed openstack/cyborg master: Bump openstacksdk 0.46.0 https://review.opendev.org/718606
07:30:55 openstackgerrit Merged openstack/cyborg-tempest-plugin master: Update to hacking 3.0 https://review.opendev.org/717519
07:31:08 openstackgerrit Brin Zhang proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
07:31:29 openstackgerrit Brin Zhang proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
07:39:53 openstackgerrit Brin Zhang proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606
08:12:00 openstackgerrit Brin Zhang proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606
08:13:57 openstackgerrit Brin Zhang proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
08:14:38 openstackgerrit Brin Zhang proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
09:30:52 openstackgerrit Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
10:06:04 openstackgerrit Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
10:32:12 openstackgerrit YumengBao proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606
10:32:13 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
10:41:37 openstackgerrit YumengBao proposed openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606
10:41:47 openstackgerrit YumengBao proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
10:42:31 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
11:07:15 openstackgerrit Wenping Song proposed openstack/cyborg master: sync data for placement https://review.opendev.org/718662
19:47:46 openstackgerrit Andreas Jaeger proposed openstack/cyborg-specs master: Cleanup py27 support and docs https://review.opendev.org/718783
#openstack-cyborg - 2020-04-10
01:19:32 openstackgerrit Merged openstack/cyborg master: Bump openstacksdk>=0.46.0 https://review.opendev.org/718606
01:36:48 openstackgerrit Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
02:00:16 openstackgerrit Merged openstack/cyborg master: Finish v2 API doc https://review.opendev.org/715980
02:31:26 openstackgerrit Merged openstack/cyborg-tempest-plugin master: Cleanup py27 support https://review.opendev.org/717520
06:59:54 openstackgerrit Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
07:21:57 openstackgerrit Wenping Song proposed openstack/cyborg master: revert device and deployable when resource provider create fail https://review.opendev.org/718584
#openstack-cyborg - 2020-04-11
07:57:45 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
07:58:14 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
#openstack-cyborg - 2020-04-13
02:19:12 openstackgerrit chenker proposed openstack/cyborg master: Fix fake attribute old interface https://review.opendev.org/719374
02:23:56 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
#openstack-cyborg - 2020-04-14
10:51:18 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
10:55:44 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
11:44:41 openstackgerrit YumengBao proposed openstack/cyborg master: Refactor v2 arq api https://review.opendev.org/696089
14:58:26 sean-k-mooney hi o/
14:59:19 sean-k-mooney can someone form the cyborg core team check https://bugs.launchpad.net/nova/+bug/1872730 and confrim if i am correct in sayin gthat if we fail to bind the arq, and dont clean it up as a result the only resouce we will leak on the cybrog side is a db record for the arq
14:59:19 openstack Launchpad bug 1872730 in OpenStack Compute (nova) ussuri "Delete ARQs for an instance when the instance is deleted only delete bound arqs" [High,Triaged]
14:59:49 sean-k-mooney e.g. since we never bound the device sucessfully cyborg would not have allocated it in its db or provisioned it
15:00:30 sean-k-mooney if that is not the case then i should increase teh severity of that bug
15:00:59 sean-k-mooney if we are just leaking a db record then we can backport it to ussuri after the release without treating it as a RC blocker
#openstack-cyborg - 2020-04-15
01:14:35 brinzhang_ sean-k-mooney: I agree with you, I think your understand is correct, if we failed to bing, that just leak db record in Cyborg, I will check again with Sundar.
02:07:16 openstackgerrit Merged openstack/cyborg-specs master: Cleanup py27 support and docs https://review.opendev.org/718783
02:08:19 brinzhang_ gmann: if you are free, please check this introduce functional test patch, I think I hit an issue https://review.opendev.org/#/c/702863/
02:09:27 brinzhang_ gmann: The mainly problem is, I cannt run "tox -e functional" success in local env, you just need review this in you free time, thanks
08:10:58 openstackgerrit YumengBao proposed openstack/cyborg master: Fix bandit error: [B108:hardcoded_tmp_directory] https://review.opendev.org/720143
08:29:37 openstackgerrit YumengBao proposed openstack/cyborg master: Fix bandit error: [B104:hardcoded_bind_all_interfaces] https://review.opendev.org/720149
#openstack-cyborg - 2020-04-16
01:40:46 openstackgerrit Shogo Saito proposed openstack/cyborg master: Programming support (v2 Deployable API) https://review.opendev.org/698190
03:01:25 Yumeng hi Sundar
03:01:45 brinzhang Hi Yumeng, Sundar

Earlier   Later