| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2020-02-20 | |||
| 03:12:00 | brinzhang_ | Li_Liu: After update, I think it's ready to go | |
| 03:12:14 | Li_Liu | ok, will do | |
| 03:12:26 | brinzhang_ | In https://review.opendev.org/#/c/702863/5 I was already add the zuul job for functional test | |
| 03:12:39 | Li_Liu | thanks a lot | |
| 03:12:44 | brinzhang_ | np | |
| 03:14:58 | shaohe_feng | Do you all think we can start the meeting? | |
| 03:15:19 | chenke | +1 | |
| 03:15:31 | Li_Liu | +1 | |
| 03:15:44 | shaohe_feng | #startmeeting openstack-cyborg | |
| 03:15:44 | openstack | Meeting started Thu Feb 20 03:15:44 2020 UTC and is due to finish in 60 minutes. The chair is shaohe_feng. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 03:15:45 | openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 03:15:47 | openstack | The meeting name has been set to 'openstack_cyborg' | |
| 03:16:07 | chenke | #info chenke | |
| 03:16:13 | Li_Liu | #info Li_Liu | |
| 03:16:14 | Yumeng | #info Yumeng | |
| 03:16:19 | xinranwang | #info xinranwang | |
| 03:16:28 | brinzhang_ | #info brinzhang_ | |
| 03:16:37 | s_shogo | #info s_shogo | |
| 03:17:04 | shaohe_feng | Sundar miss the meeting. | |
| 03:17:23 | shaohe_feng | Is there any plan link for this meeting? | |
| 03:18:21 | shaohe_feng | #topic Roll Call | |
| 03:18:41 | shaohe_feng | seems most of us are here. | |
| 03:18:56 | shaohe_feng | #topic open | |
| 03:19:00 | brinzhang_ | As xinran's microversion patch, some comments with xinranwang, and I think it should make a plan for the microversion changes | |
| 03:19:06 | brinzhang_ | https://review.opendev.org/#/c/696860/3/cyborg/api/controllers/base.py@85 | |
| 03:19:45 | brinzhang_ | Otherwise xinranwang will be waste some time to rollback the work | |
| 03:20:22 | xinranwang | Yes, I have submit the patch, hope you can give your comments, thanks brinzhang_ for your comments . | |
| 03:20:59 | brinzhang_ | xinranwang: it's my pleasure | |
| 03:21:48 | shaohe_feng | Any more on the this patch? | |
| 03:22:16 | shaohe_feng | OK, go ahead | |
| 03:22:44 | shaohe_feng | the current important things is nova-cyborg integration | |
| 03:22:58 | shaohe_feng | xinranwang have you any ideas on it? | |
| 03:24:00 | brinzhang_ | shaohe_feng: I think it should wait for Sundar in, otherwise anyone does not to say something, as I know, Sundar want to complete it | |
| 03:24:28 | brinzhang_ | Although he will go to new jobs. | |
| 03:24:35 | shaohe_feng | OK, next. | |
| 03:24:51 | xinranwang | we are still waiting for Sundar's reply | |
| 03:26:05 | shaohe_feng | Other patch do you want to discuss? | |
| 03:26:23 | Yumeng | chenke proposed this tiny fix https://review.opendev.org/#/c/708367/ | |
| 03:26:30 | shaohe_feng | Or we can go through the status of pending patch | |
| 03:26:41 | Yumeng | I reviewed this, it's ready to W+1 | |
| 03:26:53 | chenke | ye. We can go through the pending patch. | |
| 03:26:55 | brinzhang_ | Some cleanup job, please review https://review.opendev.org/#/c/707332/ | |
| 03:26:59 | Yumeng | pls help to W+1 | |
| 03:27:22 | Li_Liu | just did | |
| 03:27:26 | chenke | A lot of patches need to be review. | |
| 03:27:32 | shaohe_feng | Thanks Li_Liu | |
| 03:28:13 | Yumeng | aha. Thanks! also cyborgclient patcheshttps://review.opendev.org/#/q/owner:shogo.saito.ac%2540hco.ntt.co.jp+status:open | |
| 03:28:36 | Yumeng | patches https://review.opendev.org/#/q/owner:shogo.saito.ac%2540hco.ntt.co.jp+status:open | |
| 03:29:37 | chenke | +1 | |
| 03:29:39 | xinranwang | cyborg client looks good to me. I have tested it | |
| 03:29:43 | s_shogo | Thank you for your mention about the client and sdk patches. | |
| 03:29:53 | Li_Liu | will take a look today | |
| 03:30:11 | chenke | I also tested shogo's patch. LGTM. | |
| 03:30:30 | shaohe_feng | good work on the client and sdk . | |
| 03:30:42 | shaohe_feng | let we speed up the review on them. | |
| 03:31:09 | shaohe_feng | brinzhang_ you clean up looks good. | |
| 03:31:29 | brinzhang_ | shaohe_feng: thanks | |
| 03:33:12 | brinzhang_ | https://review.opendev.org/#/c/701518/4/cyborg/tests/unit/accelerator/drivers/gpu/test_utils.py@101 | |
| 03:33:53 | brinzhang_ | This code I want to know why add [], chenke can, you give some description? | |
| 03:34:31 | brinzhang_ | It's a separate line of code, why add []? | |
| 03:34:56 | chenke | That's ok. I tested it. | |
| 03:35:29 | chenke | [] is a magical function | |
| 03:35:45 | openstackgerrit | Merged openstack/cyborg-specs master: Fix some minor concept and typo https://review.opendev.org/708367 | |
| 03:35:55 | Yumeng | haha. brinzhang_: append included within []. seems the same as extend. | |
| 03:36:05 | shaohe_feng | I see Dan submit a patch for a provider improvement | |
| 03:36:29 | Yumeng | let me show you the results later. | |
| 03:36:39 | Yumeng | I will ping you in wechat. | |
| 03:36:50 | shaohe_feng | We can have a look at this patch. | |
| 03:36:54 | brinzhang_ | Yumeng, chenke, yes, that why I want to ask, if so, why do for x in y: xxx | |
| 03:37:17 | shaohe_feng | xinranwang you are a provider expert, also help to review it. | |
| 03:37:40 | brinzhang_ | From Dan's patch I found some error in exception, I will submit a patch, and fixed some errors | |
| 03:37:56 | openstackgerrit | Merged openstack/python-cyborgclient master: v2 API Support(using openstack-sdk) https://review.opendev.org/681391 | |
| 03:38:59 | shaohe_feng | ||
| 03:39:23 | xinranwang | shaohe_feng: what patch are you talking about, nova provider config patch ? | |
| 03:39:59 | brinzhang_ | https://review.opendev.org/708726 and https://review.opendev.org/708728 | |
| 03:40:01 | shaohe_feng | we have discuss to improve devstack before. | |
| 03:40:40 | brinzhang_ | and there are sean's patch base on | |
| 03:40:43 | shaohe_feng | brinzhang_ yes, thanks | |
| 03:41:46 | shaohe_feng | sean mooney submit a serial patches. | |
| 03:42:11 | xinranwang | brinzhang_: thanks, will look into them | |
| 03:42:25 | shaohe_feng | many of them about devstack plugin. | |
| 03:42:42 | shaohe_feng | we have found many issues devstack plugin | |
| 03:43:04 | shaohe_feng | but they are pending for a half years. | |
| 03:44:22 | shaohe_feng | such as https://review.opendev.org/#/c/693784/ | |
| 03:45:22 | shaohe_feng | also we have discuss the fake drive improvement | |
| 03:46:06 | shaohe_feng | https://review.opendev.org/#/c/697011/ | |
| 03:46:16 | shaohe_feng | they are pending. | |
| 03:46:36 | shaohe_feng | any one also want to talk about your patches? | |
| 03:48:12 | shaohe_feng | Am I online? | |
| 03:48:30 | chenke | Sure. | |
| 03:49:19 | shaohe_feng | OK, any one else? | |
| 03:49:25 | shaohe_feng | one/more | |
| 03:49:43 | chenke | Shogo's another patch:https://review.opendev.org/#/c/679914/ | |
| 03:50:00 | chenke | Aslo need review. +1 | |
| 03:50:22 | s_shogo | Thanks chenke, That is also important for the client. | |
| 03:50:38 | Yumeng | will do. | |
| 03:51:17 | s_shogo | That needs +1 from openstacksdk folks. It may needs contact them , from me via e-mail and so on. | |
| 03:51:31 | Li_Liu | Sure | |
| 03:51:48 | Li_Liu | Will review the SDK patches | |
| 03:51:56 | chenke | Nice. | |