Earlier  
Later
New Search
Posted Nick Remark
#openstack-cyborg - 2019-12-05
03:39:34 shaohe_feng now any others have comment on the config table?
03:41:08 shaohe_feng Any suggestion on how to improve the program enable on agent?
03:42:06 Sundar shaohe_feng: Please post the etherpad link again here, to ask for review
03:44:11 shaohe_feng #linkinfo https://etherpad.openstack.org/p/cyborg-ptg-ussuri
03:45:20 Sundar shaohe_feng and all, let's wait 1 more week for review. We'll take that as as the final table. Ok?
03:45:49 shaohe_feng OK
03:46:08 shaohe_feng so let's focus on agent program
03:46:15 shaohe_feng any comments?
03:46:27 Sundar You mean the patch?
03:47:01 Sundar If so, we should get the comments there
03:47:09 shaohe_feng Sundar s_shogo yikun, Yumeng, wangzhh, chenke
03:47:45 shaohe_feng yes, we have discussed them yesterday.
03:47:52 shaohe_feng on wechat
03:48:08 shaohe_feng no agent just support fpga program
03:48:27 shaohe_feng how should agent support fake driver program?
03:48:57 Sundar BTW, in terms of holiday planning, we should probably cancel the meetings on Dec 25/26 and Jan 1/2. Probably keep the meeting on Dec 18/19?
03:50:59 shaohe_feng OK.
03:51:31 Sundar s_shogo Yumeng chenke Li_Liu: ^
03:51:33 s_shogo NP > schedule
03:51:43 shaohe_feng let's load all drivers in agant manager init?
03:51:58 shaohe_feng if it is configure in setup.cfg
03:52:08 Sundar shaohe_feng: Are we not doing that today?
03:52:23 shaohe_feng and choose the right one
03:52:40 shaohe_feng yes, I have paste a picture in wechat
03:52:59 shaohe_feng for program we just support fpga
03:53:13 shaohe_feng let me show you the code.
03:53:28 Sundar shaohe_feng: agent manager init calls into resource tracker and loads drivers: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/resource_tracker.py#L47
03:53:47 shaohe_feng no this code
03:54:11 Sundar We call program API only on fpga driver today
03:54:26 Sundar We should expand that to fake driver also
03:54:55 shaohe_feng you show the resource tracker code
03:55:21 shaohe_feng https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L41
03:55:36 Sundar shaohe_feng: We get the driver name in fpga_program_v2 API: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L64
03:56:10 shaohe_feng here we init the self.fpga_driver
03:56:12 Sundar We can use that to call the right driver. No need to hardcode self.fpga_driver.
03:56:24 shaohe_feng https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L70
03:56:38 shaohe_feng so here we just let fpga do program
03:57:05 Sundar shaohe_feng: ^
03:57:26 shaohe_feng OK, let's cancel the self.fpga_driver init
03:57:50 shaohe_feng add self.drivers in AgentManager
03:58:23 shaohe_feng all drivers if implement program method
03:58:30 shaohe_feng let's do it.
03:58:41 shaohe_feng no matter it is fpga
03:59:01 Sundar We already have the list of drivers in self._rt.acc_drivers
03:59:44 Sundar The program_v2 shold check if the driver implements the program() API and then call it.
04:00:19 Sundar Do others have any thoughts, comments, objections, .... ?
04:01:08 Sundar OK, let's review it in patch changes.
04:01:28 Sundar Anything else, folks?
04:02:12 Sundar #topic AoB
04:02:25 Sundar If nothing else, we can call it a day.
04:03:19 Sundar Tanks, everybody. Have a good day!
04:03:23 Sundar *Thanks
04:03:29 Sundar #endmeeting
04:03:31 openstack Meeting ended Thu Dec 5 04:03:29 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
04:03:32 openstack Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-12-05-03.10.html
04:03:33 openstack Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-12-05-03.10.txt
04:03:34 openstack Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-12-05-03.10.log.html
04:13:34 shaohe_feng sorry something wrong with irc
04:13:44 shaohe_feng Sundar are here?
04:14:06 shaohe_feng so everyone agree all the drivers can support program?
04:14:09 shaohe_feng right?
04:20:40 Sundar shaohe_feng: I am fine with that. As I said, program_v2 should check if the driver implements the program() API and then call it. That way, it can be generic and Pythonic
04:22:08 shaohe_feng Add an abstract class for all acc drivers?
04:22:20 shaohe_feng it just define the interfaces?
04:22:40 shaohe_feng Sundar
04:23:38 Sundar shaohe_feng: The generic driver is the ABC for drivers today
04:25:51 shaohe_feng Sundar but you can see， not every drivers inherit it.
04:26:38 shaohe_feng https://opendev.org/openstack/cyborg/src/branch/master/cyborg/accelerator/drivers/gpu/base.py#L29
04:26:47 shaohe_feng here is the example?
05:54:55 openstackgerrit zhurong proposed openstack/cyborg master: Add 5 placeholder db migration scripts for Train https://review.opendev.org/697031
07:21:26 openstackgerrit Xinran WANG proposed openstack/cyborg-specs master: Re-propose specification for Cyborg APIs Version 2 https://review.opendev.org/695840
07:51:06 openstackgerrit Brin Zhang proposed openstack/cyborg master: Add cyborg quickstart reference in devstack https://review.opendev.org/697419
#openstack-cyborg - 2019-12-06
09:57:06 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: support program for fake driver https://review.opendev.org/697011
09:57:06 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: support program for all drivers. https://review.opendev.org/697639
#openstack-cyborg - 2019-12-08
01:58:45 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Do not fail ARQ binding for specific Nova notification errors. https://review.opendev.org/697243
#openstack-cyborg - 2019-12-09
03:09:46 openstackgerrit Brin Zhang proposed openstack/cyborg master: Add cyborg quickstart reference in devstack https://review.opendev.org/697419
05:32:30 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: support program for all drivers. https://review.opendev.org/697639
07:30:36 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: WIP: Do not fail ARQ binding for specific Nova notification errors. https://review.opendev.org/697243
12:05:27 openstackgerrit Jason SUN proposed openstack/cyborg master: Remove 'base object' that no longer exist https://review.opendev.org/698000
#openstack-cyborg - 2019-12-10
00:00:40 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: WIP: Do not fail ARQ binding for specific Nova notification errors. https://review.opendev.org/697243
06:14:31 openstackgerrit Shogo Saito proposed openstack/python-cyborgclient master: v2 API Support(using openstack-sdk) https://review.opendev.org/681391
07:08:18 openstackgerrit Shogo Saito proposed openstack/cyborg master: Programming support (v2 Deployable API) https://review.opendev.org/698190
07:51:14 openstackgerrit Shogo Saito proposed openstack/cyborg-specs master: Update device section in Cyborg V2 APIs specification. https://review.opendev.org/696012
09:46:00 openstackgerrit YumengBao proposed openstack/cyborg master: Replace pycodestyle with pep8 for python3 compatible https://review.opendev.org/698203
#openstack-cyborg - 2019-12-11
00:05:02 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Do not fail ARQ binding for specific Nova notification errors. https://review.opendev.org/697243
02:07:19 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Do not fail ARQ binding for specific Nova notification errors. https://review.opendev.org/697243
08:36:17 openstackgerrit Merged openstack/cyborg master: Do not fail ARQ binding for specific Nova notification errors. https://review.opendev.org/697243
#openstack-cyborg - 2019-12-12
03:00:43 Sundar49 #startmeeting openstack-cyborg
03:00:44 openstack Meeting started Thu Dec 12 03:00:43 2019 UTC and is due to finish in 60 minutes. The chair is Sundar49. Information about MeetBot at http://wiki.debian.org/MeetBot.
03:00:45 openstack Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
03:00:47 openstack The meeting name has been set to 'openstack_cyborg'
03:00:52 Sundar49 Hi all
03:01:13 chenke Hi all.
03:01:19 chenke info chenke.
03:01:23 chenke info# chenke
03:01:25 Yumeng #info Yumeng
03:01:34 Sundar49 Hi chenke, Yumeng
03:01:51 Yumeng Hi Sundar49
03:01:52 Sundar49 Let's give a min for folks to join
03:02:08 wangzhh Hi all.

Earlier   Later