| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-10-31 | |||
| 03:34:15 | Sundar | Cool. May be somebody can propose a patch to the fake driver for that | |
| 03:34:46 | Sundar | I can modify tempest to address the other problem, that all tests use the same device profile name today | |
| 03:35:16 | Sundar | #topic Core reviewers | |
| 03:35:26 | Sundar | Welcome, chenke, as a core reviewer! | |
| 03:35:52 | chenke | Thanks! | |
| 03:36:12 | chenke | I am very happy to meet you at cyborg. | |
| 03:36:17 | s_shogo | cool! | |
| 03:36:42 | Yumeng | congrats chenke! | |
| 03:36:48 | Yumeng | Sundar: I just talked to zhurong, if we wants to create more than one VMs, he would suggest run serially instead of parallelly. maybe we can add in etherpad and discuss that. | |
| 03:36:58 | Sundar | One person listed as a core reviewer has not been active since Feb 2018 (almost 2 years): Justin Kilpatrick. I wrote an email to him but no response for 1 week. Shall we remove him as core reviewer? | |
| 03:37:38 | Sundar | Yumeng: I see. Sure, let me add that for PTG. Hope zhurong can attend that part. | |
| 03:38:38 | Yumeng | I will invite him to make some time for us. ^^ | |
| 03:38:53 | Sundar | Yumeng, s_shogo, chenke: On core reviewer removal? | |
| 03:39:28 | chenke | +1. Sundar | |
| 03:39:38 | s_shogo | +1. | |
| 03:39:56 | Sundar | Cool, I'll follow up in openstack ML and follow due process. | |
| 03:40:40 | Sundar | #topic Code reviews | |
| 03:40:54 | Sundar | https://review.opendev.org/#/c/685542/ -- the famous Glance API servers patch :) | |
| 03:41:02 | chenke | haha. | |
| 03:41:26 | chenke | zhurong and Me test this code in myenv. | |
| 03:41:28 | Sundar | I don't understand the changes honestly. But, if you all understand it enough to maintain it, I'll go along with that | |
| 03:41:52 | shaohe_feng | Hi all | |
| 03:42:00 | chenke | Your test results show that this is also ok, right？ | |
| 03:42:04 | Sundar | chenke: My concern is, without FPGAs, the programming code paths that invoke Glance don't get tested | |
| 03:42:04 | chenke | Hi shaohe. | |
| 03:42:10 | Yumeng | hi shaohe_feng | |
| 03:42:18 | shaohe_feng | Sorry for late. seems something wrong with network. | |
| 03:42:31 | shaohe_feng | I change a new proxy, it can works now. | |
| 03:42:31 | Sundar | Hi shaohe_feng : Would you be able to test https://review.opendev.org/#/c/685542/ in your local env with real FPGAs? | |
| 03:42:50 | shaohe_feng | let me have a look. | |
| 03:43:04 | Sundar | DO others understand the change? | |
| 03:43:58 | chenke | If shaohe can help verify it, that would be great. | |
| 03:44:15 | shaohe_feng | the evn was destroyed by Xinran. | |
| 03:44:24 | shaohe_feng | :') | |
| 03:44:29 | Sundar | chenke: yes, my tests with real FPGAs worked. But do we all understand the changes enough to maintain it if issues arise in the future? One part touches pecan WSGI and another part touches keystone | |
| 03:44:32 | shaohe_feng | she used for other test. | |
| 03:45:01 | shaohe_feng | Sundar do you have a FPGA env? | |
| 03:45:13 | shaohe_feng | I can test it on it. | |
| 03:45:20 | Sundar | shaohe_feng: You still have FPGAs, right? Is Xinran using it for the demo? Yes, I do have FPGAs and I tested chenke's patch | |
| 03:46:00 | shaohe_feng | yes. | |
| 03:46:26 | shaohe_feng | I need to check with xinran | |
| 03:46:41 | shaohe_feng | maybe we really need to set a FPGA gate | |
| 03:46:50 | chenke | I understand your fears. Zhurong and I are good friends. He is confident in this code. | |
| 03:47:15 | shaohe_feng | Sundar who can support a server with a FPGA? | |
| 03:47:22 | Sundar | Ok. Yumeng, s_shogo, shaohe_feng: please review this patch. If you all give +1/+2, i is automatic +2 from me. :) | |
| 03:47:31 | shaohe_feng | OK. | |
| 03:47:46 | shaohe_feng | chenke can you introduce what's change in the patch? | |
| 03:48:03 | chenke | Ok. | |
| 03:48:18 | shaohe_feng | maybe you have introduce in the meeting. But I missed it. | |
| 03:48:24 | s_shogo | OK, I also test this with FPGA. | |
| 03:48:25 | shaohe_feng | chenke thanks | |
| 03:49:02 | chenke | in /etc/cyborg/cyborg.conf api_serveris useless actually. | |
| 03:49:31 | chenke | The patch does this thing. | |
| 03:50:09 | chenke | But When we remove this line. The past code occured some error. | |
| 03:51:23 | chenke | So zhurong help to modify some error that the past code occured. | |
| 03:52:34 | Sundar | Well, could you clarify what's happening at https://review.opendev.org/#/c/685542/6/cyborg/api/hooks.py@79 ? | |
| 03:54:09 | chenke | Sorry. I am not familiy with this part code now. But zhurong had explain this. | |
| 03:54:25 | chenke | He said: The rootcause is less copied request context code when init the project. the main change is add necessary info into the context, | |
| 03:56:45 | chenke | Or we can wait a little longer. I will do a detailed investigation of this code. | |
| 03:57:03 | s_shogo | Are there reference code, from other component? ( if there, I would like to check this patch with that.) | |
| 03:57:12 | chenke | Yes. | |
| 03:57:49 | chenke | Quoted from other components, not his original. | |
| 03:57:52 | Sundar | Will this be needed if we move to openstacksdk? | |
| 03:58:09 | shaohe_feng | why we need a X_SERVICE_CATALOG, but old code does not need this? | |
| 03:58:42 | chenke | old code doesn't go this. | |
| 03:59:05 | chenke | Sundar I am not sure. This patch was suggest by eric. | |
| 03:59:56 | shaohe_feng | why we need to get service_catalog now? | |
| 04:00:09 | chenke | @sh | |
| 04:00:20 | chenke | shaohe_feng The if condition of the old code prevented this code from being executed. | |
| 04:01:58 | shaohe_feng | no if condition in old code. | |
| 04:02:16 | chenke | Wait. | |
| 04:02:51 | chenke | https://review.opendev.org/#/c/685542/6/cyborg/image/glance.py@116 | |
| 04:04:49 | Sundar | My suggestion: configuring the Glance API servers is not good, but introducing mysterious code to get rid of that is not necessarily better, May be we should focus more on moving to openstacksdk? Sorry, chenke, I know you put in a lot of work into this. | |
| 04:05:05 | chenke | Ok. | |
| 04:05:09 | chenke | I understand. | |
| 04:05:23 | chenke | we can workflow -1 for this patch. | |
| 04:05:44 | chenke | When will have free time. We can check it again. | |
| 04:06:12 | Sundar | Thanks for your understanding | |
| 04:06:26 | Sundar | Next patch: https://review.opendev.org/#/c/691766/ | |
| 04:07:28 | Yumeng | seems like so many questions. we can dig more to make the whole problem clear. then decide whether workflow -1 or not | |
| 04:07:30 | Sundar | This is failing but the error seems to be trivial: https:// -587e1fde8c10362d45d985729e2fba7d.ssl.cf2.rackcdn.com/691766/4/check/cyborg-tempest-py3/56025ea/job-output.txt 2019-10-29 21:26:30.155717 | |
| 04:08:31 | Yumeng | looks like need to figure out the mysterious part first. I can help. | |
| 04:08:51 | Sundar | Yumeng: sure | |
| 04:10:02 | Sundar | For the py3 tempest patch, if this issue gets fixed, are we good with moving to Python 3 alone for tempest? Any other factor to consider? | |
| 04:12:29 | chenke | suggest that we wait for other components. | |
| 04:13:12 | Sundar | ok | |
| 04:13:21 | Sundar | #topic AoB | |
| 04:13:24 | shaohe_feng | Does everyone notice that openstack-tox-py37 test often timeout? | |
| 04:13:32 | chenke | Yes. | |
| 04:13:38 | Sundar | shaohe_feng: Yes | |
| 04:13:40 | chenke | Xinran's patch | |
| 04:13:45 | shaohe_feng | what's the reason? | |
| 04:14:22 | s_shogo | Me too, but no idea for the reason. | |
| 04:14:43 | shaohe_feng | in several patches, I have seen timeout | |
| 04:14:50 | chenke | From the zuul log. I didn't find the reason. | |
| 04:17:35 | Sundar | We can bring this up in openstack ML. If one of you want to write it up, good. Or, you can send me some concrete examples that I can cite, and I'll bring it up | |
| 04:18:28 | Sundar | Anything else for today, before we head to the summit? | |
| 04:18:57 | Yumeng | BTW, to all, if you have time pls help to review ARQ and device_profile api doc :https://review.opendev.org/#/c/691306/, https://review.opendev.org/#/c/690539/ | |
| 04:19:10 | Sundar | Yes, thanks Yumeng. Will do. | |
| 04:19:35 | Yumeng | Thanks! | |