| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-09-12 | |||
| 03:20:59 | Sundar | Yumeng: thanks a lot for all that you and your team have done. Is https://review.opendev.org/#/c/676665/ critical to merge this week? | |
| 03:21:58 | Sundar | Definitely, we need to merge https://review.opendev.org/#/c/667231/ soon. | |
| 03:22:10 | Yumeng | sundar: i will update today. I think we should merge asap | |
| 03:22:47 | Yumeng | agreed . also 667231 | |
| 03:22:55 | Sundar | Great. Glad to see your progress on privsep - but I think we can even do that in the next couple of weeks. | |
| 03:23:12 | Sundar | No need to burn yourself out :) | |
| 03:23:23 | Yumeng | about https://review.opendev.org/#/c/673957/ | |
| 03:23:50 | Yumeng | Eric and sean suggest we we don't need to have a cyborg.privsep.* sub module at all | |
| 03:23:59 | Yumeng | just a top level cyborg/privsep.py module that init the context and the privileged function should be in normal modules with privileged appended as a prefix or suffix. | |
| 03:24:29 | Yumeng | but the current fact is nova and cinder still have cyborg.privsep.* sub module | |
| 03:24:59 | Yumeng | so do we just follow the current way or change it ? what do you think？ | |
| 03:24:59 | xinranwang | Yumeng: should we merge 676665 before 667231? | |
| 03:25:07 | Sundar | Yes. I have heard it be said even nova's use of rootwrap etc. is not a good template to follow. Sometimes we are expected to do better than than the legacy projects because we are new. | |
| 03:26:47 | Sundar | Yumeng: IMHO, it is better to take some time and do this right, because it will be tough to revisit this again. So, it may be better to follow the experienced input. | |
| 03:26:53 | Yumeng | yes, pleas merge 676665 before 667231 | |
| 03:28:01 | Yumeng | Sundar: ok. then I will reconsider it. do as they suggest. | |
| 03:28:14 | Sundar | Thanks a lot, Yumeng. | |
| 03:28:24 | Sundar | Yumeng: Re. 676665, There is a -1 on that. What does it take to get it resolved? | |
| 03:28:56 | Yumeng | I will do that | |
| 03:29:08 | Sundar | Excellent. Thanks :) | |
| 03:29:59 | Sundar | What should we do about https://review.opendev.org/#/c/675990/ ? | |
| 03:30:16 | Sundar | (That is Python 3. I jumped to a different topic.) | |
| 03:31:06 | Yumeng | and to all， please help to review and merge this bug fix https://review.opendev.org/#/c/675059/ | |
| 03:31:10 | s_shogo | That was included in the py3 patch. https://review.opendev.org/#/c/667524/ | |
| 03:31:45 | chenke | Ye. That was part of s_shogo's patch. | |
| 03:31:49 | Sundar | So, it should just be abandoned, I suppose. | |
| 03:32:09 | chenke | Agree | |
| 03:32:13 | s_shogo | Sundar: That's right. | |
| 03:32:19 | Sundar | Cool. | |
| 03:32:58 | Sundar | Yumeng, wangzhh: Re. https://review.opendev.org/#/c/675059/, Has GPU been tested with the nova-integ patches? | |
| 03:35:15 | Yumeng | I have tested with part of the nova-integ patches. | |
| 03:35:24 | wangzhh | Sorry, I don't have GPU env. But I think this part should be OK. Because there is little change this part. | |
| 03:35:35 | wangzhh | Yumeng, Great. | |
| 03:35:43 | Sundar | Ok. Has anybody launched a VM with real GPU attached? Oherise, how do we know it works? | |
| 03:35:47 | Sundar | *Otherwise | |
| 03:36:30 | Yumeng | wangzhh: yes a tiny fix. pls help to review \0/ | |
| 03:36:57 | shaohe_feng | hi all | |
| 03:37:13 | chenke | hi shaohe. | |
| 03:37:15 | Sundar | Hi shaohe_feng | |
| 03:37:32 | Sundar | To summarize the most important patches for this week: | |
| 03:37:41 | Sundar | Nova notification: https://review.opendev.org/674520 | |
| 03:37:48 | Sundar | Python 3: https://review.opendev.org/#/c/667524/ | |
| 03:37:55 | Sundar | Tempest: https://review.opendev.org/#/c/676665/ , https://review.opendev.org/#/c/667231/ | |
| 03:37:57 | Yumeng | Sundar: emmmm... I tested in a devstack env. not a real GPU env | |
| 03:38:17 | Sundar | Do we all agree that these are the important patches to merge this week? | |
| 03:38:47 | Yumeng | agreed' | |
| 03:39:16 | chenke | +1 | |
| 03:40:01 | chenke | Zhurong has some suggestions on Nova notification, but I suggest we merge this patch first, and then have time to modify it. | |
| 03:40:30 | Sundar | chenke: Totally agreed. Zhurong's point is important and I am working on it. | |
| 03:40:59 | Sundar | chenke: Thanks to you and zhurong for lots of active contribution! It'll be good to merge your patches by next week, IMHO, to help further development. | |
| 03:41:28 | Sundar | #topic AoB | |
| 03:41:38 | Sundar | Anything else, folks? | |
| 03:42:00 | shaohe_feng | https://review.opendev.org/#/c/681005/ | |
| 03:42:20 | shaohe_feng | will be test on really evn today | |
| 03:42:41 | Sundar | Cool, thanks Shaohe. | |
| 03:42:42 | shaohe_feng | still some bug, I think it can works today. | |
| 03:43:10 | shaohe_feng | it is some complex. | |
| 03:43:22 | shaohe_feng | but it implemented as we discussion. | |
| 03:43:30 | shaohe_feng | welcome RFC. | |
| 03:44:56 | Sundar | Sure. All, please review and help merge the important patches above. Have a good day! | |
| 03:44:57 | wangzhh | Do we need to merge this patch before nova integrate? https://review.opendev.org/#/c/678177/ | |
| 03:45:55 | Sundar | wangzhh: Nova developers have not asked for that. They tend to take security for granted, so this may yet come up. It is important to merge that too. | |
| 03:46:04 | shaohe_feng | we need this patch, but maybe nova integrate does not need it . | |
| 03:46:31 | wangzhh | FIne, so plz also help to review this patch. | |
| 03:46:39 | shaohe_feng | sure, | |
| 03:46:40 | Sundar | Sure, will do | |
| 03:47:09 | shaohe_feng | when is the dead line of async job? | |
| 03:47:48 | shaohe_feng | it it really not easy to test it on really env. | |
| 03:48:00 | shaohe_feng | too many steps | |
| 03:48:30 | Sundar | shaohe_feng: Given that this week is milestone 3, we have to see how things go from here. I agree with you. It is better to take time and ensure it works well. | |
| 03:49:05 | Sundar | It does not have to merge this week, if that makes you feel better :) | |
| 03:49:30 | shaohe_feng | OK, I will do my best to make it works well today. | |
| 03:49:49 | Sundar | Great. Thanks, shaohe_feng | |
| 03:49:51 | shaohe_feng | for tomorrow is our Moon festival | |
| 03:50:27 | Sundar | I see. Happy Moon festival to all of you! | |
| 03:50:58 | shaohe_feng | Thanks, | |
| 03:51:04 | Sundar | All right, see you all next week. Bye :) | |
| 03:51:09 | Sundar | #endmeeting | |
| 03:51:11 | openstack | Meeting ended Thu Sep 12 03:51:09 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 03:51:12 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-12-03.04.html | |
| 03:51:13 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-12-03.04.txt | |
| 03:51:14 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-12-03.04.log.html | |
| 06:21:51 | openstackgerrit | YumengBao proposed openstack/cyborg master: add cyborg-tempest job and remove cyborg-devstack job https://review.opendev.org/676665 | |
| 08:43:29 | openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | |
| 08:53:46 | openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | |
| 10:10:06 | openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | |
| 18:45:06 | openstackgerrit | Merged openstack/cyborg master: add cyborg-tempest job and remove cyborg-devstack job https://review.opendev.org/676665 | |
| #openstack-cyborg - 2019-09-13 | |||
| 03:09:57 | openstackgerrit | Xinran WANG proposed openstack/cyborg-tempest-plugin master: End-to-end scenario test added https://review.opendev.org/667231 | |
| 06:02:36 | openstackgerrit | Merged openstack/cyborg-tempest-plugin master: End-to-end scenario test added https://review.opendev.org/667231 | |
| 08:42:59 | openstackgerrit | Merged openstack/cyborg master: Notify Nova when all ARQs are resolved for an instance. https://review.opendev.org/674520 | |
| 11:56:53 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job https://review.opendev.org/681005 | |
| 14:30:51 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: python3 patch (including zuul config) https://review.opendev.org/667524 | |
| 16:03:55 | openstackgerrit | Merged openstack/cyborg master: python3 patch (including zuul config) https://review.opendev.org/667524 | |
| 20:24:27 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| 20:27:15 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| #openstack-cyborg - 2019-09-14 | |||
| 02:06:32 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| 21:17:07 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| #openstack-cyborg - 2019-09-15 | |||
| 01:44:13 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| 01:53:55 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| #openstack-cyborg - 2019-09-16 | |||
| 02:56:59 | openstackgerrit | YumengBao proposed openstack/cyborg master: [WIP] P6.0: conductor writes device_profile update to db https://review.opendev.org/679406 | |