| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-06-06 | |||
| 03:13:08 | Sundar | We had a discussion today. For the Nova patches to merge, we need both a functional test in Nova that calls fake CYborg APIs *and* a tempest CI with a fake CYborg driver | |
| 03:13:47 | Sundar | XInran and Biwei are looking at the tempest CI in general | |
| 03:14:11 | Sundar | But the fake driver is lot like the generic driver -- I think | |
| 03:14:30 | Sundar | So, we were wondering if you could create a fake driver? | |
| 03:18:46 | Sundar | brb in 10 min | |
| 03:23:22 | yikun | Sure, but I'm not sure this fake driver looks like what? I can take this work, but I need some info from biwei or xinran | |
| 03:24:34 | Sundar | They had questions for me :) | |
| 03:24:44 | Sundar | OK, we need to figure out what this looks like | |
| 03:26:08 | Sundar | Do you know any of the tempest people? | |
| 03:28:27 | xinranwang | Actually, I don't understand why nova need fake driver test, they just wanna make sure that nova can call cyborg correctly and cyborg return the right data. It's all about API layer. | |
| 03:28:30 | yikun | No, I think maybe we can get some help from yumeng? | |
| 03:29:52 | xinranwang | Zhurong from ZTE have experience on tempest plugin. | |
| 03:32:16 | Sundar | xinranwang: Please see comments on line 409 in https://review.opendev.org/#/c/603955/13/specs/train/approved/nova-cyborg-interaction.rst,unified | |
| 03:32:38 | Sundar | yikun: Yumeng is on vacation till end June, IIRC | |
| 03:33:46 | Sundar | xinranwang: GTK. Can we contact that person or zhu.fanglei@zte.com.cn? | |
| 03:37:33 | xinranwang | According to Sean's comments, my understanding is, what nova required is still fake cyborg API, but for gate check, cyborg should have a fake driver to pass the tempest test. And there should be a test in tempest like test_boot_vm_with_accl. | |
| 03:40:06 | Sundar | Hmm, yes, so we need both, as per the comments. | |
| 03:40:14 | Sundar | xinranwang: ^ | |
| 03:41:11 | xinranwang | So no CI env need to be set up. Just code.(nova fixture, fake driver). Right? | |
| 03:41:55 | Sundar | Plus the tempest plugins for basic test cases which will call fake driver | |
| 03:42:55 | Sundar | We don't need the hardware-based CI, if that's what you mean | |
| 03:43:15 | Sundar | We do need a tempest CI env, which we are in the process of creating | |
| 03:44:10 | xinranwang | yes, sure. test_boot_vm_with_accl will be implemented in tempest plugin. I am working on this. | |
| 03:44:32 | xinranwang | But I will test it with real env. | |
| 03:47:02 | xinranwang | Hmmm, I think no need for tempest CI, we can use Zuul directly to run tempest. Just add a cyborg tempest plugin? what do you think? yikun | |
| 03:58:13 | yikun | yes, I think functional test need fake cyborg api, and tempest only need a tempest plugin, but I don't know how this plugin work in a real env. | |
| 04:01:34 | Sundar | yikun, xinwanwang: # openstack-qa is the IRC channel for tempest etc. We can ask there. | |
| 04:02:58 | Sundar | xinranwang: ^ | |
| 04:04:55 | xinranwang | OK | |
| 04:05:49 | Sundar | Please join that channel. I'll ask the question there, and you all can add/clarify | |
| 04:06:38 | xinranwang | I will go for lunch now. Will be back soon | |
| #openstack-cyborg - 2019-06-11 | |||
| 10:02:43 | openstackgerrit | huang liujie proposed openstack/cyborg master: Sync Sphinx requirement https://review.opendev.org/664548 | |
| 10:04:41 | openstackgerrit | huang liujie proposed openstack/cyborg master: Sync Sphinx requirement https://review.opendev.org/664548 | |
| #openstack-cyborg - 2019-06-12 | |||
| 01:34:44 | openstackgerrit | Merged openstack/cyborg master: Dropping the py35 testing https://review.opendev.org/659898 | |
| 01:54:07 | openstackgerrit | Merged openstack/cyborg-specs master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/654984 | |
| 01:56:23 | openstackgerrit | Merged openstack/cyborg-specs master: Use opendev repository https://review.opendev.org/654924 | |
| 01:56:24 | openstackgerrit | Merged openstack/cyborg-specs master: Change openstack-dev to openstack-discuss https://review.opendev.org/622031 | |
| 03:01:09 | Sundar | Hi wangzhh, Biwei | |
| 03:01:17 | Biwei | Hi Sundar | |
| 03:01:23 | Sundar | Let's wait a couple of min for folks to join | |
| 03:01:39 | ikuo_o | Hi Sundar, Biwei | |
| 03:01:47 | Sundar | Hi ikuo_o | |
| 03:01:53 | yikun | Hi | |
| 03:01:59 | Sundar | Hi yikun | |
| 03:02:04 | Li_Liu | Hi Sundar | |
| 03:02:15 | Sundar | Hi Li_Liu | |
| 03:02:25 | wangzhh | Hi Sundar. | |
| 03:02:29 | Sundar | #startmeeting openstack-cyborg | |
| 03:02:30 | openstack | Meeting started Wed Jun 12 03:02:29 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 03:02:31 | openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 03:02:34 | openstack | The meeting name has been set to 'openstack_cyborg' | |
| 03:02:51 | Sundar | #topic Roll call and agenda | |
| 03:02:51 | xinranwang | Hi all | |
| 03:02:58 | Sundar | #info Sundar | |
| 03:03:06 | wangzhh | #info wangzhh | |
| 03:03:10 | Biwei | #info Biwei | |
| 03:03:12 | ikuo_o | #info ikuo_o | |
| 03:03:34 | yikun | #info yikun | |
| 03:03:41 | Sundar | Agenda: https://wiki.openstack.org/wiki/Meetings/CyborgTeamMeeting#Agenda | |
| 03:03:43 | xinranwang | #info xinranwang | |
| 03:03:54 | Sundar | Anything to add to agenda? | |
| 03:04:27 | Sundar | #topic Cyborg CI | |
| 03:05:02 | Sundar | As we have said, we need two things to merge Nova patches: Nova functional test with fake Cyborg API, and tempest CI with fake driver | |
| 03:05:37 | Sundar | Taking the tempest one first, xinranwang and Biwei are working on the general framework and plugins. | |
| 03:06:13 | Sundar | For the fake driver, yikun has kindly agreed. But he needs help. I'll help as much as I know. | |
| 03:06:23 | Sundar | It would be great if others can also help him out. | |
| 03:06:43 | Sundar | yikun, please feel free to ask questions. | |
| 03:07:03 | Sundar | ANy comments or questions on fake driver and/or tempest? | |
| 03:07:18 | Li_Liu | #info Li_Liu | |
| 03:07:25 | ikuo_o | Thanks Yikun. | |
| 03:07:29 | yikun | I still don't know what is the real requirement of fake driver. I assume it's just a driver that will return empty or just pass | |
| 03:07:55 | xinranwang | Biwei and I are working on the tempest test case and general framework. We will test them in real env, once the fake driver is implemented, yikun can use these testcases. | |
| 03:08:26 | yikun | and also, we should merge these two patch, :) https://review.opendev.org/#/c/658986 https://review.opendev.org/#/c/658987 | |
| 03:08:38 | yikun | and then I can append the patch base on these two | |
| 03:08:42 | xinranwang | real env means an openstack env with fpga | |
| 03:08:49 | Sundar | yikun: The fake driver ill be a derivative of the generic driver, which will return some pre-defined driver OVO for discover() | |
| 03:09:52 | yikun | Sundar: ok, will summit a patch this week, and any detail comments can be happened in the patch | |
| 03:09:56 | Sundar | It can return success or NULL for other APIs. | |
| 03:10:21 | Sundar | yikun: Great, thanks. Please ensure the fake driver is added to the tempest repo. | |
| 03:10:25 | yikun | Sundar: got it | |
| 03:10:46 | Sundar | Now, for the Nova functional test | |
| 03:11:03 | Sundar | Can somebody take that up? | |
| 03:11:35 | Sundar | It will just mock the Cyborg APIs called by Nova -- get device profile, post/patch/delete ARQs | |
| 03:12:19 | yikun | “Please ensure the fake driver is added to the tempest repo.” not sure why it is tempest repo? | |
| 03:12:33 | yikun | I thought it should be in cyborg repo | |
| 03:13:22 | Biwei | yikun, there's a cyborg-tempest-plugin repo, living outside of the cyborg repo | |
| 03:14:12 | Sundar | The tempest plugins are going to call that fake driver. | |
| 03:14:22 | xinranwang | Sundar: what should fake driver return exactly, the info returned by this fake driver will be used in nova to boot vm, right ? | |
| 03:15:19 | Sundar | xinranwang: Yes. Its discover() API should return a pre-defined device OVO object | |
| 03:15:26 | yikun | Biwei: OK, https://github.com/openstack/cyborg-tempest-plugin | |
| 03:15:43 | xinranwang | Sundar: tempest has api test and scenario test, those 2 types only interact with API layers, I don't think tempest should call driver directly. | |
| 03:15:44 | Sundar | It could define a device with soem fake controlpath-IDs, 1 deployable and an attach handle, all with fake PCI addresses | |
| 03:15:51 | xinranwang | Biwei: what do you think? | |
| 03:16:17 | xinranwang | Sundar: yes, but what info stored in this OVO, like pci address | |
| 03:16:29 | Biwei | tempest will not call driver directly | |
| 03:17:26 | Sundar | Can be totally bogus PCI addresses. The VM may not boot up without the hardware. | |
| 03:17:51 | Sundar | To quote Eric Fried: "It should be sufficient to wait for the instance to go ACTIVE (according to Nova) (which will happen even if the guest OS boot pukes) and scrape its domain XML to assert that the correct PCI devices are present." | |
| 03:18:56 | yikun | Biwei: how to call driver directly, shouldn't it call cyborg api and cyborg api call the fake driver | |
| 03:19:00 | Sundar | Biwei Yes. Not sure if the CYborg agent will call driver API in tempest env, as it happens in real env | |
| 03:20:19 | Biwei | Sundar in tempest test, we only need to call the cyborg restful APIs. | |