| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-12-05 | |||
| 03:13:52 | Li_Liu | it's welcome to provide comments and inputs in the etherpad | |
| 03:14:16 | Sundar | Great. Are there any considerations to mock the db interface? | |
| 03:14:55 | Li_Liu | I think we will need that | |
| 03:15:12 | Li_Liu | Let me do some research for it | |
| 03:15:17 | Sundar | Yea, cool | |
| 03:15:30 | Li_Liu | I think we are doing similar mocking in unit tests | |
| 03:16:08 | Sundar | Yea. The db mocking could be a fixture. | |
| 03:16:54 | Sundar | Like https://review.opendev.org/gitweb?p=openstack/nova.git;f=nova/tests/fixtures.py;hb=refs/changes/35/673735/20#l2463 | |
| 03:17:38 | Sundar | Is Shaohe here? | |
| 03:18:18 | Sundar | Multinode is another important area. | |
| 03:18:42 | Sundar | Hi s_shogo, I know the client patch is waiting for review. | |
| 03:19:18 | Sundar | Did you get any comments from outside Cyborg? | |
| 03:19:31 | Sundar | On openstacksdk, etc.? | |
| 03:19:42 | s_shogo | Hi Sundar, Thanks for your adding reviewers. | |
| 03:20:11 | s_shogo | No comments,yet. | |
| 03:21:19 | Sundar | Ok. Is it better to ask for outside reviews now, or after we add /v2/devices etc. in the client? | |
| 03:23:59 | Sundar | s_shogo: ^ | |
| 03:24:00 | s_shogo | IMO, adding of Device doesn't effect openstack sdk ,significantly. Thus, I would like to ask review now. | |
| 03:24:17 | Sundar | Ok, I'll try to find somebody. | |
| 03:24:31 | Sundar | Hi shaohe_feng | |
| 03:24:42 | Sundar | Thanks for the patch on fake driver | |
| 03:24:43 | s_shogo | Thank you Sundar ! I also try to send e-mail and notify someone, after that. | |
| 03:25:38 | Sundar | Welcome, s_shogo | |
| 03:26:18 | Sundar | shaohe_feng: What else do you need for the multinode? Are you getting reviews for the config table? | |
| 03:28:40 | Sundar | Not sure if he is here -- I saw his join message. | |
| 03:28:52 | chenke | s_shogo I have put some comments in your client patch. | |
| 03:29:31 | s_shogo | Thank you cheke ! I'll check it. | |
| 03:29:43 | Sundar | chenke: Do you mean https://review.opendev.org/681391 ? | |
| 03:29:59 | chenke | Ye. | |
| 03:30:26 | s_shogo | s/cheke/chenke/ | |
| 03:30:39 | Sundar | Cool. chenke, what is the next step for https://review.opendev.org/#/c/691549/ ? | |
| 03:31:26 | chenke | his job should be done in Phase-2: milestone-1 -> milestone-2 | |
| 03:31:55 | Sundar | Ah I see. Sure. | |
| 03:32:08 | chenke | ok. | |
| 03:32:35 | Sundar | Next week, we should go through Storyboard, cyborg client patches and tempest plugin patches. We don't look much at those. | |
| 03:32:53 | Sundar | Anything else for today? | |
| 03:34:01 | chenke | seems lot of cyborg patch need to be review. | |
| 03:34:40 | Sundar | Yea. I've been focusing on the Nova patches, because we have the reviewer attention now and will lose it in week, as people head for holidays. | |
| 03:34:46 | Sundar | *in 1 week | |
| 03:35:30 | chenke | oh. that should be high priority. | |
| 03:35:41 | Sundar | Please review the patches we have, and I'll catch up in the last 2 weeks of Dec | |
| 03:36:17 | chenke | will do it. | |
| 03:36:38 | Sundar | Thanks. Anything else for today? | |
| 03:36:46 | Yumeng | About RBAC policy. | |
| 03:36:48 | Yumeng | I've read most of the materials provided on this page: https://wiki.openstack.org/wiki/Consistent_and_Secure_Default_Policies_Popup_Team | |
| 03:36:54 | shaohe_feng | Sundar config table is create by me | |
| 03:36:55 | Yumeng | We need to reassess each operation and associate which scope, or scopes, are appropriate. Mybe just like this: https://wiki.openstack.org/wiki/Barbican/Policy | |
| 03:37:20 | shaohe_feng | I need all of you review it | |
| 03:37:22 | Yumeng | then it will need all your comments. | |
| 03:38:01 | Sundar | Yumeng: Sounds good. Would you be creating that wiki? Do you need any help? | |
| 03:38:24 | Yumeng | yep. wiki is good. I will do that. | |
| 03:38:51 | Yumeng | I will try first. | |
| 03:38:54 | Sundar | Great. I'll add this to the agenda for next week. | |
| 03:39:34 | shaohe_feng | now any others have comment on the config table? | |
| 03:41:08 | shaohe_feng | Any suggestion on how to improve the program enable on agent? | |
| 03:42:06 | Sundar | shaohe_feng: Please post the etherpad link again here, to ask for review | |
| 03:44:11 | shaohe_feng | #linkinfo https://etherpad.openstack.org/p/cyborg-ptg-ussuri | |
| 03:45:20 | Sundar | shaohe_feng and all, let's wait 1 more week for review. We'll take that as as the final table. Ok? | |
| 03:45:49 | shaohe_feng | OK | |
| 03:46:08 | shaohe_feng | so let's focus on agent program | |
| 03:46:15 | shaohe_feng | any comments? | |
| 03:46:27 | Sundar | You mean the patch? | |
| 03:47:01 | Sundar | If so, we should get the comments there | |
| 03:47:09 | shaohe_feng | Sundar s_shogo yikun, Yumeng, wangzhh, chenke | |
| 03:47:45 | shaohe_feng | yes, we have discussed them yesterday. | |
| 03:47:52 | shaohe_feng | on wechat | |
| 03:48:08 | shaohe_feng | no agent just support fpga program | |
| 03:48:27 | shaohe_feng | how should agent support fake driver program? | |
| 03:48:57 | Sundar | BTW, in terms of holiday planning, we should probably cancel the meetings on Dec 25/26 and Jan 1/2. Probably keep the meeting on Dec 18/19? | |
| 03:50:59 | shaohe_feng | OK. | |
| 03:51:31 | Sundar | s_shogo Yumeng chenke Li_Liu: ^ | |
| 03:51:33 | s_shogo | NP > schedule | |
| 03:51:43 | shaohe_feng | let's load all drivers in agant manager init? | |
| 03:51:58 | shaohe_feng | if it is configure in setup.cfg | |
| 03:52:08 | Sundar | shaohe_feng: Are we not doing that today? | |
| 03:52:23 | shaohe_feng | and choose the right one | |
| 03:52:40 | shaohe_feng | yes, I have paste a picture in wechat | |
| 03:52:59 | shaohe_feng | for program we just support fpga | |
| 03:53:13 | shaohe_feng | let me show you the code. | |
| 03:53:28 | Sundar | shaohe_feng: agent manager init calls into resource tracker and loads drivers: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/resource_tracker.py#L47 | |
| 03:53:47 | shaohe_feng | no this code | |
| 03:54:11 | Sundar | We call program API only on fpga driver today | |
| 03:54:26 | Sundar | We should expand that to fake driver also | |
| 03:54:55 | shaohe_feng | you show the resource tracker code | |
| 03:55:21 | shaohe_feng | https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L41 | |
| 03:55:36 | Sundar | shaohe_feng: We get the driver name in fpga_program_v2 API: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L64 | |
| 03:56:10 | shaohe_feng | here we init the self.fpga_driver | |
| 03:56:12 | Sundar | We can use that to call the right driver. No need to hardcode self.fpga_driver. | |
| 03:56:24 | shaohe_feng | https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L70 | |
| 03:56:38 | shaohe_feng | so here we just let fpga do program | |
| 03:57:05 | Sundar | shaohe_feng: ^ | |
| 03:57:26 | shaohe_feng | OK, let's cancel the self.fpga_driver init | |
| 03:57:50 | shaohe_feng | add self.drivers in AgentManager | |
| 03:58:23 | shaohe_feng | all drivers if implement program method | |
| 03:58:30 | shaohe_feng | let's do it. | |
| 03:58:41 | shaohe_feng | no matter it is fpga | |
| 03:59:01 | Sundar | We already have the list of drivers in self._rt.acc_drivers | |
| 03:59:44 | Sundar | The program_v2 shold check if the driver implements the program() API and then call it. | |
| 04:00:19 | Sundar | Do others have any thoughts, comments, objections, .... ? | |
| 04:01:08 | Sundar | OK, let's review it in patch changes. | |