| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2025-12-01 | |||
| 19:02:11 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| #openstack-sdks - 2025-12-02 | |||
| 00:12:50 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 17:05:59 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 17:08:39 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 18:53:02 | opendevreview | Valentin Chassignol proposed openstack/python-openstackclient master: Add retrieve password with private key decryption https://review.opendev.org/c/openstack/python-openstackclient/+/923621 | |
| 21:41:20 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Moving tapas osc client code from neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/963445 | |
| 21:46:01 | opendevreview | Valentin Chassignol proposed openstack/python-openstackclient master: Add retrieve password with private key decryption https://review.opendev.org/c/openstack/python-openstackclient/+/923621 | |
| 21:47:05 | vinetos | Hey ~ I'm trying to rewrite the test for this change https://review.opendev.org/c/openstack/python-openstackclient/+/923621 but I cannot get the mocking of compute_client.get_server_password correctly. Does anyone see what I am doing wrong ? | |
| #openstack-sdks - 2025-12-03 | |||
| 00:05:21 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: Identity: Migrate 'project' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/965317 | |
| 04:29:48 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 04:39:29 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 04:45:49 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 04:52:45 | opendevreview | nidhi proposed openstack/python-openstackclient master: Change network tests from exact to subset checking. https://review.opendev.org/c/openstack/python-openstackclient/+/963947 | |
| 14:13:31 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Improve help strings for tap services https://review.opendev.org/c/openstack/python-openstackclient/+/968546 | |
| 14:18:52 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Use openstacksdk test generate_fake_resources factory https://review.opendev.org/c/openstack/python-openstackclient/+/966354 | |
| 14:18:52 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Moving tapas osc client code from neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/963445 | |
| #openstack-sdks - 2025-12-04 | |||
| 14:35:22 | zigo | openstacksdk fails with Python 3.14, it seems: https://buildd.debian.org/status/fetch.php?pkg=python-openstacksdk&arch=all&ver=4.7.2-1&stamp=1764789128&raw=0 | |
| 14:40:42 | stephenfin | zigo: that looks like a bug | |
| 14:40:49 | stephenfin | in scoping | |
| 14:41:10 | zigo | stephenfin: Can you expand on this? :) | |
| 14:43:16 | stephenfin | I'll try work on a minimal reproducer, but it seems to be associating 'list' with the class method defined on the class instead of the list primitive | |
| 14:43:30 | stephenfin | that's a change in scoping behavior fwict | |
| 14:43:49 | zigo | New behavior in python 3.14, you mean? | |
| 14:44:10 | stephenfin | yes | |
| 14:44:11 | zigo | (you must know it but... ) you can just pop a Debian Unstable if you want 3.14. | |
| 14:45:04 | stephenfin | All good: I've got it in F43 | |
| 14:54:30 | zigo | Let me know your findings, thanks for taking care of it. | |
| 14:55:21 | stephenfin | zigo: https://github.com/stephenfin/python-314-scoping-reproducer | |
| 14:55:34 | stephenfin | there's a minimal reproducer | |
| 14:56:40 | stephenfin | there's a chance this is an intentional change but I don't see anything in https://docs.python.org/3/whatsnew/3.14.html | |
| 14:57:21 | stephenfin | in any case, the solution will likely be to replace `list[...]` annotations with `builtins.list` in that file | |
| 15:49:56 | zigo | NameError: name 'builtins' is not defined. Did you forget to import 'builtins'? | |
| 15:49:56 | zigo | ^^^^^^^^ | |
| 15:49:56 | zigo | ) -> dict[str, ty.Any] | builtins.list[ty.Any]: | |
| 15:49:56 | zigo | File "/build/python-openstacksdk-RCihkI/python-openstacksdk-4.7.2/openstack/resource.py", line 1117, in __annotate__ | |
| 15:49:56 | zigo | stephenfin: | |
| 15:50:06 | zigo | I can just get rid of the annotation, no ? | |
| 16:27:39 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Use openstacksdk test generate_fake_resources factory https://review.opendev.org/c/openstack/python-openstackclient/+/966354 | |
| 17:02:35 | stephenfin | zigo: we want to be adding annotations, not removing them. you need to import builtins, yes | |
| 19:17:14 | opendevreview | Cyril Roelandt proposed openstack/openstacksdk master: image: Add support for downloading from a specific store https://review.opendev.org/c/openstack/openstacksdk/+/969839 | |
| 19:30:15 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 19:30:21 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 20:20:42 | opendevreview | Austin Jamias proposed openstack/ansible-collections-openstack master: Add ability to allocate floating IP https://review.opendev.org/c/openstack/ansible-collections-openstack/+/969848 | |
| #openstack-sdks - 2025-12-05 | |||
| 11:02:38 | zigo | Should I push them to gerrit then? | |
| 11:02:38 | zigo | https://salsa.debian.org/openstack-team/libs/python-openstacksdk/-/tree/debian/flamingo/debian/patches?ref_type=heads | |
| 11:02:38 | zigo | stephenfin: Here's my 2 patches for py3.13 : | |
| 11:56:26 | zigo | *3.14 I mean | |
| 15:47:50 | stephenfin | zigo: yes please | |
| 15:50:08 | croelandt | Hello! I see upload_image() is marked as deprecated in the SDK and that I should switch to using "create_image". I'm not sure I can use create_image to upload data to an existing image though | |
| 15:50:21 | croelandt | Also I could use the import workflow, but I'd like for the data upload to work in an env where that is not configured | |
| 15:50:24 | croelandt | Any idea? | |
| 15:54:16 | stephenfin | croelandt: the issue with that method was that it was doing too much: it should have only been handling the upload step of the legacy flow but it was instead doing create (which afaik is also part of the image import flow) + upload | |
| 15:54:36 | stephenfin | mrjoshi was working on it in the past but never got to the bottom of it https://review.opendev.org/c/openstack/openstacksdk/+/881939 | |
| 15:55:21 | stephenfin | I still think that's the correct path to take but someone needs to pick it up again | |
| 15:56:54 | croelandt | OK, I see she's answered comments by Artem, Maxim and yourself and then uploaded a patchset that passes the CI. Do you know whether there is something specific to change from patchset #21? | |
| 15:58:49 | stephenfin | croelandt: It's a really hard patch to review, and I struggle each time I've to try. I think it needs to be broken up to reviewable and mergeable, if I'm being honest :( | |
| 15:59:01 | stephenfin | For example, this could be a separate patch https://review.opendev.org/c/openstack/openstacksdk/+/881939/21/openstack/image/v2/image.py | |
| 16:00:29 | stephenfin | I also think we'd benefit from a precursor patch that tests calling upload_image with arguments in various forms | |
| 16:00:37 | stephenfin | e.g. upload_image('ami', None) | |
| 16:00:41 | stephenfin | upload_image('ami', disk_format=None) | |
| 16:00:58 | stephenfin | upload_image(container_format='ami', disk_format=None) | |
| 16:01:24 | stephenfin | etc. etc. That would give us confidence that the code to handle the old deprecated signature works as intended and we don't break users | |
| 16:03:39 | stephenfin | croelandt: You and I have reason to be cautious around this code too: we have made mistakes here in the recent past 😅 https://review.opendev.org/c/openstack/openstacksdk/+/910218 https://review.opendev.org/c/openstack/openstacksdk/+/960136 | |
| 16:04:39 | croelandt | yes, this is all fairly complex | |
| 16:05:15 | croelandt | but ok now I got an idea of what is needed to move forward | |
| 16:05:18 | croelandt | great, thanks! | |
| 16:06:09 | stephenfin | nw, let me know when it's good to go and I'll give it a run through 🫡 | |
| 16:10:48 | croelandt | stephenfin: so (provided I can make this work) we'd be undeprecating upload_image? | |
| 16:10:58 | stephenfin | yes | |
| 16:11:45 | stephenfin | but it would be refocused purely on the legacy image upload flow | |
| 16:12:56 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 16:13:23 | stephenfin | fwiw I'd also like to do the same in `create_image` but I think that ship has sailed... | |
| 16:14:39 | croelandt | does create_image do two things? | |
| 16:14:53 | stephenfin | create_image does about 5 things | |
| 16:15:06 | stephenfin | 😅 | |
| 16:15:07 | croelandt | oh yeah you can have create_image(..., data='stuff') so it creates the image and uploads data to it | |
| 16:15:10 | stephenfin | yup | |
| 16:15:36 | stephenfin | I get why it does that but I'd much rather people manually chose between the two flows | |
| 16:17:51 | croelandt | indeed | |
| 16:29:33 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: image: Move some code around https://review.opendev.org/c/openstack/openstacksdk/+/969965 | |
| 16:29:33 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: image: Deprecate rewriting of is_public property https://review.opendev.org/c/openstack/openstacksdk/+/969964 | |
| 19:30:24 | opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | |
| 21:09:10 | opendevreview | cid proposed openstack/openstacksdk master: Add Node.instance_name support https://review.opendev.org/c/openstack/openstacksdk/+/955103 | |
| #openstack-sdks - 2025-12-08 | |||
| 07:53:33 | opendevreview | Thomas Goirand proposed openstack/openstacksdk master: Fix Python 3.14 annotation https://review.opendev.org/c/openstack/openstacksdk/+/970100 | |
| 07:57:40 | opendevreview | Thomas Goirand proposed openstack/openstacksdk master: Python 3.14: fix timeout wait https://review.opendev.org/c/openstack/openstacksdk/+/970101 | |
| 10:50:56 | opendevreview | Thomas Goirand proposed openstack/openstacksdk master: Python 3.14: fix timeout wait https://review.opendev.org/c/openstack/openstacksdk/+/970101 | |
| 11:21:14 | opendevreview | Thomas Goirand proposed openstack/openstacksdk master: Python 3.14: fix timeout wait https://review.opendev.org/c/openstack/openstacksdk/+/970101 | |
| 12:07:23 | rpittau | hi all! we've removed/renamed some jobs from bifrost, please look at https://review.opendev.org/c/openstack/openstacksdk/+/969079 to avoid any disruption, thanks! | |
| 15:03:55 | opendevreview | Andriy Kurilin proposed openstack/openstacksdk master: Define tenant_id as a server-side filter for Port resource https://review.opendev.org/c/openstack/openstacksdk/+/970135 | |
| 16:20:49 | croelandt | stephenfin: haven't looked into improving the image upload support in the SDK, but I did rework the md-tags quite heavily (https://review.opendev.org/c/openstack/openstacksdk/+/897276), I could use your opinion on that | |
| 17:41:47 | stephenfin | rpittau: thanks, done | |
| 17:42:08 | stephenfin | croelandt: ack, will take a look shortly | |
| 18:08:02 | croelandt | stephenfin: thanks! I'm not too happy about reimplementing some methods but it'll have to do | |
| 18:22:27 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Moving tapas osc client code from neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/963445 | |
| 18:24:01 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 18:24:33 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Implement conflict resolution https://review.opendev.org/c/openstack/python-openstackclient/+/968178 | |
| 18:40:35 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Improve help strings for tap services https://review.opendev.org/c/openstack/python-openstackclient/+/968546 | |
| 19:00:45 | opendevreview | Miro Tomaska proposed openstack/python-openstackclient master: Improve help strings for tap services https://review.opendev.org/c/openstack/python-openstackclient/+/968546 | |
| 19:11:14 | opendevreview | Merged openstack/openstacksdk master: Update name of bifrost CI job https://review.opendev.org/c/openstack/openstacksdk/+/969079 | |
| 19:11:46 | opendevreview | Merged openstack/openstacksdk master: Fix Python 3.14 annotation https://review.opendev.org/c/openstack/openstacksdk/+/970100 | |